Re: [PATCH V2 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2012-07-19 Thread Namjae Jeon
2012/7/17 vinayak holikatti vinholika...@gmail.com:
 On Mon, Jul 16, 2012 at 7:19 PM, Namjae Jeon linkinj...@gmail.com wrote:
 Hi Vinayak.
 + * ufshcd_pltfrm_remove - remove platform driver routine
 + * @pdev: pointer to platform device handle
 + *
 + * Returns 0 on success, non-zero value on failure
 + */
 +static int __devexit ufshcd_pltfrm_remove(struct platform_device *pdev)
 +{
 + struct resource *mem_res;
 + struct resource *irq_res;
 + resource_size_t mem_size;
 + struct ufs_hba *hba =  platform_get_drvdata(pdev);
 +
 + ufshcd_remove(hba);
 + irq_res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
 + if (!irq_res)
 + dev_err(pdev-dev, ufshcd: IRQ resource not available\n);
 + free_irq(irq_res-start, hba);
 Is there no possibility of null pointer dereferencing error ?(irq_res-start)
 I think that free_irq should be not called if irq_res is NULL.
 I agree, I have overlooked at this logic, the free_irq should have
 been in the else
 part of this section. I will make the modification in the next version
 of patches.
Okay.
You can add my
Reviewed-by: Namjae Jeon linkinj...@gmail.com
in these patchset

Thanks.
 + mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 Looks mem_res is also same with upper case.
 Thanks.
 + mem_size = resource_size(mem_res);
 + release_mem_region(mem_res-start, mem_size);
 + platform_set_drvdata(pdev, NULL);
 + return 0;
 +}
 +
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH V2 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2012-07-17 Thread vinayak holikatti
On Mon, Jul 16, 2012 at 7:19 PM, Namjae Jeon linkinj...@gmail.com wrote:
 Hi Vinayak.
 + * ufshcd_pltfrm_remove - remove platform driver routine
 + * @pdev: pointer to platform device handle
 + *
 + * Returns 0 on success, non-zero value on failure
 + */
 +static int __devexit ufshcd_pltfrm_remove(struct platform_device *pdev)
 +{
 + struct resource *mem_res;
 + struct resource *irq_res;
 + resource_size_t mem_size;
 + struct ufs_hba *hba =  platform_get_drvdata(pdev);
 +
 + ufshcd_remove(hba);
 + irq_res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
 + if (!irq_res)
 + dev_err(pdev-dev, ufshcd: IRQ resource not available\n);
 + free_irq(irq_res-start, hba);
 Is there no possibility of null pointer dereferencing error ?(irq_res-start)
 I think that free_irq should be not called if irq_res is NULL.
I agree, I have overlooked at this logic, the free_irq should have
been in the else
part of this section. I will make the modification in the next version
of patches.
 + mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 Looks mem_res is also same with upper case.
 Thanks.
 + mem_size = resource_size(mem_res);
 + release_mem_region(mem_res-start, mem_size);
 + platform_set_drvdata(pdev, NULL);
 + return 0;
 +}
 +
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH V2 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2012-07-16 Thread Namjae Jeon
Hi Vinayak.
 + * ufshcd_pltfrm_remove - remove platform driver routine
 + * @pdev: pointer to platform device handle
 + *
 + * Returns 0 on success, non-zero value on failure
 + */
 +static int __devexit ufshcd_pltfrm_remove(struct platform_device *pdev)
 +{
 + struct resource *mem_res;
 + struct resource *irq_res;
 + resource_size_t mem_size;
 + struct ufs_hba *hba =  platform_get_drvdata(pdev);
 +
 + ufshcd_remove(hba);
 + irq_res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
 + if (!irq_res)
 + dev_err(pdev-dev, ufshcd: IRQ resource not available\n);
 + free_irq(irq_res-start, hba);
Is there no possibility of null pointer dereferencing error ?(irq_res-start)
I think that free_irq should be not called if irq_res is NULL.
 + mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
Looks mem_res is also same with upper case.
Thanks.
 + mem_size = resource_size(mem_res);
 + release_mem_region(mem_res-start, mem_size);
 + platform_set_drvdata(pdev, NULL);
 + return 0;
 +}
 +
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH V2 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2012-07-13 Thread Vinayak Holikatti
This patch adds Platform glue driver for ufshcd.

Signed-off-by: Vinayak Holikatti vinholika...@gmail.com
Signed-off-by: Santosh Yaraganavi santos...@gmail.com
---
 drivers/scsi/ufs/Kconfig |   11 ++
 drivers/scsi/ufs/Makefile|1 +
 drivers/scsi/ufs/ufshcd-pltfrm.c |  215 ++
 3 files changed, 227 insertions(+)
 create mode 100644 drivers/scsi/ufs/ufshcd-pltfrm.c

diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
index 265a8c8..8c06330 100644
--- a/drivers/scsi/ufs/Kconfig
+++ b/drivers/scsi/ufs/Kconfig
@@ -67,3 +67,14 @@ config SCSI_UFSHCD_PCI
  If you have a controller with this interface, say Y or M here.
 
  If unsure, say N.
+
+config SCSI_UFSHCD_PLATFORM
+   tristate Platform based UFS Controller support
+   depends on SCSI_UFSHCD
+   ---help---
+   This selects the UFS host controller support. If you have a
+  platform with UFS controller, say Y or M here.
+
+  If you have a controller with this interface, say Y or M here.
+
+ If unsure, say N.
diff --git a/drivers/scsi/ufs/Makefile b/drivers/scsi/ufs/Makefile
index 9eda0df..1e5bd48 100644
--- a/drivers/scsi/ufs/Makefile
+++ b/drivers/scsi/ufs/Makefile
@@ -1,3 +1,4 @@
 # UFSHCD makefile
 obj-$(CONFIG_SCSI_UFSHCD) += ufshcd.o
 obj-$(CONFIG_SCSI_UFSHCD_PCI) += ufshcd-pci.o
+obj-$(CONFIG_SCSI_UFSHCD_PLATFORM) += ufshcd-pltfrm.o
diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
new file mode 100644
index 000..1d3a63f
--- /dev/null
+++ b/drivers/scsi/ufs/ufshcd-pltfrm.c
@@ -0,0 +1,215 @@
+/*
+ * Universal Flash Storage Host controller driver
+ *
+ * This code is based on drivers/scsi/ufs/ufshcd-pltfm.c
+ * Copyright (C) 2011-2012 Samsung India Software Operations
+ *
+ * Santosh Yaraganavi santosh...@samsung.com
+ * Vinayak Holikatti h.vina...@samsung.com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * NO WARRANTY
+ * THE PROGRAM IS PROVIDED ON AN AS IS BASIS, WITHOUT WARRANTIES OR
+ * CONDITIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED INCLUDING, WITHOUT
+ * LIMITATION, ANY WARRANTIES OR CONDITIONS OF TITLE, NON-INFRINGEMENT,
+ * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE. Each Recipient is
+ * solely responsible for determining the appropriateness of using and
+ * distributing the Program and assumes all risks associated with its
+ * exercise of rights under this Agreement, including but not limited to
+ * the risks and costs of program errors, damage to or loss of data,
+ * programs or equipment, and unavailability or interruption of operations.
+
+ * DISCLAIMER OF LIABILITY
+ * NEITHER RECIPIENT NOR ANY CONTRIBUTORS SHALL HAVE ANY LIABILITY FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING WITHOUT LIMITATION LOST PROFITS), HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
+ * TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
+ * USE OR DISTRIBUTION OF THE PROGRAM OR THE EXERCISE OF ANY RIGHTS GRANTED
+ * HEREUNDER, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGES
+
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301,
+ * USA.
+ */
+
+#include ufshcd.h
+#include ufshcd_common.h
+#include linux/platform_device.h
+
+#ifdef CONFIG_PM
+/**
+ * ufshcd_suspend - suspend power management function
+ * @pdev: pointer to Platform device handle
+ * @mesg: power state
+ *
+ * Returns -ENOSYS
+ */
+static int ufshcd_pltfrm_suspend(struct platform_device *pdev,
+pm_message_t mesg)
+{
+   /*
+* TODO:
+* 1. Block SCSI requests from SCSI midlayer
+* 2. Change the internal driver state to non operational
+* 3. Set UTRLRSR and UTMRLRSR bits to zero
+* 4. Wait until outstanding commands are completed
+* 5. Set HCE to zero to send the UFS host controller to reset state
+*/
+
+   return -ENOSYS;
+}
+
+/**
+ * ufshcd_resume - resume power management function
+ * @pdev: pointer to Platform device handle
+ *
+ * Returns -ENOSYS
+ */
+static int ufshcd_pltfrm_resume(struct platform_device *pdev)
+{
+   /*
+* TODO:
+* 1. Set HCE to 1, to start the UFS host controller
+* initialization process
+* 2. Set UTRLRSR and UTMRLRSR bits to 1
+* 3.