RE: [PATCH 1/3] s3c64xx: Fix build without SDHCI controllers

2010-06-11 Thread Kukjin Kim 

 -Original Message-
 From: Kyungmin Park [mailto:kyungmin.p...@samsung.com]
 Sent: Friday, June 11, 2010 1:35 PM
 To: 'Kukjin Kim'
 Cc: 'Marek Szyprowski'; linux-arm-ker...@lists.infradead.org; linux-samsung-
 s...@vger.kernel.org; linux-...@vger.kernel.org; ben-li...@fluff.org
 Subject: RE: [PATCH 1/3] s3c64xx: Fix build without SDHCI controllers
 
 
 
  -Original Message-
  From: Kukjin Kim [mailto:kgene@samsung.com]
  Sent: Friday, June 11, 2010 12:59 PM
  To: 'Kyungmin Park'
  Cc: 'Marek Szyprowski'; linux-arm-ker...@lists.infradead.org; linux-
  samsung-...@vger.kernel.org; linux-...@vger.kernel.org; ben-
  li...@fluff.org
  Subject: RE: [PATCH 1/3] s3c64xx: Fix build without SDHCI controllers
 
  Kyungmin Park wrote:
  
   On Fri, Jun 11, 2010 at 9:56 AM, Kukjin Kim kgene@samsung.com
  wrote:
Marek Szyprowski wrote:
   
This patch fixes the following compilation problem if only NCP
  machine
is selected:
   
arch/arm/mach-s3c64xx/s3c6410.c: In function ‘s3c6410_map_io’:
arch/arm/mach-s3c64xx/s3c6410.c:51: error: implicit declaration of
  function
‘s3c6410_default_sdhci2’
   
Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
 arch/arm/plat-samsung/include/plat/sdhci.h |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
   
diff --git a/arch/arm/plat-samsung/include/plat/sdhci.h
  b/arch/arm/plat-
samsung/include/plat/sdhci.h
index 13f9fb2..c2044e5 100644
--- a/arch/arm/plat-samsung/include/plat/sdhci.h
+++ b/arch/arm/plat-samsung/include/plat/sdhci.h
@@ -166,6 +166,7 @@ static inline void s3c6410_default_sdhci2(void)
  { }
 #else
 static inline void s3c6410_default_sdhci0(void) { }
 static inline void s3c6410_default_sdhci1(void) { }
+static inline void s3c6410_default_sdhci2(void) { }
 static inline void s3c6400_default_sdhci0(void) { }
 static inline void s3c6400_default_sdhci1(void) { }
   
--
   
Maybe missed in Maurus' patch 'S3C64XX: add HSMMC2 support'
commit 92b118f6968ae0788ac659af47b464acd9a754a1
  
   Which kernel tree do you use?
   it's against the latest kernel.
  
  Of course, Linus' 35-rc2.
 
 We used 63a07cb64ccc3ceae619d3298545d602ab5ecd38
 And there's no s3c6410_default_sdhci2(void) .
 
Hmm. Maybe some misunderstanding.

I meant maybe Maurus missed when he submitted HSMMC2 support patch.
(it means Marek's patch is correct)
And need 's3c6400_default_sdhci2()' as well as 's36410_default_sdhci2()' in 
Marek's patch.
So requested to re-submit updated patch.

 
  Any problem?
 
   
Also need 'static inline s3c6400_default_sdhci2(void) { }'
Could you re-submit updated patch including s3c6400_default_sdhci2()?
   
 
 


Thanks.

Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] s3c64xx: Fix build without SDHCI controllers

2010-06-10 Thread Kyungmin Park 
On Fri, Jun 11, 2010 at 9:56 AM, Kukjin Kim kgene@samsung.com wrote:
 Marek Szyprowski wrote:

 This patch fixes the following compilation problem if only NCP machine
 is selected:

 arch/arm/mach-s3c64xx/s3c6410.c: In function ‘s3c6410_map_io’:
 arch/arm/mach-s3c64xx/s3c6410.c:51: error: implicit declaration of function
 ‘s3c6410_default_sdhci2’

 Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
 Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
 ---
  arch/arm/plat-samsung/include/plat/sdhci.h |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

 diff --git a/arch/arm/plat-samsung/include/plat/sdhci.h b/arch/arm/plat-
 samsung/include/plat/sdhci.h
 index 13f9fb2..c2044e5 100644
 --- a/arch/arm/plat-samsung/include/plat/sdhci.h
 +++ b/arch/arm/plat-samsung/include/plat/sdhci.h
 @@ -166,6 +166,7 @@ static inline void s3c6410_default_sdhci2(void) { }
  #else
  static inline void s3c6410_default_sdhci0(void) { }
  static inline void s3c6410_default_sdhci1(void) { }
 +static inline void s3c6410_default_sdhci2(void) { }
  static inline void s3c6400_default_sdhci0(void) { }
  static inline void s3c6400_default_sdhci1(void) { }

 --

 Maybe missed in Maurus' patch 'S3C64XX: add HSMMC2 support'
 commit 92b118f6968ae0788ac659af47b464acd9a754a1

Which kernel tree do you use?
it's against the latest kernel.

Thank you,
Kyungmin Park


 Also need 'static inline s3c6400_default_sdhci2(void) { }'
 Could you re-submit updated patch including s3c6400_default_sdhci2()?

 Thanks.

 Best regards,
 Kgene.
 --
 Kukjin Kim kgene@samsung.com, Senior Engineer,
 SW Solution Development Team, Samsung Electronics Co., Ltd.

 --
 To unsubscribe from this list: send the line unsubscribe linux-samsung-soc 
 in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/3] s3c64xx: Fix build without SDHCI controllers

2010-06-10 Thread Kyungmin Park 


 -Original Message-
 From: Kukjin Kim [mailto:kgene@samsung.com]
 Sent: Friday, June 11, 2010 12:59 PM
 To: 'Kyungmin Park'
 Cc: 'Marek Szyprowski'; linux-arm-ker...@lists.infradead.org; linux-
 samsung-...@vger.kernel.org; linux-...@vger.kernel.org; ben-
 li...@fluff.org
 Subject: RE: [PATCH 1/3] s3c64xx: Fix build without SDHCI controllers
 
 Kyungmin Park wrote:
 
  On Fri, Jun 11, 2010 at 9:56 AM, Kukjin Kim kgene@samsung.com
 wrote:
   Marek Szyprowski wrote:
  
   This patch fixes the following compilation problem if only NCP
 machine
   is selected:
  
   arch/arm/mach-s3c64xx/s3c6410.c: In function ‘s3c6410_map_io’:
   arch/arm/mach-s3c64xx/s3c6410.c:51: error: implicit declaration of
 function
   ‘s3c6410_default_sdhci2’
  
   Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
   Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
   ---
arch/arm/plat-samsung/include/plat/sdhci.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
  
   diff --git a/arch/arm/plat-samsung/include/plat/sdhci.h
 b/arch/arm/plat-
   samsung/include/plat/sdhci.h
   index 13f9fb2..c2044e5 100644
   --- a/arch/arm/plat-samsung/include/plat/sdhci.h
   +++ b/arch/arm/plat-samsung/include/plat/sdhci.h
   @@ -166,6 +166,7 @@ static inline void s3c6410_default_sdhci2(void)
 { }
#else
static inline void s3c6410_default_sdhci0(void) { }
static inline void s3c6410_default_sdhci1(void) { }
   +static inline void s3c6410_default_sdhci2(void) { }
static inline void s3c6400_default_sdhci0(void) { }
static inline void s3c6400_default_sdhci1(void) { }
  
   --
  
   Maybe missed in Maurus' patch 'S3C64XX: add HSMMC2 support'
   commit 92b118f6968ae0788ac659af47b464acd9a754a1
 
  Which kernel tree do you use?
  it's against the latest kernel.
 
 Of course, Linus' 35-rc2.

We used 63a07cb64ccc3ceae619d3298545d602ab5ecd38
And there's no s3c6410_default_sdhci2(void) .

Thank you,
Kyungmin Park

 Any problem?
 
  
   Also need 'static inline s3c6400_default_sdhci2(void) { }'
   Could you re-submit updated patch including s3c6400_default_sdhci2()?
  
 
 
 Thanks.
 
 Best regards,
 Kgene.
 --
 Kukjin Kim kgene@samsung.com, Senior Engineer,
 SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html