RE: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD

2010-11-12 Thread Inki Dae
; a...@linux-foundation.org; 'Jonghun Han' Subject: Re: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD On Fri, Nov 12, 2010 at 06:54:29PM +0900, Inki Dae wrote: @@ -1314,13 +1319,22 @@ static int __devinit s3c_fb_probe(struct platform_device *pdev) sfb-pdata = pd; sfb-variant = fbdrv

Re: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD

2010-10-25 Thread han jonghun
Hi, Thanks for comment. [snip] I don't think that the driver is the right place to change the parent of the sclk_fimd clock. It should be done in the boot loader or the board startup code. As you know, there are two clock sources for LCD pixel clock. s3c-fb only used 'lcd' clock as

RE: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD

2010-10-20 Thread Jonghun Han
...@lists.infradead.org; linux-samsung- s...@vger.kernel.org; linux-fb...@vger.kernel.org Cc: 'Jonghun Han'; a...@linux-foundation.org; kgene@samsung.com; ben- li...@fluff.org; kyungmin.p...@samsung.com Subject: RE: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD 1AFAAVgAzADEAMAAgAEY ASQBNAEQA

RE: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD

2010-10-20 Thread Inki Dae
...@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- fb...@vger.kernel.org Cc: a...@linux-foundation.org; kgene@samsung.com; ben-li...@fluff.org; kyungmin.p...@samsung.com Subject: RE: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD 1AFAAVgAzADEAMAAgAEY ASQBNAEQA x-cr

RE: [PATCH 3/4] s3c-fb: Add support S5PV310 FIMD

2010-10-19 Thread Marek Szyprowski
1AFAAVgAzADEAMAAgAEY ASQBNAEQA x-cr-puzzleid: {C4CCB40E-D5C6-4119-AA7C-BBBA7A1503E4} Hello, On Monday, October 18, 2010 2:55 PM Sangbeom Kim wrote: From: Jonghun Han jonghun@samsung.com This patch adds s3c_fb_driverdata for S5PV310 FIMD0. The clk_type is added to distinguish