RE: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver
Joonyoung Shim wrote: On 8/2/2010 2:12 PM, Kukjin Kim wrote: Joonyoung Shim wrote: On 8/2/2010 12:38 PM, Kukjin Kim wrote: Joonyoung Shim wrote: Hi, I came back from vacation. Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including. I applied the patch adding samsung-keypad.c and the platform data arch/arm/plat-samsung/include/plat/keypad.h and I expect that patches to actually enable keypad will go through appropriate platform tree(s). OK, the rest will go through samsung platform tree Ok..will apply. Kukjin, could you remove keypad.h on the commit ARM: SAMSUNG: Add keypad device support of the samsung platform tree. The keypad.h file was included on input tree. (http://git.kernel.org/?p=linux/kernel/git/dtor/input.git;a=commit;h=0fffed27f92d9d7 a34de9fe017b7082b5958bb93) You mean in plat-samsung/dev-keypad.c? If remove inclusion plat/keypad.h in there, following build error happens. No. I mean to remove arch/arm/plat-samsung/include/plat/keypad.h file on samsung platform tree, it was applied on input tree already. If needs, i can repost. If it is not small change like to remove a file in a patch, I think should be re- submitted. Will drop your previous patch in my tree. arch/arm/plat-samsung/dev-keypad.c:41: warning: 'struct samsung_keypad_platdata' declared inside parameter list arch/arm/plat-samsung/dev-keypad.c:41: warning: its scope is only this definition or declaration, which is probably not what you want arch/arm/plat-samsung/dev-keypad.c: In function 'samsung_keypad_set_platdata': arch/arm/plat-samsung/dev-keypad.c:50: error: invalid application of 'sizeof' to incomplete type 'struct samsung_keypad_platdata' arch/arm/plat-samsung/dev-keypad.c:54: error: dereferencing pointer to incomplete type arch/arm/plat-samsung/dev-keypad.c:55: error: dereferencing pointer to incomplete type arch/arm/plat-samsung/dev-keypad.c:55: error: 'samsung_keypad_cfg_gpio' undeclared (first use in this function) arch/arm/plat-samsung/dev-keypad.c:55: error: (Each undeclared identifier is reported only once arch/arm/plat-samsung/dev-keypad.c:55: error: for each function it appears in.) make[1]: *** [arch/arm/plat-samsung/dev-keypad.o] Error 1 As you know, released 35 today. So we have no much time for this merge window. I'm not sure about merge rule, but I think the compile problem can be solved by merge to 36 of input tree and samsung platform tree. Hmm...actually, already informed about that on linux-next. If it's just build problem, I or Dmitry can fix it. However, this is not just that. I cannot understand how your 'plat/keypad.h' was included to both of patch. Please see the prior mail history. The keypad.h file is included only at the 1/3 patch in the original patch set, but Dmitry applied the 3/3 patch modified with keypad.h. The basic problem is that each patches be applied on two tree. It makes compile errors at the one tree lacking keypad.h file because both tree share keypad.h file. There are two solutions, First, all patches go to one tree. Second, we wait for merging to 36 of both tree then apply platform patches. And I'm not sure, should be 'plat/keypad.h' in which tree... Hi Dmitry, How can/should I do for it?...Which way is better to us? :-) Joonyoung, Let's wait for Dmitry's reply. I will holding drop your previous patch in my tree till that time. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver
On Mon, Aug 02, 2010 at 03:30:57PM +0900, Kukjin Kim wrote: Joonyoung Shim wrote: On 8/2/2010 2:12 PM, Kukjin Kim wrote: Joonyoung Shim wrote: On 8/2/2010 12:38 PM, Kukjin Kim wrote: Joonyoung Shim wrote: Hi, I came back from vacation. Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including. I applied the patch adding samsung-keypad.c and the platform data arch/arm/plat-samsung/include/plat/keypad.h and I expect that patches to actually enable keypad will go through appropriate platform tree(s). OK, the rest will go through samsung platform tree Ok..will apply. Kukjin, could you remove keypad.h on the commit ARM: SAMSUNG: Add keypad device support of the samsung platform tree. The keypad.h file was included on input tree. (http://git.kernel.org/?p=linux/kernel/git/dtor/input.git;a=commit;h=0fffed27f92d9d7 a34de9fe017b7082b5958bb93) You mean in plat-samsung/dev-keypad.c? If remove inclusion plat/keypad.h in there, following build error happens. No. I mean to remove arch/arm/plat-samsung/include/plat/keypad.h file on samsung platform tree, it was applied on input tree already. If needs, i can repost. If it is not small change like to remove a file in a patch, I think should be re- submitted. Will drop your previous patch in my tree. arch/arm/plat-samsung/dev-keypad.c:41: warning: 'struct samsung_keypad_platdata' declared inside parameter list arch/arm/plat-samsung/dev-keypad.c:41: warning: its scope is only this definition or declaration, which is probably not what you want arch/arm/plat-samsung/dev-keypad.c: In function 'samsung_keypad_set_platdata': arch/arm/plat-samsung/dev-keypad.c:50: error: invalid application of 'sizeof' to incomplete type 'struct samsung_keypad_platdata' arch/arm/plat-samsung/dev-keypad.c:54: error: dereferencing pointer to incomplete type arch/arm/plat-samsung/dev-keypad.c:55: error: dereferencing pointer to incomplete type arch/arm/plat-samsung/dev-keypad.c:55: error: 'samsung_keypad_cfg_gpio' undeclared (first use in this function) arch/arm/plat-samsung/dev-keypad.c:55: error: (Each undeclared identifier is reported only once arch/arm/plat-samsung/dev-keypad.c:55: error: for each function it appears in.) make[1]: *** [arch/arm/plat-samsung/dev-keypad.o] Error 1 As you know, released 35 today. So we have no much time for this merge window. I'm not sure about merge rule, but I think the compile problem can be solved by merge to 36 of input tree and samsung platform tree. Hmm...actually, already informed about that on linux-next. If it's just build problem, I or Dmitry can fix it. However, this is not just that. I cannot understand how your 'plat/keypad.h' was included to both of patch. Please see the prior mail history. The keypad.h file is included only at the 1/3 patch in the original patch set, but Dmitry applied the 3/3 patch modified with keypad.h. The basic problem is that each patches be applied on two tree. It makes compile errors at the one tree lacking keypad.h file because both tree share keypad.h file. There are two solutions, First, all patches go to one tree. Second, we wait for merging to 36 of both tree then apply platform patches. And I'm not sure, should be 'plat/keypad.h' in which tree... Hi Dmitry, How can/should I do for it?...Which way is better to us? :-) Joonyoung, Let's wait for Dmitry's reply. I will holding drop your previous patch in my tree till that time. Kgene, I will be sending pull request to Linus in the next day or so, so it will have plat/keypad.h as it is in my tree. Once you merge (with his or mine) you have an option to patching the plat/keypad.h with hooks that I removed, although I would prefer if you changed the way you initialize your devices since having the these hooks defeats the purpose of having config pointer in platform data. Another option would be to have a separate include file for the hooks, one that drivers/input/keyboard/samsung-keypad.c does not use. Thanks. -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver
Dmitry Torokhov wrote: On Mon, Aug 02, 2010 at 03:30:57PM +0900, Kukjin Kim wrote: Joonyoung Shim wrote: On 8/2/2010 2:12 PM, Kukjin Kim wrote: Joonyoung Shim wrote: On 8/2/2010 12:38 PM, Kukjin Kim wrote: Joonyoung Shim wrote: Hi, I came back from vacation. Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including. I applied the patch adding samsung-keypad.c and the platform data arch/arm/plat-samsung/include/plat/keypad.h and I expect that patches to actually enable keypad will go through appropriate platform tree(s). OK, the rest will go through samsung platform tree Ok..will apply. Kukjin, could you remove keypad.h on the commit ARM: SAMSUNG: Add keypad device support of the samsung platform tree. The keypad.h file was included on input tree. (http://git.kernel.org/?p=linux/kernel/git/dtor/input.git;a=commit;h=0fffed2 7f92d9d7 a34de9fe017b7082b5958bb93) You mean in plat-samsung/dev-keypad.c? If remove inclusion plat/keypad.h in there, following build error happens. No. I mean to remove arch/arm/plat-samsung/include/plat/keypad.h file on samsung platform tree, it was applied on input tree already. If needs, i can repost. If it is not small change like to remove a file in a patch, I think should be re- submitted. Will drop your previous patch in my tree. arch/arm/plat-samsung/dev-keypad.c:41: warning: 'struct samsung_keypad_platdata' declared inside parameter list arch/arm/plat-samsung/dev-keypad.c:41: warning: its scope is only this definition or declaration, which is probably not what you want arch/arm/plat-samsung/dev-keypad.c: In function 'samsung_keypad_set_platdata': arch/arm/plat-samsung/dev-keypad.c:50: error: invalid application of 'sizeof' to incomplete type 'struct samsung_keypad_platdata' arch/arm/plat-samsung/dev-keypad.c:54: error: dereferencing pointer to incomplete type arch/arm/plat-samsung/dev-keypad.c:55: error: dereferencing pointer to incomplete type arch/arm/plat-samsung/dev-keypad.c:55: error: 'samsung_keypad_cfg_gpio' undeclared (first use in this function) arch/arm/plat-samsung/dev-keypad.c:55: error: (Each undeclared identifier is reported only once arch/arm/plat-samsung/dev-keypad.c:55: error: for each function it appears in.) make[1]: *** [arch/arm/plat-samsung/dev-keypad.o] Error 1 As you know, released 35 today. So we have no much time for this merge window. I'm not sure about merge rule, but I think the compile problem can be solved by merge to 36 of input tree and samsung platform tree. Hmm...actually, already informed about that on linux-next. If it's just build problem, I or Dmitry can fix it. However, this is not just that. I cannot understand how your 'plat/keypad.h' was included to both of patch. Please see the prior mail history. The keypad.h file is included only at the 1/3 patch in the original patch set, but Dmitry applied the 3/3 patch modified with keypad.h. The basic problem is that each patches be applied on two tree. It makes compile errors at the one tree lacking keypad.h file because both tree share keypad.h file. There are two solutions, First, all patches go to one tree. Second, we wait for merging to 36 of both tree then apply platform patches. And I'm not sure, should be 'plat/keypad.h' in which tree... Hi Dmitry, How can/should I do for it?...Which way is better to us? :-) Joonyoung, Let's wait for Dmitry's reply. I will holding drop your previous patch in my tree till that time. Kgene, I will be sending pull request to Linus in the next day or so, so it will have plat/keypad.h as it is in my tree. Once you merge (with his or mine) you have an option to patching the plat/keypad.h with hooks that I removed, although I would prefer if you changed the way you initialize your devices since having the these hooks defeats the purpose of having config pointer in platform data. Another option would be to have a separate include file for the hooks, one that drivers/input/keyboard/samsung-keypad.c does not use. Thanks. Hi Dmitry, Hmm...I saw your pull request to Linus...ok...will replace new one which don't have duplicate 'plat/keypad.h' in my tree. But..in this case, I'm not sure which way is better to us... Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver
Joonyoung Shim wrote: Hi, I came back from vacation. Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including. I applied the patch adding samsung-keypad.c and the platform data arch/arm/plat-samsung/include/plat/keypad.h and I expect that patches to actually enable keypad will go through appropriate platform tree(s). OK, the rest will go through samsung platform tree Ok..will apply. Kukjin, could you remove keypad.h on the commit ARM: SAMSUNG: Add keypad device support of the samsung platform tree. The keypad.h file was included on input tree. (http://git.kernel.org/?p=linux/kernel/git/dtor/input.git;a=commit;h=0fffed27f92d9d7 a34de9fe017b7082b5958bb93) You mean in plat-samsung/dev-keypad.c? If remove inclusion plat/keypad.h in there, following build error happens. arch/arm/plat-samsung/dev-keypad.c:41: warning: 'struct samsung_keypad_platdata' declared inside parameter list arch/arm/plat-samsung/dev-keypad.c:41: warning: its scope is only this definition or declaration, which is probably not what you want arch/arm/plat-samsung/dev-keypad.c: In function 'samsung_keypad_set_platdata': arch/arm/plat-samsung/dev-keypad.c:50: error: invalid application of 'sizeof' to incomplete type 'struct samsung_keypad_platdata' arch/arm/plat-samsung/dev-keypad.c:54: error: dereferencing pointer to incomplete type arch/arm/plat-samsung/dev-keypad.c:55: error: dereferencing pointer to incomplete type arch/arm/plat-samsung/dev-keypad.c:55: error: 'samsung_keypad_cfg_gpio' undeclared (first use in this function) arch/arm/plat-samsung/dev-keypad.c:55: error: (Each undeclared identifier is reported only once arch/arm/plat-samsung/dev-keypad.c:55: error: for each function it appears in.) make[1]: *** [arch/arm/plat-samsung/dev-keypad.o] Error 1 As you know, released 35 today. So we have no much time for this merge window. The only caveat is that I removed declarations for copying platform data around and for gpio config function - if it is there there is no point of invoking it through the pointer in platform data. I agree, but currently samsung platform framework uses such this way. I believe these can change later at once. Dmitry, could you apply original keypad.h. We can get problem such this on most samsung device driver too. As i said before, these can be fixed later. Overall I am confused why you set up keypad in platform code in the way you do. I'd put the device definitions and all supporting functions in the same module that registers platform device and be done with it. Thanks. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver
Joonyoung Shim wrote: On 8/2/2010 12:38 PM, Kukjin Kim wrote: Joonyoung Shim wrote: Hi, I came back from vacation. Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including. I applied the patch adding samsung-keypad.c and the platform data arch/arm/plat-samsung/include/plat/keypad.h and I expect that patches to actually enable keypad will go through appropriate platform tree(s). OK, the rest will go through samsung platform tree Ok..will apply. Kukjin, could you remove keypad.h on the commit ARM: SAMSUNG: Add keypad device support of the samsung platform tree. The keypad.h file was included on input tree. (http://git.kernel.org/?p=linux/kernel/git/dtor/input.git;a=commit;h=0fffed27f92d9d7 a34de9fe017b7082b5958bb93) You mean in plat-samsung/dev-keypad.c? If remove inclusion plat/keypad.h in there, following build error happens. No. I mean to remove arch/arm/plat-samsung/include/plat/keypad.h file on samsung platform tree, it was applied on input tree already. If needs, i can repost. If it is not small change like to remove a file in a patch, I think should be re-submitted. Will drop your previous patch in my tree. arch/arm/plat-samsung/dev-keypad.c:41: warning: 'struct samsung_keypad_platdata' declared inside parameter list arch/arm/plat-samsung/dev-keypad.c:41: warning: its scope is only this definition or declaration, which is probably not what you want arch/arm/plat-samsung/dev-keypad.c: In function 'samsung_keypad_set_platdata': arch/arm/plat-samsung/dev-keypad.c:50: error: invalid application of 'sizeof' to incomplete type 'struct samsung_keypad_platdata' arch/arm/plat-samsung/dev-keypad.c:54: error: dereferencing pointer to incomplete type arch/arm/plat-samsung/dev-keypad.c:55: error: dereferencing pointer to incomplete type arch/arm/plat-samsung/dev-keypad.c:55: error: 'samsung_keypad_cfg_gpio' undeclared (first use in this function) arch/arm/plat-samsung/dev-keypad.c:55: error: (Each undeclared identifier is reported only once arch/arm/plat-samsung/dev-keypad.c:55: error: for each function it appears in.) make[1]: *** [arch/arm/plat-samsung/dev-keypad.o] Error 1 As you know, released 35 today. So we have no much time for this merge window. I'm not sure about merge rule, but I think the compile problem can be solved by merge to 36 of input tree and samsung platform tree. Hmm...actually, already informed about that on linux-next. If it's just build problem, I or Dmitry can fix it. However, this is not just that. I cannot understand how your 'plat/keypad.h' was included to both of patch. And I'm not sure, should be 'plat/keypad.h' in which tree... Anyway, as I said, should be solved that as soon as possible Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver
On 8/2/2010 2:12 PM, Kukjin Kim wrote: Joonyoung Shim wrote: On 8/2/2010 12:38 PM, Kukjin Kim wrote: Joonyoung Shim wrote: Hi, I came back from vacation. Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including. I applied the patch adding samsung-keypad.c and the platform data arch/arm/plat-samsung/include/plat/keypad.h and I expect that patches to actually enable keypad will go through appropriate platform tree(s). OK, the rest will go through samsung platform tree Ok..will apply. Kukjin, could you remove keypad.h on the commit ARM: SAMSUNG: Add keypad device support of the samsung platform tree. The keypad.h file was included on input tree. (http://git.kernel.org/?p=linux/kernel/git/dtor/input.git;a=commit;h=0fffed27f92d9d7 a34de9fe017b7082b5958bb93) You mean in plat-samsung/dev-keypad.c? If remove inclusion plat/keypad.h in there, following build error happens. No. I mean to remove arch/arm/plat-samsung/include/plat/keypad.h file on samsung platform tree, it was applied on input tree already. If needs, i can repost. If it is not small change like to remove a file in a patch, I think should be re-submitted. Will drop your previous patch in my tree. arch/arm/plat-samsung/dev-keypad.c:41: warning: 'struct samsung_keypad_platdata' declared inside parameter list arch/arm/plat-samsung/dev-keypad.c:41: warning: its scope is only this definition or declaration, which is probably not what you want arch/arm/plat-samsung/dev-keypad.c: In function 'samsung_keypad_set_platdata': arch/arm/plat-samsung/dev-keypad.c:50: error: invalid application of 'sizeof' to incomplete type 'struct samsung_keypad_platdata' arch/arm/plat-samsung/dev-keypad.c:54: error: dereferencing pointer to incomplete type arch/arm/plat-samsung/dev-keypad.c:55: error: dereferencing pointer to incomplete type arch/arm/plat-samsung/dev-keypad.c:55: error: 'samsung_keypad_cfg_gpio' undeclared (first use in this function) arch/arm/plat-samsung/dev-keypad.c:55: error: (Each undeclared identifier is reported only once arch/arm/plat-samsung/dev-keypad.c:55: error: for each function it appears in.) make[1]: *** [arch/arm/plat-samsung/dev-keypad.o] Error 1 As you know, released 35 today. So we have no much time for this merge window. I'm not sure about merge rule, but I think the compile problem can be solved by merge to 36 of input tree and samsung platform tree. Hmm...actually, already informed about that on linux-next. If it's just build problem, I or Dmitry can fix it. However, this is not just that. I cannot understand how your 'plat/keypad.h' was included to both of patch. Please see the prior mail history. The keypad.h file is included only at the 1/3 patch in the original patch set, but Dmitry applied the 3/3 patch modified with keypad.h. The basic problem is that each patches be applied on two tree. It makes compile errors at the one tree lacking keypad.h file because both tree share keypad.h file. There are two solutions, First, all patches go to one tree. Second, we wait for merging to 36 of both tree then apply platform patches. And I'm not sure, should be 'plat/keypad.h' in which tree... -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver
Joonyoung Shim wrote: On 7/21/2010 5:07 PM, Dmitry Torokhov wrote: Hi Joonyoung, On Wed, Jul 21, 2010 at 02:42:22PM +0900, Joonyoung Shim wrote: Hi, Dmitry. On 7/9/2010 4:39 PM, Joonyoung Shim wrote: On 7/9/2010 4:07 PM, Kukjin Kim wrote: Joonyoung Shim wrote: On 7/7/2010 8:52 AM, Kukjin Kim wrote: Joonyoung Shim wrote: Hi, Naveen. On 6/28/2010 8:33 PM, Joonyoung Shim wrote: This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/input/keyboard/Kconfig |9 + drivers/input/keyboard/Makefile |1 + drivers/input/keyboard/samsung-keypad.c | 491 +++ 3 files changed, 501 insertions(+), 0 deletions(-) create mode 100644 drivers/input/keyboard/samsung-keypad.c Could you please test this v6 keypad driver on your various targets? Hi, I received the test result from Naveen. And now he is debugging about that. ..his e-mail client has some problem..so I replied... --- From: Naveen Ch I've tested with v6 patches and they are working fine on SMDK6410, SMDKC100 and SMDKV210, except for some header inclusion (linux/sched.h) in samsung- keypad.c. The build breaking error is like following: (make s5pc100_defconfig and select input-keypad-samsung keypad) drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_irq': drivers/input/keyboard/samsung-keypad.c:170: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function) drivers/input/keyboard/samsung-keypad.c:170: error: (Each undeclared identifier is reported only once drivers/input/keyboard/samsung-keypad.c:170: error: for each function it appears in.) drivers/input/keyboard/samsung-keypad.c:170: error: implicit declaration of function 'schedule_timeout' drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_stop': drivers/input/keyboard/samsung-keypad.c:202: error: 'TASK_NORMAL' undeclared (first use in this function) make[3]: *** [drivers/input/keyboard/samsung-keypad.o] Error 1 This error occurs on s5pc100_defconfig having disabled CONFIG_PREEMPT option. I think sched.h should be included to remove like this dependency in driver, are there other ways? I'm not sure root cause is that. But as you said, I think need inclusion it for prevent the problem. Actually didn't happen it before..so maybe the some core functions have moved between rc-3 and earlier versions... The sched.h is included by below path. interrupt.h - hardirq.h - smp_lock.h - sched.h The smp_lock.h in hardirq.h is included if CONFIG_PREEMPT is defined. The samsung keypad driver haven't needed including sched.h before Dmitry's patch is applied.. Anyway, if no any issues, could you please re-submit updated it soon? I haven't get yet Dmitry's review of v6 patch set, so i am waiting it. Ping. Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including. I applied the patch adding samsung-keypad.c and the platform data arch/arm/plat-samsung/include/plat/keypad.h and I expect that patches to actually enable keypad will go through appropriate platform tree(s). OK, the rest will go through samsung platform tree Ok..will apply. The only caveat is that I removed declarations for copying platform data around and for gpio config function - if it is there there is no point of invoking it through the pointer in platform data. I agree, but currently samsung platform framework uses such this way. I believe these can change later at once. Overall I am confused why you set up keypad in platform code in the way you do. I'd put the device definitions and all supporting functions in the same module that registers platform device and be done with it. Thanks. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver
Hi, Dmitry. On 7/9/2010 4:39 PM, Joonyoung Shim wrote: On 7/9/2010 4:07 PM, Kukjin Kim wrote: Joonyoung Shim wrote: On 7/7/2010 8:52 AM, Kukjin Kim wrote: Joonyoung Shim wrote: Hi, Naveen. On 6/28/2010 8:33 PM, Joonyoung Shim wrote: This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/input/keyboard/Kconfig |9 + drivers/input/keyboard/Makefile |1 + drivers/input/keyboard/samsung-keypad.c | 491 +++ 3 files changed, 501 insertions(+), 0 deletions(-) create mode 100644 drivers/input/keyboard/samsung-keypad.c Could you please test this v6 keypad driver on your various targets? Hi, I received the test result from Naveen. And now he is debugging about that. ..his e-mail client has some problem..so I replied... --- From: Naveen Ch I've tested with v6 patches and they are working fine on SMDK6410, SMDKC100 and SMDKV210, except for some header inclusion (linux/sched.h) in samsung- keypad.c. The build breaking error is like following: (make s5pc100_defconfig and select input-keypad-samsung keypad) drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_irq': drivers/input/keyboard/samsung-keypad.c:170: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function) drivers/input/keyboard/samsung-keypad.c:170: error: (Each undeclared identifier is reported only once drivers/input/keyboard/samsung-keypad.c:170: error: for each function it appears in.) drivers/input/keyboard/samsung-keypad.c:170: error: implicit declaration of function 'schedule_timeout' drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_stop': drivers/input/keyboard/samsung-keypad.c:202: error: 'TASK_NORMAL' undeclared (first use in this function) make[3]: *** [drivers/input/keyboard/samsung-keypad.o] Error 1 This error occurs on s5pc100_defconfig having disabled CONFIG_PREEMPT option. I think sched.h should be included to remove like this dependency in driver, are there other ways? I'm not sure root cause is that. But as you said, I think need inclusion it for prevent the problem. Actually didn't happen it before..so maybe the some core functions have moved between rc-3 and earlier versions... The sched.h is included by below path. interrupt.h - hardirq.h - smp_lock.h - sched.h The smp_lock.h in hardirq.h is included if CONFIG_PREEMPT is defined. The samsung keypad driver haven't needed including sched.h before Dmitry's patch is applied.. Anyway, if no any issues, could you please re-submit updated it soon? I haven't get yet Dmitry's review of v6 patch set, so i am waiting it. Ping. Do you have any feedback? If ok, i want to go to input tree or samsung tree these added sched.h including. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver
Joonyoung Shim wrote: On 7/7/2010 8:52 AM, Kukjin Kim wrote: Joonyoung Shim wrote: Hi, Naveen. On 6/28/2010 8:33 PM, Joonyoung Shim wrote: This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/input/keyboard/Kconfig |9 + drivers/input/keyboard/Makefile |1 + drivers/input/keyboard/samsung-keypad.c | 491 +++ 3 files changed, 501 insertions(+), 0 deletions(-) create mode 100644 drivers/input/keyboard/samsung-keypad.c Could you please test this v6 keypad driver on your various targets? Hi, I received the test result from Naveen. And now he is debugging about that. ..his e-mail client has some problem..so I replied... --- From: Naveen Ch I've tested with v6 patches and they are working fine on SMDK6410, SMDKC100 and SMDKV210, except for some header inclusion (linux/sched.h) in samsung- keypad.c. The build breaking error is like following: (make s5pc100_defconfig and select input-keypad-samsung keypad) drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_irq': drivers/input/keyboard/samsung-keypad.c:170: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function) drivers/input/keyboard/samsung-keypad.c:170: error: (Each undeclared identifier is reported only once drivers/input/keyboard/samsung-keypad.c:170: error: for each function it appears in.) drivers/input/keyboard/samsung-keypad.c:170: error: implicit declaration of function 'schedule_timeout' drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_stop': drivers/input/keyboard/samsung-keypad.c:202: error: 'TASK_NORMAL' undeclared (first use in this function) make[3]: *** [drivers/input/keyboard/samsung-keypad.o] Error 1 This error occurs on s5pc100_defconfig having disabled CONFIG_PREEMPT option. I think sched.h should be included to remove like this dependency in driver, are there other ways? I'm not sure root cause is that. But as you said, I think need inclusion it for prevent the problem. Actually didn't happen it before..so maybe the some core functions have moved between rc-3 and earlier versions... Anyway, if no any issues, could you please re-submit updated it soon? Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver
On 7/9/2010 4:07 PM, Kukjin Kim wrote: Joonyoung Shim wrote: On 7/7/2010 8:52 AM, Kukjin Kim wrote: Joonyoung Shim wrote: Hi, Naveen. On 6/28/2010 8:33 PM, Joonyoung Shim wrote: This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/input/keyboard/Kconfig |9 + drivers/input/keyboard/Makefile |1 + drivers/input/keyboard/samsung-keypad.c | 491 +++ 3 files changed, 501 insertions(+), 0 deletions(-) create mode 100644 drivers/input/keyboard/samsung-keypad.c Could you please test this v6 keypad driver on your various targets? Hi, I received the test result from Naveen. And now he is debugging about that. ..his e-mail client has some problem..so I replied... --- From: Naveen Ch I've tested with v6 patches and they are working fine on SMDK6410, SMDKC100 and SMDKV210, except for some header inclusion (linux/sched.h) in samsung- keypad.c. The build breaking error is like following: (make s5pc100_defconfig and select input-keypad-samsung keypad) drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_irq': drivers/input/keyboard/samsung-keypad.c:170: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function) drivers/input/keyboard/samsung-keypad.c:170: error: (Each undeclared identifier is reported only once drivers/input/keyboard/samsung-keypad.c:170: error: for each function it appears in.) drivers/input/keyboard/samsung-keypad.c:170: error: implicit declaration of function 'schedule_timeout' drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_stop': drivers/input/keyboard/samsung-keypad.c:202: error: 'TASK_NORMAL' undeclared (first use in this function) make[3]: *** [drivers/input/keyboard/samsung-keypad.o] Error 1 This error occurs on s5pc100_defconfig having disabled CONFIG_PREEMPT option. I think sched.h should be included to remove like this dependency in driver, are there other ways? I'm not sure root cause is that. But as you said, I think need inclusion it for prevent the problem. Actually didn't happen it before..so maybe the some core functions have moved between rc-3 and earlier versions... The sched.h is included by below path. interrupt.h - hardirq.h - smp_lock.h - sched.h The smp_lock.h in hardirq.h is included if CONFIG_PREEMPT is defined. The samsung keypad driver haven't needed including sched.h before Dmitry's patch is applied.. Anyway, if no any issues, could you please re-submit updated it soon? I haven't get yet Dmitry's review of v6 patch set, so i am waiting it. Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver
Hi, Naveen. On 6/28/2010 8:33 PM, Joonyoung Shim wrote: This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/input/keyboard/Kconfig |9 + drivers/input/keyboard/Makefile |1 + drivers/input/keyboard/samsung-keypad.c | 491 +++ 3 files changed, 501 insertions(+), 0 deletions(-) create mode 100644 drivers/input/keyboard/samsung-keypad.c Could you please test this v6 keypad driver on your various targets? -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver
Joonyoung Shim wrote: Hi, Naveen. On 6/28/2010 8:33 PM, Joonyoung Shim wrote: This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/input/keyboard/Kconfig |9 + drivers/input/keyboard/Makefile |1 + drivers/input/keyboard/samsung-keypad.c | 491 +++ 3 files changed, 501 insertions(+), 0 deletions(-) create mode 100644 drivers/input/keyboard/samsung-keypad.c Could you please test this v6 keypad driver on your various targets? Hi, I received the test result from Naveen. And now he is debugging about that. ..his e-mail client has some problem..so I replied... --- From: Naveen Ch I've tested with v6 patches and they are working fine on SMDK6410, SMDKC100 and SMDKV210, except for some header inclusion (linux/sched.h) in samsung-keypad.c. The build breaking error is like following: (make s5pc100_defconfig and select input-keypad-samsung keypad) drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_irq': drivers/input/keyboard/samsung-keypad.c:170: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function) drivers/input/keyboard/samsung-keypad.c:170: error: (Each undeclared identifier is reported only once drivers/input/keyboard/samsung-keypad.c:170: error: for each function it appears in.) drivers/input/keyboard/samsung-keypad.c:170: error: implicit declaration of function 'schedule_timeout' drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_stop': drivers/input/keyboard/samsung-keypad.c:202: error: 'TASK_NORMAL' undeclared (first use in this function) make[3]: *** [drivers/input/keyboard/samsung-keypad.o] Error 1 --- Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 3/3] input: samsung-keypad - Add samsung keypad driver
On 7/7/2010 8:52 AM, Kukjin Kim wrote: Joonyoung Shim wrote: Hi, Naveen. On 6/28/2010 8:33 PM, Joonyoung Shim wrote: This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/input/keyboard/Kconfig |9 + drivers/input/keyboard/Makefile |1 + drivers/input/keyboard/samsung-keypad.c | 491 +++ 3 files changed, 501 insertions(+), 0 deletions(-) create mode 100644 drivers/input/keyboard/samsung-keypad.c Could you please test this v6 keypad driver on your various targets? Hi, I received the test result from Naveen. And now he is debugging about that. ..his e-mail client has some problem..so I replied... --- From: Naveen Ch I've tested with v6 patches and they are working fine on SMDK6410, SMDKC100 and SMDKV210, except for some header inclusion (linux/sched.h) in samsung-keypad.c. The build breaking error is like following: (make s5pc100_defconfig and select input-keypad-samsung keypad) drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_irq': drivers/input/keyboard/samsung-keypad.c:170: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function) drivers/input/keyboard/samsung-keypad.c:170: error: (Each undeclared identifier is reported only once drivers/input/keyboard/samsung-keypad.c:170: error: for each function it appears in.) drivers/input/keyboard/samsung-keypad.c:170: error: implicit declaration of function 'schedule_timeout' drivers/input/keyboard/samsung-keypad.c: In function 'samsung_keypad_stop': drivers/input/keyboard/samsung-keypad.c:202: error: 'TASK_NORMAL' undeclared (first use in this function) make[3]: *** [drivers/input/keyboard/samsung-keypad.o] Error 1 This error occurs on s5pc100_defconfig having disabled CONFIG_PREEMPT option. I think sched.h should be included to remove like this dependency in driver, are there other ways? -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
