RE: [PATCH] ARM: S5PV210: Fix on SECTION_SIZE_BITS on S5PV210/S5PC110.
Russell King wrote: On Thu, Jul 08, 2010 at 09:01:16AM +0900, Kukjin Kim wrote: Ok...let's suppose the size of section is 32MiB. Physical Mem.Sections . . . . . . | || | 0x3000 0x3000 | || offline | | | 0x2C00 | || offline | | | 0x2A00 | none || offline | | | 0x2800 | || offline | | | 0x2600 0x2500 | *online | | | 0x2400 | || online | | 80 MiB | 0x2200 | || online | 0x2000 0x2000 In the above diagram, *section includes a 'hole' that is invalid online area between 0x2500 and 0x2600. So, memory starts at 0x2000 and finishes at 0x2500. That's fine. That doesn't mean the section size is 16MB. As I've already said, the section size has _nothing_ what so ever to do with the size of memory, or the granularity of the size of memory. By way of illustration, it is perfectly legal to have a section size of 256MB but only have 1MB in a section and this is perfectly legal. So sections do not have to be completely filled. Actually, as you know, the hole's area of mem_map is freed from bootmem if a section has a hole when initializing sparse memory. I identified that a section doesn't need to be a contiguous area of physical memory when reading your comment with the fact that the mem_map of a section can be smaller than the size of a section. I found, however, the kernel panics when modifying min_free_kbytes file in the proc filesystem if a section has a hole. While processing the change of min_free_kbytes in the kernel, page descriptors in a hole of an online section is accessed. Hmm... Also, what is the maximum physical address which memory can be located? Following is memory map of S5PV210/S5PC110. 0x8000 --- | | 0x7000 | | | | 0x6000 | DMC 1 | up to 1GiB | | 0x5000 | | | | 0x4000 - | | 0x3000 | DMC 0 | up to 512MiB | | 0x2000 --- So from this diagram, the sections should be 512MB - SECTION_SIZE_BITS should be 28. Maybe typo...should be 29 when it is 512MiB. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] ARM: S5PV210: Fix on SECTION_SIZE_BITS on S5PV210/S5PC110.
Russell King wrote: On Wed, Jul 07, 2010 at 08:27:53AM +0900, Kukjin Kim wrote: Russell King wrote: What is the spacing of chunks of memory, and minimum alignment of those chunks in physical address space? Some S5PC110(MCP D-type) has only available 80MiB in a bank. So the space accounts for 432MiB in a DMC0, but larger memory(256MiB + 128MiB) exists in a DMC1. Ok. As you know, the size of a section should be a power of 2 and a physical address space of a section should be contiguous. If a section size is greater than 16MiB, a section have a hole. So the SECTION_SIZE_BITS should be 16MiB. Where is this hole? Please show it as a diagram similar to the one you've produced below. Ok...let's suppose the size of section is 32MiB. Physical Mem.Sections . . . . . . | || | 0x3000 0x3000 | || offline | | | 0x2C00 | || offline | | | 0x2A00 | none || offline | | | 0x2800 | || offline | | | 0x2600 0x2500 | *online | | | 0x2400 | || online | | 80 MiB | 0x2200 | || online | 0x2000 0x2000 In the above diagram, *section includes a 'hole' that is invalid online area between 0x2500 and 0x2600. Also, what is the maximum physical address which memory can be located? Following is memory map of S5PV210/S5PC110. 0x8000 --- | | 0x7000 | | | | 0x6000 | DMC 1 | up to 1GiB | | 0x5000 | | | | 0x4000 - | | 0x3000 | DMC 0 | up to 512MiB | | 0x2000 --- Right, so MAX_PHYSMEM_BITS is 31 and not 32 as you don't have memory at or above 0x8000. This will immediately halve the amount of sparsemem supporting structures irrespective of the SECTION_SIZE_BITS value. Ok..will fix it. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: S5PV210: Fix on SECTION_SIZE_BITS on S5PV210/S5PC110.
On Tue, Jul 06, 2010 at 01:36:47PM +0900, Kukjin Kim wrote: This patch fixes on SECTION_SIZE_BITS for Sparsemem on S5PV210/S5PC110. Because smallest size of a bank on S5PV210/S5PC110 is aligned by 16MB. So each section's maximum size should be 16MB. What is the spacing of chunks of memory, and minimum alignment of those chunks in physical address space? Also, what is the maximum physical address which memory can be located? -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: S5PV210: Fix on SECTION_SIZE_BITS on S5PV210/S5PC110.
Hello. Kukjin Kim wrote: This patch fixes on SECTION_SIZE_BITS for Sparsemem on S5PV210/S5PC110. Because smallest size of a bank on S5PV210/S5PC110 is aligned by 16MB. So each section's maximum size should be 16MB. Reported-by: Kyongho Cho pullip@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- arch/arm/mach-s5pv210/include/mach/memory.h |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-s5pv210/include/mach/memory.h b/arch/arm/mach-s5pv210/include/mach/memory.h index 379117e..4a372d8 100644 --- a/arch/arm/mach-s5pv210/include/mach/memory.h +++ b/arch/arm/mach-s5pv210/include/mach/memory.h @@ -16,8 +16,12 @@ #define PHYS_OFFSETUL(0x2000) #define CONSISTENT_DMA_SIZE(SZ_8M + SZ_4M + SZ_2M) -/* Maximum of 256MiB in one bank */ +/* Sparsemem support. Each section is a maximum of 16MB. + * Because there are many different memory type on S5PC110(MCP), + * and there is a case that having 80MB, 128MB or 256MB in one + * bank. +*/ According to CodingStyle, the prefrerrable format for multi-line comments is this: /* * bla * bla */ WBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] ARM: S5PV210: Fix on SECTION_SIZE_BITS on S5PV210/S5PC110.
Sergei Shtylyov wrote: Hello. Hi :-) Kukjin Kim wrote: This patch fixes on SECTION_SIZE_BITS for Sparsemem on S5PV210/S5PC110. Because smallest size of a bank on S5PV210/S5PC110 is aligned by 16MB. So each section's maximum size should be 16MB. Reported-by: Kyongho Cho pullip@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- arch/arm/mach-s5pv210/include/mach/memory.h |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-s5pv210/include/mach/memory.h b/arch/arm/mach- s5pv210/include/mach/memory.h index 379117e..4a372d8 100644 --- a/arch/arm/mach-s5pv210/include/mach/memory.h +++ b/arch/arm/mach-s5pv210/include/mach/memory.h @@ -16,8 +16,12 @@ #define PHYS_OFFSETUL(0x2000) #define CONSISTENT_DMA_SIZE(SZ_8M + SZ_4M + SZ_2M) -/* Maximum of 256MiB in one bank */ +/* Sparsemem support. Each section is a maximum of 16MB. + * Because there are many different memory type on S5PC110(MCP), + * and there is a case that having 80MB, 128MB or 256MB in one + * bank. +*/ According to CodingStyle, the prefrerrable format for multi-line comments is this: /* * bla * bla */ Oh, ok..will modify. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] ARM: S5PV210: Fix on SECTION_SIZE_BITS on S5PV210/S5PC110.
Kyungmin Park wrote: On Tue, Jul 6, 2010 at 1:36 PM, Kukjin Kim kgene@samsung.com wrote: This patch fixes on SECTION_SIZE_BITS for Sparsemem on S5PV210/S5PC110. Because smallest size of a bank on S5PV210/S5PC110 is aligned by 16MB. So each section's maximum size should be 16MB. Could you explain what's the problem? The size of a section for use in Sparsemem should be a power of 2. And as you know, S5PC110 D-type has only 80MiB in a bank(DMC0). 80 = 2^4 * 5, thus should be 16MiB. In case the section size is greater than 16MiB, a section will have a hole in it. Even though 80MiB is used at logical size. it used the physical 128MiB so. it's reasonable to use 128MiB align instead of 16MiB. Are there boards use 64MiB or less? I think if decrease the SECTIONS_SIZE_BITS, it wastes the memory. Thank you, Kyungmin Park Reported-by: Kyongho Cho pullip@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- arch/arm/mach-s5pv210/include/mach/memory.h | 8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-s5pv210/include/mach/memory.h b/arch/arm/mach- s5pv210/include/mach/memory.h index 379117e..4a372d8 100644 --- a/arch/arm/mach-s5pv210/include/mach/memory.h +++ b/arch/arm/mach-s5pv210/include/mach/memory.h @@ -16,8 +16,12 @@ #define PHYS_OFFSET UL(0x2000) #define CONSISTENT_DMA_SIZE (SZ_8M + SZ_4M + SZ_2M) -/* Maximum of 256MiB in one bank */ +/* Sparsemem support. Each section is a maximum of 16MB. + * Because there are many different memory type on S5PC110(MCP), + * and there is a case that having 80MB, 128MB or 256MB in one + * bank. +*/ #define MAX_PHYSMEM_BITS 32 -#define SECTION_SIZE_BITS 28 +#define SECTION_SIZE_BITS 24 #endif /* __ASM_ARCH_MEMORY_H */ -- Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: S5PV210: Fix on SECTION_SIZE_BITS on S5PV210/S5PC110.
On 7/7/2010 8:27 AM, Kukjin Kim wrote: Russell King wrote: Hi Russell :-) On Tue, Jul 06, 2010 at 01:36:47PM +0900, Kukjin Kim wrote: This patch fixes on SECTION_SIZE_BITS for Sparsemem on S5PV210/S5PC110. Because smallest size of a bank on S5PV210/S5PC110 is aligned by 16MB. So each section's maximum size should be 16MB. What is the spacing of chunks of memory, and minimum alignment of those chunks in physical address space? Some S5PC110(MCP D-type) has only available 80MiB in a bank. So the space accounts for 432MiB in a DMC0, but larger memory(256MiB + 128MiB) exists in a DMC1. As you know, the size of a section should be a power of 2 and a physical address space of a section should be contiguous. If a section size is greater than 16MiB, a section have a hole. So the SECTION_SIZE_BITS should be 16MiB. Also, what is the maximum physical address which memory can be located? Following is memory map of S5PV210/S5PC110. 0x8000 --- | | 0x7000 | | | | 0x6000 | DMC 1 | up to 1GiB | | 0x5000 | | | | 0x4000 - | | 0x3000 | DMC 0 | up to 512MiB | | 0x2000 --- Please see arch/arm/include/asm/sparsemem.h * SECTION_SIZE_BITS: The number of physical address bits to cover * the maximum amount of memory in a section. I know 1 bank of S5PV210/S5PC110 have maximum 256MB, so i think SECTION_SIZE_BITS is 28. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] ARM: S5PV210: Fix on SECTION_SIZE_BITS on S5PV210/S5PC110.
Joonyoung Shim wrote: On 7/7/2010 8:27 AM, Kukjin Kim wrote: Russell King wrote: Hi Russell :-) On Tue, Jul 06, 2010 at 01:36:47PM +0900, Kukjin Kim wrote: This patch fixes on SECTION_SIZE_BITS for Sparsemem on S5PV210/S5PC110. Because smallest size of a bank on S5PV210/S5PC110 is aligned by 16MB. So each section's maximum size should be 16MB. What is the spacing of chunks of memory, and minimum alignment of those chunks in physical address space? Some S5PC110(MCP D-type) has only available 80MiB in a bank. So the space accounts for 432MiB in a DMC0, but larger memory(256MiB + 128MiB) exists in a DMC1. As you know, the size of a section should be a power of 2 and a physical address space of a section should be contiguous. If a section size is greater than 16MiB, a section have a hole. So the SECTION_SIZE_BITS should be 16MiB. Also, what is the maximum physical address which memory can be located? Following is memory map of S5PV210/S5PC110. 0x8000 --- | | 0x7000 | | | | 0x6000 | DMC 1 | up to 1GiB | | 0x5000 | | | | 0x4000 - | | 0x3000 | DMC 0 | up to 512MiB | | 0x2000 --- Please see arch/arm/include/asm/sparsemem.h * SECTION_SIZE_BITS: The number of physical address bits to cover * the maximum amount of memory in a section. I know 1 bank of S5PV210/S5PC110 have maximum 256MB, so i think SECTION_SIZE_BITS is 28. Actually, the concept of section is different from bank. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: S5PV210: Fix on SECTION_SIZE_BITS on S5PV210/S5PC110.
On Wed, Jul 7, 2010 at 8:27 AM, Kukjin Kim kgene@samsung.com wrote: Russell King wrote: Hi Russell :-) On Tue, Jul 06, 2010 at 01:36:47PM +0900, Kukjin Kim wrote: This patch fixes on SECTION_SIZE_BITS for Sparsemem on S5PV210/S5PC110. Because smallest size of a bank on S5PV210/S5PC110 is aligned by 16MB. So each section's maximum size should be 16MB. What is the spacing of chunks of memory, and minimum alignment of those chunks in physical address space? Some S5PC110(MCP D-type) has only available 80MiB in a bank. So the space accounts for 432MiB in a DMC0, but larger memory(256MiB + 128MiB) exists in a DMC1. It's OneDRAM consists of 80MiB for AP, 16MiB for shared between AP and CP, and last 32MiB for CP. Even though we use the dedicated 80MiB for AP. we also use the shared 16MiB at AP side. Then can we access the last 32MiB? the answer is no. But it's connected physically. so we can't use the last 32MiB area for other case. Additionally it's almost difficult to 16MiB align by Spec. Memory Chip0 Configuration Register (MemConfig0, R/W, Address=0xF000_0008, 0xF140_0008) chip_mask [23:16] AXI Base Address Mask Upper address bit mask to determine AXI offset address of memory chip0. 0 = Corresponding address bit is not to be used for comparison 1 = Corresponding address bit is to be used for comparison For example, if chip_mask = 0xF8, then AXI offset address becomes 0x_ ~ 0x07FF_. If AXI base address of memory chip0 is 0x2000_, then memory chip0 has an address range of 0x2000_ ~ 0x27FF_. Thank you, Kyungmin Park As you know, the size of a section should be a power of 2 and a physical address space of a section should be contiguous. If a section size is greater than 16MiB, a section have a hole. So the SECTION_SIZE_BITS should be 16MiB. Also, what is the maximum physical address which memory can be located? Following is memory map of S5PV210/S5PC110. 0x8000 --- | | 0x7000 | | | | 0x6000 | DMC 1 | up to 1GiB | | 0x5000 | | | | 0x4000 - | | 0x3000 | DMC 0 | up to 512MiB | | 0x2000 --- Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: S5PV210: Fix on SECTION_SIZE_BITS on S5PV210/S5PC110.
On Tue, Jul 6, 2010 at 1:36 PM, Kukjin Kim kgene@samsung.com wrote: This patch fixes on SECTION_SIZE_BITS for Sparsemem on S5PV210/S5PC110. Because smallest size of a bank on S5PV210/S5PC110 is aligned by 16MB. So each section's maximum size should be 16MB. Could you explain what's the problem? Even though 80MiB is used at logical size. it used the physical 128MiB so. it's reasonable to use 128MiB align instead of 16MiB. Are there boards use 64MiB or less? I think if decrease the SECTIONS_SIZE_BITS, it wastes the memory. Thank you, Kyungmin Park Reported-by: Kyongho Cho pullip@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- arch/arm/mach-s5pv210/include/mach/memory.h | 8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-s5pv210/include/mach/memory.h b/arch/arm/mach-s5pv210/include/mach/memory.h index 379117e..4a372d8 100644 --- a/arch/arm/mach-s5pv210/include/mach/memory.h +++ b/arch/arm/mach-s5pv210/include/mach/memory.h @@ -16,8 +16,12 @@ #define PHYS_OFFSET UL(0x2000) #define CONSISTENT_DMA_SIZE (SZ_8M + SZ_4M + SZ_2M) -/* Maximum of 256MiB in one bank */ +/* Sparsemem support. Each section is a maximum of 16MB. + * Because there are many different memory type on S5PC110(MCP), + * and there is a case that having 80MB, 128MB or 256MB in one + * bank. +*/ #define MAX_PHYSMEM_BITS 32 -#define SECTION_SIZE_BITS 28 +#define SECTION_SIZE_BITS 24 #endif /* __ASM_ARCH_MEMORY_H */ -- 1.6.2.5 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
