Re: [PATCH] ASoC: samsung: s3c24xx-i2s: Fix return value check in s3c24xx_iis_dev_probe()

2015-04-17 Thread Mark Brown
On Thu, Apr 16, 2015 at 08:18:02PM +0800, weiyj...@163.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR().

Re: [PATCH] ASoC: samsung: s3c24xx-i2s: Fix return value check in s3c24xx_iis_dev_probe()

2015-04-16 Thread Krzysztof Kozłowski
2015-04-16 21:18 GMT+09:00 weiyj...@163.com: From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun

Re: [PATCH] ASoC: samsung: s3c24xx-i2s: Fix return value check in s3c24xx_iis_dev_probe()

2015-04-16 Thread Varka Bhadram
On 04/16/2015 05:48 PM, weiyj...@163.com wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). This bug is there in