Re: [PATCH 2/3] mmc: sdhci-s3c: Fix crash on module insertion for second time

2012-09-18 Thread Chris Ball 
Hi,

On Fri, Sep 14 2012, Chander Kashyap wrote:
> If sdhci-s3c driver is built as module, it gives following error if inserted
> again after removing. This was happening as pm_runtime_use_autosuspend() is
> called in sdhci_s3c_probe() function but in sdhci_s3c_remove() its 
> complementry
> pm_runtime_dont_use_autosuspend() is not called.
>
> BUG: spinlock bad magic on CPU#1, insmod/955
>  lock: 0xee771368, .magic: , .owner: insmod/955, .owner_cpu: 1
> [] (unwind_backtrace+0x0/0xf8) from [] 
> (do_raw_spin_unlock+0xa4/0xe4)
> [] (do_raw_spin_unlock+0xa4/0xe4) from [] 
> (_raw_spin_unlock_irqrestore+0xc/0x38)
> [] (_raw_spin_unlock_irqrestore+0xc/0x38) from [] 
> (sdhci_runtime_suspend_host+0x54/0x80)
> [] (sdhci_runtime_suspend_host+0x54/0x80) from [] 
> (sdhci_s3c_runtime_suspend+0x14/0x38 [sdhci_s3c])
> [] (sdhci_s3c_runtime_suspend+0x14/0x38 [sdhci_s3c]) from 
> [] (pm_generic_runtime_suspend+0x2c/0x40)
> [] (pm_generic_runtime_suspend+0x2c/0x40) from [] 
> (__rpm_callback+0x70/0x98)
> [] (__rpm_callback+0x70/0x98) from [] 
> (rpm_suspend+0xf0/0x534)
> [] (rpm_suspend+0xf0/0x534) from [] 
> (__pm_runtime_suspend+0x5c/0x74)
> [] (__pm_runtime_suspend+0x5c/0x74) from [] 
> (pm_generic_runtime_idle+0x44/0x4c)
> [] (pm_generic_runtime_idle+0x44/0x4c) from [] 
> (__rpm_callback+0x70/0x98)
> [] (__rpm_callback+0x70/0x98) from [] 
> (rpm_idle+0xdc/0x18c)
> [] (rpm_idle+0xdc/0x18c) from [] 
> (pm_runtime_set_autosuspend_delay+0x30/0x3c)
> [] (pm_runtime_set_autosuspend_delay+0x30/0x3c) from [] 
> (sdhci_s3c_probe+0x35c/0x52c [sdhci_s3c])
> [] (sdhci_s3c_probe+0x35c/0x52c [sdhci_s3c]) from [] 
> (platform_drv_probe+0x18/0x1c)
>
> Signed-off-by: Chander Kashyap 
> ---
>  drivers/mmc/host/sdhci-s3c.c |1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 0cbb4c2..3f4518d 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -658,6 +658,7 @@ static int __devexit sdhci_s3c_remove(struct 
> platform_device *pdev)
>  
>   sdhci_remove_host(host, 1);
>  
> + pm_runtime_dont_use_autosuspend(&pdev->dev);
>   pm_runtime_disable(&pdev->dev);
>  
>   clk_disable(sc->clk_bus[sc->cur_clk]);

Thanks, pushed to mmc-next for 3.7.

- Chris.
-- 
Chris Ball  
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] mmc: sdhci-s3c: Fix crash on module insertion for second time

2012-09-14 Thread Girish K S 
good catch
Reviewed by: Girish K S 

On 14 September 2012 14:38, Chander Kashyap  wrote:
> If sdhci-s3c driver is built as module, it gives following error if inserted
> again after removing. This was happening as pm_runtime_use_autosuspend() is
> called in sdhci_s3c_probe() function but in sdhci_s3c_remove() its 
> complementry
> pm_runtime_dont_use_autosuspend() is not called.
>
> BUG: spinlock bad magic on CPU#1, insmod/955
>  lock: 0xee771368, .magic: , .owner: insmod/955, .owner_cpu: 1
> [] (unwind_backtrace+0x0/0xf8) from [] 
> (do_raw_spin_unlock+0xa4/0xe4)
> [] (do_raw_spin_unlock+0xa4/0xe4) from [] 
> (_raw_spin_unlock_irqrestore+0xc/0x38)
> [] (_raw_spin_unlock_irqrestore+0xc/0x38) from [] 
> (sdhci_runtime_suspend_host+0x54/0x80)
> [] (sdhci_runtime_suspend_host+0x54/0x80) from [] 
> (sdhci_s3c_runtime_suspend+0x14/0x38 [sdhci_s3c])
> [] (sdhci_s3c_runtime_suspend+0x14/0x38 [sdhci_s3c]) from 
> [] (pm_generic_runtime_suspend+0x2c/0x40)
> [] (pm_generic_runtime_suspend+0x2c/0x40) from [] 
> (__rpm_callback+0x70/0x98)
> [] (__rpm_callback+0x70/0x98) from [] 
> (rpm_suspend+0xf0/0x534)
> [] (rpm_suspend+0xf0/0x534) from [] 
> (__pm_runtime_suspend+0x5c/0x74)
> [] (__pm_runtime_suspend+0x5c/0x74) from [] 
> (pm_generic_runtime_idle+0x44/0x4c)
> [] (pm_generic_runtime_idle+0x44/0x4c) from [] 
> (__rpm_callback+0x70/0x98)
> [] (__rpm_callback+0x70/0x98) from [] 
> (rpm_idle+0xdc/0x18c)
> [] (rpm_idle+0xdc/0x18c) from [] 
> (pm_runtime_set_autosuspend_delay+0x30/0x3c)
> [] (pm_runtime_set_autosuspend_delay+0x30/0x3c) from [] 
> (sdhci_s3c_probe+0x35c/0x52c [sdhci_s3c])
> [] (sdhci_s3c_probe+0x35c/0x52c [sdhci_s3c]) from [] 
> (platform_drv_probe+0x18/0x1c)
>
> Signed-off-by: Chander Kashyap 
> ---
>  drivers/mmc/host/sdhci-s3c.c |1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 0cbb4c2..3f4518d 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -658,6 +658,7 @@ static int __devexit sdhci_s3c_remove(struct 
> platform_device *pdev)
>
> sdhci_remove_host(host, 1);
>
> +   pm_runtime_dont_use_autosuspend(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
>
> clk_disable(sc->clk_bus[sc->cur_clk]);
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] mmc: sdhci-s3c: Fix crash on module insertion for second time

2012-09-14 Thread Jaehoon Chung 
Looks good to me..

Acked-by: Jaehoon Chung 

On 09/14/2012 06:08 PM, Chander Kashyap wrote:
> If sdhci-s3c driver is built as module, it gives following error if inserted
> again after removing. This was happening as pm_runtime_use_autosuspend() is
> called in sdhci_s3c_probe() function but in sdhci_s3c_remove() its 
> complementry
> pm_runtime_dont_use_autosuspend() is not called.
> 
> BUG: spinlock bad magic on CPU#1, insmod/955
>  lock: 0xee771368, .magic: , .owner: insmod/955, .owner_cpu: 1
> [] (unwind_backtrace+0x0/0xf8) from [] 
> (do_raw_spin_unlock+0xa4/0xe4)
> [] (do_raw_spin_unlock+0xa4/0xe4) from [] 
> (_raw_spin_unlock_irqrestore+0xc/0x38)
> [] (_raw_spin_unlock_irqrestore+0xc/0x38) from [] 
> (sdhci_runtime_suspend_host+0x54/0x80)
> [] (sdhci_runtime_suspend_host+0x54/0x80) from [] 
> (sdhci_s3c_runtime_suspend+0x14/0x38 [sdhci_s3c])
> [] (sdhci_s3c_runtime_suspend+0x14/0x38 [sdhci_s3c]) from 
> [] (pm_generic_runtime_suspend+0x2c/0x40)
> [] (pm_generic_runtime_suspend+0x2c/0x40) from [] 
> (__rpm_callback+0x70/0x98)
> [] (__rpm_callback+0x70/0x98) from [] 
> (rpm_suspend+0xf0/0x534)
> [] (rpm_suspend+0xf0/0x534) from [] 
> (__pm_runtime_suspend+0x5c/0x74)
> [] (__pm_runtime_suspend+0x5c/0x74) from [] 
> (pm_generic_runtime_idle+0x44/0x4c)
> [] (pm_generic_runtime_idle+0x44/0x4c) from [] 
> (__rpm_callback+0x70/0x98)
> [] (__rpm_callback+0x70/0x98) from [] 
> (rpm_idle+0xdc/0x18c)
> [] (rpm_idle+0xdc/0x18c) from [] 
> (pm_runtime_set_autosuspend_delay+0x30/0x3c)
> [] (pm_runtime_set_autosuspend_delay+0x30/0x3c) from [] 
> (sdhci_s3c_probe+0x35c/0x52c [sdhci_s3c])
> [] (sdhci_s3c_probe+0x35c/0x52c [sdhci_s3c]) from [] 
> (platform_drv_probe+0x18/0x1c)
> 
> Signed-off-by: Chander Kashyap 
> ---
>  drivers/mmc/host/sdhci-s3c.c |1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 0cbb4c2..3f4518d 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -658,6 +658,7 @@ static int __devexit sdhci_s3c_remove(struct 
> platform_device *pdev)
>  
>   sdhci_remove_host(host, 1);
>  
> + pm_runtime_dont_use_autosuspend(&pdev->dev);
>   pm_runtime_disable(&pdev->dev);
>  
>   clk_disable(sc->clk_bus[sc->cur_clk]);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html