Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-06-03 Thread Thomas Abraham
On 1 June 2012 18:09, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Fri, Jun 01, 2012 at 10:47:44AM +0800, Thomas Abraham wrote: 1. There is one instance of 'struct platform_device' for each of the spi controller instances (0/1/2) named s3c64xx-spi (in

Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-06-01 Thread Mark Brown
On Fri, Jun 01, 2012 at 10:47:44AM +0800, Thomas Abraham wrote: 1. There is one instance of 'struct platform_device' for each of the spi controller instances (0/1/2) named s3c64xx-spi (in arch/arm/plat-samsung/devs.c). Right, which looks rather like it is specific to s3c64xx at least given

Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-31 Thread Mark Brown
On Thu, May 31, 2012 at 10:05:42AM +0800, Thomas Abraham wrote: On 30 May 2012 18:13, Mark Brown broo...@opensource.wolfsonmicro.com wrote: No there isn't.  You've got things like s3c64xx_device_spi0 in arch/arm/plat-samsung/devs.c (which you'd expect since the resources that are passed in

Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-31 Thread Thomas Abraham
On 31 May 2012 19:36, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, May 31, 2012 at 10:05:42AM +0800, Thomas Abraham wrote: On 30 May 2012 18:13, Mark Brown broo...@opensource.wolfsonmicro.com wrote: No there isn't.  You've got things like s3c64xx_device_spi0 in

Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-30 Thread Olof Johansson
On Sun, May 20, 2012 at 2:21 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Fri, May 18, 2012 at 03:03:31PM +0530, Thomas Abraham wrote: -     s3c64xx_spi0_set_platdata(s3c64xx_spi0_pdata, 0, 1); +     s3c64xx_spi0_set_platdata(s3c6410-spi, NULL, 0, 1); ... +    

Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-30 Thread Thomas Abraham
On 30 May 2012 15:28, Olof Johansson o...@lixom.net wrote: On Sun, May 20, 2012 at 2:21 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Fri, May 18, 2012 at 03:03:31PM +0530, Thomas Abraham wrote: -     s3c64xx_spi0_set_platdata(s3c64xx_spi0_pdata, 0, 1); +    

Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-30 Thread Mark Brown
On Wed, May 30, 2012 at 12:28:55AM -0700, Olof Johansson wrote: On Sun, May 20, 2012 at 2:21 AM, Mark Brown This dev_name also isn't equivalent to dev_name() which makes matters more confusing than they need to be. Looks like they use the name as the magic string to pick initialization

Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-30 Thread Thomas Abraham
On 30 May 2012 17:34, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, May 30, 2012 at 12:28:55AM -0700, Olof Johansson wrote: On Sun, May 20, 2012 at 2:21 AM, Mark Brown This dev_name also isn't equivalent to dev_name() which makes matters more confusing than they need to be.

Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-30 Thread Mark Brown
On Wed, May 30, 2012 at 06:05:31PM +0800, Thomas Abraham wrote: On 30 May 2012 17:34, Mark Brown broo...@opensource.wolfsonmicro.com wrote: Right, and there's no problem at all with using the name.  The thing is that there's no need to set the name at runtime since the struct device being

Re: [PATCH v2 4/6] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-30 Thread Thomas Abraham
On 30 May 2012 18:13, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, May 30, 2012 at 06:05:31PM +0800, Thomas Abraham wrote: On 30 May 2012 17:34, Mark Brown broo...@opensource.wolfsonmicro.com wrote: Right, and there's no problem at all with using the name.  The thing is