Re: [2.6.13-rc6-latest] SCSI disk registration msgs repeat themselves

2005-08-16 Thread Pete Zaitcev
On Tue, 16 Aug 2005 21:39:33 -0700, Patrick Mansfield <[EMAIL PROTECTED]> wrote: > On Tue, Aug 16, 2005 at 11:01:30PM -0400, Chuck Ebbert wrote: > > I just added some usb-storage devices to my system and got the below. > > Why do the first four lines repeat for each device? (Not sure if > > th

Re: [2.6.13-rc6-latest] SCSI disk registration msgs repeat themselves

2005-08-16 Thread Patrick Mansfield
On Tue, Aug 16, 2005 at 11:01:30PM -0400, Chuck Ebbert wrote: > I just added some usb-storage devices to my system and got the below. > Why do the first four lines repeat for each device? (Not sure if > this is a SCSI or USB problem.) It is in the partition code. I posted twice before about thi

[2.6.13-rc6-latest] SCSI disk registration msgs repeat themselves

2005-08-16 Thread Chuck Ebbert
I just added some usb-storage devices to my system and got the below. Why do the first four lines repeat for each device? (Not sure if this is a SCSI or USB problem.) [ 23.433725] SCSI device sda: 63424 512-byte hdwr sectors (32 MB) [ 23.560564] sda: Write Protect is off [ 23.560581] sda:

[RFC] embryonic RAID class

2005-08-16 Thread James Bottomley
The idea behind a RAID class is to provide a uniform interface to all RAID subsystems (both hardware and software) in the kernel. To do that, I've made this class a transport class that's entirely subsystem independent (although the matching routines have to match per subsystem, as you'll see look

[PATCH 2.6.12.5 1/2] lib: allow idr to be used in irq context

2005-08-16 Thread Luben Tuikov
Hi, This patch allows idr to be used in irq context. idr_pre_get() is necessary to be called before idr_get_new() is called. No locking is necessary when calling idr_pre_get(). But idr_get_new(), idr_find() and idr_remove() must be serialized with respect to each other. All of the aforemention

[PATCH 2.6.12.5 2/2] include/linux: enclose idr.h in #ifndef

2005-08-16 Thread Luben Tuikov
Hi, This patch encloses the idr.h header file in #ifndef __IDR_H__ macro. Signed-off-by: Luben Tuikov <[EMAIL PROTECTED]> --- linux-2.6.12.5/include/linux/idr.h.old 2005-08-16 17:20:15.0 -0400 +++ linux-2.6.12.5/include/linux/idr.h 2005-08-16 17:21:11.0 -0400 @@ -8,6 +8,10

[PATCH 2.4.12.5 2/2] include/linux: enclose idr.h in #ifndef

2005-08-16 Thread Luben Tuikov
Hi, This patch encloses the idr.h header file in #ifndef __IDR_H__ macro. Signed-off-by: Luben Tuikov <[EMAIL PROTECTED]> --- linux-2.6.12.5/include/linux/idr.h.old 2005-08-16 17:20:15.0 -0400 +++ linux-2.6.12.5/include/linux/idr.h 2005-08-16 17:21:11.0 -0400 @@ -8,6 +8,10

[PATCH 2.4.12.5 1/2] lib: allow idr to be used in irq context

2005-08-16 Thread Luben Tuikov
Hi, This patch allows idr to be used in irq context. idr_pre_get() is necessary to be called before idr_get_new() is called. No locking is necessary when calling idr_pre_get(). But idr_get_new(), idr_find() and idr_remove() must be serialized with respect to each other. All of the aforemention

Re: [PATCH] add transport class symlink to device object

2005-08-16 Thread Russell King
On Tue, Aug 16, 2005 at 09:37:18AM -0400, Luben Tuikov wrote: > On 08/15/05 20:52, [EMAIL PROTECTED] wrote: > > My vote is to make the multiplexor instantiate each serial line > > as a separate device. > > Yes, you're absolutely and completely correct. I think the same > way as you do. Just don'

[PATCH 2.6.13-rc6] improve start/stop code for worker thread in cpqfcTS driver, take 3

2005-08-16 Thread Rolf Eike Beer
Improve start/stop code for HBA worker thread. For the moment the return code of the start/stop functions is ignored, this will change once the init/exit code is changed to use 2.6 driver model. Version 2: remove that lock_kernel() stuff missed in the first version Version 3: use kthread API (po

Re: [PATCH 2.6.13-rc6] improve start/stop code for worker thread in cpqfcTS driver, take 2

2005-08-16 Thread Christoph Hellwig
On Tue, Aug 16, 2005 at 06:20:56PM +0200, Rolf Eike Beer wrote: > Use pid of worker thread and struct completion for signaling end of worker > thread (code more or less taken from drivers/net/8139too.c). For the moment > the return code of the start/stop functions is ignored, this will change >

[PATCH 2.6.13-rc6] improve start/stop code for worker thread in cpqfcTS driver, take 2

2005-08-16 Thread Rolf Eike Beer
Use pid of worker thread and struct completion for signaling end of worker thread (code more or less taken from drivers/net/8139too.c). For the moment the return code of the start/stop functions is ignored, this will change once the init/exit code is changed to use 2.6 driver model. Version 2:

RE: [PATCH] add transport class symlink to device object

2005-08-16 Thread James . Smart
> On Mon, 2005-08-15 at 20:52 -0400, [EMAIL PROTECTED] wrote: > > What is ":00:04:0" in this case ? The "device" is not a serial > > port, which is what the ttyXX back link would lead you to believe. > > Thus, it's a serial port multiplexer that supports up to N ports, > > right ? and wouldn't

Re: [PATCH 2.6.13-rc6] remove dead reset function from cpqfcTS driver

2005-08-16 Thread Rolf Eike Beer
Martin K. Petersen wrote: >> "Rolf" == Rolf Eike Beer <[EMAIL PROTECTED]> writes: > >Hey Rolf! I should go and use "R. Eike Beer" ;) >Rolf> There was a request on lkml last week for a working version of >Rolf> this driver. For the moment I try to clean this up a bit before >Rolf> doing some r

[PATCH 2.6.13-rc6] improve start/stop code for worker thread in cpqfcTS driver

2005-08-16 Thread Rolf Eike Beer
Use pid of worker thread and struct completion for signaling end of worker thread (code more or less taken from drivers/net/8139too.c). For the moment the return code of the start/stop functions is ignored, this will change once the init/exit code is changed to use 2.6 driver model. Signed-off-

[PATCH 2.6.13-rc6] MODULE_DEVICE_TABLE for cpqfcTS driver, take 2

2005-08-16 Thread Rolf Eike Beer
cpqfcTSinit has a static array of PCI device and vendor ids supported by the driver. Sounds familiar, doesn't it? Use pci_device_id as type for the entries of this array and declare the array as MODULE_DEVICE_TABLE. Also use pci_get_device() instead of pci_find_device() and remove some superfluo

[PATCH 2.6.13-rc6] remove 2.4 compat code from cpqfcTS driver, take 3

2005-08-16 Thread Rolf Eike Beer
Remove compat code for Linux 2.4 and earlier. Version 2: Fixed bug in earlier version that caused compile error. Version 3: found bug in previous patch, changed this to apply cleanly. Sorry for the noise. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- a/drivers/scsi/cpqfcTScontrol.c 2

Re: [PATCH 2.6.13-rc6] remove dead reset function from cpqfcTS driver

2005-08-16 Thread Martin K. Petersen
> "Rolf" == Rolf Eike Beer <[EMAIL PROTECTED]> writes: Hey Rolf! Rolf> There was a request on lkml last week for a working version of Rolf> this driver. For the moment I try to clean this up a bit before Rolf> doing some real work. I found 4 major things that should be Rolf> done, for half of

[PATCH 2.6.13-rc6] remove 2.4 compat code from cpqfcTS driver, take 2

2005-08-16 Thread Rolf Eike Beer
Remove compat code for Linux 2.4 and earlier. Fixed bug in earlier version that caused compile error. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- a/drivers/scsi/cpqfcTScontrol.c 2005-08-13 19:00:35.0 +0200 +++ b/drivers/scsi/cpqfcTScontrol.c 2005-08-14 11:02:09.0

Re: [PATCH 2.6.13-rc6] MODULE_DEVICE_TABLE for cpqfcTS driver

2005-08-16 Thread Rolf Eike Beer
Jiri Slaby wrote: >Rolf Eike Beer napsal(a): >>Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> >> >>--- a/drivers/scsi/cpqfcTSinit.c 2005-08-14 14:20:40.0 +0200 >>+++ b/drivers/scsi/cpqfcTSinit.c 2005-08-14 14:25:33.0 +0200 >>@@ -264,18 +264,14 @@ static void launch_FCwo

Re: [PATCH] add transport class symlink to device object

2005-08-16 Thread Luben Tuikov
On 08/15/05 21:08, James Bottomley wrote: >>Think if SCSI used this same style of representation. For example, >>if there was no scsi target device entity, but class entities did >>exist and they just pointed back to the scsi host device entry. > > > Yes, it's theoretically possible to have had S

Re: [PATCH] add transport class symlink to device object

2005-08-16 Thread Luben Tuikov
On 08/15/05 20:52, [EMAIL PROTECTED] wrote: > Actually, I view this as being a little odd... > > What is ":00:04:0" in this case ? The "device" is not a serial > port, which is what the ttyXX back link would lead you to believe. > Thus, it's a serial port multiplexer that supports up to N port

Re: [PATCH 2.6.13-rc6] MODULE_DEVICE_TABLE for cpqfcTS driver

2005-08-16 Thread Jiri Slaby
Rolf Eike Beer napsal(a): Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- a/drivers/scsi/cpqfcTSinit.c2005-08-14 14:20:40.0 +0200 +++ b/drivers/scsi/cpqfcTSinit.c2005-08-14 14:25:33.0 +0200 @@ -264,18 +264,14 @@ static void launch_FCworker_thread(struc * A

RE: Request to add EMC Invista to the v2.6.x SCSI Blacklist...

2005-08-16 Thread conway, heather
Hi James, I will request additional information from the engineer and will get back to you as soon as I can. Thanks. Heather -Original Message- From: James Bottomley [mailto:[EMAIL PROTECTED] Sent: Thursday, August 11, 2005 12:39 PM To: conway, heather Cc: 'linux-scsi@vger.kernel.org' Sub

Re: [PATCH 2.6.13-rc6] remove dead reset function from cpqfcTS driver

2005-08-16 Thread Rolf Eike Beer
Christoph Hellwig wrote: >On Tue, Aug 16, 2005 at 11:11:06AM +0200, Rolf Eike Beer wrote: >> cpqfcTS_reset() is never referenced from anywhere. By using the >> nonexistent constant SCSI_RESET_ERROR it causes just another unneeded >> compile error. > >That was the old reset handler. Do you actually

Re: [PATCH 2.6.13-rc6] remove dead reset function from cpqfcTS driver

2005-08-16 Thread Christoph Hellwig
On Tue, Aug 16, 2005 at 11:11:06AM +0200, Rolf Eike Beer wrote: > cpqfcTS_reset() is never referenced from anywhere. By using the nonexistent > constant SCSI_RESET_ERROR it causes just another unneeded compile error. That was the old reset handler. Do you actually have this hardware? The driver

[PATCH 2.6.13-rc6] remove 2.4 compat code from cpqfcTS driver

2005-08-16 Thread Rolf Eike Beer
Remove compat code for Linux 2.4 and earlier. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- a/drivers/scsi/cpqfcTScontrol.c 2005-08-13 19:00:35.0 +0200 +++ b/drivers/scsi/cpqfcTScontrol.c 2005-08-14 11:02:09.0 +0200 @@ -28,8 +28,6 @@ Hewlitt Packard Manual Part

[PATCH 2.6.13-rc6] remove superfluos ioctls from cpqfcTS

2005-08-16 Thread Rolf Eike Beer
Remove ioctls to get PCI information and driver version. These information can be found via lspci or dmesg. Also remove two typedefs already commented out. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- a/drivers/scsi/cpqfcTSioctl.h 2005-08-07 20:18:56.0 +0200 +++ b/drivers

[PATCH 2.6.13-rc6] more whitespace cleanups for cpqfcTS

2005-08-16 Thread Rolf Eike Beer
More whitespace cleanups: -remove trailing whitespace -remove brakets around return statements -remove some double (or more) newlines Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- a/drivers/scsi/cpqfcTSi2c.c 2005-08-07 20:18:56.0 +0200 +++ b/drivers/scsi/cpqfcTSi2c.c 2005-08-14 15

[PATCH 2.6.13-rc6] remove dead reset function from cpqfcTS driver

2005-08-16 Thread Rolf Eike Beer
cpqfcTS_reset() is never referenced from anywhere. By using the nonexistent constant SCSI_RESET_ERROR it causes just another unneeded compile error. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- a/drivers/scsi/cpqfcTSinit.c2005-08-13 09:34:20.0 +0200 +++ b/drivers/scsi/cp

[PATCH 2.6.13-rc6] MODULE_DEVICE_TABLE for cpqfcTS driver

2005-08-16 Thread Rolf Eike Beer
cpqfcTSinit has a static array of PCI device and vendor ids supported by the driver. Sounds familiar, doesn't it? Use pci_device_id as type for the entries of this array and declare the array as MODULE_DEVICE_TABLE. Also use pci_get_device() instead of pci_find_device() and remove some superfluo