Re: [PATCH] qla4xxx: allow hba to be online when initiator ip address is uninitialized

2007-06-14 Thread Mike Christie
David C Somayajulu wrote: On Fri, 2007-06-08 at 17:29 -0700, David C Somayajulu wrote: This patch provides the following: 1. remove warning ignoring the return value of pci_set_mwi() 2. allows HBA to be online when the initiator ip address is uninitialized. Including Signed-off-by: David

[PATCH] FC_Transport: Check portstates before invoking target scan

2007-06-14 Thread Hannes Reinecke
Hi James ( James, too :-), scsi_transport_fc.c:fc_user_scan() should check the portstates prior to calling scsi_scan_target(). Otherwise we might get a nice oops as the rport might already been disconnected from the host by the time we're calling scsi_scan_target(). Thus the traversal from the

Re: [patch 0/3] AHCI Link Power Management

2007-06-14 Thread Tejun Heo
Kristen Carlson Accardi wrote: I'm not sure about this. We need better PM framework to support powersaving in other controllers and some ahcis don't save much when only link power management is used, do you have data to support this? Yeah, it was some Lenovo notebook. Pavel is more

[PATCH] zfcp: Replace kmalloc/memset with kzalloc

2007-06-14 Thread Swen Schillig
From: Swen Schillig [EMAIL PROTECTED] Memory allocated with kmalloc is always initialzed to 0 with memset. Replace the two calls with kzalloc, that already does both steps. Signed-off-by: Swen Schillig [EMAIL PROTECTED] --- drivers/s390/scsi/zfcp_erp.c |3 +-- 1 files changed, 1

missing patches

2007-06-14 Thread Swen Schillig
James on the 29th of may I posted 3 patches for the zfcp driver named [PATCH 2/3] zfcp: clear adapter status flags during adapter shutdown [PATCH 3/3] zfcp: Don't report device as LUN 0 to SCSI stack unfortunately I can't find them in the tree so far, is there any reason for that ? Thanks

Re: [patch 0/3] AHCI Link Power Management

2007-06-14 Thread Jens Axboe
On Tue, Jun 12 2007, Tejun Heo wrote: Arjan van de Ven wrote: I'm not sure about this. We need better PM framework to support powersaving in other controllers and some ahcis don't save much when only link power management is used, do you have data to support this? Yeah, it was

Re: [patch 0/3] AHCI Link Power Management

2007-06-14 Thread Tejun Heo
Jens Axboe wrote: 1. It didn't have proper interface with userland. This was mainly because of missing ATA sysfs nodes. I'm not sure whether adding this to scsi node is a good idea. 2. It was focused on SATA link PS and couldn't cover the Lenovo case. I think we need something at the

[PATCH] iscsi_tcp: convert to use the data buffer accessors

2007-06-14 Thread FUJITA Tomonori
The previous patch has a typo in the debug code (thanks to Boaz). This is an updated version, which was ACKed by Mike. http://groups.google.com/group/open-iscsi/msg/a9b364715c9b304e --- From: FUJITA Tomonori [EMAIL PROTECTED] - remove the unnecessary map_single path. - convert to use the new

Re: [PATCH] FC_Transport: Check portstates before invoking target scan

2007-06-14 Thread Hannes Reinecke
Hi James, On Thu, Jun 14, 2007 at 07:57:05AM -0400, James Smart wrote: Sounds reasonable... Only change I'd make is rather than comparing all the different states, simply compare (rport-port_state != FC_PORTSTATE_ONLINE) As per normal you are oh-so correct. Updated patch attached. Cheers,

Re: [PATCH 1/5] ibmvscsi: Remove unnecessary map_sg check

2007-06-14 Thread Brian King
Jeff Garzik wrote: Brian King wrote: Since sg_tablesize is set appropriately in the scsi host template, remove the unnecessary check to make sure it is not exceeded following the dma_map_sg call. Signed-off-by: Brian King [EMAIL PROTECTED] ---

Re: [PATCH 3/5] ibmvscsi: Add eh_host_reset_handler

2007-06-14 Thread Brian King
Jeff Garzik wrote: Brian King wrote: +spin_lock_irqsave(hostdata-host-host_lock, flags); +list_for_each_entry_safe(tmp_evt, pos, hostdata-sent, list) { +list_del(tmp_evt-list); +del_timer(tmp_evt-timer); +if (tmp_evt-cmnd) { +

[PATCH 0/0] scsi_cmnd accessors issues

2007-06-14 Thread Boaz Harrosh
FUJITA Tomonori wrote: There are just two llds. I suspect that we can fix them. Or they can access to the data directly (without the accessors) if we can't. I don't think that introducing something like scsi_set_sg_count, which is meaningless to most of llds, is a good idea. Following are

Re: [PATCH 2/3] Farther clean-up of tmscsim driver

2007-06-14 Thread Boaz Harrosh
From 4a7ac954dcc11531a09fa07d6a6365d98c67b216 Mon Sep 17 00:00:00 2001 From: Boaz Harrosh [EMAIL PROTECTED](none) Date: Thu, 14 Jun 2007 19:04:17 +0300 Subject: [PATCH] Farther clean-up of tmscsim driver - this is a followup of commit 85289f2efa108d1586a86d0c426ffc9d641bbdc2 [SCSI] tmscsim:

Re: [PATCH 3/3] Farther clean up of stex.c driver

2007-06-14 Thread Boaz Harrosh
From 2b82909202cab8dc35184daef45b4b388f93112a Mon Sep 17 00:00:00 2001 From: Boaz Harrosh [EMAIL PROTECTED](none) Date: Thu, 14 Jun 2007 19:14:40 +0300 Subject: [PATCH] Farther clean up of stex.c driver - now that scsi-ml accessors do not allow modifying of sg_count bufflen and sglist. The

Re: [patch 2a/3] Expose Power Management Policy option to users

2007-06-14 Thread Kristen Carlson Accardi
On Wed, 13 Jun 2007 08:26:48 -0700 James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2007-06-12 at 10:46 -0700, Kristen Carlson Accardi wrote: Expose Power Management Policy option to users This patch will modify the scsi subsystem to allow users to set a power management policy for the

Re: [PATCH] qla4xxx: allow hba to be online when initiator ip address is uninitialized

2007-06-14 Thread David C Somayajulu
On Thu, 2007-06-14 at 01:54 -0400, Mike Christie wrote: David C Somayajulu wrote: On Fri, 2007-06-08 at 17:29 -0700, David C Somayajulu wrote: This patch provides the following: 1. remove warning ignoring the return value of pci_set_mwi() 2. allows HBA to be online when the initiator ip

Re: [patch 2a/3] Expose Power Management Policy option to users

2007-06-14 Thread Jeff Garzik
Kristen Carlson Accardi wrote: Ok - sorry for my ignorance about SCSI - but my sources (i.e. Arjan) tell me that the problem is that Link in ATA land means something different than Link in SCSI land, and that what I really need to do is leave this code under the Host class, but rename it to

Re: [PATCH] qla4xxx: allow hba to be online when initiator ip address is uninitialized

2007-06-14 Thread Andrew Vasquez
On Thu, 14 Jun 2007, David Somayajulu wrote: On Thu, 2007-06-14 at 01:54 -0400, Mike Christie wrote: David C Somayajulu wrote: It looks ok, but creating the status variable and setting it like this, just to quiet the compile warning, and never doing anything else with it doesn't seem

doubts about sg driver

2007-06-14 Thread Parav Pandit
Hi, Few basic questions on sg driver: 1. Are there any hooks that low level HBA driver needs to implement - for providing support for SG (SCSI generic) driver? Or SG always interacts with scsi_mod and it is transparent to the HBA drivers? From the tldp How-to and sg.c it looks like it doesn't

Re: [PATCH] qla4xxx: allow hba to be online when initiator ip address is uninitialized

2007-06-14 Thread Randy Dunlap
On Thu, 14 Jun 2007 10:44:20 -0700 Andrew Vasquez wrote: On Thu, 14 Jun 2007, David Somayajulu wrote: On Thu, 2007-06-14 at 01:54 -0400, Mike Christie wrote: David C Somayajulu wrote: It looks ok, but creating the status variable and setting it like this, just to quiet the

Re: [PATCH 1/3] Restrict scsi accessors access to read-only

2007-06-14 Thread Jeff Garzik
Boaz Harrosh wrote: +static inline struct scatterlist *scsi_sglist(struct scsi_cmnd *cmd) +{ + return (struct scatterlist *)cmd-request_buffer; +} It is quite nice to have this accessor, especially. Jeff - To unsubscribe from this list: send the line unsubscribe linux-scsi in

RE: [PATCH 3/3] Farther clean up of stex.c driver

2007-06-14 Thread Ed Lin
-Original Message- From: Boaz Harrosh [mailto:[EMAIL PROTECTED] Sent: Thursday, June 14, 2007 9:34 AM To: FUJITA Tomonori; Ed Lin; Guennadi Liakhovetski Cc: linux-scsi@vger.kernel.org Subject: Re: [PATCH 3/3] Farther clean up of stex.c driver From

Re: doubts about sg driver

2007-06-14 Thread Andrew Patterson
Hi Parav, On Thu, 2007-06-14 at 10:47 -0700, Parav Pandit wrote: Hi, Few basic questions on sg driver: 1. Are there any hooks that low level HBA driver needs to implement - for providing support for SG (SCSI generic) driver? No. This is all done in the sg/scsi-midlayer. Or SG always

Re: doubts about sg driver

2007-06-14 Thread Douglas Gilbert
Parav Pandit wrote: Hi, Few basic questions on sg driver: 1. Are there any hooks that low level HBA driver needs to implement - for providing support for SG (SCSI generic) driver? Or SG always interacts with scsi_mod and it is transparent to the HBA drivers? From the tldp How-to and

Re: missing patches

2007-06-14 Thread James Bottomley
On Thu, 2007-06-14 at 12:18 +0200, Swen Schillig wrote: James on the 29th of may I posted 3 patches for the zfcp driver named [PATCH 2/3] zfcp: clear adapter status flags during adapter shutdown [PATCH 3/3] zfcp: Don't report device as LUN 0 to SCSI stack unfortunately I can't find them

RE: [PATCH 3/3] Farther clean up of stex.c driver

2007-06-14 Thread FUJITA Tomonori
From: Ed Lin [EMAIL PROTECTED] Subject: RE: [PATCH 3/3] Farther clean up of stex.c driver Date: Thu, 14 Jun 2007 12:29:05 -0700 -Original Message- From: Boaz Harrosh [mailto:[EMAIL PROTECTED] Sent: Thursday, June 14, 2007 9:34 AM To: FUJITA Tomonori; Ed Lin; Guennadi

RE: [PATCH 3/3] Farther clean up of stex.c driver

2007-06-14 Thread Ed Lin
-Original Message- From: FUJITA Tomonori [mailto:[EMAIL PROTECTED] Sent: Thursday, June 14, 2007 3:21 PM To: Ed Lin Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; linux-scsi@vger.kernel.org Subject: RE: [PATCH 3/3] Farther clean up of stex.c driver From: Ed

Re: [PATCH] a100u2w: Convert into Linux style

2007-06-14 Thread Christoph Hellwig
On Fri, Jun 15, 2007 at 12:11:22AM +0100, Alan Cox wrote: - Remove the BSD dual licence on the new work - Switch the if ALPHA to if __LP64__. (struct size is then right elsewhere) __LP64__ is not a correct check unfortunately. Please use CONFIG_64BIT instead. - To unsubscribe from this list:

RE: [PATCH 3/3] Farther clean up of stex.c driver

2007-06-14 Thread FUJITA Tomonori
From: Ed Lin [EMAIL PROTECTED] Subject: RE: [PATCH 3/3] Farther clean up of stex.c driver Date: Thu, 14 Jun 2007 16:02:30 -0700 -Original Message- From: FUJITA Tomonori [mailto:[EMAIL PROTECTED] Sent: Thursday, June 14, 2007 3:21 PM To: Ed Lin Cc: [EMAIL PROTECTED]; [EMAIL

Re: SG TUR and AIO

2007-06-14 Thread FUJITA Tomonori
From: Christophe Varoqui [EMAIL PROTECTED] Subject: SG TUR and AIO Date: Thu, 14 Jun 2007 00:59:03 +0200 Hi, I'm trying to make multipath daemon checking asynchronous, and most path checkers use SG. Please bare with some questions on this wild wild topic (to search engine criteria). Is

RE: RAID1 can't be written after pulling out the secondary hard disk

2007-06-14 Thread Lee Webb
Hi Eric, Zhao, Can I ask which kernel version the fix for this issue was introduced in? I have recently installed CentOS5 running a 2.6.18-8.1.4.el5 kernel on a new Dell PowerEdge SC1435 appear to be having the same issue as that reported by Zhao. I'm trying to track down the fix for it, but am

[PATCH01] scsi: improve areca driver stability and compatibility

2007-06-14 Thread 鄭守謙
Subject: [PATCH01] scsi: improve areca driver stability and compatibility From: Nick Cheng [EMAIL PROTECTED] Description: 1. Implement PCI-Express error recovery function and AER capability, especially thanks to Yanmin Zhang's openhanded help about AER 2. Implement the selection of