Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread Tejun Heo
Kristen Carlson Accardi wrote: >> I don't think the interface you're suggesting is a good one. Do you? > > I think if it's applicable to SCSI at all it is fine. If it is not, then > I think we need to make do with the interface we are given. I do not think > we should hold up a feature for liba

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread Tejun Heo
Kristen Carlson Accardi wrote: > So at current rate of development and kernel release schedule, the best > possible scenario is still 6 months away - whereas this patchset is already > tested and ready for merging now. The best possible scenario is .24-rc1 merge window with or without waiting. W

[PATCH] initialize shost_data to zero

2007-07-31 Thread FUJITA Tomonori
It's better to initialize host->shost_data to zero like target->starget_data and device->sdev_data. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/hosts.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c ind

Re: git-scsi-misc build error

2007-07-31 Thread James Bottomley
On Tue, 2007-07-31 at 15:41 -0700, Andrew Morton wrote: > On Tue, 31 Jul 2007 17:30:52 -0500 > James Bottomley <[EMAIL PROTECTED]> wrote: > > > On Tue, 2007-07-31 at 15:27 -0700, Andrew Morton wrote: > > > ERROR: "scsi_tgt_it_nexus_create" [drivers/scsi/scsi_transport_srp.ko] > > > undefined! > >

Re: git-scsi-misc build error

2007-07-31 Thread Andrew Morton
On Tue, 31 Jul 2007 17:30:52 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2007-07-31 at 15:27 -0700, Andrew Morton wrote: > > ERROR: "scsi_tgt_it_nexus_create" [drivers/scsi/scsi_transport_srp.ko] > > undefined! > > ERROR: "scsi_tgt_it_nexus_destroy" [drivers/scsi/scsi_transport_srp

Re: scsi: fix warning in scsi_sysfs.c

2007-07-31 Thread James Bottomley
On Tue, 2007-07-31 at 23:35 +0200, Lado wrote: > Subject: scsi: fix warning in scsi_sysfs.c > > From: Ladislav Penko <[EMAIL PROTECTED]> > > change: trivial fix warning (removed unused variable rq) > > Signed-off-by: Ladislav Penko <[EMAIL PROTECTED]> The trivial fixes aren't always the best.

Re: git-scsi-misc build error

2007-07-31 Thread James Bottomley
On Tue, 2007-07-31 at 15:27 -0700, Andrew Morton wrote: > ERROR: "scsi_tgt_it_nexus_create" [drivers/scsi/scsi_transport_srp.ko] > undefined! > ERROR: "scsi_tgt_it_nexus_destroy" [drivers/scsi/scsi_transport_srp.ko] > undefined! > > This bug was reported about seven times against 2.6.23-rc1-mm1'

git-scsi-misc build error

2007-07-31 Thread Andrew Morton
ERROR: "scsi_tgt_it_nexus_create" [drivers/scsi/scsi_transport_srp.ko] undefined! ERROR: "scsi_tgt_it_nexus_destroy" [drivers/scsi/scsi_transport_srp.ko] undefined! This bug was reported about seven times against 2.6.23-rc1-mm1's git-scsi-target, and now it has been moved into git-scsi-misc.

scsi: fix warning in scsi_sysfs.c

2007-07-31 Thread Lado
Subject: scsi: fix warning in scsi_sysfs.c From: Ladislav Penko <[EMAIL PROTECTED]> change: trivial fix warning (removed unused variable rq) Signed-off-by: Ladislav Penko <[EMAIL PROTECTED]> Index: linux/drivers/scsi/scsi_sysfs.c =

[PATCH 82] drivers/scsi/zorro7xx.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/zorro7xx.c | 4579 -> 4501 (-78 bytes) drivers/scsi/zorro7xx.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) --- linux-2.6.23-rc1-mm1-a/drivers/scsi/zorro7xx.c 2007-07-26 13:07:42.0 +0200 +++ linu

Re: [PATCH 64] drivers/scsi/qla2xxx/qla_init.c: mostly kmalloc + memset conversion to k[cz]alloc

2007-07-31 Thread Andrew Vasquez
On Tue, 31 Jul 2007, Mariusz Kozlowski wrote: > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> > > drivers/scsi/qla2xxx/qla_init.c | 107445 -> 107327 (-118 bytes) > drivers/scsi/qla2xxx/qla_init.o | 237540 -> 237424 (-116 bytes) > > drivers/scsi/qla2xxx/qla_init.c | 14 ++

[PATCH 64] drivers/scsi/qla2xxx/qla_init.c: mostly kmalloc + memset conversion to k[cz]alloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/qla2xxx/qla_init.c | 107445 -> 107327 (-118 bytes) drivers/scsi/qla2xxx/qla_init.o | 237540 -> 237424 (-116 bytes) drivers/scsi/qla2xxx/qla_init.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) --- linux

Re: Inclusion of vmware mptbase regression fix

2007-07-31 Thread Petr Vandrovec
James Bottomley wrote: On Tue, 2007-07-31 at 20:24 +0200, Maarten Bressers wrote: Hi Petr, The patch you posted for the MPT Fusion driver regression with VMware 5.5.4 (http://lkml.org/lkml/2007/3/23/345) was used to fix a Gentoo kernel bug (http://bugs.gentoo.org/show_bug.cgi?id=185272). Ha

[PATCH 63] drivers/scsi/pluto.c: mostly kmalloc + memset conversion to kcalloc

2007-07-31 Thread Mariusz Kozlowski
This patch does kmalloc + memset conversion to kcalloc. Also the following warning is fixed. CC drivers/scsi/pluto.o drivers/scsi/pluto.c: In function 'pluto_info': drivers/scsi/pluto.c:283: warning: unused variable 'p' Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/sc

[PATCH 61] drivers/scsi/osst.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/osst.c | 185412 -> 185361 (-51 bytes) drivers/scsi/osst.o | 272432 -> 272344 (-88 bytes) drivers/scsi/osst.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- linux-2.6.23-rc1-mm1-a/drivers/scsi/osst.c 2007-07-

[PATCH 56] drivers/scsi/NCR_D700.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/NCR_D700.c | 10643 -> 10615 (-28 bytes) drivers/scsi/NCR_D700.o | 118400 -> 118196 (-204 bytes) drivers/scsi/NCR_D700.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.23-rc1-mm1-a/drivers/scsi/NCR_D7

[PATCH 7/8] lpfc 8.2.2 : Style cleanups

2007-07-31 Thread James Smart
Style cleanups: - Clean up all instances of mixed tab-space indentation - Clean up sparse build errors - Add appropriate static's Signed-off-by: James Smart <[EMAIL PROTECTED]> diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c --- a/drivers/scsi/lpfc/lpfc_attr.c 20

[PATCH 8/8] lpfc 8.2.2 : Change version number to 8.2.2

2007-07-31 Thread James Smart
Change version number to 8.2.2 Signed-off-by: James Smart <[EMAIL PROTECTED]> diff -upNr a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h --- a/drivers/scsi/lpfc/lpfc_version.h 2007-08-02 07:07:46.0 -0400 +++ b/drivers/scsi/lpfc/lpfc_version.h 2007-08-02 09:13:52

[PATCH 6/8] lpfc 8.2.2 : Miscellaneous Bug Fixes

2007-07-31 Thread James Smart
Miscellaneous Bug Fixes: - Fix vport ndlp ref counting errors - Fix use after free of ndlp structure - Use the correct flag to check for LOADING setting. - Fix driver unload bugs (related to shost references) after link down or rscn - Fix up HBQ initialization - Fix port_list locking around driver

[PATCH 5/8] lpfc 8.2.2 : Miscellaneous management and logging mods

2007-07-31 Thread James Smart
Miscellaneous management and logging mods: - Remove the "management_version" sysfs parameter (was unused) - Add HBQ information to lpfc debugfs - Change lpfc_npiv_enable name back to lpfc_enable_npiv (internal stds) - Remove "issue_lip" attribute from the vports transport template Signed-off

[PATCH 2/8] lpfc 8.2.2 : Fix locking around HBA's port_list

2007-07-31 Thread James Smart
Fix locking around HBA's port_list Cleans up a lot of bad behaviors that have been in this area a while Signed-off-by: James Smart <[EMAIL PROTECTED]> diff -upNr a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c --- a/drivers/scsi/lpfc/lpfc_attr.c 2007-07-20 13:38:28.000

[PATCH 3/8] lpfc 8.2.2 : Attribute and Parameter splits for vport and physical port

2007-07-31 Thread James Smart
Attribute and Parameter splits for vport and physical port - Split attributes up into vport and non-vport attributes. - Move vport specific cfg params to vport Many of the vport-specific behaviors were still global attributes on the physical port. Move them to the vport itself. Signed-off-by:

[PATCH 1/8] lpfc 8.2.2 : Error messages and debugfs updates

2007-07-31 Thread James Smart
Error messages and debugfs updates: - Fix up GID_FT error messages - Enhance debugfs with slow_ring_trace, dumpslim and nodelist information - Add log type (and messages) for vport state changes - Enhance log messages when retries ELS fail Signed-off-by: James Smart <[EMAIL PROTECTED]> di

[PATCH 0/8] lpfc 8.2.2 : lpfc 8.2.2 patches

2007-07-31 Thread James Smart
This set of patches updates the lpfc driver to revision 8.2.2. It is mainly bug fixes, further splitting of parameters between physical port and virtual port, and expanded debug logging. The patches contain the following: - Error messages and debugfs updates - Fix locking around HBA's port_list

[PATCH 54] drivers/scsi/mvme16x_scsi.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/mvme16x_scsi.c | 3740 -> 3678 (-62 bytes) drivers/scsi/mvme16x_scsi.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- linux-2.6.23-rc1-mm1-a/drivers/scsi/mvme16x_scsi.c 2007-07-26 13:07:42.0 +0200 +++ li

Re: Inclusion of vmware mptbase regression fix

2007-07-31 Thread James Bottomley
On Tue, 2007-07-31 at 20:24 +0200, Maarten Bressers wrote: > Hi Petr, > > The patch you posted for the MPT Fusion driver regression with VMware > 5.5.4 (http://lkml.org/lkml/2007/3/23/345) was used to fix a Gentoo > kernel bug (http://bugs.gentoo.org/show_bug.cgi?id=185272). > > Have you receiv

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread Kristen Carlson Accardi
On Wed, 01 Aug 2007 02:48:42 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > Hello, Kristen. > > Kristen Carlson Accardi wrote: > > On Tue, 31 Jul 2007 23:45:25 +0900 > > Tejun Heo <[EMAIL PROTECTED]> wrote: > > > >> Anyways, I don't really think this attribute belongs to SCSI sysfs > >> hierarchy.

Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining

2007-07-31 Thread Boaz Harrosh
Boaz Harrosh wrote: > FUJITA Tomonori wrote: >> From: Benny Halevy <[EMAIL PROTECTED]> >> Subject: Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large >> IO sg-chaining >> Date: Wed, 25 Jul 2007 11:26:44 +0300 >> However, I'm perfectly happy to go with whatever the empirical ev

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread Kristen Carlson Accardi
On Wed, 01 Aug 2007 03:02:55 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > Kristen Carlson Accardi wrote: > > I think what you are saying is that you'd like a way to use your HIPM > > and DIPM without ALPM on the AHCI driver. Fine - it's really easy > > to add these levels later - if they don't ma

[PATCH] Some cosmetic changes to QlogicPTI SCSI driver

2007-07-31 Thread Mark Fortescue
From: Mark Fortescue <[EMAIL PROTECTED]> Change a printk sequencing issue where <6> ... was coming up in the middle of a line when scsi_add_host was being called. Reduce the length of some printk messages and make the messages more consistant. All cosmetic but it makes it easier to read as it scr

Re: Inclusion of vmware mptbase regression fix

2007-07-31 Thread Jan Engelhardt
On Jul 31 2007 20:24, Maarten Bressers wrote: >Hi Petr, > >The patch you posted for the MPT Fusion driver regression with VMware >5.5.4 (http://lkml.org/lkml/2007/3/23/345) was used to fix a Gentoo >kernel bug (http://bugs.gentoo.org/show_bug.cgi?id=185272). > >Have you received word from upstre

[PATCH 50] drivers/message/fusion/mptctl.c: mostly kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
This patch does kmalloc + memset conversion to kzalloc and simplifies mptctl_probe(). Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/message/fusion/mptctl.c | 82092 -> 81884 (-208 bytes) drivers/message/fusion/mptctl.o | 201784 -> 200648 (-1136 bytes) drivers/message/fusion/mpt

Inclusion of vmware mptbase regression fix

2007-07-31 Thread Maarten Bressers
Hi Petr, The patch you posted for the MPT Fusion driver regression with VMware 5.5.4 (http://lkml.org/lkml/2007/3/23/345) was used to fix a Gentoo kernel bug (http://bugs.gentoo.org/show_bug.cgi?id=185272). Have you received word from upstream (kernel devs) yet as to whether your patch will be

RE: [PATCH 0/5] mpt fusion: Add logging support

2007-07-31 Thread Moore, Eric
On Monday, July 30, 2007 4:32 PM, FUJITA Tomonori wrote: > > On another note, while unloading the driver, and I get an > following opps > > from bsg in the context of scsi_remove_host. This is w/o the "SMP > > passthrough" patch, so why would fusion drivers be linked to bsg? > > Woudn't this br

Re: [PATCH update 3/3] firewire: fw-sbp2: add support for multiple logical units per target

2007-07-31 Thread Stefan Richter
Kristian Høgsberg wrote: > On 7/28/07, Stefan Richter <[EMAIL PROTECTED]> wrote: >> struct sbp2_logical_unit { >> struct sbp2_target *tgt; >> + struct list_head tgt_list; > > I would call this link. I've consistently named all instances of > struct list_head that are used as a list

Re: [PATCH 5/6] aha152x.c - Fix check_condition code-path

2007-07-31 Thread Randy Dunlap
On Tue, 31 Jul 2007 10:59:51 +0300 Boaz Harrosh wrote: > Randy Dunlap wrote: > > > > Since you grok all of that (above), maybe you can help here: > > > > With these 6 patches applied, I do the following: > > > > 1. insert PCMCIA aha152x card with SCSI drive attached (/dev/sdb4) > > 2. mount -

[PATCH 47] drivers/scsi/megaraid.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
This patch does kmalloc + memset conversion to kzalloc and adds missing check for kzaloc return value. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/megaraid.c | 116109 -> 116094 (-15 bytes) drivers/scsi/megaraid.o | 257872 -> 257772 (-100 bytes) drivers/scsi/megaraid.c |

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread Tejun Heo
Arjan van de Ven wrote: >> They were hardware problems. I don't think any amount of proper >> implementation can fix them. I have one DVD RAM somewhere in my pile of >> hardware which locks up solidly if any link PS mode is used and had a > > and the AHCI ALPM code decides to use power savings o

[PATCH 46] drivers/scsi/lpfc/lpfc_scsi.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/lpfc/lpfc_scsi.c | 42769 -> 42721 (-48 bytes) drivers/scsi/lpfc/lpfc_scsi.o | 191332 -> 191240 (-92 bytes) drivers/scsi/lpfc/lpfc_scsi.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- linux-2.6.23-rc1-mm1-a/driv

[PATCH 45] drivers/scsi/lpfc/lpfc_init.c: kmalloc + memset conversion to kcalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/lpfc/lpfc_init.c | 65932 -> 65881 (-51 bytes) drivers/scsi/lpfc/lpfc_init.o | 219760 -> 219616 (-144 bytes) drivers/scsi/lpfc/lpfc_init.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- linux-2.6.23-rc1-mm1-a/dri

[PATCH 44] drivers/scsi/lpfc/lpfc_debugfs.c: kmalloc + memset conversion to kcalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/lpfc/lpfc_debugfs.c | 13809 -> 13716 (-93 bytes) drivers/scsi/lpfc/lpfc_debugfs.o | 146124 -> 146124 (0 bytes) drivers/scsi/lpfc/lpfc_debugfs.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) --- linux-2.6.23-rc

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread Tejun Heo
Kristen Carlson Accardi wrote: > I think what you are saying is that you'd like a way to use your HIPM > and DIPM without ALPM on the AHCI driver. Fine - it's really easy > to add these levels later - if they don't make sense at the sysfs interface > we can add module params to specify the definit

[PATCH 31] drivers/scsi/ide-scsi.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/ide-scsi.c | 34642 -> 34536 (-106 bytes) drivers/scsi/ide-scsi.o | 171728 -> 171524 (-204 bytes) drivers/scsi/ide-scsi.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) --- linux-2.6.23-rc1-mm1-a/drivers/scsi

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread Tejun Heo
Hello, Kristen. Kristen Carlson Accardi wrote: > On Tue, 31 Jul 2007 23:45:25 +0900 > Tejun Heo <[EMAIL PROTECTED]> wrote: > >> Anyways, I don't really think this attribute belongs to SCSI sysfs >> hierarchy. There currently isn't any alternative but sysfs is part of >> userland visible interfac

RE: [PATCH 21] drivers/scsi/dpt_i2o.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Salyzyn, Mark
ACK Looks good and ultra-light on side effects! Sincerely -- Mark Salyzyn > -Original Message- > From: Mariusz Kozlowski [mailto:[EMAIL PROTECTED] > Sent: Tuesday, July 31, 2007 1:35 PM > To: [EMAIL PROTECTED] > Cc: [EMAIL PROTECTED]; Andrew Morton; > linux-scsi@vger.kernel.org; AACRAI

[PATCH 26] drivers/scsi/gdth.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/gdth.c | 189401 -> 189342 (-59 bytes) drivers/scsi/gdth.o | 331028 -> 330324 (-704 bytes) drivers/scsi/gdth.c |8 1 file changed, 4 insertions(+), 4 deletions(-) --- linux-2.6.23-rc1-mm1-a/drivers/scsi/gdth.c 2007

Re: [PATCH update 3/3] firewire: fw-sbp2: add support for multiple logical units per target

2007-07-31 Thread Kristian Høgsberg
On 7/28/07, Stefan Richter <[EMAIL PROTECTED]> wrote: > This makes multiple logical units on a single target accessible to > fw-sbp2. Successfully tested with the IOI FWB-IDE01AB dual LU bridge. Very nice, this is good code. I have a couple of nitpicks below. > Signed-off-by: Stefan Richter <[E

[PATCH 21] drivers/scsi/dpt_i2o.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/dpt_i2o.c | 87632 -> 87457 (-175 bytes) drivers/scsi/dpt_i2o.o | 213064 -> 212324 (-740 bytes) drivers/scsi/dpt_i2o.c | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) --- linux-2.6.23-rc1-mm

Re: [PATCH 5/6] aha152x.c - Fix check_condition code-path

2007-07-31 Thread Randy Dunlap
On Tue, 31 Jul 2007 10:59:51 +0300 Boaz Harrosh wrote: > Randy Dunlap wrote: > > > > Since you grok all of that (above), maybe you can help here: > > > > With these 6 patches applied, I do the following: > > > > 1. insert PCMCIA aha152x card with SCSI drive attached (/dev/sdb4) > > 2. mount -

[PATCH 06] drivers/scsi/bvme6000_scsi.c: kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/bvme6000_scsi.c | 3330 -> 3253 (-77 bytes) drivers/scsi/bvme6000_scsi.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) --- linux-2.6.23-rc1-mm1-a/drivers/scsi/bvme6000_scsi.c 2007-07-26 13:07:42.0 +0200

[PATCH 02] kmalloc + memset conversion to kzalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/aic7xxx_old.c | 367101 -> 366983 (-118 bytes) drivers/scsi/aic7xxx_old.o | 333892 -> 333192 (-700 bytes) drivers/scsi/aic7xxx_old.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) --- linux-2.6.23-rc1-mm1-a/dri

[PATCH 01] kmalloc + memset conversion co kzalloc

2007-07-31 Thread Mariusz Kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/scsi/a4000t.c | 3534 -> 3457 (-77 bytes) drivers/scsi/a4000t.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) --- linux-2.6.23-rc1-mm1-a/drivers/scsi/a4000t.c2007-07-26 13:07:42.0 +0200 +++ linux-2.6

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread Kristen Carlson Accardi
On Tue, 31 Jul 2007 15:27:34 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > Jeff Garzik wrote: > > Any chance the SCSI peeps could ACK this, and then let me include it in > > the ALPM patchset in the libata tree? > > ATA link PS is pretty complex with HIPM, DIPM and AHCI ALPM. I'm not > sure wheth

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread Kristen Carlson Accardi
On Tue, 31 Jul 2007 23:45:25 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > Anyways, I don't really think this attribute belongs to SCSI sysfs > hierarchy. There currently isn't any alternative but sysfs is part of > userland visible interface and putting something into SCSI sysfs > hierarchy just

Re: [PATCH] Correct some mistakes in drivers using the scsi hotplug model

2007-07-31 Thread James Bottomley
On Tue, 2007-07-31 at 10:00 -0600, Matthew Wilcox wrote: > On Tue, Jul 31, 2007 at 10:05:50AM -0500, James Bottomley wrote: > > I agree the NCR_700_release should be the last method called. However, > > the NCR_700_detect() API calls scsi_host_alloc/scsi_add_host() ... the > > API will be horribly

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread Arjan van de Ven
> They were hardware problems. I don't think any amount of proper > implementation can fix them. I have one DVD RAM somewhere in my pile of > hardware which locks up solidly if any link PS mode is used and had a and the AHCI ALPM code decides to use power savings on this device? if so, please g

Re: [PATCH] Correct some mistakes in drivers using the scsi hotplug model

2007-07-31 Thread Matthew Wilcox
On Tue, Jul 31, 2007 at 10:05:50AM -0500, James Bottomley wrote: > I agree the NCR_700_release should be the last method called. However, > the NCR_700_detect() API calls scsi_host_alloc/scsi_add_host() ... the > API will be horribly assymetric (and thus prone to misuse) with regard > to the host

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-31 Thread Moore, Eric
On Monday, July 30, 2007 5:36 PM, FUJITA Tomonori wrote: > > Looks good for me. > > Here's an updated version. Can you add your signed-off or acked-by? > > --- > From: FUJITA Tomonori <[EMAIL PROTECTED]> > Subject: [PATCH] mptsas: add SAS management protocol handler > > This patch adds support

Re: [PATCH 1/1] scsi: Fix SRP_ATTRS Kconfig

2007-07-31 Thread FUJITA Tomonori
From: Brian King <[EMAIL PROTECTED]> Subject: [PATCH 1/1] scsi: Fix SRP_ATTRS Kconfig Date: Mon, 30 Jul 2007 11:12:10 -0500 > > Since the srp transport class was added, if scsi tgt support is not > selected, the current Kconfig allows for enabling a dependent device > driver, such as ibmvscsi, wh

Re: [PATCH] Correct some mistakes in drivers using the scsi hotplug model

2007-07-31 Thread Boaz Harrosh
On 7/31/07, Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Tue, Jul 31, 2007 at 09:42:25AM -0500, James Bottomley wrote: > > Rather than changing this in every 53c700 based driver, shouldn't it > > just be added to NCR_700_release()? > > > > diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152

Re: [PATCH] Correct some mistakes in drivers using the scsi hotplug model

2007-07-31 Thread James Bottomley
On Tue, 2007-07-31 at 15:57 +0100, Christoph Hellwig wrote: > On Tue, Jul 31, 2007 at 08:52:28AM -0600, Matthew Wilcox wrote: > > On Tue, Jul 31, 2007 at 09:42:25AM -0500, James Bottomley wrote: > > > Rather than changing this in every 53c700 based driver, shouldn't it > > > just be added to NCR_70

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread Tejun Heo
Arjan van de Ven wrote: > either sucks. AHCI ALPM ought to work if it's supported; it's what other > operating systems also use... A question. Does the other OS enable ALPM without checking against white/black list? Or is it enabled only on certain configurations - e.g. specific notebooks, etc?

Re: [PATCH] Correct some mistakes in drivers using the scsi hotplug model

2007-07-31 Thread Christoph Hellwig
On Tue, Jul 31, 2007 at 08:52:28AM -0600, Matthew Wilcox wrote: > On Tue, Jul 31, 2007 at 09:42:25AM -0500, James Bottomley wrote: > > Rather than changing this in every 53c700 based driver, shouldn't it > > just be added to NCR_700_release()? > > Then I'd have to change the few drivers that weren

Re: [PATCH] Correct some mistakes in drivers using the scsi hotplug model

2007-07-31 Thread Matthew Wilcox
On Tue, Jul 31, 2007 at 09:42:25AM -0500, James Bottomley wrote: > Rather than changing this in every 53c700 based driver, shouldn't it > just be added to NCR_700_release()? Then I'd have to change the few drivers that weren't leaking scsi_hosts ;-) But I can, if that's what you prefer. > > diff

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread Tejun Heo
Arjan van de Ven wrote: > On Tue, 2007-07-31 at 15:27 +0900, Tejun Heo wrote: >> Jeff Garzik wrote: >>> Any chance the SCSI peeps could ACK this, and then let me include it in >>> the ALPM patchset in the libata tree? >> ATA link PS is pretty complex with HIPM, DIPM and AHCI ALPM. I'm not >> sure

Re: [PATCH] Correct some mistakes in drivers using the scsi hotplug model

2007-07-31 Thread James Bottomley
On Tue, 2007-07-31 at 06:55 -0600, Matthew Wilcox wrote: > A few drivers are doing things like releasing IRQs before calling > scsi_remove_host(), which can lead to some ugly error messages. > Many more drivers are simply forgetting to call scsi_host_put() after > they've finished tearing down thei

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread James Bottomley
On Tue, 2007-07-31 at 15:27 +0900, Tejun Heo wrote: > Jeff Garzik wrote: > > Any chance the SCSI peeps could ACK this, and then let me include it in > > the ALPM patchset in the libata tree? > > ATA link PS is pretty complex with HIPM, DIPM and AHCI ALPM. I'm not > sure whether this three level k

Re: [patch 2/4] Expose Power Management Policy option to users

2007-07-31 Thread Arjan van de Ven
On Tue, 2007-07-31 at 15:27 +0900, Tejun Heo wrote: > Jeff Garzik wrote: > > Any chance the SCSI peeps could ACK this, and then let me include it in > > the ALPM patchset in the libata tree? > > ATA link PS is pretty complex with HIPM, DIPM and AHCI ALPM. I'm not > sure whether this three level k

Re: build #308 failed for 2.6.23-rc1-gd941cf5 in linux/./drivers/scsi/libsas/sas_ata.c

2007-07-31 Thread Toralf Förster
Am Samstag, 28. Juli 2007 17:07 schrieb James Bottomley: > On Fri, 2007-07-27 at 12:53 +0200, Toralf Förster wrote: > > Hello, > > > > the build with the attached .config failed, make ends with: > > ... > > CHK include/linux/compile.h > > UPD include/linux/compile.h > > CC init/

Re: [PATCH] Correct some mistakes in drivers using the scsi hotplug model

2007-07-31 Thread Jeff Garzik
Matthew Wilcox wrote: A few drivers are doing things like releasing IRQs before calling scsi_remove_host(), which can lead to some ugly error messages. Many more drivers are simply forgetting to call scsi_host_put() after they've finished tearing down their driver structures. Signed-off-by: Matt

[PATCH] Correct some mistakes in drivers using the scsi hotplug model

2007-07-31 Thread Matthew Wilcox
A few drivers are doing things like releasing IRQs before calling scsi_remove_host(), which can lead to some ugly error messages. Many more drivers are simply forgetting to call scsi_host_put() after they've finished tearing down their driver structures. Signed-off-by: Matthew Wilcox <[EMAIL PROT

RE: [PATCH] dpt_i2o: convert to SCSI hotplug model

2007-07-31 Thread Salyzyn, Mark
ACK! Sincerely -- Mark Salyzyn > -Original Message- > From: Matthew Wilcox [mailto:[EMAIL PROTECTED] > Sent: Monday, July 30, 2007 5:19 PM > To: AACRAID; linux-scsi@vger.kernel.org > Subject: [PATCH] dpt_i2o: convert to SCSI hotplug model > > dpt_i2o: Convert to new SCSI driver model >

Re: [PATCH] zfcp: convert to use the data buffer accessors

2007-07-31 Thread Swen Schillig
Replying to the mailing-list as well. ACK On Sunday 29 July 2007 09:46, FUJITA Tomonori wrote: > The patch is only compile tested. > > --- > From: FUJITA Tomonori <[EMAIL PROTECTED]> > Subject: [PATCH] zfcp: convert to use the data buffer accessors > > - remove the unnecessary map_single path.

[PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-07-31 Thread Denis Vlasenko
Hi, Attached patch deinlines and moves big functions from .h to .c files in drivers/scsi/aic7xxx/*. I also had to add prototypes for ahc_lookup_scb and ahd_lookup_scb to .h files. No other code changes made. Compile-tested on i386 and x86-64. Total .text size reduction: ~60k in 64 bits, ~90k in

Re: [PATCH 5/6] aha152x.c - Fix check_condition code-path

2007-07-31 Thread Boaz Harrosh
Randy Dunlap wrote: > > Since you grok all of that (above), maybe you can help here: > > With these 6 patches applied, I do the following: > > 1. insert PCMCIA aha152x card with SCSI drive attached (/dev/sdb4) > 2. mount -t vfat /dev/sdb4 /mnt/disk > 3. play with /mnt/disk > 4. umount /mnt/d