Re: isd200.c Has fatal bugs and is probably not used any more

2007-08-21 Thread Doug Maxey
On Tue, 21 Aug 2007 22:06:26 +0300, Boaz Harrosh wrote: > Hi! > > the driver drivers/usb/storage/isd200.c has code like: > > static int isd200_action( struct us_data *us, int action, > void* pointer, int value ) > > ... > > case ACTION_READ_STATUS: > US_DEBUGP(" isd

isd200.c Has fatal bugs and is probably not used any more

2007-08-21 Thread Boaz Harrosh
Hi! the driver drivers/usb/storage/isd200.c has code like: static int isd200_action( struct us_data *us, int action, void* pointer, int value ) ... case ACTION_READ_STATUS: US_DEBUGP(" isd200_action(READ_STATUS)\n"); ata.generic.ActionSelect = ACTION_SELECT_0

[RFC][PATCH] Removal of #include from scsi drivers

2007-08-21 Thread Michal Piotrowski
Hi, This patch removes linux/stat.h from scsi drivers. Tested with allyesconfig and allmodconfig. Regards, Michal -- LOG http://www.stardust.webpages.pl/log/ Signed-off-by: Michal Piotrowski <[EMAIL PROTECTED]> diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c index 9b20617..8e91

Re: [PATCH] FC transport: Allow LLDD to disable LUN scanning

2007-08-21 Thread Matthew Wilcox
On Tue, Aug 21, 2007 at 05:37:17PM +0200, Christof Schmitt wrote: > unsigned long show_host_system_hostname:1; > + > + /* The driver can disable the LUN scanning from the FC transport class > */ > + unsigned long disable_target_scan:1; > }; The comment exceeds 80 columns. Why

[PATCH] FC transport: Allow LLDD to disable LUN scanning

2007-08-21 Thread Christof Schmitt
From: Christof Schmitt <[EMAIL PROTECTED]> Introduce a flag that allows the SCSI low level device driver to disable the automatic scanning for LUNs from the FC transport class. This is for the zfcp device driver that manages the attached units on its own and does not want to have the automatic di

Re: [RFC] FC transport: Disable LUN scanning from low level driver

2007-08-21 Thread Christof Schmitt
On Tue, Aug 21, 2007 at 09:03:17AM -0400, James Smart wrote: > Nit (but preferred) : change "no_target_scan" to "disable_target_scan". > Otherwise, patch is good. Ok. I will send the fixed version in a separate mail. > Yep. However, I don't agree with Hannes in this case. Given that the > firm

Re: [RFC] FC transport: Disable LUN scanning from low level driver

2007-08-21 Thread James Smart
Nit (but preferred) : change "no_target_scan" to "disable_target_scan". Otherwise, patch is good. Christof Schmitt wrote: I attached a new patch that adds a flag to the fc template. So far, it is untested. What is the better approach? Avoid scanning with the flag being 1 or use the 1 to enable

Re: [RFC] FC transport: Disable LUN scanning from low level driver

2007-08-21 Thread Christof Schmitt
James, thanks for the feedback. On Mon, Aug 20, 2007 at 09:07:23PM -0400, James Smart wrote: > I'd prefer a flag/bit in the fc template to indicate no scanning by the > transport. Thus, it's up to the driver to call __scsi_add_device, or > perform the appropriate scans... I attached a new patch