[PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread Jesper Juhl
From: Jesper Juhl [EMAIL PROTECTED] in sas_get_phy_change_count(), the line disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE); will allocate 56 bytes due to this define: #define DISCOVER_RESP_SIZE 56 But, the struct is actually 60 bytes in size. So change the define to be

Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread James Bottomley
On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: From: Jesper Juhl [EMAIL PROTECTED] in sas_get_phy_change_count(), the line disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE); will allocate 56 bytes due to this define: #define DISCOVER_RESP_SIZE 56 But, the struct is actually

Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread Jesper Juhl
On 12/11/2007, James Bottomley [EMAIL PROTECTED] wrote: On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: From: Jesper Juhl [EMAIL PROTECTED] in sas_get_phy_change_count(), the line disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE); will allocate 56 bytes due to this define:

Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread Douglas Gilbert
James Bottomley wrote: On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: From: Jesper Juhl [EMAIL PROTECTED] in sas_get_phy_change_count(), the line disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE); will allocate 56 bytes due to this define: #define DISCOVER_RESP_SIZE 56 But,

Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread James Bottomley
On Mon, 2007-11-12 at 01:13 +0100, Jesper Juhl wrote: On 12/11/2007, James Bottomley [EMAIL PROTECTED] wrote: On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: From: Jesper Juhl [EMAIL PROTECTED] in sas_get_phy_change_count(), the line disc_resp =

Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread James Bottomley
On Sun, 2007-11-11 at 19:33 -0500, Douglas Gilbert wrote: James Bottomley wrote: On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: From: Jesper Juhl [EMAIL PROTECTED] in sas_get_phy_change_count(), the line disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE); will allocate 56 bytes

Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread Jesper Juhl
On 12/11/2007, James Bottomley [EMAIL PROTECTED] wrote: On Mon, 2007-11-12 at 01:13 +0100, Jesper Juhl wrote: On 12/11/2007, James Bottomley [EMAIL PROTECTED] wrote: On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: From: Jesper Juhl [EMAIL PROTECTED] in

[PATCH] SCSI: Fix bugs and canonicalize irq handler usage in NCR5380 drivers

2007-11-11 Thread Jeff Garzik
* Always pass the same value to free_irq() that we pass to request_irq(). This fixes several bugs. * Always call NCR5380_intr() with 'irq' and 'dev_id' arguments. Note, scsi_falcon_intr() is the only case now where dev_id is not the scsi_host. * Always pass Scsi_Host to request_irq().

[PATCH] cciss: use upper_32_bits() macro to eliminate warnings

2007-11-11 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Use upper_32_bits(x) macro to handle shifts that may be = the width of the data type. drivers/block/cciss.c: In function 'do_cciss_request': drivers/block/cciss.c:2655: warning: right shift count = width of type drivers/block/cciss.c:2656: warning: right

Re: [PATCH 4/6] scsi: megaraid_sas - call cmd completion from reset

2007-11-11 Thread Jon Masters
On Fri, 2007-11-09 at 04:35 -0500, bo yang wrote: Driver will call cmd completion routine from Reset path without waiting for cmd completion from isr context. Thanks. I'm going to take a look at this, as well as the other recent 2 patches for a couple of test kernels we have that are based on