Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window

2008-02-11 Thread Harvey Harrison
On Fri, 2008-02-08 at 10:37 -0600, James Bottomley wrote: On Fri, 2008-02-08 at 10:03 +0100, Geert Uytterhoeven wrote: On Thu, 7 Feb 2008, James Bottomley wrote: On Thu, 2008-02-07 at 17:04 -0800, Harvey Harrison wrote: I'm going to guess that this is the entry in feature-removal.txt

Re: [SCSI] ses: fix memory leaks

2008-02-11 Thread Yinghai Lu
On Monday 11 February 2008 09:02:06 am James Bottomley wrote: On Mon, 2008-02-11 at 10:23 -0600, James Bottomley wrote: On Sun, 2008-02-10 at 23:25 -0800, Yinghai Lu wrote: please check it... This one looks perfect, thanks! Well, nearly perfect. I corrected this typo: +

Re: [PATCH 7/9] scsi_dh: Add support for SDEV_PASSIVE

2008-02-11 Thread Chandra Seetharaman
On Sat, 2008-02-09 at 05:45 -0700, Matthew Wilcox wrote: On Mon, Feb 04, 2008 at 01:19:30PM -0800, Chandra Seetharaman wrote: The device does send these error messages currently, but it takes some time to get the check condition back, which adds up the time to boot especially when the # of

Re: [PATCH] drivers/scsi/aic7xxx/aic7xxx_osm_pci.c - remove pointer comparison to 0

2008-02-11 Thread Randy Dunlap
On Mon, 11 Feb 2008 09:08:05 -0800 Joe Perches wrote: On Mon, 2008-02-11 at 09:30 -0600, James Bottomley wrote: On Sun, 2008-02-10 at 21:47 -0800, Joe Perches wrote: - if (request_region(*base, 256, aic7xxx) == 0) + if (!request_region(*base, 256, aic7xxx)) This patch is

Re: [PATCH] scsi_error: Fix language abuse.

2008-02-11 Thread Benny Halevy
Seriously, can't you just add a disclaimer to the README file? In http://lkml.org/lkml/2008/2/9/29, Luben Tuikov made an interesting point that in many cases illegal refers to a valid value that violates the specification, so the term invalid may be technically incorrect. Benny On Feb. 11,

Re: [PATCH] drivers/scsi/aic7xxx/aic7xxx_osm_pci.c - remove pointer comparison to 0

2008-02-11 Thread Joe Perches
On Mon, 2008-02-11 at 09:30 -0600, James Bottomley wrote: On Sun, 2008-02-10 at 21:47 -0800, Joe Perches wrote: - if (request_region(*base, 256, aic7xxx) == 0) + if (!request_region(*base, 256, aic7xxx)) This patch is completely pointless. It removes a sparse warning.

Re: [SCSI] ses: fix memory leaks

2008-02-11 Thread James Bottomley
On Sun, 2008-02-10 at 23:25 -0800, Yinghai Lu wrote: please check it... This one looks perfect, thanks! James - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] iscsi: bidi support - libiscsi

2008-02-11 Thread Boaz Harrosh
On Mon, Feb 11 2008 at 17:43 +0200, Pete Wyckoff [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote on Thu, 31 Jan 2008 22:29 +0200: iscsi bidi support at the generic libiscsi level - prepare the additional bidi_read rlength header. - access the right scsi_in() and/or scsi_out() side of

Re: [PATCH] scsi_error: Fix language abuse.

2008-02-11 Thread linux-os (Dick Johnson)
On Fri, 8 Feb 2008, Mark Hounschell wrote: linux-os (Dick Johnson) wrote: The correct word should be invalid, in spite of the fact that the SCSI committee used invalid syntax. Alan is right. There is nothing illegal in the kernel and if there is, it must be removed as soon as it is

[PATCH] mpt fusion: Power Management fixes for MPT SAS PCI-E controllers

2008-02-11 Thread Prakash, Sathya
This patch was submitted as [PATCH 2/3] yesterday, since it did not reach the list due to CC errors sending this again. It is regenerated against new git tree. The system power state changes like hibernation and standby are not happening properly with 106XE controllers, this patch modifies the

Re: [PATCH] mpt fusion: Power Management fixes for MPT SAS PCI-E controllers

2008-02-11 Thread James Bottomley
On Mon, 2008-02-11 at 18:36 +0530, Prakash, Sathya wrote: This patch was submitted as [PATCH 2/3] yesterday, since it did not reach the list due to CC errors sending this again. It is regenerated against new git tree. The system power state changes like hibernation and standby are not

[PATCH] sym53c416: fix module parameters

2008-02-11 Thread James Bottomley
It looks like there's been a bug in the module parameter setup forever. The upshot doesn't really matter, because even if no parameters are ever set, we just call sym53c416_setup() three times, but the zero values in the arrays eventually cause nothing to happen. Unfortunately gcc has started to

[PATCH 1/1] cciss: procfs updates to display info about many volumes

2008-02-11 Thread Mike Miller
Patch 1 of 1 This patch allows us to display information about all of the logical volumes configured on a particular without stepping on memory even when there are many volumes (128 or more) configured. This patch replaces the one submitted on 20071214. See

Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window

2008-02-11 Thread James Bottomley
On Mon, 2008-02-11 at 13:13 -0800, Harvey Harrison wrote: On Fri, 2008-02-08 at 10:37 -0600, James Bottomley wrote: On Fri, 2008-02-08 at 10:03 +0100, Geert Uytterhoeven wrote: On Thu, 7 Feb 2008, James Bottomley wrote: On Thu, 2008-02-07 at 17:04 -0800, Harvey Harrison wrote: I'm

Re: [PATCH] drivers/scsi/aic7xxx/aic7xxx_osm_pci.c - remove pointer comparison to 0

2008-02-11 Thread James Bottomley
On Mon, 2008-02-11 at 09:17 -0800, Randy Dunlap wrote: On Mon, 11 Feb 2008 09:08:05 -0800 Joe Perches wrote: On Mon, 2008-02-11 at 09:30 -0600, James Bottomley wrote: On Sun, 2008-02-10 at 21:47 -0800, Joe Perches wrote: - if (request_region(*base, 256, aic7xxx) == 0) +

Drivers 'sd' 'sr' need updating: please use bus_type methods...

2008-02-11 Thread Linda Walsh
I turned on the option to flag deprecated code, and these two popped up: Driver 'sd' needs updating - please use bus_type methods Driver 'sr' needs updating - please use bus_type methods I'm assuming these are referring to the SCSI devices? I'm assuming they are already known about? Just

Re: [SCSI] ses: fix memory leaks

2008-02-11 Thread James Bottomley
On Mon, 2008-02-11 at 10:23 -0600, James Bottomley wrote: On Sun, 2008-02-10 at 23:25 -0800, Yinghai Lu wrote: please check it... This one looks perfect, thanks! Well, nearly perfect. I corrected this typo: + if (!buf) + goto simple_polulate;

Re: [PATCH] drivers/scsi/aic7xxx/aic7xxx_osm_pci.c - remove pointer comparison to 0

2008-02-11 Thread James Bottomley
On Sun, 2008-02-10 at 21:47 -0800, Joe Perches wrote: - if (request_region(*base, 256, aic7xxx) == 0) + if (!request_region(*base, 256, aic7xxx)) This patch is completely pointless. if (x == 0) and if (!x) mean identical things and there's no style standard preferring one form over

Re: Patches not reaching the list

2008-02-11 Thread James Bottomley
On Mon, 2008-02-11 at 10:24 +0530, Prakash, Sathya wrote: I tried to send few patches on last friday, out of which only one reached the list I resent the rest two and again only on reached the list Again I have resent the third patch two times, but they are still to reach the list. I am

Re: [SCSI] sun3x_esp: convert to esp_scsi

2008-02-11 Thread James Bottomley
On Mon, 2008-02-11 at 12:24 +0100, Thomas Bogendoerfer wrote: On Sun, Feb 10, 2008 at 10:38:15AM +0100, Kars de Jong wrote: Thomas, can't you use ioreadxx() and friends instead of rolling your own memory mapped I/O handlers? well, at least ioread32be/iowrite32be are looking promising, but

Re: scsi/arm/fas216.c compile error

2008-02-11 Thread Russell King
On Mon, Feb 11, 2008 at 11:47:57AM +0200, Boaz Harrosh wrote: On Mon, Feb 11 2008 at 0:44 +0200, James Bottomley [EMAIL PROTECTED] wrote: Andrew this patch was in -mm for two month or so. I was under the impression that you have an arm cross compiler that tries to build every -mm kernel. Is it

Re: scsi/arm/fas216.c compile error

2008-02-11 Thread Boaz Harrosh
On Mon, Feb 11 2008 at 0:44 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Sun, 2008-02-10 at 22:02 +, Russell King wrote: On Sun, Feb 10, 2008 at 08:20:24AM -0600, James Bottomley wrote: On Sun, 2008-02-10 at 13:58 +, Russell King wrote: On Sun, Feb 10, 2008 at 03:07:09PM +0200,

Re: [PATCH 2/3] iscsi: bidi support - libiscsi

2008-02-11 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Thu, 31 Jan 2008 22:29 +0200: iscsi bidi support at the generic libiscsi level - prepare the additional bidi_read rlength header. - access the right scsi_in() and/or scsi_out() side of things. also for resid. - Handle BIDI underflow overflow from target

Re: [PATCH 5/7] block: clear drain buffer if draining for write command

2008-02-11 Thread James Bottomley
On Sat, 2008-02-09 at 10:40 +0900, Tejun Heo wrote: Clear drain buffer before chaining if the command in question is a write. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- block/blk-merge.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/block/blk-merge.c

Re: [PATCH 7/9] scsi_dh: Add support for SDEV_PASSIVE

2008-02-11 Thread Matthew Wilcox
On Mon, Feb 11, 2008 at 10:27:46AM -0800, Chandra Seetharaman wrote: On Sat, 2008-02-09 at 05:45 -0700, Matthew Wilcox wrote: On Mon, Feb 04, 2008 at 01:19:30PM -0800, Chandra Seetharaman wrote: The device does send these error messages currently, but it takes some time to get the check

Re: Integration of SCST in the mainstream Linux kernel

2008-02-11 Thread Vladislav Bolkhovitin
Luben Tuikov wrote: Is there an open iSCSI Target implementation which does NOT issue commands to sub-target devices via the SCSI mid-layer, but bypasses it completely? What do you mean? To call directly low level backstorage SCSI drivers queuecommand() routine? What are advantages of

Re: [PATCH 2/3] iscsi: bidi support - libiscsi

2008-02-11 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Mon, 11 Feb 2008 18:05 +0200: You are most probably right I will investigate what happened. It looks like I went back to some old version right? or a merge fallout Thanks for reviewing. Please also test latest head-of-line code if possible + iscsi patches + last

Re: [SCSI] sun3x_esp: convert to esp_scsi

2008-02-11 Thread Thomas Bogendoerfer
On Sun, Feb 10, 2008 at 10:38:15AM +0100, Kars de Jong wrote: Thomas, can't you use ioreadxx() and friends instead of rolling your own memory mapped I/O handlers? well, at least ioread32be/iowrite32be are looking promising, but a quick grep didn't show them for m68k. readxx() and friends are

Re: scsi/arm/fas216.c compile error

2008-02-11 Thread Boaz Harrosh
On Mon, Feb 11 2008 at 12:02 +0200, Russell King [EMAIL PROTECTED] wrote: On Mon, Feb 11, 2008 at 11:47:57AM +0200, Boaz Harrosh wrote: On Mon, Feb 11 2008 at 0:44 +0200, James Bottomley [EMAIL PROTECTED] wrote: Andrew this patch was in -mm for two month or so. I was under the impression that