Re: ips.c broken since 2.6.23 on x86_64?

2008-02-19 Thread FUJITA Tomonori
ips did scsi_add_host(sh, NULL) so scsi_dma_map uses shost_gendev.parent that isn't initialized properly, then the kernel crashes. 2.6.23 and 2.6.24 have this bug. We can fix this by calling scsi_add_host with pdev-dev, in the standard way (like the following way) but this bug was fixed in the

[PATCH update] firewire: fw-sbp2: fix NULL pointer deref in scsi_remove_device

2008-02-19 Thread Stefan Richter
Fix a kernel bug when unplugging an SBP-2 device after having its scsi_device already removed via the delete sysfs attribute. Signed-off-by: Stefan Richter [EMAIL PROTECTED] --- Update: A _put was missing in a failure path. drivers/firewire/fw-sbp2.c |8 1 file changed, 4

[PATCH] ips: fix data buffer accessors conversion bug

2008-02-19 Thread FUJITA Tomonori
There is one more bug in ips. I think that this needs to go to scsi-rc-fixes, 2.6.24-stable, and 2.6.23-stable though we might rarely hit this bug. = From: FUJITA Tomonori [EMAIL PROTECTED] Date: Tue, 19 Feb 2008 16:03:47 +0900 Subject: [PATCH] ips: fix data buffer accessors conversion bug This

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-19 Thread FUJITA Tomonori
On Mon, 18 Feb 2008 19:48:49 -0800 Tim Pepper [EMAIL PROTECTED] wrote: On Feb 18, 2008 4:11 PM, FUJITA Tomonori [EMAIL PROTECTED] wrote: Can you please help me just once more? 2.6.25-rc2 fixed this bug in a bit different way by chance. Please test 2.6.25-rc2 with the attached patch to make

[PATCH] ips: sg chaining support to the path to non I/O commands

2008-02-19 Thread FUJITA Tomonori
Here is another ips patch, but not a bug fix. = From: FUJITA Tomonori [EMAIL PROTECTED] Subject: [PATCH] ips: sg chaining support to the path to non I/O commands I overlooked ips_scmd_buf_write and ips_scmd_buf_read when I converted ips to use the data buffer accessors. ips is unlikely to use

Re: [PATCH 1/1] cciss: procfs updates to display info about many volumes

2008-02-19 Thread Andrew Morton
On Tue, 19 Feb 2008 11:48:18 +0100 Jens Axboe [EMAIL PROTECTED] wrote: On Mon, Feb 11 2008, Mike Miller wrote: Patch 1 of 1 This patch allows us to display information about all of the logical volumes configured on a particular without stepping on memory even when there are many

RE: [PATCH] ips: sg chaining support to the path to non I/O commands

2008-02-19 Thread Salyzyn, Mark
ACK Other RAID drivers (eg: aacraid) makes the assumption that commands in these paths (INQUIRY, READ CAPACITY, MODE SENSE etc spoofing) are single scatter gather elements and have yet to be bitten. I agree with Fujita-san about the practical unlikelihood. The fix does not incur any change in

Re: SCSI RAM driver

2008-02-19 Thread Matthew Wilcox
On Tue, Feb 19, 2008 at 10:14:53PM +0900, FUJITA Tomonori wrote: I see that two drivers have very different objectives but if we add use_thread option to scsi_debug (we can do easily), it seems that scsi_debug can provide all the features that scsi_ram does. It's not just use_thread. It's

Re: SCSI RAM driver

2008-02-19 Thread FUJITA Tomonori
On Tue, 19 Feb 2008 06:31:20 -0700 Matthew Wilcox [EMAIL PROTECTED] wrote: On Tue, Feb 19, 2008 at 10:14:53PM +0900, FUJITA Tomonori wrote: I see that two drivers have very different objectives but if we add use_thread option to scsi_debug (we can do easily), it seems that scsi_debug can

RE: [PATCH 1/1] cciss: procfs updates to display info about many volumes

2008-02-19 Thread Miller, Mike (OS Dev)
-Original Message- From: Andrew Morton [mailto:[EMAIL PROTECTED] Sent: Tuesday, February 19, 2008 6:00 AM To: Jens Axboe Cc: Miller, Mike (OS Dev); LKML; LKML-scsi Subject: Re: [PATCH 1/1] cciss: procfs updates to display info about many volumes On Tue, 19 Feb 2008 11:48:18

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-19 Thread James Bottomley
On Tue, 2008-02-19 at 17:02 +0900, FUJITA Tomonori wrote: ips did scsi_add_host(sh, NULL) so scsi_dma_map uses shost_gendev.parent that isn't initialized properly, then the kernel crashes. 2.6.23 and 2.6.24 have this bug. We can fix this by calling scsi_add_host with pdev-dev, in the

[PATCH 1/2] libsas: Provide a transport-level facility to request SAS addrs

2008-02-19 Thread Darrick J. Wong
Provide a facility to use the request_firmware() interface to get a SAS address from userspace. This can be used by SAS LLDDs that cannot obtain the address from the host adapter. Resend of 8 Oct. 2007 patch, now based off 2.6.25-rc2 + scsi_misc. Signed-off-by: Darrick J. Wong [EMAIL PROTECTED]

[PATCH] aic94xx: Don't free ABORT_TASK SCBs that are timed out (Was: Re: aic94xx: failing on high load)

2008-02-19 Thread Darrick J. Wong
If we send an ABORT_TASK ascb that doesn't return within the timeout period, we should not free that ascb because the sequencer is still holding onto it. Hopefully it will fix what James Bottomley describes below: On Tue, Feb 19, 2008 at 10:22:20AM -0600, James Bottomley wrote: Unfortunately,

Re: [PATCH] enclosure: add support for enclosure services

2008-02-19 Thread Pavel Machek
On Wed 2008-02-13 09:45:02, Kristen Carlson Accardi wrote: On Tue, 12 Feb 2008 13:28:15 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-02-12 at 11:07 -0800, Kristen Carlson Accardi wrote: I understand what you are trying to do - I guess I just doubt the value you've added

[PATCH 2/2] aic94xx: Use sas_request_addr() to provide SAS WWN if the adapter lacks one

2008-02-19 Thread Darrick J. Wong
If the aic94xx chip doesn't have a SAS address in the chip's flash memory, make libsas get one for us. Resend of 8 Oct 2007 patch, now based off 2.6.25-rc2 + scsi_misc. Signed-off-by: Darrick J. Wong [EMAIL PROTECTED] --- drivers/scsi/aic94xx/aic94xx.h | 16

Re: [PATCH] aic94xx: Don't free ABORT_TASK SCBs that are timed out (Was: Re: aic94xx: failing on high load)

2008-02-19 Thread James Bottomley
On Tue, 2008-02-19 at 10:44 -0800, Darrick J. Wong wrote: If we send an ABORT_TASK ascb that doesn't return within the timeout period, we should not free that ascb because the sequencer is still holding onto it. Hopefully it will fix what James Bottomley describes below: On Tue, Feb 19, 2008

[2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-19 Thread Adrian Bunk
This patch removes dead code spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/scsi/qla4xxx/ql4_isr.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) --- linux-2.6/drivers/scsi/qla4xxx/ql4_isr.c.old2008-02-19

Re: [PATCH 1/2] libsas: Provide a transport-level facility to request SAS addrs

2008-02-19 Thread Jeff Garzik
Darrick J. Wong wrote: Provide a facility to use the request_firmware() interface to get a SAS address from userspace. This can be used by SAS LLDDs that cannot obtain the address from the host adapter. Resend of 8 Oct. 2007 patch, now based off 2.6.25-rc2 + scsi_misc. Signed-off-by: Darrick

Re: ips.c broken since 2.6.23 on x86_64?

2008-02-19 Thread FUJITA Tomonori
On Tue, 19 Feb 2008 10:06:39 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-02-19 at 17:02 +0900, FUJITA Tomonori wrote: ips did scsi_add_host(sh, NULL) so scsi_dma_map uses shost_gendev.parent that isn't initialized properly, then the kernel crashes. 2.6.23 and 2.6.24 have

Re: USB regression (and other failures) in 2.6.2[45]* - mostly resolved

2008-02-19 Thread Andrew Buehler
On 2/16/2008 10:35 PM, Alan Stern wrote: On Sat, 16 Feb 2008, Andrew Buehler wrote: Until this thread, I was not even aware that ACPI was related to USB; I had largely conflated it with a similar acronym which I think is related to power management and which I can suddenly not even find in

Re: arcmsr + archttp64 calls dma_free_coherent() with irqs disabled - dmesg filled with warnings

2008-02-19 Thread Joshua Hoblitt
I have a test machine running: 0001-arcmsr-fix-message-allocation.patch arcmsr-pci-alloc-consistent.patch 2.6.24-gentoo-r2 The arcmsr driver is loaded and archttp64 is running. I've been access archttp64 and there are no warnings in dmesg. Without the patches this would have generated 10s of

Re: no INQUIRY from userspace please

2008-02-19 Thread Douglas Gilbert
Stefan Richter wrote: James Bottomley wrote: It's all very well to say this, but I think if you look at what udev does, you'll find that it uses scsi_id to send a VPD inquiry to the device so it can populate /dev/disk/by-id, so the point is already conceded PS: Alas we don't have a

[Bug 10050] New: message/fusion/mptbase.c: fix use-after-free's

2008-02-19 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=10050 Summary: message/fusion/mptbase.c: fix use-after-free's Product: SCSI Drivers Version: 2.5 KernelVersion: 2.6.25-rc2-git Platform: All OS/Version: Linux Tree: Mainline

[Fwd: [2.6 patch] message/fusion/mptbase.c: fix use-after-free's]

2008-02-19 Thread James Bottomley
Forwarded Message From: Adrian Bunk [EMAIL PROTECTED] To: Sathya Prakash [EMAIL PROTECTED], James Bottomley [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Subject: [2.6 patch] message/fusion/mptbase.c: fix use-after-free's Date: Wed, 20 Feb 2008 02:39:43 +0200 This patch fixes two

Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-19 Thread James Bottomley
On Tue, 2008-02-19 at 21:29 +0200, Adrian Bunk wrote: This patch removes dead code spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/scsi/qla4xxx/ql4_isr.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) ---

Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-19 Thread Andrew Vasquez
On Tue, 19 Feb 2008, James Bottomley wrote: On Tue, 2008-02-19 at 21:29 +0200, Adrian Bunk wrote: This patch removes dead code spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/scsi/qla4xxx/ql4_isr.c | 18 +- 1 file

Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

2008-02-19 Thread James Bottomley
On Tue, 2008-02-19 at 18:35 -0800, Andrew Vasquez wrote: On Tue, 19 Feb 2008, James Bottomley wrote: On Tue, 2008-02-19 at 21:29 +0200, Adrian Bunk wrote: This patch removes dead code spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] ---

Re: + mpt-fusion-dont-oops-if-numphys==0.patch added to -mm tree

2008-02-19 Thread Krzysztof Oledzki
On Tue, 19 Feb 2008, James Bottomley wrote: On Tue, 2008-02-19 at 15:34 -0800, [EMAIL PROTECTED] wrote: Subject: mpt fusion: don't oops if NumPhys==0 From: Krzysztof Oledzki [EMAIL PROTECTED] Don't oops if NumPhys==0, instead return -ENODEV. This patch fixes

Re: + mpt-fusion-dont-oops-if-numphys==0.patch added to -mm tree

2008-02-19 Thread James Bottomley
On Wed, 2008-02-20 at 04:17 +0100, Maximilian Wilhelm wrote: Am Wednesday, den 20 February hub Krzysztof Oledzki folgendes in die Tasten: What's the topology this thing is connected to? It is a Dell-1950III server with two 400GB SAS disks (RAID1) installed in a dwo disk SAS backplane.

Re: aic94xx: failing on high load (another data point)

2008-02-19 Thread James Bottomley
On Tue, 2008-02-19 at 10:22 -0600, James Bottomley wrote: I'll see if I can come up with patches to fix this ... or at least mitigate the problems it causes. Darrick's working on the ascb sequencer use after free problem. I looked into some of the error handling in libsas, and apparently

Re: + mpt-fusion-dont-oops-if-numphys==0.patch added to -mm tree

2008-02-19 Thread Maximilian Wilhelm
Am Wednesday, den 20 February hub Krzysztof Oledzki folgendes in die Tasten: Hi Krzysztof, * Thanks for CC'ing me. On Tue, 2008-02-19 at 15:34 -0800, [EMAIL PROTECTED] wrote: Subject: mpt fusion: don't oops if NumPhys==0 From: Krzysztof Oledzki [EMAIL PROTECTED] Don't oops if NumPhys==0,

Re: Integration of SCST in the mainstream Linux kernel

2008-02-19 Thread Erez Zilber
Bart Van Assche wrote: On Feb 18, 2008 10:43 AM, Erez Zilber [EMAIL PROTECTED] wrote: If you use a high value for FirstBurstLength, all (or most) of your data will be sent as unsolicited data-out PDUs. These PDUs don't use the RDMA engine, so you miss the advantage of IB. Hello