Re: [PATCH v4 4/7] scsi: sr: block events when runtime suspended

Hello, Not sure if I should use EXPORT_SYMBOL or EXPORT_SYMBOL_GPL, any comments? Thanks, Aaron On 07/27/2012 05:00 PM, Aaron Lu wrote: When the ODD is runtime suspended, there is no need to poll it for events, so block events poll for it and unblock when resumed. Signed-off-by: Aaron Lu

Re: [PATCH 4/4] scsi: translate errors for power management

On Thursday 02 August 2012 11:43:44 James Bottomley wrote: this should be inside the switch as default: return -EIO; and no return statment outside of the switch. OK Don't you still want to handle BUSY and QUEUE_FULL as -EBUSY? Right at the moment they'll fall through the

Handle errors during transitions to sleep states in sd

During transition to sleep sd can encounter errors. They must be translated to a form the generic layer understands, so that it knows whether an error can be ignored (eg. medium removal) should be retried (eg. BUSY) or the transition must be aborted. -- To unsubscribe from this list: send the

[PATCH 1/5] sd: SCSI error codes must not be returned to generic code

sd_start_stop_device leaks SCSI specific error codes to the generic driver code Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/scsi/sd.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 4df73e5..cef06f5 100644 ---

[PATCH 3/5] sd: deal with removal of medium to be synched

sd_sync_cache() is called for purposes of power management. Under those circumstances a medium removal is no error. The data is lost under any circumstances, so the system may as well sleep. Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/scsi/sd.c |8 1 files changed, 8

[PATCH 5/5] scsi: more error conditions for power management

BUSY and QUEUE_FULL are retryable errors. Signed-off-by: Oliver Neukum oneu...@suse.de --- drivers/scsi/scsi_error.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index 195cc75..2f70a07 100644 ---

Re: [PATCH v4 4/7] scsi: sr: block events when runtime suspended

On 08/03/2012 05:50 AM, Aaron Lu wrote: Hello, Not sure if I should use EXPORT_SYMBOL or EXPORT_SYMBOL_GPL, any comments? Typically you follow the pattern of similar exports in the file (or in the API, if no others are in the file). Jeff -- To unsubscribe from this list: send

[PATCH 00/21] lpfc 8.3.33: Update lpfc to revision 8.3.33

This patch set updates the lpfc driver to revision 8.3.33 The patches for 8.3.33 contain: - When doing loopback testing, set the diag valid bit - Enable attachment to OCe14000 adapters - Fix bug with rrq_pool not being destroyed during driver removal. - Fix error of not reiniting mbx cmd before

[PATCH 01/21] lpfc 8.3.33: When doing loopback testing, set the diag valid bit

When doing loopback testing, set the diag valid bit Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_bsg.c |2 ++ lpfc_hw4.h |5 + 2 files changed, 7 insertions(+) diff -upNr a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c ---

[PATCH 03/21] lpfc 8.3.33: Fix bug with rrq_pool not being destroyed during driver removal.

Fix bug with rrq_pool not being destroyed during driver removal. Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_mem.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_mem.c b/drivers/scsi/lpfc/lpfc_mem.c ---

[PATCH 05/21] lpfc 8.3.33: Check data transfer amount on write commands

Check data transfer amount on write commands Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_scsi.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c --- a/drivers/scsi/lpfc/lpfc_scsi.c

[PATCH 06/21] lpfc 8.3.33: Fix scsi_eh escalation panic by checking the proper return status

Fix scsi_eh escalation panic by checking the proper return status Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_scsi.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c ---

[PATCH 08/21] lpfc 8.3.33: Add debugfs interface to display SLI queue information

Add debugfs interface to display SLI queue information Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_debugfs.h |3 +++ lpfc_sli.c | 35 ++- lpfc_sli4.h| 29 + 3 files changed, 66 insertions(+), 1

[PATCH 09/21] lpfc 8.3.33: Convert to no SCSI host lock in queuecommand

Convert to no SCSI host lock in queuecommand Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_scsi.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c --- a/drivers/scsi/lpfc/lpfc_scsi.c

[PATCH 10/21] lpfc 8.3.33: Formally separate lpfc_sli_ring SLI-3 and SLI-4 variantions

Formally separate lpfc_sli_ring SLI-3 and SLI-4 variantions Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_debugfs.c |8 +- lpfc_init.c|6 - lpfc_mbox.c| 25 --- lpfc_sli.c | 182 - lpfc_sli.h

[PATCH 11/21] lpfc 8.3.33: Misc changes to optimize critical path

Misc changes to optimize critical path Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_scsi.c | 22 -- lpfc_sli.c | 21 + 2 files changed, 29 insertions(+), 14 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_scsi.c

[PATCH 12/21] lpfc 8.3.33: Parallelize SLI-4 Q distribution

Commonize SLI-3/4 Ring/Queue framework, to keep SLI-3 compatibility Parallelize SLI-4 Q distribution - to use multiple posting/completion queues Signed-off-by: James Smart james.sm...@emulex.com --- lpfc.h |2 +- lpfc_hw.h | 14 +++--- lpfc_init.c | 35

[PATCH 13/21] lpfc 8.3.33: Add Interrupts per second stats via debugfs

Add Interrupts per second stats via debugfs Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_sli.c | 18 +- lpfc_sli.h |2 ++ 2 files changed, 19 insertions(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c ---

[PATCH 15/21] lpfc 8.3.33: Allow per-hba interrupt rate tuning

Allow per-hba interrupt rate tuning Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_attr.c | 27 --- lpfc_hw4.h |8 +--- lpfc_init.c |2 +- lpfc_sli.c |3 ++- 4 files changed, 28 insertions(+), 12 deletions(-) diff -upNr

[PATCH 16/21] lpfc 8.3.33: Change Naming convention for SLI4 Interrupt vector

Change Naming convention for SLI4 Interrupt vector Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_init.c|6 +- lpfc_sli4.h|3 +++ lpfc_version.h |5 + 3 files changed, 13 insertions(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_init.c

[PATCH 18/21] lpfc 8.3.33: Add lpfc_fcp_look_ahead module parameter

Add lpfc_fcp_look_ahead module parameter Signed-off-by: James Smart james.sm...@emulex.com --- lpfc.h |2 + lpfc_attr.c | 11 +++ lpfc_crtn.h |1 lpfc_init.c |3 ++ lpfc_sli.c | 88 +--- lpfc_sli4.h |1 6

[PATCH 19/21] lpfc 8.3.33: Fixed debugfs queInfo to include queue stats

Fixed debugfs queInfo to include queue stats Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_debugfs.c | 420 +++-- 1 file changed, 261 insertions(+), 159 deletions(-) diff -upNr a/drivers/scsi/lpfc/lpfc_debugfs.c

[PATCH 20/21] lpfc 8.3.33: Fixed incomplete list of SLI4 commands with extended timeout value

Fixed incomplete list of SLI4 commands with extended second timeout value Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_hw.h |1 + lpfc_hw4.h |6 ++ lpfc_mbox.c | 11 ++- lpfc_sli.c |1 + 4 files changed, 18 insertions(+), 1 deletion(-) diff -upNr

[PATCH 21/21] lpfc 8.3.33: Update lpfc version for 8.3.33 driver release

Update lpfc version for 8.3.33 driver release Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_version.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -upNr a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h ---

[PATCH 02/21] lpfc 8.3.33: Enable attachment to OCe14000 adapters

Enable attachment to OCe14000 adapters Signed-off-by: James Smart james.sm...@emulex.com --- lpfc_hw.h |2 ++ lpfc_init.c |9 + 2 files changed, 11 insertions(+) diff -upNr a/drivers/scsi/lpfc/lpfc_hw.h b/drivers/scsi/lpfc/lpfc_hw.h --- a/drivers/scsi/lpfc/lpfc_hw.h

Re: [PATCH v2] tmscsim: spin_unlock_irq in interrupt handler fix

On Tue, 31 Jul 2012, Denis Efremov wrote: The replacement of spin_lock_irq/spin_unlock_irq pairs which can be called from interrupt handler by irqsave/irqrestore versions. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Denis Efremov yefremov.de...@gmail.com

[PATCH V1] scsi/mvsas: Fix oops when ata commond timeout.

Kernel message follows: [ 511.712011] sd 11:0:0:0: [sdf] command 8800a4e81400 timed out [ 511.712022] sas: Enter sas_scsi_recover_host busy: 1 failed: 1 [ 511.712024] sas: trying to find task 0x8800a4d24c80 [ 511.712026] sas: sas_scsi_find_task: aborting task 0x8800a4d24c80 [