[PATCH 1/5] virtio-scsi: remove the useless assignment

2012-11-07 Thread Wanlong Gao
Reassign err is not needed, just a cleanup. Cc: James E.J. Bottomley jbottom...@parallels.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Rusty Russell ru...@rustcorp.com.au Cc: linux-scsi@vger.kernel.org Cc: k...@vger.kernel.org Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com ---

[PATCH 5/5] virtio-scsi: tidy up the goto label in init()

2012-11-07 Thread Wanlong Gao
Tidy up the goto label in init(), and remove the useless NULL pointer assignment. Cc: James E.J. Bottomley jbottom...@parallels.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Rusty Russell ru...@rustcorp.com.au Cc: linux-scsi@vger.kernel.org Cc: k...@vger.kernel.org Signed-off-by: Wanlong Gao

[PATCH 4/5] virtio-scsi: create a separate work queue for virtio-scsi

2012-11-07 Thread Wanlong Gao
Create a separate work queue for virtio-scsi to improve the performance. Cc: James E.J. Bottomley jbottom...@parallels.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Rusty Russell ru...@rustcorp.com.au Cc: linux-scsi@vger.kernel.org Cc: k...@vger.kernel.org Signed-off-by: Wanlong Gao

[PATCH 2/5] virtio-scsi: remove the needless variable gfp_mask

2012-11-07 Thread Wanlong Gao
Just use the macro instead of define a variable. Cc: James E.J. Bottomley jbottom...@parallels.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Rusty Russell ru...@rustcorp.com.au Cc: linux-scsi@vger.kernel.org Cc: k...@vger.kernel.org Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com ---

[PATCH 3/5] virtio-scsi: use pr_err instead of printk

2012-11-07 Thread Wanlong Gao
Use pr_err() instead of printk() for code cleanups. Cc: James E.J. Bottomley jbottom...@parallels.com Cc: Paolo Bonzini pbonz...@redhat.com Cc: Rusty Russell ru...@rustcorp.com.au Cc: linux-scsi@vger.kernel.org Cc: k...@vger.kernel.org Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com ---

[PATCH 0/5] virtio-scsi: create a separate workqueue

2012-11-07 Thread Wanlong Gao
patch 1-3,5 are some cleanups. patch 4: create a separate work queue for virtio-scsi to improve the performance, I tested with tmpfs backed disk, the config file is like below, [global] bsrange=4k-64k ioengine=libaio direct=1 iodepth=4 loops=10 size=64M Before: Disk stats (read/write): sda:

[PATCH] [SCSI] scsi_sysfs: fix a buffer overflow in sysfs handling

2012-11-07 Thread Nikolay Aleksandrov
Fix a stack buffer overflow in the SCSI layer sysfs handling code (store_host_reset()). When a host reset type is read via sscanf in str there is no limit on the length and str is defined as char str[10]. How to reproduce: Given that the sysfs entry exists, execute echo

Re: [PATCH 0/5] virtio-scsi: create a separate workqueue

2012-11-07 Thread Asias He
On Wed, Nov 7, 2012 at 6:18 PM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: patch 1-3,5 are some cleanups. patch 4: create a separate work queue for virtio-scsi to improve the performance, I tested with tmpfs backed disk, the config file is like below, [global] bsrange=4k-64k

Re: [PATCH 0/5] virtio-scsi: create a separate workqueue

2012-11-07 Thread Wanlong Gao
On 11/07/2012 08:23 PM, Asias He wrote: On Wed, Nov 7, 2012 at 6:18 PM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: patch 1-3,5 are some cleanups. patch 4: create a separate work queue for virtio-scsi to improve the performance, I tested with tmpfs backed disk, the config file is like below,

scsi target, likely GPL violation

2012-11-07 Thread Andy Grover
Nick, Your company appears to be shipping kernel features in RTS OS that are not made available under the GPL, specifically support for the EXTENDED_COPY and COMPARE_AND_WRITE SCSI commands, in order to claim full Vmware vSphere 5 VAAI support. http://www.risingtidesystems.com/storage.html

Re: [PATCH 0/5] virtio-scsi: create a separate workqueue

2012-11-07 Thread Paolo Bonzini
patch 1-3,5 are some cleanups. patch 4: create a separate work queue for virtio-scsi to improve the performance, I tested with tmpfs backed disk, the config file is like below, I think something else caused the improvement, because the code you touched (complete_event) shouldn't ever run

Re: [PATCH 0/5] virtio-scsi: create a separate workqueue

2012-11-07 Thread Wanlong Gao
On 11/08/2012 06:12 AM, Paolo Bonzini wrote: patch 1-3,5 are some cleanups. patch 4: create a separate work queue for virtio-scsi to improve the performance, I tested with tmpfs backed disk, the config file is like below, I think something else caused the improvement, because the code you

Re: scsi target, likely GPL violation

2012-11-07 Thread Jon Mason
On Wed, Nov 7, 2012 at 9:50 AM, Andy Grover agro...@redhat.com wrote: Nick, Your company appears to be shipping kernel features in RTS OS that are not made available under the GPL, specifically support for the EXTENDED_COPY and COMPARE_AND_WRITE SCSI commands, in order to claim full Vmware

Re: scsi target, likely GPL violation

2012-11-07 Thread Chris Friesen
On 11/07/2012 07:02 PM, Jon Mason wrote: I'm not a lawyer, nor do I play one on TV, but if I understand the GPL correctly, RTS only needs to provide the relevant source to their customers upon request. Not quite. Assuming the GPL applies, and that they have modified the code, then they must