Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status

2012-11-20 Thread Aaron Lu
On 11/20/2012 02:00 PM, Aaron Lu wrote: On 11/19/2012 10:56 PM, Tejun Heo wrote: I really think we need a way for (auto)pm and event polling to talk to each other so that autopm can tell event poll to sod off while pm is in effect. Trying to solve this from inside libata doesn't seem right.

be_main.c:273 always evaluates to 'false'

2012-11-20 Thread Hannes Reinecke
Hi Jayamohan, drivers/scsi/be2iscsi/be_main.c:273 has this statement: if (abrt_task-sc-device-lun != abrt_task-sc-device-lun) continue; which is pointless at best, and actually harmful at worst as it probably should compare with the scmd as passed to beiscsi_eh_device_reset(struct

SCSI LLDs, the SCSI error handler and host resource lifetime

2012-11-20 Thread Bart Van Assche
Hello, If I interpret the SCSI error handler source code correctly then scsi_unjam_host() may proceed concurrently with scsi_remove_host(). This means that the LLD eh_abort_handler callback may get invoked after scsi_remove_host() finished. At least the SRP initiator (ib_srp) cleans up resources

[Bug 15171] smartd crashing recent 2.6.32 kernel

2012-11-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=15171 Alan a...@lxorguk.ukuu.org.uk changed: What|Removed |Added Status|REOPENED|RESOLVED

Re: [PATCH 0/7] Add support for new IBM SAS controllers

2012-11-20 Thread Brian King
On 11/19/2012 03:36 PM, wenxi...@linux.vnet.ibm.com wrote: Hi all, The new generation IBM SAS controllers will support MSI-X interrupt and Distributed Completion Processing features. The patches in this series add the code to support these new hardware features and also add some patches for

Re: [PATCH RESEND v4 0/5] Migrate SCSI drivers to use dev_pm_ops

2012-11-20 Thread Rafael J. Wysocki
Hi James, On Friday, November 09, 2012 03:27:50 PM Aaron Lu wrote: This patchset has been quiet for a while, so resend them. v4: Only Patch 4 is modified: Fixed a line over 80 characters warning by checkpatch.pl; Update the changelog so that it is no more a try :-) v3: Only patch 4 is

Re: SCSI LLDs, the SCSI error handler and host resource lifetime

2012-11-20 Thread Hannes Reinecke
On 11/20/2012 03:24 PM, Bart Van Assche wrote: Hello, If I interpret the SCSI error handler source code correctly then scsi_unjam_host() may proceed concurrently with scsi_remove_host(). This means that the LLD eh_abort_handler callback may get invoked after scsi_remove_host() finished. At

[PATCH 3/5] qla2xxx: Change in setting UNLOADING flag and FC vports logout sequence while unloading qla2xxx driver.

2012-11-20 Thread Saurav Kashyap
From: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_attr.c |3 +-- drivers/scsi/qla2xxx/qla_os.c |3 +-- 2 files changed, 2 insertions(+),

[PATCH 4/5] qla2xxx: Free rsp_data even on error in qla2x00_process_loopback()

2012-11-20 Thread Saurav Kashyap
From: Steve Hodgson st...@purestorage.com Signed-off-by: Steve Hodgson st...@purestorage.com Signed-off-by: Armen Baloyan armen.balo...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_bsg.c |7 --- 1 files changed, 4 insertions(+), 3

[PATCH 2/5] qla2xxx: Test and clear FCPORT_UPDATE_NEEDED atomically.

2012-11-20 Thread Saurav Kashyap
From: David Jeffery djeff...@redhat.com When the qla2xxx driver loses access to multiple, remote ports, there is a race condition which can occur which will keep the request stuck on a scsi request queue indefinitely. This bad state occurred do to a race condition with how the

[PATCH 0/5] qla2xxx: Patches for 3.7-rc.

2012-11-20 Thread Saurav Kashyap
Hi James, Please apply the following patches for 3.7-rc. Thanks, ~Saurav Armen Baloyan (1): qla2xxx: Properly set result field of bsg_job reply structure for success and failure. David Jeffery (1): qla2xxx: Test and clear FCPORT_UPDATE_NEEDED atomically. Giridhar Malavali (1):

[PATCH 1/5] qla2xxx: Properly set result field of bsg_job reply structure for success and failure.

2012-11-20 Thread Saurav Kashyap
From: Armen Baloyan armen.balo...@qlogic.com FC transport on receiving bsg_job submission failure, calls bsg_job-job_done() and sets the bsg_job-reply-result the returned value. In contrast, when the success code (0) is returned fc transport doesn't call bsg_job-job_done() and doesn't populate

[PATCH 00/19] qla2xxx: Patches for scsi misc branch.

2012-11-20 Thread Saurav Kashyap
From: Saurav Kashyap saurav.kash...@qlogic.com Hi James, Please apply the following patches to the scsi tree at your earliest convenience for inclusion in the next mainline merge window. Thanks, ~Saurav Andrew Vasquez (2): qla2xxx: Clear unsupported 'states' during Get-FW-State queries.

[PATCH 01/19] qla2xxx: Clear unsupported 'states' during Get-FW-State queries.

2012-11-20 Thread Saurav Kashyap
From: Andrew Vasquez andrew.vasq...@qlogic.com Rather than returning stale mailbox values. Signed-off-by: Andrew Vasquez andrew.vasq...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_init.c |1 + 1 files changed, 1 insertions(+), 0

[PATCH 03/19] qla2xxx: Honor status value of 2 for report-id acquisition.

2012-11-20 Thread Saurav Kashyap
The value of 2 is informational message and it means that port id has changed. The driver should honor the value and continue its normal course. Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com ---

[PATCH 13/19] qla2xxx: Move marking fcport online ahead of setting iiDMA speed.

2012-11-20 Thread Saurav Kashyap
From: Joe Carnuccio joe.carnuc...@qlogic.com Signed-off-by: Joe Carnuccio joe.carnuc...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_init.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c

[PATCH 14/19] qla2xxx: Add 16Gb/s case to get port speed capability.

2012-11-20 Thread Saurav Kashyap
From: Joe Carnuccio joe.carnuc...@qlogic.com Signed-off-by: Joe Carnuccio joe.carnuc...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_gs.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_gs.c

[PATCH 15/19] qla2xxx: Parameterize the link speed of hba rather than fcport.

2012-11-20 Thread Saurav Kashyap
From: Joe Carnuccio joe.carnuc...@qlogic.com Parameterize qla2x00_get_link_speed_str() to be generic on link speed. Signed-off-by: Joe Carnuccio joe.carnuc...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_gbl.h |2 +-

[PATCH 17/19] qla2xxx: Fix typo in qla2xxx driver.

2012-11-20 Thread Saurav Kashyap
From: Masanari Iida standby2...@gmail.com Signed-off-by: Masanari Iida standby2...@gmail.com Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_isr.c |4 ++-- drivers/scsi/qla2xxx/qla_nx.c |4

[PATCH 19/19] qla2xxx: Display that driver is operating in legacy interrupt mode.

2012-11-20 Thread Saurav Kashyap
Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_dbg.c |2 +- drivers/scsi/qla2xxx/qla_isr.c |4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 11/19] qla2xxx: Ignore driver ack bit if corresponding presence bit is not set.

2012-11-20 Thread Saurav Kashyap
Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_os.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index

[PATCH 16/19] qla2xxx: Update ql2xextended_error_logging parameter description with new option.

2012-11-20 Thread Saurav Kashyap
From: Chad Dupuis chad.dup...@qlogic.com Update the parameter description for the ql2xextended_error_logging parameter with the following new option: 0x8000 - Verbose output 0x4000 - Target mode 0x2000 - Target mode management 0x1000 - Target mode task management Signed-off-by:

[PATCH 02/19] qla2xxx: Remove spurious taking of ha-vport_slock spinlock.

2012-11-20 Thread Saurav Kashyap
From: Chad Dupuis chad.dup...@qlogic.com Signed-off-by: Chad Dupuis chad.dup...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_init.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c

[PATCH 18/19] qla2xxx: Dont clear drv active on iospace config failure.

2012-11-20 Thread Saurav Kashyap
Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_nx.c |2 -- drivers/scsi/qla2xxx/qla_os.c |8 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git

[PATCH 10/19] qla2xxx: Fix typo in qla83xx_fw_dump function.

2012-11-20 Thread Saurav Kashyap
Signed-off-by: Chad Dupuis chad.dup...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_dbg.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c index

[PATCH 09/19] qla2xxx: Add Gen3 PCIe speed 8GT/s to the log message.

2012-11-20 Thread Saurav Kashyap
Signed-off-by: Chad Dupuis chad.dup...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_os.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index

[PATCH 06/19] qla2xxx: Fix coccinelle warnings in qla2x00_relogin.

2012-11-20 Thread Saurav Kashyap
Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_os.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH 05/19] qla2xxx: No fcport FC-4 type assignment in GA_NXT response.

2012-11-20 Thread Saurav Kashyap
From: Armen Baloyan armen.balo...@qlogic.com Signed-off-by: Armen Baloyan armen.balo...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_gs.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_gs.c

[PATCH 07/19] qla2xxx: Move noisy Start scsi failed messages to verbose logging level.

2012-11-20 Thread Saurav Kashyap
From: Chad Dupuis chad.dup...@qlogic.com This message can fill up the system logs and is not a common occurrence so move it to the verbose logging level. Signed-off-by: Chad Dupuis chad.dup...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_os.c |

[PATCH 08/19] qla2xxx: Use correct Request-Q-Out register during bidirectional request processing

2012-11-20 Thread Saurav Kashyap
From: Andrew Vasquez andrew.vasq...@qlogic.com Original code was not corrected for ISP83xx support. Instead code should used the cached reference from the req_que structure, rather than the legacy 'if (ISP-TYPE(X))... else if (ISP-TYPE(Y))...' codes. Signed-off-by: Andrew Vasquez

[PATCH 04/19] qla2xxx: Fix for warnings reported by sparse.

2012-11-20 Thread Saurav Kashyap
Signed-off-by: Giridhar Malavali giridhar.malav...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_dbg.c|4 +- drivers/scsi/qla2xxx/qla_def.h|4 +- drivers/scsi/qla2xxx/qla_gbl.h|1 - drivers/scsi/qla2xxx/qla_init.c | 62