Re: [PATCH V5 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2013-01-06 Thread Sujit Reddy Thumma
Hi Vinayak, I have few comments below: +#ifdef CONFIG_PM +/** + * ufshcd_pltfrm_suspend - suspend power management function + * @pdev: pointer to Platform device handle + * @mesg: power state + * + * Returns -ENOSYS What breaks if you return 0 instead of retu

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

2013-01-06 Thread Rusty Russell
Paolo Bonzini writes: > Il 02/01/2013 06:03, Rusty Russell ha scritto: >> Paolo Bonzini writes: >>> The virtqueue_add_buf function has two limitations: >>> >>> 1) it requires the caller to provide all the buffers in a single call; >>> >>> 2) it does not support chained scatterlists: the buffers m

Re: [PATCH v11 9/9] libata: do not suspend port if normal ODD is attached

2013-01-06 Thread Aaron Lu
Hi Sergei, Thanks for reviewing, will update in next revision. -Aaron On 01/06/2013 10:34 PM, Sergei Shtylyov wrote: > Hello. > > On 06-01-2013 6:48, Aaron Lu wrote: > >> For ODDs, the upper layer will poll for media change every a few >> seconds, which will make it enter and leave suspend sta

Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

2013-01-06 Thread Rusty Russell
Wanlong Gao writes: > On 01/02/2013 01:03 PM, Rusty Russell wrote: >> Paolo Bonzini writes: >>> The virtqueue_add_buf function has two limitations: >>> >>> 1) it requires the caller to provide all the buffers in a single call; >>> >>> 2) it does not support chained scatterlists: the buffers must

Re: [PATCH V5 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2013-01-06 Thread Subhash Jadavani
On 1/4/2013 1:07 PM, vinayak holikatti wrote: On Thu, Dec 27, 2012 at 8:28 PM, Subhash Jadavani wrote: On 12/27/2012 1:45 AM, vinholika...@gmail.com wrote: From: Vinayak Holikatti This patch adds Platform glue driver for ufshcd. Reviewed-by: Arnd Bergmann Reviewed-by: Namjae Jeon Signed-o

Re: [PATCH V5 1/4] [SCSI] drivers/scsi/ufs: Seggregate PCI Specific Code

2013-01-06 Thread Subhash Jadavani
On 1/4/2013 12:30 PM, vinayak holikatti wrote: On Thu, Dec 27, 2012 at 7:59 PM, Subhash Jadavani wrote: Few comments inline: On 12/27/2012 1:45 AM, vinholika...@gmail.com wrote: From: Vinayak Holikatti This patch seggregates the PCI specific code in ufshcd.c to make it ready for splitting i

Re: [PATCH v11 9/9] libata: do not suspend port if normal ODD is attached

2013-01-06 Thread Sergei Shtylyov
Hello. On 06-01-2013 6:48, Aaron Lu wrote: For ODDs, the upper layer will poll for media change every a few seconds, which will make it enter and leave suspend state very oftern. And as each suspend will also cause a hard/soft reset, s/oftern/often/ the gain of runtime suspend is very li

[PATCH v6 3/4] block: implement runtime pm strategy

2013-01-06 Thread Aaron Lu
From: Lin Ming When a request is added: If device is suspended or is suspending and the request is not a PM request, resume the device. When the last request finishes: Call pm_runtime_mark_last_busy() and pm_runtime_autosuspend(). When pick a request: If device is resuming/suspe

[PATCH v6 1/4] block: add a flag to identify PM request

2013-01-06 Thread Aaron Lu
From: Lin Ming Add a flag REQ_PM to identify the request is PM related. As an example, modify scsi code to use this flag. Signed-off-by: Lin Ming Signed-off-by: Aaron Lu --- drivers/scsi/scsi_lib.c| 9 - drivers/scsi/sd.c | 9 + include/linux/blk_types.h | 2 +

[PATCH v6 2/4] block: add runtime pm helpers

2013-01-06 Thread Aaron Lu
From: Lin Ming Add runtime pm helper functions: void blk_pm_runtime_init(struct request_queue *q, struct device *dev) - Initialization function for drivers to call. int blk_pre_runtime_suspend(struct request_queue *q) - If any requests are in the queue, return -EBUSY. Otherwise set q->r

[PATCH v6 0/4] block layer runtime pm

2013-01-06 Thread Aaron Lu
In August 2010, Jens and Alan discussed about "Runtime PM and the block layer". http://marc.info/?t=12825910841&r=1&w=2 And then Alan has given a detailed implementation guide: http://marc.info/?l=linux-scsi&m=133727953625963&w=2 To test: # ls -l /sys/block/sda /sys/devices/pci:00/:00:

[PATCH v6 4/4] sd: change to auto suspend mode

2013-01-06 Thread Aaron Lu
From: Lin Ming Uses block layer runtime pm helper functions in scsi_runtime_suspend/resume. Remove scsi_autopm_* from sd open/release path and check_events path. And remove the quiesce call in runtime suspend path, as we know there is no request to quiesce for the device. [aaron...@intel.com: Do