RE: [patch] [SCSI] bfa: fix strncpy() limiter in bfad_start_ops()

2013-01-11 Thread Anil Gurumurthy
-Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Dan Carpenter Sent: Thursday, January 10, 2013 2:36 PM To: Anil Gurumurthy Cc: Vijay Mohan Guvva; James E.J. Bottomley; linux-scsi@vger.kernel.org;

Re: [PATCH V5 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2013-01-11 Thread Sujit Reddy Thumma
On 1/9/2013 5:41 PM, vinayak holikatti wrote: On Mon, Jan 7, 2013 at 1:11 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: Hi Vinayak, I have few comments below: +#ifdef CONFIG_PM +/** + * ufshcd_pltfrm_suspend - suspend power management function + * @pdev: pointer to Platform device

Re: [PATCH V5 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2013-01-11 Thread Subhash Jadavani
On 1/11/2013 4:11 PM, Sujit Reddy Thumma wrote: On 1/9/2013 5:41 PM, vinayak holikatti wrote: On Mon, Jan 7, 2013 at 1:11 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: Hi Vinayak, I have few comments below: +#ifdef CONFIG_PM +/** + * ufshcd_pltfrm_suspend - suspend power management

Re: linux-next: build failure after merge of the scsi tree

2013-01-11 Thread Brian King
It looks like this was a due to the fact that the new patches added __devinit tags in the same merge window the __devinit tag itself was getting removed. As to the sparse warnings, this patch fixed the ones that were actual bugs in the new code, although we could have made that more clear in the

Re: linux-next: build failure after merge of the scsi tree

2013-01-11 Thread James Bottomley
On Fri, 2013-01-11 at 09:27 -0600, Brian King wrote: It looks like this was a due to the fact that the new patches added __devinit tags in the same merge window the __devinit tag itself was getting removed. Not exactly. The patch which makes them nops went into 3.8. Now there's a patch

Re: linux-next: build failure after merge of the scsi tree

2013-01-11 Thread Greg KH
On Fri, Jan 11, 2013 at 03:37:17PM +, James Bottomley wrote: On Fri, 2013-01-11 at 09:27 -0600, Brian King wrote: It looks like this was a due to the fact that the new patches added __devinit tags in the same merge window the __devinit tag itself was getting removed. Not exactly.

[PATCH v1 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors

2013-01-11 Thread Subhash Jadavani
blk_rq_map_sg() function merges the physically contiguous pages to use same scatter-gather node without checking if their page descriptors are contiguous or not. Now when dma_map_sg() is called on the scatter gather list, it would take the base page pointer from each node (one by one) and

Re: linux-next: build failure after merge of the scsi tree

2013-01-11 Thread Brian King
On 01/11/2013 10:05 AM, Greg KH wrote: On Fri, Jan 11, 2013 at 03:37:17PM +, James Bottomley wrote: On Fri, 2013-01-11 at 09:27 -0600, Brian King wrote: It looks like this was a due to the fact that the new patches added __devinit tags in the same merge window the __devinit tag itself was

Re: linux-next: build failure after merge of the scsi tree

2013-01-11 Thread James Bottomley
On Fri, 2013-01-11 at 11:35 -0600, Brian King wrote: On 01/11/2013 10:05 AM, Greg KH wrote: On Fri, Jan 11, 2013 at 03:37:17PM +, James Bottomley wrote: On Fri, 2013-01-11 at 09:27 -0600, Brian King wrote: It looks like this was a due to the fact that the new patches added __devinit

Re: [PATCH v12 7/9] libata: scsi: no poll when ODD is powered off

2013-01-11 Thread Tejun Heo
Hello, On Fri, Jan 11, 2013 at 11:16:26AM +0800, Aaron Lu wrote: OK, will make it atomic in next version, thanks for the advice. Perhaps I can add two scsi helper functions in scsi_lib.c like: void sdev_disable_disk_events(struct scsi_device *sdev) {

[PATCH] cxgb4i: Remove the scsi host device when removing device

2013-01-11 Thread Thadeu Lima de Souza Cascardo
When doing a hotplug remove of a cxgb4 device, there are still dandling symlinks at /sys/class/scsi_host/hostX to the removed PCI device. The upper layer device may also try to send data, which may crash the system. The DETACH message from the lower level driver is sent to the ULD when the device

[PATCH 1/8] V2 ipr: Add sereral new CCIN definitions for new adapters support

2013-01-11 Thread wenxiong
Add the appropriate definitions and table entries for new adapter support. Signed-off-by: Wen Xiong wenxi...@linux.vnet.ibm.com --- drivers/scsi/ipr.c | 10 ++ drivers/scsi/ipr.h |5 + 2 files changed, 15 insertions(+) Index: b/drivers/scsi/ipr.c

[PATCH 0/8] V2 Add support for new IBM SAS controllers

2013-01-11 Thread wenxiong
This is version 2 of ipr patches to support new IBM SAS controllers. In V2, we have fixed the following suggestions/warning/sparse errors: 1.Changed simple_strtoul() to kstrtoul() in ipr_restore_iopoll_weight routine. 2.Removed the __dev annotations. 3.Fixed unlock bugs which are caused by my

[PATCH 2/8] V2 ipr: Handler ID memory allocation failure

2013-01-11 Thread wenxiong
From: Brian King brk...@linux.vnet.ibm.com Add code to handle memory allocation failures at module load time. Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Wen Xiong wenxi...@linux.vnet.ibm.com --- drivers/scsi/ipr.c |7

[PATCH 8/8] V2 ipr: Fix sparse error in ipr driver

2013-01-11 Thread wenxiong
This patch fixes the following sparse error: CHECK drivers/scsi/ipr.c spinlock.h:147:9: warning: context imbalance in 'ipr_reset_reload' - unexpected unlock Signed-off-by: Wen Xiong wenxi...@linux.vnet.ibm.com --- drivers/scsi/ipr.c | 69

[PATCH 6/8] V2 ipr: Implement block iopoll

2013-01-11 Thread wenxiong
This patch implements blk iopoll in ipr driver for performance improvement. Signed-off-by: Wen Xiong wenxi...@linux.vnet.ibm.com --- drivers/scsi/ipr.c | 221 + drivers/scsi/ipr.h |6 + 2 files changed, 178 insertions(+), 49 deletions(-)

[PATCH 7/8] V2 ipr: Driver version 2.6.0

2013-01-11 Thread wenxiong
Bump driver version. Signed-off-by: Wen Xiong wenxi...@linux.vnet.ibm.com --- drivers/scsi/ipr.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/scsi/ipr.h === --- a/drivers/scsi/ipr.h

[PATCH 5/8] V2 ipr: Reduce lock contention

2013-01-11 Thread wenxiong
This patch reduces lock contention while implementing distributed completion processing. Signed-off-by: Wen Xiong wenxi...@linux.vnet.ibm.com --- drivers/scsi/ipr.c | 323 + drivers/scsi/ipr.h | 21 +-- 2 files changed, 240 insertions(+),

[PATCH 3/8] V2 ipr: Resource path error logging cleanup

2013-01-11 Thread wenxiong
From: Brian King brk...@linux.vnet.ibm.com The resource path as displayed by the ipr driver is the location string identifying a location on the SAS fabric. This patch adds the SCSI host number such that error logs can be more easily correlated in multiple adapter configurations. Signed-off-by:

[PATCH 4/8] V2 ipr: Add support for MSI-X and distributed completion

2013-01-11 Thread wenxiong
The new generation IBM SAS Controllers will support MSI-X interrupts and Distributed Completion Processing features. This patch add these support in ipr device driver. Signed-off-by: Wen Xiong wenxi...@linux.vnet.ibm.com --- drivers/scsi/ipr.c | 718

Re: [PATCH 6/8] V2 ipr: Implement block iopoll

2013-01-11 Thread Asias He
Hello Wen Xiong, On Sat, Jan 12, 2013 at 7:43 AM, wenxi...@linux.vnet.ibm.com wrote: This patch implements blk iopoll in ipr driver for performance improvement. Can you provide the performance numbers with/without the io polling? It would be interesting to know. Signed-off-by: Wen Xiong

Re: linux-next: build failure after merge of the scsi tree

2013-01-11 Thread wenxiong
Quoting James Bottomley james.bottom...@hansenpartnership.com: On Fri, 2013-01-11 at 11:35 -0600, Brian King wrote: On 01/11/2013 10:05 AM, Greg KH wrote: On Fri, Jan 11, 2013 at 03:37:17PM +, James Bottomley wrote: On Fri, 2013-01-11 at 09:27 -0600, Brian King wrote: It looks like