Re: [PATCH V4 0/5] virtio-scsi multiqueue

2013-03-18 Thread Asias He
On Mon, Mar 11, 2013 at 10:43:57AM +0800, Wanlong Gao wrote: > This series implements virtio-scsi queue steering, which gives > performance improvements of up to 50% (measured both with QEMU and > tcm_vhost backends). > > This version rebased on Rusty's virtio ring rework patches. > We hope this c

Re: [PATCH V4 1/5] virtio-scsi: redo allocation of target data

2013-03-18 Thread Asias He
On Mon, Mar 11, 2013 at 10:43:58AM +0800, Wanlong Gao wrote: > From: Paolo Bonzini > > virtio_scsi_target_state is now empty, but we will find new uses > for it in the next few patches. However, dropping the sglist lets > us turn the array-of-pointers into a simple array, which simplifies > the

Re: [PATCH] scsi_transport_fc: Make 'port_state' writeable

2013-03-18 Thread Jeremy Linton
On 3/15/2013 8:28 AM, Bryn M. Reeves wrote: > On 03/15/2013 12:46 PM, Bart Van Assche wrote: >> The SCSI EH keeps trying until all outstanding request have been >> finished. Does lpfc_host_reset_handler() invoke scsi_done() for > > I don't think so (ends up calling lpfc_sli_cancel_iocbs() via >

Re: [PATCH -next] target: fix possible memory leak in core_tpg_register()

2013-03-18 Thread Nicholas A. Bellinger
On Fri, 2013-03-15 at 17:19 +0800, Wei Yongjun wrote: > From: Wei Yongjun > > 'se_tpg->tpg_lun_list' is malloced in core_tpg_register() and should be freed > before leaving from the error handling cases, otherwise it will cause memory > leak. > 'se_tpg' is malloced out of this function, and will

Re: [PATCH] tcm_fc: using kfree_rcu() to simplify the code

2013-03-18 Thread Nicholas A. Bellinger
Hi Wei, On Mon, 2013-03-11 at 21:48 +0800, Wei Yongjun wrote: > From: Wei Yongjun > > The callback function of call_rcu() just calls a kfree(), so we > can use kfree_rcu() instead of call_rcu() + callback function. > > Signed-off-by: Wei Yongjun > --- Apologies for the delay. Applied to targ

Re: [PATCH -next] [SCSI] lpfc 8.3.36: fix potential NULL pointer dereference in lpfc_sli4_rq_put()

2013-03-18 Thread James Smart
James, Can you please merge this fix into scsi git for merging into 3.9 ? -- james s On 12/6/2012 10:46 AM, James Smart wrote: Acked-By: James Smart Thanks -- james s On 12/2/2012 8:33 AM, Wei Yongjun wrote: From: Wei Yongjun The dereference to 'put_index' should be moved below the

Re: [PATCH][RFC] scsi: Use W_LUN for scanning

2013-03-18 Thread Hannes Reinecke
On 03/15/2013 04:54 PM, Steffen Maier wrote: While we're at it: I recently figured that there are targets responding to inquiry with PQ=1 && PDT=31 for LUN0 if LUN0 has no backing device (e.g. no disk mapped for the initiator host). While this is likely to work with in-kernel lun scanning, the ke

Possible reentrancy issue in be_iopoll

2013-03-18 Thread Shlomo Pongratz
Hi Jayamohan. I think that there is a reentrancy issue in "drivers/scsi/be2iscsi/be_main.c::be_iopoll". The driver creates "NAPI" context per core which is fine, however the above routine declares the ret variable as static! Thus there is only one instance of this variable, so if this routine i

Re: [PATCH 1/1] aacraid: Dual firmware image support

2013-03-18 Thread Tomas Henzl
On 03/18/2013 05:58 AM, Mahesh Rajashekhara wrote: > This patch adds dual flash firmware support for Series 7 and above > controllers. > > Signed-off-by: Mahesh Rajashekhara > --- > drivers/scsi/aacraid/aacraid.h |6 +- > drivers/scsi/aacraid/comminit.c |2 +- > drivers/scsi/aacraid

Re: [PATCH] [SCSI]: print the msgbytes and statusbyte from scsi result

2013-03-18 Thread Namjae Jeon
2013/3/18, James Bottomley : > On Sun, 2013-03-17 at 17:29 +0900, Namjae Jeon wrote: >> From: Namjae Jeon >> >> Introduce msgbyte and statusbyte in the prints as part of the >> result which is returned by the lower layer driver in response to >> SCSI command issued, in case of any error conditions

[Bug 53281] megaraid_mbox kernel panic during boot

2013-03-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=53281 justgivemeafkenaccount...@yahoo.co.uk changed: What|Removed |Added CC||justgivemeafkenacc

[PATCH 1/1] aacraid: Dual firmware image support

2013-03-18 Thread Mahesh Rajashekhara
This patch adds dual flash firmware support for Series 7 and above controllers. Signed-off-by: Mahesh Rajashekhara --- drivers/scsi/aacraid/aacraid.h |6 +- drivers/scsi/aacraid/comminit.c |2 +- drivers/scsi/aacraid/src.c | 31 ++- 3 files changed

Re: [PATCH] [SCSI]: print the msgbytes and statusbyte from scsi result

2013-03-18 Thread James Bottomley
On Sun, 2013-03-17 at 17:29 +0900, Namjae Jeon wrote: > From: Namjae Jeon > > Introduce msgbyte and statusbyte in the prints as part of the > result which is returned by the lower layer driver in response to > SCSI command issued, in case of any error conditions. > > Purpose of adding these prin

Re: [PATCH] scsi_transport_fc: Make 'port_state' writeable

2013-03-18 Thread Hannes Reinecke
On 03/15/2013 08:13 PM, Bart Van Assche wrote: On 03/15/13 19:51, Mike Christie wrote: On 03/15/2013 08:41 AM, Bart Van Assche wrote: How about using the value of scsi_cmnd.jiffies_at_alloc to finish only those SCSI commands in the host reset handler that exceeded a certain processing time ?