Re: [PATCH 04/24] drivers/scsi/initio: Convert to module_pci_driver

2013-05-27 Thread James Bottomley
On Mon, 2013-05-27 at 10:28 +0800, Libo Chen wrote: use module_pci_driver instead of init/exit, make code clean. For the ancient drivers, like this, the principal is that we really don't touch except for tested bug fixes. For the current ones (like mvumi) it's up to the maintainer. James --

Re: [PATCH 04/24] drivers/scsi/initio: Convert to module_pci_driver

2013-05-27 Thread Libo Chen
On 2013/5/27 14:38, James Bottomley wrote: On Mon, 2013-05-27 at 10:28 +0800, Libo Chen wrote: use module_pci_driver instead of init/exit, make code clean. For the ancient drivers, like this, the principal is that we really don't touch except for tested bug fixes. For the current ones (like

MAINTAINERS: Fix tape driver file mappings

2013-05-27 Thread Jean Delvare
The masks for the st and osst tape drivers in MAINTAINERS are too broad and include unrelated files. Make the file list accurate so that maintainers of these drivers aren't bothered with unrelated work. Signed-off-by: Jean Delvare jdelv...@suse.de Cc: Willem Riede o...@riede.org Cc: Kai Mäkisara

Re: [PATCH 1/2] SCSI: nsp32: replace large udelay by mdelay

2013-05-27 Thread Marc Dietrich
James, Am Mittwoch, 22. Mai 2013, 22:33:18 schrieb Marc Dietrich: Looks like Arnd already send a fix for this. Sorry for the noise. are you going to pick up Arnd's patch [1] for scsi-stable (3.10) branch? Marc [1] https://patchwork.kernel.org/patch/2489251/ Am Mittwoch, 22. Mai 2013,

Re: [PATCH] ufshcd-pltfrm: add missing empty slot in ufs_of_match[]

2013-05-27 Thread Santosh Y
On Sun, May 26, 2013 at 4:54 PM, Akinobu Mita m...@fixstars.com wrote: of_match_table member in struct device_driver must be terminated by empty slot as a sentinel. Signed-off-by: Akinobu Mita m...@fixstars.com Cc: Vinayak Holikatti vinholika...@gmail.com Cc: Santosh Y santos...@gmail.com

[RFC PATCH 3/4] block: add back command filter modification via sysfs

2013-05-27 Thread Paolo Bonzini
This adds two new sysfs attributes to the queue kobject. The attributes allow reading and writing the whitelist of unprivileged commands. This is again a bit different from what was removed in commit 018e044 (block: get rid of queue-private command filter, 2009-06-26), but the idea is the same.

[RFC PATCH 1/4] block: add back queue-private command filter

2013-05-27 Thread Paolo Bonzini
The command filter used to be mutable via sysfs, but this was broken and backed out. Let's add it back. This patch adds the infrastructure for filtering, but unlike the old code this one just adds a pointer to request_queue, so as to make it cheaper in the majority of cases where no special

[RFC PATCH 2/4] scsi: create an all-zero filter for scanners

2013-05-27 Thread Paolo Bonzini
Using /dev/sg for scanners is blocked from unprivileged users. Reimplement this using customizable command filters, so that the sysfs knobs will work in this case too. Cc: linux-scsi@vger.kernel.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- drivers/scsi/scsi_scan.c | 8 +++-

Re: SCSI error handling -- one error blocks the whole SCSI host

2013-05-27 Thread Hannes Reinecke
On 05/27/2013 12:44 AM, James Bottomley wrote: On Thu, 2013-05-23 at 11:14 -0700, Roland Dreier wrote: At LSF this year, we had a discussion about error handling and in particular the problem that SCSI midlayer error handling waits for the entire SCSI host (HBA) to quiesce before it starts

Re: [PATCH v5 1/2] block,scsi: verify return pointer from blk_get_request

2013-05-27 Thread Jiri Kosina
On Fri, 24 May 2013, Joe Lawrence wrote: From 22307be1bc6e404622b1f074094902e385a1bd30 Mon Sep 17 00:00:00 2001 From: Joe Lawrence joe.lawre...@stratus.com Date: Fri, 24 May 2013 12:39:04 -0400 Subject: [PATCH v5 1/2] block,scsi: verify return pointer from blk_get_request The blk-core dead

Re: [PATCH v5 2/2] block,scsi: convert and handle ERR_PTR from blk_get_request

2013-05-27 Thread Jiri Kosina
On Fri, 24 May 2013, Joe Lawrence wrote: From 5b26d593807b30f60ed41f6fd5a16a56c3c9a43c Mon Sep 17 00:00:00 2001 From: Joe Lawrence joe.lawre...@stratus.com Date: Fri, 24 May 2013 13:05:09 -0400 Subject: [PATCH v5 2/2] block,scsi: convert and handle ERR_PTR from blk_get_request The

[RFC PATCH 0/4] SG_IO filtering via sysfs and minimal whitelist

2013-05-27 Thread Paolo Bonzini
On Wed, 12 Sep 2012 09:05:41 +0100, James Bottomley wrote: This is why the whole filter thing was mutable via sysfs. That way the admin could set this up per device. It sounds like this is what you want to fix, rather than opening up more holes in an already leaky security apparatus. The

[RFC PATCH 4/4] scsi: lock out SG_IO by default to unprivileged users

2013-05-27 Thread Paolo Bonzini
Move policy on SG_IO access to userspace. Some level of checking at the kernel level (compared to just having an opt-out for the default whitelist) is needed because any userspace whitelist is too easily circumvented by doing ptrace on the program that has a file descriptor open. This would be a

[PATCH] [SCSI] sd: Fix parsing of 'temporary ' cache mode prefix

2013-05-27 Thread Ben Hutchings
Commit 39c60a0948cc '[SCSI] sd: fix array cache flushing bug causing performance problems' added temp as a pointer to temporary and used sizeof(temp) - 1 as its length. But sizeof(temp) is the size of the pointer, not the size of the string constant. Change temp to a static array so that

Re: SCSI error handling -- one error blocks the whole SCSI host

2013-05-27 Thread James Bottomley
On Mon, 2013-05-27 at 16:39 +0200, Hannes Reinecke wrote: On 05/27/2013 12:44 AM, James Bottomley wrote: On Thu, 2013-05-23 at 11:14 -0700, Roland Dreier wrote: At LSF this year, we had a discussion about error handling and in particular the problem that SCSI midlayer error handling

Re: SCSI error handling -- one error blocks the whole SCSI host

2013-05-27 Thread Baruch Even
On Mon, May 27, 2013 at 11:41 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Mon, 2013-05-27 at 16:39 +0200, Hannes Reinecke wrote: - LLDDs typically won't return a command status even for a command which has been aborted via ABORT TASK TMF. So the midlayer probably