Re: [PATCH 1/9] target: Add transport_cmd_check_stop write_pending bit

2013-06-08 Thread Christoph Hellwig
On Sat, Jun 08, 2013 at 12:00:36AM -0400, Jörn Engel wrote: -static int transport_cmd_check_stop(struct se_cmd *cmd, bool remove_from_lists) +static int transport_cmd_check_stop(struct se_cmd *cmd, bool remove_from_lists, + bool write_pending) ... -

Re: [PATCH 4/9] target: Avoid extra t_state_lock access in __target_execute_cmd

2013-06-08 Thread Christoph Hellwig
On Fri, Jun 07, 2013 at 09:34:19PM +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch makes target_execute_cmd() set CMD_T_BUSY|CMD_T_SENT while holding se_cmd-t_state_lock, in order to avoid the extra aquire/release in __target_execute_cmd(). Can

Re: [PATCH 0/10] qla2xxx: Reduce the number of Coverity warnings

2013-06-08 Thread Bart Van Assche
On 06/07/13 21:06, Saurav Kashyap wrote: Thanks for the patches. Please share the warnings reported by Coverity, so that its easy for us to review the patches. Hello Saurav, The Coverity warnings that led me to developing this patch series are as follows: - For patches 1, 2, 3, 8: Logically

Re: [PATCH 1/3] lib/scatterlist: introduce sg_pcopy_from_buffer() and sg_pcopy_to_buffer()

2013-06-08 Thread Akinobu Mita
2013/6/6 Imre Deak imre.d...@intel.com: Looks ok to me, perhaps adding the seek functionality to the mapping iterator would make things more generic and the mapping iterator more resemble the page iterator. So we'd have a new sg_miter_start_offset and call it here something like:

Re: [PATCH 1/3] lib/scatterlist: introduce sg_pcopy_from_buffer() and sg_pcopy_to_buffer()

2013-06-08 Thread Akinobu Mita
2013/6/7 Tejun Heo t...@kernel.org: Hello, On Thu, Jun 06, 2013 at 09:52:56PM +0900, Akinobu Mita wrote: +static bool sg_miter_get_next_page(struct sg_mapping_iter *miter) +{ + if (!miter-__remaining) { + struct scatterlist *sg; + unsigned long pgoffset; + +

Re: [PATCH v3 0/6] scsi_debug: bug fixes and cleanups for data integrity support

2013-06-08 Thread Akinobu Mita
2013/6/7 Martin K. Petersen martin.peter...@oracle.com: Akinobu == Akinobu Mita akinobu.m...@gmail.com writes: Akinobu So Martin and Douglas, can I have your ACKs on this patch Akinobu series for now? Only concern is the one I mentioned before: You're mapping and unmapping the ppage for

Re: [PATCH 1/3] Percpu tag allocator

2013-06-08 Thread Oleg Nesterov
On 06/08, Nicholas A. Bellinger wrote: +unsigned tag_alloc(struct tag_pool *pool, bool wait) +{ + struct tag_cpu_freelist *tags; + unsigned long flags; + unsigned ret; +retry: + preempt_disable(); + local_irq_save(flags); + tags = this_cpu_ptr(pool-tag_cpu); + +