Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-29 Thread Oliver Neukum
On Fri, 2013-07-26 at 09:54 -0700, Andy Lutomirski wrote: This is kernel 3.9.9-302.fc19.x86_64. I plugged in a BN Nook (a usb mass storage device), used it, and ejected it. This makes suspend fail: [50135.265514] PM: Entering freeze sleep [50135.265517] Suspending console(s) (use

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-29 Thread Oliver Neukum
On Fri, 2013-07-26 at 16:31 -0400, Alan Stern wrote: In addition to my earlier comment, the patch below should be applied. It will fix your immediate problem, although not in the best way. Alan, I think your diagnosis is correct, but not the fix. This is run even in the runtime case. We

Re: [PATCH 1/7] scsi: ufs: amend the ocs handling with fatal error

2013-07-29 Thread Subhash Jadavani
On 7/26/2013 7:15 PM, Seungwon Jeon wrote: Fatal error in OCS(overall command status) field indicates error conditions which is not covered by UFSHCI. It means that host cannot define the result of command status and therefore host may need to check transfer response UPIU's response and status

Re: [PATCH 2/7] scsi: ufs: find out sense data over scsi status values

2013-07-29 Thread Subhash Jadavani
On 7/26/2013 7:16 PM, Seungwon Jeon wrote: Except for 'GOOD' and 'CHECK CONDITION', other status value This is what UFS device spec says: A GOOD status indicates successful SCSI completion and therefore no Sense Data will be returned. So please change the commit text accordingly. in Response

Re: [PATCH 3/7] scsi: ufs: fix the setting interrupt aggregation counter

2013-07-29 Thread Subhash Jadavani
On 7/26/2013 7:16 PM, Seungwon Jeon wrote: LACTH(Interrupt aggregation counter threshold) value is allowed I guess you mean IACTH not LACTH. Other than this, change looks good to me. Reviewed-by: Subhash Jadavani subha...@codeaurora.org up to 0x1F and current setting value is the maximum.

Re: Kernel 3.10.3 reset SuperSpeed USB device number 2 using xhci_hcd

2013-07-29 Thread Stuart Foster
On 07/28/13 20:28, Alan Stern wrote: On Sat, 27 Jul 2013, Stuart Foster wrote: On 07/27/13 20:34, Alan Stern wrote: On Sat, 27 Jul 2013, Stuart Foster wrote: On 07/27/13 15:58, Alan Stern wrote: On Sat, 27 Jul 2013, Stuart Foster wrote: Hi, I have started having problems with an

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-29 Thread Hannes Reinecke
On 07/26/2013 04:09 AM, Jens Axboe wrote: On Thu, Jul 25 2013, Nicholas A. Bellinger wrote: On Thu, 2013-07-25 at 12:16 +0200, Alexander Gordeev wrote: On Mon, Jul 22, 2013 at 02:10:36PM -0700, Nicholas A. Bellinger wrote: Np. FYI, you'll want to use the latest commit e7827b351 HEAD from

Re: [PATCH 4/7] scsi: ufs: add dme configuration primitives

2013-07-29 Thread Subhash Jadavani
On 7/26/2013 7:17 PM, Seungwon Jeon wrote: Implements to support GET and SET operations of the DME. These operations are used to configure the behavior of the UNIPRO. Along with basic operation, {Peer/AttrSetType} can be mixed. Signed-off-by: Seungwon Jeon tgih@samsung.com ---

Re: [PATCH 5/7] scsi: ufs: add unipro attribute IDs

2013-07-29 Thread Subhash Jadavani
Looks good to me. Reviewed-by: Subhash Jadavani subha...@codeaurora.org On 7/26/2013 7:18 PM, Seungwon Jeon wrote: 'drivers/scsi/ufs/unipro.h' is added. Attributes in the layers of the UNIPRO stack can be read and written via the DME. Signed-off-by: Seungwon Jeon tgih@samsung.com ---

Re: [PATCH V3 4/4] scsi: ufs: Improve UFS fatal error handling

2013-07-29 Thread Sujit Reddy Thumma
On 7/24/2013 7:09 PM, Seungwon Jeon wrote: On Wed, July 24, 2013, Sujit Reddy Thumma wrote: On 7/23/2013 2:04 PM, Seungwon Jeon wrote: On Sat, July 20, 2013, Sujit Reddy Thumma wrote: On 7/19/2013 7:28 PM, Seungwon Jeon wrote: On Tue, July 09, 2013, Sujit Reddy Thumma wrote: Error handling

Re: [PATCH V3 3/4] scsi: ufs: Fix device and host reset methods

2013-07-29 Thread Sujit Reddy Thumma
On 7/24/2013 7:09 PM, Seungwon Jeon wrote: On Wed, July 24, 2013, Sujit Reddy Thumma wrote: On 7/23/2013 1:57 PM, Seungwon Jeon wrote: On Sat, July 20, 2013, Sujit Reddy Thumma wrote: On 7/19/2013 7:27 PM, Seungwon Jeon wrote: On Tue, July 09, 2013, Sujit Reddy Thumma wrote: As of now SCSI

Re: [PATCH 6/7] scsi: ufs: add operation for the uic power mode change

2013-07-29 Thread Subhash Jadavani
Change looks good except few minor comments. On 7/26/2013 7:18 PM, Seungwon Jeon wrote: Setting PA_PWRMode using DME_SET triggers the power mode change. And then the result will be given by the HCS.UPMCRS. This operation should be done atomically. Signed-off-by: Seungwon Jeon

RE: [PATCH 1/7] scsi: ufs: amend the ocs handling with fatal error

2013-07-29 Thread Seungwon Jeon
On Mon, July 29, 2013, Subhash Jadavani wrote: On 7/26/2013 7:15 PM, Seungwon Jeon wrote: Fatal error in OCS(overall command status) field indicates error conditions which is not covered by UFSHCI. It means that host cannot define the result of command status and therefore host may need

[SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-29 Thread Nick Alcock
My server's ARC-1210 has been working fine for years, but when I upgraded from 3.10.1, it started failing: Instead of [0.784044] Areca RAID Controller0: F/W V1.46 2009-01-06 Model ARC-1210 [0.804028] scsi0 : Areca SATA Host Adapter RAID Controller Driver Version 1.20.00.15 2010/08/05

Re: [PATCH 1/7] scsi: ufs: amend the ocs handling with fatal error

2013-07-29 Thread Subhash Jadavani
On 7/29/2013 3:35 PM, Seungwon Jeon wrote: On Mon, July 29, 2013, Subhash Jadavani wrote: On 7/26/2013 7:15 PM, Seungwon Jeon wrote: Fatal error in OCS(overall command status) field indicates error conditions which is not covered by UFSHCI. It means that host cannot define the result of

Re: [PATCH 2/7] scsi: ufs: find out sense data over scsi status values

2013-07-29 Thread Sujit Reddy Thumma
On 7/26/2013 7:16 PM, Seungwon Jeon wrote: Except for 'GOOD' and 'CHECK CONDITION', other status value in Response UPIU may or may contain sense data. If a non-zero value is in the Data Segment Length field, it means that UPIU has Sense Data in the Data Segment area. Signed-off-by: Seungwon

Re: [PATCH 1/7] scsi: ufs: amend the ocs handling with fatal error

2013-07-29 Thread Sujit Reddy Thumma
On 7/29/2013 11:47 AM, Subhash Jadavani wrote: On 7/26/2013 7:15 PM, Seungwon Jeon wrote: Fatal error in OCS(overall command status) field indicates error conditions which is not covered by UFSHCI. It means that host cannot define the result of command status and therefore host may need to

Re: [PATCH 1/4] scsi_debug: fix endianness bug in sdebug_build_parts()

2013-07-29 Thread Martin Peschke
On Sat, 2013-07-27 at 02:07 +0900, Akinobu Mita wrote: 2013/7/26 Martin Peschke mpesc...@linux.vnet.ibm.com: On Mon, 2013-07-15 at 20:52 +0900, Akinobu Mita wrote: With module parameter num_parts 0, partition table is built on the ramdisk storage when loading the driver. Unfortunately,

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-29 Thread Alexander Gordeev
On Fri, Jul 26, 2013 at 05:43:13PM -0700, Nicholas A. Bellinger wrote: On Fri, 2013-07-26 at 14:14 -0700, Nicholas A. Bellinger wrote: On Thu, 2013-07-25 at 20:09 -0600, Jens Axboe wrote: On Thu, Jul 25 2013, Nicholas A. Bellinger wrote: On Thu, 2013-07-25 at 12:16 +0200, Alexander

Re: [RFC/RFT PATCH 0/5] mm: ARM nobootmem and few dma_mask fixes

2013-07-29 Thread Russell King - ARM Linux
On Fri, Jul 26, 2013 at 12:28:26PM -0400, Santosh Shilimkar wrote: On Friday 26 July 2013 11:10 AM, Russell King - ARM Linux wrote: On Fri, Jul 12, 2013 at 05:48:09PM -0400, Santosh Shilimkar wrote: The series is an attempt to move ARM port to NO_BOOTMEM. As discussed on list NO_BOOTMEM

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-07-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 Sreekanth Reddy sreekanth.re...@lsi.com changed: What|Removed |Added CC|

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-29 Thread Tejun Heo
Hello, On Fri, Jul 26, 2013 at 02:14:36PM -0700, Nicholas A. Bellinger wrote: So I don't think (completely) getting rid of ata_port-qcmds[] will be possible, and just converting the ata_scsi_queuecmd() path to use the extra SHT-cmd_size pre-allocation for *ata_queued_cmd might end up being

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-29 Thread Tejun Heo
Yo, On Fri, Jul 26, 2013 at 05:43:13PM -0700, Nicholas A. Bellinger wrote: Considering there can be more than a single ata_device hanging off each ata_port, the '*sdev = ap-link.device[0].sdev' in __ata_qc_from_tag() is definitely bogus, but I'm not sure how else to correlate blk-mq/scsi-mq

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-29 Thread Bernd Schubert
Hi Nick, On 07/29/2013 12:10 PM, Nick Alcock wrote: My server's ARC-1210 has been working fine for years, but when I upgraded from 3.10.1, it started failing: Instead of [0.784044] Areca RAID Controller0: F/W V1.46 2009-01-06 Model ARC-1210 [0.804028] scsi0 : Areca SATA Host Adapter

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-29 Thread Nix
On 29 Jul 2013, Bernd Schubert said: Hi Nick, On 07/29/2013 12:10 PM, Nick Alcock wrote: arcmsr0: abort device command of scsi id = 0 lun = 1 arcmsr0: abort device command of scsi id = 0 lun = 0 arcmsr: executing bus reset eh.num_resets=0, num_[...] arcmsr0: wait 'abort all

Re: [RFC/RFT PATCH 0/5] mm: ARM nobootmem and few dma_mask fixes

2013-07-29 Thread Santosh Shilimkar
On Monday 29 July 2013 07:15 AM, Russell King - ARM Linux wrote: On Fri, Jul 26, 2013 at 12:28:26PM -0400, Santosh Shilimkar wrote: On Friday 26 July 2013 11:10 AM, Russell King - ARM Linux wrote: On Fri, Jul 12, 2013 at 05:48:09PM -0400, Santosh Shilimkar wrote: The series is an attempt to

Re: [RFC/RFT PATCH 0/5] mm: ARM nobootmem and few dma_mask fixes

2013-07-29 Thread Russell King - ARM Linux
On Mon, Jul 29, 2013 at 09:26:44AM -0400, Santosh Shilimkar wrote: On Monday 29 July 2013 07:15 AM, Russell King - ARM Linux wrote: Would you mind putting them all in the patch system, I can add the acks should anyone supply them later, and I'll repost them along with my set of dma-mask

Re: [RFC/RFT PATCH 0/5] mm: ARM nobootmem and few dma_mask fixes

2013-07-29 Thread Santosh Shilimkar
On Monday 29 July 2013 09:40 AM, Russell King - ARM Linux wrote: On Mon, Jul 29, 2013 at 09:26:44AM -0400, Santosh Shilimkar wrote: On Monday 29 July 2013 07:15 AM, Russell King - ARM Linux wrote: Would you mind putting them all in the patch system, I can add the acks should anyone supply them

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-29 Thread Jens Axboe
On 07/29/2013 05:46 AM, Tejun Heo wrote: Hello, On Fri, Jul 26, 2013 at 02:14:36PM -0700, Nicholas A. Bellinger wrote: So I don't think (completely) getting rid of ata_port-qcmds[] will be possible, and just converting the ata_scsi_queuecmd() path to use the extra SHT-cmd_size

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-29 Thread Jens Axboe
On 07/29/2013 05:18 AM, Alexander Gordeev wrote: -static struct ata_queued_cmd *ata_qc_new(struct ata_port *ap) +static struct ata_queued_cmd *ata_qc_new(struct ata_port *ap, +struct scsi_cmnd *sc) { struct ata_queued_cmd *qc = NULL; -

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-07-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #4 from livea...@live.com --- Hi . I'll attach it , however dmesg only shows the last 16000 events . I hope it would be enough . Sorry for being a noob in reporting my first bug , but can you tell me how can I find the exact IO rate

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-07-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #5 from livea...@live.com --- Created attachment 107033 -- https://bugzilla.kernel.org/attachment.cgi?id=107033action=edit dmeg logs 2 -- You are receiving this mail because: You are watching the assignee of the bug. -- To

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-29 Thread Bernd Schubert
On 07/29/2013 03:05 PM, Nix wrote: On 29 Jul 2013, Bernd Schubert said: Hi Nick, On 07/29/2013 12:10 PM, Nick Alcock wrote: arcmsr0: abort device command of scsi id = 0 lun = 1 arcmsr0: abort device command of scsi id = 0 lun = 0 arcmsr: executing bus reset eh.num_resets=0, num_[...]

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-29 Thread Alan Stern
On Mon, 29 Jul 2013, Oliver Neukum wrote: On Fri, 2013-07-26 at 16:31 -0400, Alan Stern wrote: In addition to my earlier comment, the patch below should be applied. It will fix your immediate problem, although not in the best way. Alan, I think your diagnosis is correct, but not

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-29 Thread Martin K. Petersen
Nick == Nick Alcock n...@esperi.org.uk writes: Nick My server's ARC-1210 has been working fine for years, but when I Nick upgraded from 3.10.1, it started failing: Nick [ 0.784044] Areca RAID Controller0: F/W V1.46 2009-01-06 Model Nick ARC-1210 [ 0.804028] scsi0 : Areca SATA Host Adapter RAID

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-29 Thread Martin K. Petersen
Bernd == Bernd Schubert bernd.schub...@fastmail.fm writes: Bernd I tested this patch with ARC-1260 and F/W V1.49, no issues. It could be due to the firmware version discrepancy. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-29 Thread Nix
On 29 Jul 2013, Bernd Schubert spake thusly: On 07/29/2013 03:05 PM, Nix wrote: On 29 Jul 2013, Bernd Schubert said: I tested this patch with ARC-1260 and F/W V1.49, no issues. Also, this patch is only in 3.10.3, but not yet in 3.10.1. ... and I see this problem with 3.10.3 but not 3.10.1.

Re: Kernel 3.10.3 reset SuperSpeed USB device number 2 using xhci_hcd

2013-07-29 Thread Martin K. Petersen
Alan == Alan Stern st...@rowland.harvard.edu writes: Alan, Alan It was introduced by commit 98dcc2946adb (SCSI: sd: Update WRITE Alan SAME heuristics). This commit adds a call to scsi_get_vpd_page() Alan in sd_read_write_same() without first checking Alan sd_try_extended_inquiry(). As noted

Re: Kernel 3.10.3 reset SuperSpeed USB device number 2 using xhci_hcd

2013-07-29 Thread Alan Stern
On Mon, 29 Jul 2013, Martin K. Petersen wrote: Alan == Alan Stern st...@rowland.harvard.edu writes: Alan, Alan It was introduced by commit 98dcc2946adb (SCSI: sd: Update WRITE Alan SAME heuristics). This commit adds a call to scsi_get_vpd_page() Alan in sd_read_write_same() without

Re: Kernel 3.10.3 reset SuperSpeed USB device number 2 using xhci_hcd

2013-07-29 Thread Martin K. Petersen
Alan == Alan Stern st...@rowland.harvard.edu writes: Alan In the case of these bug reports, the scsi_report_opcode() call Alan returns -EINVAL. Oh, right. Because I actually do an explicit SCSI version check in scsi_report_opcode(). That's OK, then... -- Martin K. Petersen Oracle Linux

Re: Kernel 3.10.3 reset SuperSpeed USB device number 2 using xhci_hcd

2013-07-29 Thread Stuart Foster
On 07/29/13 16:23, Alan Stern wrote: On Mon, 29 Jul 2013, Martin K. Petersen wrote: Alan == Alan Stern st...@rowland.harvard.edu writes: Alan, Alan It was introduced by commit 98dcc2946adb (SCSI: sd: Update WRITE Alan SAME heuristics). This commit adds a call to scsi_get_vpd_page() Alan in

Re: [PATCH 1/7] scsi: ufs: amend the ocs handling with fatal error

2013-07-29 Thread Santosh Y
On Fri, Jul 26, 2013 at 7:15 PM, Seungwon Jeon tgih@samsung.com wrote: Fatal error in OCS(overall command status) field indicates error conditions which is not covered by UFSHCI. It means that host cannot define the result of command status and therefore host may need to check transfer

Re: [PATCH 4/9] scsi: ufs: Add runtime PM support for UFS host controller driver

2013-07-29 Thread Sujit Reddy Thumma
On 7/28/2013 10:40 PM, Santosh Y wrote: + /** * ufshcd_pltfrm_probe - probe routine of the driver * @pdev: pointer to Platform device handle @@ -122,14 +157,20 @@ static int ufshcd_pltfrm_probe(struct platform_device *pdev) goto out; } +

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-29 Thread Nicholas A. Bellinger
On Mon, 2013-07-29 at 07:50 -0400, Tejun Heo wrote: Yo, On Fri, Jul 26, 2013 at 05:43:13PM -0700, Nicholas A. Bellinger wrote: Considering there can be more than a single ata_device hanging off each ata_port, the '*sdev = ap-link.device[0].sdev' in __ata_qc_from_tag() is definitely

Re: [PATCH 0/9] scsi:ufs: query, bkops support and other fixes

2013-07-29 Thread Santosh Y
On Sun, Jul 28, 2013 at 10:40 PM, Santosh Y santos...@gmail.com wrote: Hi James, Please apply the following patches to 'misc' branch. Thanks, Santosh Akinobu Mita (3): ufshcd-pci: release ioremapped region during removing driver ufs: don't disable_irq() if the IRQ can be shared among

[PATCH 0/9] scsi:ufs: query, bkops support and other fixes

2013-07-29 Thread Santosh Y
Hi James, Please apply the following patches to 'misc' branch. Thanks, Santosh Akinobu Mita (3): ufshcd-pci: release ioremapped region during removing driver ufs: don't disable_irq() if the IRQ can be shared among devices ufs: don't stop controller before scsi_remove_host() Dolev Raviv

[PATCH 1/9] scsi: ufs: Add support for sending NOP OUT UPIU

2013-07-29 Thread Santosh Y
From: Sujit Reddy Thumma sthu...@codeaurora.org As part of device initialization sequence, sending NOP OUT UPIU and waiting for NOP IN UPIU response is mandatory. This confirms that the device UFS Transport (UTP) layer is functional and the host can configure the device with further commands. Add

[PATCH 2/9] scsi: ufs: Set fDeviceInit flag to initiate device initialization

2013-07-29 Thread Santosh Y
From: Dolev Raviv dra...@codeaurora.org Allow UFS device to complete its initialization and accept SCSI commands by setting fDeviceInit flag. The device may take time for this operation and hence the host should poll until fDeviceInit flag is toggled to zero. This step is mandated by UFS device

[PATCH 3/9] scsi: ufs: Add support for host assisted background operations

2013-07-29 Thread Santosh Y
From: Sujit Reddy Thumma sthu...@codeaurora.org Background operations in the UFS device can be disabled by the host to reduce the response latency of transfer requests. Add support for enabling/disabling the background operations during runtime suspend/resume of the device. If the device is in

[PATCH 5/9] ufshcd-pci: release ioremapped region during removing driver

2013-07-29 Thread Santosh Y
From: Akinobu Mita m...@fixstars.com Before commit 2953f850c3b80bdca004967c83733365d8aa0aa2 ([SCSI] ufs: use devres functions for ufshcd), UFSHCI register was ioremapped by each glue-driver (ufshcd-pltfrm and ufshcd-pci) during probing and it was iounmapped by core-driver during removing driver.

[PATCH 4/9] scsi: ufs: Add runtime PM support for UFS host controller driver

2013-07-29 Thread Santosh Y
From: Sujit Reddy Thumma sthu...@codeaurora.org Add runtime PM helpers to suspend/resume UFS controller at runtime. Enable runtime PM by default for pci and platform drivers as the initialized hardware can suspend if it is not used after bootup. Signed-off-by: Sujit Reddy Thumma

[PATCH 6/9] ufs: don't disable_irq() if the IRQ can be shared among devices

2013-07-29 Thread Santosh Y
From: Akinobu Mita m...@fixstars.com When removing the UFS driver, disable_irq() is called and the IRQ is not enabled again. Unfortunately, the IRQ is requested with IRQF_SHARED and it can be shared among several devices. So disabling the IRQ in this way is just breaking other devices which are

[PATCH 7/9] ufs: don't stop controller before scsi_remove_host()

2013-07-29 Thread Santosh Y
From: Akinobu Mita m...@fixstars.com scsi_remove_host() sends SYNCHRONIZE CACHE commands for write cache enabled scsi disk devices. So stopping controller working shouldn't be done before scsi_remove_host(). Signed-off-by: Akinobu Mita m...@fixstars.com Cc: Vinayak Holikatti

[PATCH 8/9] ufshcd-pltfrm: remove redundant dev_err call in ufshcd_pltfrm_probe()

2013-07-29 Thread Santosh Y
From: Wei Yongjun yongjun_...@trendmicro.com.cn There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Signed-off-by: Santosh Y santos...@gmail.com diff --git

[PATCH 9/9] drivers/scsi/ufs: don't check resource with devm_ioremap_resource

2013-07-29 Thread Santosh Y
From: Wolfram Sang w...@the-dreams.de devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang w...@the-dreams.de Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-29 Thread Nicholas A. Bellinger
On Mon, 2013-07-29 at 13:18 +0200, Alexander Gordeev wrote: On Fri, Jul 26, 2013 at 05:43:13PM -0700, Nicholas A. Bellinger wrote: On Fri, 2013-07-26 at 14:14 -0700, Nicholas A. Bellinger wrote: SNIP I also tried to make a quick conversion and hit the same issue(s) as you. Generally, I am

Re: [PATCH v2 06/10] scsi: ufs: use devres functions for ufshcd

2013-07-29 Thread Santosh Y
On Thu, Jun 27, 2013 at 10:01 AM, Seungwon Jeon tgih@samsung.com wrote: This patch replaces normal calls for resource allocation with devm_*() derivative functions. It makes resource freeing simpler. Signed-off-by: Seungwon Jeon tgih@samsung.com Signed-off-by: Santosh Y

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-29 Thread Nix
On 29 Jul 2013, Bernd Schubert spake thusly: Could you try to run these commands with 3.10.1? # # check if reporting opcodes works # sg_opcodes -v -n /dev/sdX spindle:/boot# sg_opcodes -v -n /dev/sda inquiry cdb: 12 00 00 00 24 00 Report Supported Operation Codes cmd: a3 0c 00 00 00

[Bug 60648] New: csiostor/csio_scsi.c: out of bounds access

2013-07-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60648 Bug ID: 60648 Summary: csiostor/csio_scsi.c: out of bounds access Product: SCSI Drivers Version: 2.5 Kernel Version: 3.11rc2 Hardware: All OS: Linux Tree:

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-29 Thread Martin K. Petersen
Nix == Nix n...@esperi.org.uk writes: Nix spindle:/boot# sg_vpd --page=0x89 /dev/sda ATA information VPD Nix page: fetching VPD page failed Please add -v I'll also need the output of: # sg_vpd -vl Nix I'll try rebooting into a kernel with that commit reverted next. Doesn't matter as far

[Bug 60649] New: mpt3sas/mpt3sas_scsih.c: mem leak on error path

2013-07-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60649 Bug ID: 60649 Summary: mpt3sas/mpt3sas_scsih.c: mem leak on error path Product: SCSI Drivers Version: 2.5 Kernel Version: 3.11rc2 Hardware: All OS: Linux

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-29 Thread Nix
On 29 Jul 2013, Bernd Schubert uttered the following: On 07/29/2013 03:05 PM, Nix wrote: On 29 Jul 2013, Bernd Schubert said: Hi Nick, On 07/29/2013 12:10 PM, Nick Alcock wrote: arcmsr0: abort device command of scsi id = 0 lun = 1 arcmsr0: abort device command of scsi id = 0 lun = 0

Re: sparc ESP SCSI error handling BUG+hang

2013-07-29 Thread David Miller
From: Meelis Roos mr...@linux.ee Date: Sun, 21 Apr 2013 14:02:11 +0300 (EEST) I revived my Sun E3000 after its main disk died, reinstalled Debian and after long apuse I am testing linux kernels again on it. In general it works fine but I left the bad disk connected and sometimes it causes

Re: sparc ESP SCSI error handling BUG+hang

2013-07-29 Thread David Miller
From: David Miller da...@davemloft.net Date: Mon, 29 Jul 2013 15:32:23 -0700 (PDT) Therefore I think the fix is going to involve adding a member to struct esp_cmd_entry called -orig_tag[] so that we can see what the original tag[] values were at esp_alloc_lun_tag() time. Please try this

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-07-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #6 from livea...@live.com --- Hi again . I did monitor the IO of the RAID array using IOstat tool . I'll attach the output . One thing I noticed is that monitoring the raid array made it survive a LOT longer than before . I simply

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-07-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #7 from livea...@live.com --- Created attachment 107038 -- https://bugzilla.kernel.org/attachment.cgi?id=107038action=edit iostat log -- You are receiving this mail because: You are watching the assignee of the bug. -- To

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-29 Thread Martin K. Petersen
Nix == Nix n...@esperi.org.uk writes: Bernd, Nix I can now confirm that reverting this commit causes this problem to Nix go away, and my machine boots fine again. Can you please send me the output of sq_inq with your 1.49 firmware? I made a tweak that allowed Nix to boot but we're trying to

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-29 Thread Douglas Gilbert
On 13-07-29 05:09 PM, Nix wrote: On 29 Jul 2013, Bernd Schubert uttered the following: On 07/29/2013 03:05 PM, Nix wrote: On 29 Jul 2013, Bernd Schubert said: Hi Nick, On 07/29/2013 12:10 PM, Nick Alcock wrote: arcmsr0: abort device command of scsi id = 0 lun = 1 arcmsr0: abort device

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-29 Thread Nix
On 30 Jul 2013, Douglas Gilbert outgrape: Please supply the information that Martin Petersen asked for. Did it in private IRC (the advantage of working for the same division of the same company!) I didn't realise the original fix was actually implemented to allow Bernd, with a different Areca

Re: [PATCH 2/7] scsi: ufs: find out sense data over scsi status values

2013-07-29 Thread Santosh Y
On Fri, Jul 26, 2013 at 7:16 PM, Seungwon Jeon tgih@samsung.com wrote: Except for 'GOOD' and 'CHECK CONDITION', other status value in Response UPIU may or may contain sense data. If a non-zero value is in the Data Segment Length field, it means that UPIU has Sense Data in the Data Segment

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-07-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #8 from Sreekanth Reddy sreekanth.re...@lsi.com --- Hi, Can you please provide me the /var/log/message file as dmesg logs is not enough to analysize this issue. Thanks, Sreekanth -- You are receiving this mail because: You are

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-07-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #9 from livea...@live.com --- Hi . Ok . Journal for this entire day will be attached . It starts at 12:00 AM To save your time , mpt2sas errors start at (03:19:26) mark . Thank you . -- You are receiving this mail because: You

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-07-29 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #10 from livea...@live.com --- Created attachment 107041 -- https://bugzilla.kernel.org/attachment.cgi?id=107041action=edit Journal 1 -- You are receiving this mail because: You are watching the assignee of the bug. -- To

[PATCH V5 1/4] scsi: ufs: Fix broken task management command implementation

2013-07-29 Thread Sujit Reddy Thumma
Currently, sending Task Management (TM) command to the card might be broken in some scenarios as listed below: Problem: If there are more than 8 TM commands the implementation returns error to the caller. Fix: Wait for one of the slots to be emptied and send the command. Problem:

[PATCH V5 3/4] scsi: ufs: Fix device and host reset methods

2013-07-29 Thread Sujit Reddy Thumma
As of now SCSI initiated error handling is broken because, the reset APIs don't try to bring back the device initialized and ready for further transfers. In case of timeouts, the scsi error handler takes care of handling aborts and resets. Improve the error handling in such scenario by resetting

[PATCH V5 0/4] scsi: ufs: Improve UFS error handling

2013-07-29 Thread Sujit Reddy Thumma
The first patch fixes many issues with current task management handling in UFSHCD driver. Others improve error handling in various scenarios. These patches are rebased on: [PATCH 9/9] drivers/scsi/ufs: don't check resource with devm_ioremap_resource Changes from v4: - Addressed comments

[PATCH V5 2/4] scsi: ufs: Fix hardware race conditions while aborting a command

2013-07-29 Thread Sujit Reddy Thumma
There is a possible race condition in the hardware when the abort command is issued to terminate the ongoing SCSI command as described below: - A bit in the door-bell register is set in the controller for a new SCSI command. - In some rare situations, before controller get a chance to issue

[PATCH V5 4/4] scsi: ufs: Improve UFS fatal error handling

2013-07-29 Thread Sujit Reddy Thumma
Error handling in UFS driver is broken and resets the host controller for fatal errors without re-initialization. Correct the fatal error handling sequence according to UFS Host Controller Interface (HCI) v1.1 specification. o Processed requests which are completed w/wo error are reported to