Re: [PATCH RFC 06/77] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-10-03 Thread Alexander Gordeev
On Thu, Oct 03, 2013 at 10:52:54PM +0100, Ben Hutchings wrote: > On Wed, 2013-10-02 at 12:48 +0200, Alexander Gordeev wrote: > > #ifndef CONFIG_PCI_MSI > > +static inline int pci_get_msi_cap(struct pci_dev *dev) > > +{ > > + return -1; > [...] > > Shouldn't this also return -EINVAL? Yep, all i

Re: [PATCH RFC 01/77] PCI/MSI: Fix return value when populate_msi_sysfs() failed

2013-10-03 Thread Jon Mason
On Thu, Oct 03, 2013 at 10:46:21PM +0100, Ben Hutchings wrote: > On Wed, 2013-10-02 at 17:39 -0700, Jon Mason wrote: > > On Wed, Oct 02, 2013 at 12:48:17PM +0200, Alexander Gordeev wrote: > > > Signed-off-by: Alexander Gordeev > > > > Since you are changing the behavior of the msix_capability_ini

Re: Odd behavior of a "SAS-2" backplane with SGPIO commands

2013-10-03 Thread Douglas Gilbert
On 13-10-03 03:11 PM, Pasi Kärkkäinen wrote: On Mon, Sep 02, 2013 at 05:44:35PM +0300, Pasi Kärkkäinen wrote: On Sun, Sep 01, 2013 at 08:13:02PM +0300, Pasi Kärkkäinen wrote: On Fri, Aug 30, 2013 at 05:38:04PM -0400, Rich wrote: Apparently, only about 4 months. P17 firmware is out.

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-03 Thread Ben Hutchings
On Wed, 2013-10-02 at 12:48 +0200, Alexander Gordeev wrote: > This series is against "next" branch in Bjorn's repo: > git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git > > Currently pci_enable_msi_block() and pci_enable_msix() interfaces > return a error code in case of failure, 0 in c

Re: [PATCH RFC 06/77] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-10-03 Thread Ben Hutchings
On Wed, 2013-10-02 at 12:48 +0200, Alexander Gordeev wrote: [...] > --- a/drivers/pci/msi.c > +++ b/drivers/pci/msi.c > @@ -812,6 +812,21 @@ static int pci_msi_check_device(struct pci_dev *dev, int > nvec, int type) > return 0; > } > > +int pci_get_msi_cap(struct pci_dev *dev) > +{ > +

Re: [PATCH RFC 01/77] PCI/MSI: Fix return value when populate_msi_sysfs() failed

2013-10-03 Thread Ben Hutchings
On Wed, 2013-10-02 at 17:39 -0700, Jon Mason wrote: > On Wed, Oct 02, 2013 at 12:48:17PM +0200, Alexander Gordeev wrote: > > Signed-off-by: Alexander Gordeev > > Since you are changing the behavior of the msix_capability_init > function on populate_msi_sysfs error, a comment describing why in thi

[PATCH 1/3] iscsi-target: Only perform wait_for_tasks when performing shutdown

2013-10-03 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch changes transport_generic_free_cmd() to only wait_for_tasks when shutdown=true is passed to iscsit_free_cmd(). With the advent of >= v3.10 iscsi-target code using se_cmd->cmd_kref, the extra wait_for_tasks with shutdown=false is unnecessary, and may end up cau

[PATCH 0/3] iscsi-target: percpu_ida tag starvation regression fixes

2013-10-03 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi folks, This series addresses a v3.12 starvation regression in iscsi-target after the conversion to use percpu_ida tag preallocation for all iscsi_cmd descriptors. The first patch addresses an unnecessary overhead during iscsi_cmd acknowledgement -> release, that coul

[PATCH 3/3] iscsi-target; Allow an extra tag_num / 2 number of percpu_ida tags

2013-10-03 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch bumps the default number of tags allocated per session by iscsi-target via transport_alloc_session_tags() -> percpu_ida_init() by another (tag_num / 2). This is done to take into account the tags waiting to be acknowledged and released in iscsit_ack_from_expst

[PATCH 2/3] iscsi-target: Perform release of acknowledged tags from RX context

2013-10-03 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch converts iscsit_ack_from_expstatsn() to populate a local ack_list of commands, and call iscsit_free_cmd() directly from RX thread context, instead of using iscsit_add_cmd_to_immediate_queue() to queue the acknowledged commands to be released from TX thread cont

Re: Drivers: scsi: FLUSH timeout

2013-10-03 Thread Eric Seppanen
On Thu, Oct 3, 2013 at 5:09 AM, Nicholas A. Bellinger wrote: > > On Wed, 2013-10-02 at 18:29 +, KY Srinivasan wrote: > > Ideally, I want this to be adjustable like the way we can change the I/O > > timeout. > > Since that has been attempted earlier and rejected (not clear what the > > reason

Re: Odd behavior of a "SAS-2" backplane with SGPIO commands

2013-10-03 Thread Pasi Kärkkäinen
On Thu, Oct 03, 2013 at 04:07:31PM -0400, Rich wrote: > I, and a few others, have scripted the hell out of sas2ircu and a few > other things on various platforms. > Been there, done that :) I was mostly wondering if there are other tools so I could evaluate if it makes sense to continue wrapping

Re: Odd behavior of a "SAS-2" backplane with SGPIO commands

2013-10-03 Thread Rich
I, and a few others, have scripted the hell out of sas2ircu and a few other things on various platforms. I haven't had time to clean up mine and post it publicly yet (it's all in VCS, I use it a lot, on Windows + Linux + Solaris...), but https://github.com/swacquie/DiskMap is an example on Solaris

looking for loan

2013-10-03 Thread Aijaz Lending
Do you have a firm or company that need loan to start up a business or need,personal loan, Debt consolidation? For more information,Contact us now for a guarantee loan with low interest rate. We will provide you with loan to meet your needs. For more information contact us with the following inf

Re: [PATCH RFC 50/77] mlx5: Update MSI/MSI-X interrupts enablement code

2013-10-03 Thread Alexander Gordeev
On Thu, Oct 03, 2013 at 10:14:33AM +0300, Eli Cohen wrote: > On Wed, Oct 02, 2013 at 12:49:06PM +0200, Alexander Gordeev wrote: > > > > + err = pci_msix_table_size(dev->pdev); > > + if (err < 0) > > + return err; > > + > > nvec = dev->caps.num_ports * num_online_cpus() + MLX5_EQ

Re: Odd behavior of a "SAS-2" backplane with SGPIO commands

2013-10-03 Thread Pasi Kärkkäinen
On Mon, Sep 02, 2013 at 05:44:35PM +0300, Pasi Kärkkäinen wrote: > On Sun, Sep 01, 2013 at 08:13:02PM +0300, Pasi Kärkkäinen wrote: > > On Fri, Aug 30, 2013 at 05:38:04PM -0400, Rich wrote: > > >Apparently, only about 4 months. > > >P17 firmware is out. > > >Tested on a card which was d

Re: [PATCH RFC 51/77] mthca: Update MSI/MSI-X interrupts enablement code

2013-10-03 Thread Jack Morgenstein
On Wed, 2 Oct 2013 12:49:07 +0200 Alexander Gordeev wrote: > Subject: [PATCH RFC 51/77] mthca: Update MSI/MSI-X interrupts > enablement code Date: Wed, 2 Oct 2013 12:49:07 +0200 > Sender: linux-rdma-ow...@vger.kernel.org > X-Mailer: git-send-email 1.7.7.6 > > As result of recent re-design of t

RE: Drivers: scsi: FLUSH timeout

2013-10-03 Thread KY Srinivasan
> -Original Message- > From: Nicholas A. Bellinger [mailto:n...@linux-iscsi.org] > Sent: Thursday, October 03, 2013 5:09 AM > To: KY Srinivasan > Cc: Geert Uytterhoeven; Mike Christie; Jack Wang; Greg KH; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com; > j

Re: Drivers: scsi: FLUSH timeout

2013-10-03 Thread James Bottomley
On Wed, 2013-10-02 at 18:29 +, KY Srinivasan wrote: > > > -Original Message- > > From: geert.uytterhoe...@gmail.com [mailto:geert.uytterhoe...@gmail.com] > > On Behalf Of Geert Uytterhoeven > > Sent: Wednesday, September 25, 2013 1:40 AM > > To: KY Srinivasan > > Cc: Mike Christie; Jac

Re: [PATCH 0/3] target: Fixes for COMPARE_AND_WRITE backend I/O failure cases

2013-10-03 Thread Nicholas A. Bellinger
On Thu, 2013-10-03 at 13:38 +0200, Thomas Glanzmann wrote: > Hallo Nab, > > > Please let me know if you encounter any issues, and a patch to address > > this bit should be along in the next 24-48 hours. > > I just did a little bit of stress testing: > > - Rescan from 12 Initiators at the

Re: Drivers: scsi: FLUSH timeout

2013-10-03 Thread Nicholas A. Bellinger
On Wed, 2013-10-02 at 18:29 +, KY Srinivasan wrote: > > > -Original Message- > > From: geert.uytterhoe...@gmail.com [mailto:geert.uytterhoe...@gmail.com] > > On Behalf Of Geert Uytterhoeven > > Sent: Wednesday, September 25, 2013 1:40 AM > > To: KY Srinivasan > > Cc: Mike Christie; Jac

Re: [PATCH 0/3] target: Fixes for COMPARE_AND_WRITE backend I/O failure cases

2013-10-03 Thread Thomas Glanzmann
Hallo Nab, > Please let me know if you encounter any issues, and a patch to address > this bit should be along in the next 24-48 hours. I just did a little bit of stress testing: - Rescan from 12 Initiators at the same time - PASS - Deployed 24 VMs over 12 Initiators at the same

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-10-03 Thread Christoph Hellwig
On Sat, Jul 20, 2013 at 09:48:28AM -0500, Mike Christie wrote: > What about the attached only compile tested patch. The patch has the mq > block code work like the non mq code for bio cleanups. > > > blk-mq: blk-mq should free bios in pass through case > > For non mq calls, the block layer will

Sometimes things happen much quicker than you would love to.

2013-10-03 Thread DavidNKane
Dear Customer Why missing moments with your loved ones when you have the solution at one click distance? Never miss a moment again http://onlineshop59.yolasite.com/store Best Regards, -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i

Re: [PATCH RFC 46/77] mlx4: Update MSI/MSI-X interrupts enablement code

2013-10-03 Thread Jack Morgenstein
On Wed, 2 Oct 2013 12:49:02 +0200 Alexander Gordeev wrote: > As result of recent re-design of the MSI/MSI-X interrupts enabling > pattern this driver has to be updated to use the new technique to > obtain a optimal number of MSI/MSI-X interrupts required. > > Signed-off-by: Alexander Gordeev

Re: [PATCH RFC 46/77] mlx4: Update MSI/MSI-X interrupts enablement code

2013-10-03 Thread Jack Morgenstein
On Wed, 2 Oct 2013 12:49:02 +0200 Alexander Gordeev wrote: UPDATING THIS REPLY. Your change log confused me. The change below is not from a "recent re-design", it is required due to an earlier patch in this patch set. >From the log, I assumed that the change you are talking about is already upst

Re: [PATCH RFC 46/77] mlx4: Update MSI/MSI-X interrupts enablement code

2013-10-03 Thread Jack Morgenstein
On Wed, 2 Oct 2013 12:49:02 +0200 Alexander Gordeev wrote: NACK. This change does not do anything logically as far as I can tell. pci_enable_msix in the current upstream kernel itself calls pci_msix_table_size. The current code yields the same results as the code suggested below. (i.e., the su

[PATCH 1/2] qla2xxx: Fix request queue null dereference.

2013-10-03 Thread Saurav Kashyap
From: Chad Dupuis If an invalid IOCB is returned on the response queue then the index into the request queue map could be invalid and could return to us a bogus value. This could cause us to try to deference an invalid pointer and cause an exception. If we encounter this condition, simply return

[PATCH 2/2] qla2xxx: Remove entry in outstanding_cmds array if we fail to abort a request.

2013-10-03 Thread Saurav Kashyap
From: Chad Dupuis If the call to abort a request fails we need to clear it's entry in the in-flight commands array as it won't be cleared in interrupt context. Not doing so could potentially lead to a double completion. Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap --- drivers/sc

[PATCH 0/2] qla2xxx: Patches for 3.12-rc.

2013-10-03 Thread Saurav Kashyap
Hi James, Please apply the following patches for 3.12-rc. Thanks, ~Saurav Chad Dupuis (2): qla2xxx: Fix request queue null dereference. qla2xxx: Remove entry in outstanding_cmds array if we fail to abort a request. drivers/scsi/qla2xxx/qla_dbg.c |2 +- drivers/scsi/qla2xxx/qla_isr.

Re: [PATCH RFC 50/77] mlx5: Update MSI/MSI-X interrupts enablement code

2013-10-03 Thread Eli Cohen
On Wed, Oct 02, 2013 at 12:49:06PM +0200, Alexander Gordeev wrote: > > + err = pci_msix_table_size(dev->pdev); > + if (err < 0) > + return err; > + > nvec = dev->caps.num_ports * num_online_cpus() + MLX5_EQ_VEC_COMP_BASE; > nvec = min_t(int, nvec, num_eqs); > +