Re: [PATCH 2/5] scsi: improved eh timeout handler

2013-11-09 Thread James Bottomley
On Thu, 2013-11-07 at 07:45 +0100, Hannes Reinecke wrote: On 11/06/2013 06:23 PM, Mike Christie wrote: On 11/05/2013 10:48 PM, Hannes Reinecke wrote: On 11/05/2013 08:19 PM, Mike Christie wrote: On 11/04/2013 11:05 PM, Hannes Reinecke wrote: + +scmd-eh_eflags |=

Re: [PATCH 2/5] scsi: improved eh timeout handler

2013-11-09 Thread Hannes Reinecke
On 11/09/2013 09:35 AM, James Bottomley wrote: On Thu, 2013-11-07 at 07:45 +0100, Hannes Reinecke wrote: On 11/06/2013 06:23 PM, Mike Christie wrote: On 11/05/2013 10:48 PM, Hannes Reinecke wrote: On 11/05/2013 08:19 PM, Mike Christie wrote: On 11/04/2013 11:05 PM, Hannes Reinecke wrote: +

Re: [PATCH/RESEND v2 0/2] SATA disk resume time optimization

2013-11-09 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 11/08/2013 08:20 PM, Todd E Brandt wrote: I tested your patches and they do function. We tried a similar approach a few months back where instead of waking the scsi disks we just set them all to runtime_suspended and skipped the resume. Then

[PATCH 1/6] libata: use sleep instead of standby command

2013-11-09 Thread Phillip Susi
The ATA SLEEP mode saves some more power than SUSPEND, and has basically the same recovery time, so use it instead. --- drivers/ata/libata-scsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 97a0cef..79b75fd

[PATCH 0/6] Let sleeping disks lie

2013-11-09 Thread Phillip Susi
I've made a few corrections and extentions to this patch set after more testing. Changes include fixing the faked command to return the correct status, fixing some errors and adding more commands to be faked. The one command I have yet to figure out how to fake is IDENTIFY DEVICE, which I would

[PATCH 2/6] libata: avoid waking disk to check power

2013-11-09 Thread Phillip Susi
When a disk is in SLEEP mode it can not respond to commands, including the CHECK POWER command. Instead of waking up the sleeping disk, fake the reply to the CHECK POWER command to indicate the disk is in standby mode. This prevents udisks from waking up sleeping disks when it polls to see if

[PATCH 6/6] libata: fake some more commands when drive is sleeping

2013-11-09 Thread Phillip Susi
The sd driver issues a flush cache when suspending, and this was causing a sleeping drive to wake up for no reason. Another sleep or standby command when the drive is already sleeping obviously should also not cause the disk to spin up. --- drivers/ata/libata-core.c | 6 +- 1 file changed, 5

[PATCH 3/6] sd: don't bother spinning up disks on resume

2013-11-09 Thread Phillip Susi
Don't bother forcing disks to spin up on resume, as they will do so automatically when accessed, and forcing them to spin up slows down the resume. Add a second bit to the manage_start_stop flag to restore the previous behavior. --- drivers/scsi/sd.c | 6 +++---

[PATCH 4/6] libata: resume in the background

2013-11-09 Thread Phillip Susi
Don't block the resume path waiting for the disk to spin up. --- drivers/ata/libata-core.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 686c441..128ce0d 100644 --- a/drivers/ata/libata-core.c +++

[PATCH 5/6] libata: don't start disks on resume

2013-11-09 Thread Phillip Susi
Disks with Power Up In Standby enabled that required the SET FEATURES command to start up were being issued the command during resume. Suppress this until the disk is actually accessed. --- drivers/ata/libata-core.c | 12 ++-- drivers/ata/libata-eh.c | 10 --

[GIT PULL] First round of SCSI updates for the 3.11+ merge window

2013-11-09 Thread James Bottomley
This patch set is driver updates for qla4xxx, scsi_debug, pm80xx, fcoe/libfc, eas2r, lpfc, be2iscsi and megaraid_sas plus some assorted bug fixes and cleanups The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-for-linus The short changelog is: Aaron