On 02/06/2014 04:11 PM, Nicholas A. Bellinger wrote:
+struct request_queue *scsi_mq_alloc_queue(struct scsi_device *sdev)
+{
+ struct Scsi_Host *shost = sdev-host;
+ struct blk_mq_hw_ctx *hctx;
+ struct request_queue *q;
+ struct request *rq;
+ struct scsi_cmnd *cmd;
+ struct
Il 05/02/2014 13:39, Christoph Hellwig ha scritto:
Avoid hitting the host-wide free_list lock unless we need to put a command
back onto the freelist.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/scsi.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff
Il 05/02/2014 13:39, Christoph Hellwig ha scritto:
+ pool = scsi_find_host_cmd_pool(shost);
Should you have a WARN_ON somewhere if shost-hostt-cmd_size
shost-unchecked_isa_dma?
Apart from this,
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
Paolo
+ if (!pool) {
+
Il 05/02/2014 13:39, Christoph Hellwig ha scritto:
Taken almost entirely from Nicholas Bellinger's scsi-mq conversion.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/virtio_scsi.c | 25 +++--
1 file changed, 7 insertions(+), 18 deletions(-)
diff --git
On 02/05/2014 06:39 AM, Christoph Hellwig wrote:
-static struct scsi_host_cmd_pool *scsi_get_host_cmd_pool(gfp_t gfp_mask)
+static struct scsi_host_cmd_pool *
+scsi_find_host_cmd_pool(struct Scsi_Host *shost)
{
+ if (shost-hostt-cmd_size)
+ return shost-hostt-cmd_pool;
+
On 02/06/14 22:58, Nicholas A. Bellinger wrote:
Starting with a baseline using scsi_debug that NOPs REQ_TYPE_FS commands
to measure improvements would be a better baseline vs. scsi_request_fn()
existing code that what your doing above.
That way at least it's easier to measure specific
On 02/06/14 19:41, James Bottomley wrote:
On Thu, 2014-02-06 at 18:10 +0100, Bart Van Assche wrote:
On 02/06/14 17:56, James Bottomley wrote:
Could you benchmark this lot and show what the actual improvement is
just for this series, if any?
I see a performance improvement of 12% with the SRP
-Original Message-
From: Alexander Gordeev [mailto:agord...@redhat.com]
Sent: Tuesday, February 04, 2014 4:47 PM
To: linux-ker...@vger.kernel.org
Cc: Alexander Gordeev; DL-MegaRAID Linux; linux-scsi@vger.kernel.org;
linux-...@vger.kernel.org
Subject: [PATCH 13/22] megaraid: Use
On Fri, Feb 07, 2014 at 02:45:18AM -0600, Mike Christie wrote:
Yeah, it would be nice if like in Nick's patches, the driver could just
set the scsi_host_template-cmd_size then when the scsi_cmnd got to the
driver's queuecommand, the driver could just get its internal cmd struct
from the
On Fri, Feb 07, 2014 at 10:13:25AM +0100, Paolo Bonzini wrote:
Il 05/02/2014 13:39, Christoph Hellwig ha scritto:
+pool = scsi_find_host_cmd_pool(shost);
Should you have a WARN_ON somewhere if shost-hostt-cmd_size
shost-unchecked_isa_dma?
Seems like we could support passing
On Fri, Feb 07, 2014 at 03:35:00AM -0600, Mike Christie wrote:
It seems there is a issue with using the cmd_size to indicate the driver
has its own cmd pool and also using that for scsi mq enabled drivers to
indicate that we want the LLD's struct allocated by blk/scsi mq.
If a driver sets
Is there extra scsi_mq_done() part that does IPI here even necessary
anymore..?
I was under the assumption that blk_mq_end_io() is already taking care
of this..?
blk_mq_end_io does it, but given that the SCSI-specific I/O completion
path is non-trivial I'd rather run it on the indicated CPU
Hello Erich Chen,
The patch 1c57e86d75cf: [SCSI] arcmsr: initial driver, version
1.20.00.13 from Jul 12, 2006, leads to the following static checker
warning:
drivers/scsi/arcmsr/arcmsr_hba.c:816 arcmsr_report_sense_info()
error: memcpy() 'ccb-arcmsr_cdb.SenseData' too small (15
Hello Nick Cheng,
The patch cdd3cb156f19: [SCSI] SCSI: Support Type C RAID controller
from Jul 13, 2010, leads to the following static checker warning:
drivers/scsi/arcmsr/arcmsr_hba.c:2474 arcmsr_polling_hbc_ccbdone()
warn: this loop depends on readl() succeeding
This file has many many Sparse warnings. Most of them are just a matter
of using correct __iomem tags but some are real bugs where we
dereference __iomem pointers. Can you take a look?
regards,
dan carpenter
drivers/scsi/arcmsr/arcmsr_hba.c:81:19: warning: symbol 'wait_q' was not
declared.
The original code always set the upper 32 bits to zero because it was
doing a shift of the wrong variable.
Fixes: 1a4f550a09f8 ('[SCSI] arcmsr: 1.20.00.15: add SATA RAID plus other
fixes')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c
Hi,
On Sat, Feb 01, 2014 at 02:24:33AM +, Albert Chen wrote:
[LSF/MM TOPIC] SMR: Disrupting recording technology meriting a new class of
storage device
Shingle Magnetic Recording is a disruptive technology that delivers the next
areal density gain for the HDD industry by partially
On Fri, Feb 07, 2014 at 04:00:28PM +0300, Dan Carpenter wrote:
The original code always set the upper 32 bits to zero because it was
doing a shift of the wrong variable.
Actually let me redo this. I want to add a cast to prevent a static
checker warning on 32 bit systems. Sorry, for the
On 02/07/2014 02:00 PM, Carlos Maiolino wrote:
Hi,
On Sat, Feb 01, 2014 at 02:24:33AM +, Albert Chen wrote:
[LSF/MM TOPIC] SMR: Disrupting recording technology meriting
a new class of storage device
Shingle Magnetic Recording is a disruptive technology that
delivers the next areal
On 02/06/2014 08:14 PM, Douglas Gilbert wrote:
On 14-02-06 08:04 AM, Hannes Reinecke wrote:
EVPD page 0x83 is used to uniquely identify the device.
So instead of having each and every program issue a separate
SG_IO call to retrieve this information it does make far more
sense to display it in
-Original Message-
From: Hannes Reinecke [mailto:h...@suse.de]
Sent: Friday, February 07, 2014 5:46 AM
To: Carlos Maiolino; Albert Chen
Cc: lsf...@lists.linux-foundation.org; James Borden; Jim Malina; Curtis
Stevens; linux-...@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-
Hi Jens,
these small blk-mq core updates fell out of the scsi multiqueue work.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
This is neede for proper SG_IO operation as well as various uses of
blk_execute_rq from the SCSI midlayer.
Signed-off-by: Christoph Hellwig h...@lst.de
---
block/blk-exec.c |2 +-
block/blk-mq.c | 17 ++---
include/linux/blk-mq.h |3 ++-
3 files changed, 13
__blk_put_request needs to call into the blk-mq code just like
blk_put_request. As we don't have the queue lock in this case both
end up calling the same function.
Signed-off-by: Christoph Hellwig h...@lst.de
---
block/blk-core.c |5 +
1 file changed, 5 insertions(+)
diff --git
To behave the same way as the old request path.
Signed-off-by: Christoph Hellwig h...@lst.de
---
block/blk-mq.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 35800e1..f5fcd9a 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1373,6 +1373,8 @@
Make blk-mq handle the dma_drain_size field the same way as the old request
path.
Signed-off-by: Christoph Hellwig h...@lst.de
---
block/blk-mq.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 40fc4dd..35800e1 100644
--- a/block/blk-mq.c
On Fri, Feb 07 2014, Christoph Hellwig wrote:
Hi Jens,
these small blk-mq core updates fell out of the scsi multiqueue work.
Thanks, all nice and simple, applied to for-linus.
--
Jens Axboe
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to
On Thu, 2014-02-06 at 18:56 -0800, Andy Grover wrote:
On 02/06/2014 03:51 PM, Nicholas A. Bellinger wrote:
The problem with this patch and all of the other patches that follow the
same logic is the false assumption that it's safe to return from
configfs_group_operations-drop_item() before
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Is it possible to use the scsi_debug module to create more than one
device? It seems to me that it needs rewritten to have an interface
to dynamically create devices and set their parameters with a tool
like losetup, rather than using module
On Fri, 2014-02-07 at 11:32 +0100, Bart Van Assche wrote:
On 02/06/14 22:58, Nicholas A. Bellinger wrote:
Starting with a baseline using scsi_debug that NOPs REQ_TYPE_FS commands
to measure improvements would be a better baseline vs. scsi_request_fn()
existing code that what your doing
On Fri, 2014-02-07 at 10:22 -0800, Christoph Hellwig wrote:
Hi Jens,
these small blk-mq core updates fell out of the scsi multiqueue work.
That reminds me, the following blk-mq patch was required to get DIF
working with scsi-mq.
Jens, care to pick this up as well..?
--nab
From
https://bugzilla.kernel.org/show_bug.cgi?id=60758
kome...@gmail.com changed:
What|Removed |Added
CC||kome...@gmail.com
--- Comment #56
Kurt == Kurt Miller k...@intricatesoftware.com writes:
Kurt Is TRIM working for anyone using LSI SAS2008 controllers?
Yes. But its SAT appears to be somewhat selective about which devices it
flags as capable.
Please send me the output of:
# sg_readcap -l /dev/sdc
# sg_vpd -p bl /dev/sdc
#
Phillip == Phillip Susi ps...@ubuntu.com writes:
Phillip Is it possible to use the scsi_debug module to create more than
Phillip one device? It seems to me that it needs rewritten to have an
Phillip interface to dynamically create devices and set their
Phillip parameters with a tool like
On Fri, Feb 07 2014, Nicholas A. Bellinger wrote:
On Fri, 2014-02-07 at 10:22 -0800, Christoph Hellwig wrote:
Hi Jens,
these small blk-mq core updates fell out of the scsi multiqueue work.
That reminds me, the following blk-mq patch was required to get DIF
working with scsi-mq.
On Thu, 2014-02-06 at 18:56 -0500, Kurt Miller wrote:
Various sources indicate that LSI's SAS2008 controllers support TRIM
when running their IT firmware (LSI [1] and this list [2]). However, I
have not been able to get it working with Dell PERC H200 or H310 cross
flashed into LSI IT firmware.
On Fri, 2014-02-07 at 15:44 -0500, Martin K. Petersen wrote:
Kurt == Kurt Miller k...@intricatesoftware.com writes:
Kurt Is TRIM working for anyone using LSI SAS2008 controllers?
Yes. But its SAT appears to be somewhat selective about which devices it
flags as capable.
Please send me
Kurt == Kurt Miller k...@intricatesoftware.com writes:
Kurt Thank you for your reply. Below is the output you requested. Note
Kurt that when the EVO's are connected to a SATA AHCI port on my
Kurt desktop motherboard, TRIM works okay. Please let me know if you
Kurt need additional information.
On Fri, 2014-02-07 at 15:59 -0500, Martin K. Petersen wrote:
Kurt == Kurt Miller k...@intricatesoftware.com writes:
Kurtprovisioning: lbpme=0, lbprz=0 Last logical block
^^^
This indicates the SAT on the mpt2sas board didn't enable discard
support for the
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 2/7/2014 3:46 PM, Martin K. Petersen wrote:
The question is how much sense it makes to invest in scsi_debug now
that we have the LIO target in the kernel?
Thanks, I hadn't heard of this. It looks interesting, though a bit
complicated.
On 02/07/2014 06:46 AM, Christoph Hellwig wrote:
On Fri, Feb 07, 2014 at 03:35:00AM -0600, Mike Christie wrote:
It seems there is a issue with using the cmd_size to indicate the driver
has its own cmd pool and also using that for scsi mq enabled drivers to
indicate that we want the LLD's
On Fri, 2014-02-07 at 16:36 -0500, Phillip Susi wrote:
On 2/7/2014 3:46 PM, Martin K. Petersen wrote:
The question is how much sense it makes to invest in scsi_debug now
that we have the LIO target in the kernel?
Thanks, I hadn't heard of this. It looks interesting, though a bit
Kurt == Kurt Miller k...@intricatesoftware.com writes:
Kurt # hdparm -I /dev/sdc
[...]
I don't see any deterministic read after trim/read zero after trim
support on your drive. And I have a sneaking suspicion that those are
two of the fields that the LSI firmware looks at when deciding
43 matches
Mail list logo
