Re: [PATCH 04/16] scsi_dh_alua: Make stpg synchronous

2014-02-19 Thread Hannes Reinecke
On 02/14/2014 07:21 PM, Mike Christie wrote: On 2/14/14 5:37 AM, Bart Van Assche wrote: [ .. ] I think this will only be sufficient if there are more CPU threads available than the number of LUNs for which an STPG has to be issued. Ah shoot, you reminded me of some other issue. With the

Re: [PATCH 00/22] scsi: Use pci_enable_msix_range()

2014-02-19 Thread Alexander Gordeev
On Tue, Feb 04, 2014 at 12:16:46PM +0100, Alexander Gordeev wrote: As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and pci_enable_msix_range()

Re: PROBLEM: special sense code asc,ascq=04h,0Ch abort scsi scan in the middle

2014-02-19 Thread vaughan
Hi Hannes, Sorry to bother you. Months ago, you made a patch to fix this scsi_scan abort error found on zfssa storage. Though it's only a specific storage, the logic -- not abort scsi scan process because of an inquiry failure of a LU in the middle, is helpful as a way to make our scanning more

[PATCH] st: use dev_printk() to avoid linebreaks in kernel messages.

2014-02-19 Thread Maurizio Lombardi
This patch converts the st driver to use dev_printk() instead of printk(), every st device has a reference to the underlying scsi device. Signed-off-by: Maurizio Lombardi mlomb...@redhat.com --- drivers/scsi/st.c | 613 +++--- 1 file changed, 349

Re: [PATCH] st: use dev_printk() to avoid linebreaks in kernel messages.

2014-02-19 Thread Hannes Reinecke
On 02/19/2014 10:04 AM, Maurizio Lombardi wrote: This patch converts the st driver to use dev_printk() instead of printk(), every st device has a reference to the underlying scsi device. Signed-off-by: Maurizio Lombardi mlomb...@redhat.com Thanks for doing this. I've actually a full patchset

Re: [PATCH] st: use dev_printk() to avoid linebreaks in kernel messages.

2014-02-19 Thread Maurizio Lombardi
Hi Hannes, On 02/19/2014 10:09 AM, Hannes Reinecke wrote: Thanks for doing this. I've actually a full patchset queued, converting all the stray 'printk' invocations in the SCSI stack to dev_printk() and friends. And moving to a per-device scsi_log_level :-) So far I haven't posted them

Re: [PATCH] st: use dev_printk() to avoid linebreaks in kernel messages.

2014-02-19 Thread Hannes Reinecke
On 02/19/2014 10:23 AM, Maurizio Lombardi wrote: Hi Hannes, On 02/19/2014 10:09 AM, Hannes Reinecke wrote: Thanks for doing this. I've actually a full patchset queued, converting all the stray 'printk' invocations in the SCSI stack to dev_printk() and friends. And moving to a per-device

re: [SCSI] mpt fusion: Add support for ATTO 4LD: Rebranded LSI 53C1030

2014-02-19 Thread Dan Carpenter
Hello Eric Moore, The patch 232f08fc82b1: [SCSI] mpt fusion: Add support for ATTO 4LD: Rebranded LSI 53C1030 from Aug 14, 2007, leads to the following static checker warning: drivers/message/fusion/mptbase.c:5527 mpt_GetScsiPortSettings() warn: was hexadecimal intended '10'

Re: [PATCH] target_core_alua: silence GCC warning

2014-02-19 Thread Geert Uytterhoeven
On Wed, Feb 19, 2014 at 10:52 AM, Paul Bolle pebo...@tiscali.nl wrote: - ret = core_alua_state_nonoptimized(cmd, cdb, - nonop_delay_msecs, alua_ascq); + core_alua_state_nonoptimized(cmd, cdb, nonop_delay_msecs); I suggest making

Re: [PATCH] target_core_alua: silence GCC warning

2014-02-19 Thread Paul Bolle
On Wed, 2014-02-19 at 10:59 +0100, Geert Uytterhoeven wrote: On Wed, Feb 19, 2014 at 10:52 AM, Paul Bolle pebo...@tiscali.nl wrote: - ret = core_alua_state_nonoptimized(cmd, cdb, - nonop_delay_msecs, alua_ascq); +

[PATCH] target_core_alua: silence GCC warning

2014-02-19 Thread Paul Bolle
On Tue, 2014-02-18 at 10:02 +0100, Geert Uytterhoeven wrote: *** WARNINGS *** 188 regressions: [...] + /scratch/kisskb/src/drivers/target/target_core_alua.c: warning: 'alua_ascq' may be used uninitialized in this function [-Wuninitialized]: = 773:18 This one popped up on my (Fedora

loading scsi_debug with data integrity hits BUG_ON

2014-02-19 Thread Akinobu Mita
After commit 5837c80e870b (bio-integrity: Fix bio_integrity_verify segment start bug), loading scsi_debug with data integrity enabled (for example modprobe scsi_debug dif=1 dix=1) starts hitting BUG_ON() at bio_integrity_verify(): BUG_ON(total bio-bi_integrity-bip_iter.bi_size); Because

[Bug 70851] New: mpt3sas / LSI SAS 9300-8i write performance bottleneck

2014-02-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=70851 Bug ID: 70851 Summary: mpt3sas / LSI SAS 9300-8i write performance bottleneck Product: SCSI Drivers Version: 2.5 Kernel Version: 3.12.9-201.fc19.x86_64 Hardware: x86-64 OS:

[Bug 70851] mpt3sas / LSI SAS 9300-8i write performance bottleneck

2014-02-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=70851 Heinz Mauelshagen hei...@redhat.com changed: What|Removed |Added Tree|Mainline|Fedora -- You are

[Bug 70851] mpt3sas / LSI SAS 9300-8i write performance bottleneck

2014-02-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=70851 --- Comment #1 from Heinz Mauelshagen hei...@redhat.com --- The same with 3.13.3-201.fc20.x86_64 -- You are receiving this mail because: You are watching the assignee of the bug. -- To unsubscribe from this list: send the line unsubscribe

mpt2sas and HP Ultrium 1840 SAS LTO4 sporadic EBUSY

2014-02-19 Thread Larry Keegan
Dear fellow SASers, I wonder if I might pick your brains. I have an HP Storageworks Ultrium 1840 SAS tape drive and an LSI SAS9211-4i PCI Express SAS HBA which are behaving temperamentally. The SAS card uses the mpt2sas driver. There are no other devices connected to the SAS controller. After

Re: [PATCH] target_core_alua: silence GCC warning

2014-02-19 Thread Nicholas A. Bellinger
On Wed, 2014-02-19 at 11:05 +0100, Paul Bolle wrote: On Wed, 2014-02-19 at 10:59 +0100, Geert Uytterhoeven wrote: On Wed, Feb 19, 2014 at 10:52 AM, Paul Bolle pebo...@tiscali.nl wrote: - ret = core_alua_state_nonoptimized(cmd, cdb, -

Re: loading scsi_debug with data integrity hits BUG_ON

2014-02-19 Thread Nicholas A. Bellinger
Hi Akinobu, On Wed, 2014-02-19 at 22:22 +0900, Akinobu Mita wrote: After commit 5837c80e870b (bio-integrity: Fix bio_integrity_verify segment start bug), loading scsi_debug with data integrity enabled (for example modprobe scsi_debug dif=1 dix=1) starts hitting BUG_ON() at