RE: [PATCH v2 02/23] bfa: Do not call pci_enable_msix() after it failed once

2014-03-02 Thread Anil Gurumurthy
Patch look good. Acked-by: Anil Gurumurthy anil.gurumur...@qlogic.com -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Alexander Gordeev Sent: 24 February 2014 13:32 To: linux-kernel Cc: Alexander Gordeev; Anil Gurumurthy;

[PATCH/RESEND 4/4] megaraid_sas : Performance boost fixes

2014-03-02 Thread Sumit.Saxena
Please ignore last sent patch on performance boost with subject line - [PATCH 4/4] megaraid_sas : Performance boost fixes Resending the performance boost patch with one change being reverted back- Remove host lock for queuecommand for asynchronous IO submission , Host lock is added back around

RE: [PATCH v2 03/23] bfa: Cleanup bfad_setup_intr() function

2014-03-02 Thread Anil Gurumurthy
Patch look good. Acked-by: Anil Gurumurthy anil.gurumur...@qlogic.com -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Alexander Gordeev Sent: 24 February 2014 13:32 To: linux-kernel Cc: Alexander Gordeev; Anil Gurumurthy;

Re: [PATCH 2/3] Add EVPD page 0x83 to sysfs

2014-03-02 Thread Bart Van Assche
On 02/13/14 11:28, Hannes Reinecke wrote: static ssize_t -show_iostat_counterbits(struct device *dev, struct device_attribute *attr, char *buf) +show_vpd_pg(const unsigned char *pg_buf, int pg_len, char *buf) +{ + int len = 0, i; + + if (!pg_buf) +

Re: [PATCH 2/3] Add EVPD page 0x83 to sysfs

2014-03-02 Thread Bart Van Assche
On 02/13/14 11:28, Hannes Reinecke wrote: - return 0; + return (buffer[2] 8) + buffer[3] + 4; Has it been considered to use get_unaligned_be16() instead of open coding this function ? Bart. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a

Re: [PATCHv7 0/3][Resend] Display EVPD pages in sysfs

2014-03-02 Thread Bart Van Assche
On 02/13/14 11:27, Hannes Reinecke wrote: After discussion with jejb I've dropped the EVPD parsing. So with this version we're just displaying the EVPD page 0x80 and 0x83 as hexdumps; no parsing is attempted. This drastically simplifies the patch, and we don't have to worry about any parsing

Re: [PATCHv2 00/16] scsi_dh_alua updates

2014-03-02 Thread Bart Van Assche
On 01/31/14 10:29, Hannes Reinecke wrote: here's an update for the ALUA device handler I've been hoarding for quite some time. The major bit here is the asynchronous RTPG handling. With the original design we would treat every LUN independently, despite the fact that several LUNs might in

Re: [PATCH v1 11/13] SCSI/libiscsi: Add check_protection callback for transports

2014-03-02 Thread Mike Christie
On 02/27/2014 05:13 AM, Sagi Grimberg wrote: diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c index 4046241..a58a6bb 100644 --- a/drivers/scsi/libiscsi.c +++ b/drivers/scsi/libiscsi.c @@ -395,6 +395,10 @@ static int iscsi_prep_scsi_cmd_pdu(struct iscsi_task *task)

Re: [PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-03-02 Thread Mike Christie
On 02/27/2014 05:13 AM, Sagi Grimberg wrote: diff --git a/drivers/infiniband/ulp/iser/iser_initiator.c b/drivers/infiniband/ulp/iser/iser_initiator.c index 58e14c7..7fd95fe 100644 --- a/drivers/infiniband/ulp/iser/iser_initiator.c +++ b/drivers/infiniband/ulp/iser/iser_initiator.c @@ -62,6

Re: [PATCH v12 1/4] PHY: Add function set_speed to generic PHY framework

2014-03-02 Thread Loc Ho
Hi Felipe and Kishon, This patch adds function set_speed to the generic PHY framework operation structure. This function can be called to instruct the PHY underlying layer at specified lane to configure for specified speed in hertz. why ? looks like clk_set_rate() is your