[PATCH for-3.15] scsi/libiscsi: Fix static checker warning on bh locking

2014-03-30 Thread Or Gerlitz
From: Shlomo Pongratz shlo...@mellanox.com Commit 659743b [SCSI] libiscsi: Reduce locking contention in fast path introduced a new smatch warning on libiscsi.c iscsi_xmit_task() warn: inconsistent returns bottom_half:: locked (1410 [(-61)]) unlocked (1425 [0], 1425 [s32min-(-1),1-s32max]),

[PATCH] aic79xx: fix misuse of static variables

2014-03-30 Thread Mathias Krause
The format strings for various printk()s make use of a temporary variable that is declared 'static'. This is probably not intended, so fix those. Found in the PaX patch, written by the PaX Team. Cc: PaX Team pagee...@freemail.hu Cc: Hannes Reinecke h...@suse.de Cc: James E.J. Bottomley

Re: misc scsi midlayer updates

2014-03-30 Thread Boaz Harrosh
On 03/27/2014 06:14 PM, Christoph Hellwig wrote: Various patches from the scsi multiqueue development that make sense on their own. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 5/6] be2iscsi: Fix TCP parameters while connection offloading.

2014-03-30 Thread Mike Christie
On 03/27/2014 11:39 AM, Jayamohan Kallickal wrote: +int mgmt_open_connection_v1(struct beiscsi_hba *phba, + struct sockaddr *dst_addr, + struct beiscsi_endpoint *beiscsi_ep, + struct be_dma_mem *nonemb_cmd) +{ +

Re: [PATCH 2/6] be2iscsi: relinquishing control after processing 512 CQE

2014-03-30 Thread Mike Christie
On 03/27/2014 11:39 AM, Jayamohan Kallickal wrote: @@ -2323,14 +2319,33 @@ void beiscsi_process_all_cqs(struct work_struct *work) static int be_iopoll(struct blk_iopoll *iop, int budget) { - unsigned int ret; + unsigned int ret, num_eq_processed; struct beiscsi_hba *phba;

Re: [PATCH 2/4] scsi: remove scsi_end_request

2014-03-30 Thread Nicholas A. Bellinger
Hi hch jejb, On Thu, 2014-03-27 at 17:14 +0100, Christoph Hellwig wrote: Simply the I/O completion logic by folding scsi_end_request into its only caller. There is a single site to either requeue the command or move on to the next one instead of of the previous convoluted logic.

Re: [PATCH 09/10] qla4xxx: Fix memory leak in func qla4_84xx_config_acb()

2014-03-30 Thread Mike Christie
On 02/24/2014 09:07 PM, vikas.chaudh...@qlogic.com wrote: From: Vikas Chaudhary vikas.chaudh...@qlogic.com Use correct goto statement to free dma memory in case of failure in function qla4_84xx_config_acb() Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com ---

Re: [PATCH 4/4] scsi: handle command allocation failure in scsi_reset_provider

2014-03-30 Thread Nicholas A. Bellinger
On Thu, 2014-03-27 at 17:14 +0100, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig h...@lst.de --- drivers/scsi/scsi_error.c |6 ++ 1 file changed, 6 insertions(+) Reviewed-by: Nicholas Bellinger n...@linux-iscsi.org -- To unsubscribe from this list: send the line

Re: [PATCH 3/4] scsi: reintroduce scsi_driver.init_command

2014-03-30 Thread Nicholas A. Bellinger
On Thu, 2014-03-27 at 17:14 +0100, Christoph Hellwig wrote: Move control of the prep_fn back from the ULDs into the scsi layer. Besides cleaning up the code and removing the only use of the unprep_fn requeuest_queue method this also prepares for usinng blk-mq, which doesn't have equivalent

Re: [PATCH 0/7] Performance improvements for LSI SCSI cards

2014-03-30 Thread Nicholas A. Bellinger
Hi Matthew, On Thu, 2014-03-27 at 16:40 -0400, Matthew Wilcox wrote: The host lock is a serious scalability problem on 2-socket and larger systems which are doing a lot of I/O. Before removing the temporary usgae of DEF_SCSI_QCMD, we need to remove all uses of serial_number. An unrelated

Re: [PATCH] aic79xx: fix misuse of static variables

2014-03-30 Thread Hannes Reinecke
On 03/30/2014 03:30 PM, Mathias Krause wrote: The format strings for various printk()s make use of a temporary variable that is declared 'static'. This is probably not intended, so fix those. Found in the PaX patch, written by the PaX Team. Cc: PaX Team pagee...@freemail.hu Cc: Hannes

Re: [PATCH 1/4] scsi: explicitly release bidi buffers

2014-03-30 Thread Mike Christie
On 03/27/2014 11:14 AM, Christoph Hellwig wrote: +static void scsi_release_bidi_buffers(struct scsi_cmnd *cmd) +{ + struct scsi_data_buffer *bidi_sdb = cmd-request-next_rq-special; + + scsi_free_sgtable(bidi_sdb); + kmem_cache_free(scsi_sdb_cache, bidi_sdb); +