Re: [PATCH] aic79xx: fix misuse of static variables

2014-04-15 Thread Mathias Krause
On 30 March 2014 15:30, Mathias Krause mini...@googlemail.com wrote: The format strings for various printk()s make use of a temporary variable that is declared 'static'. This is probably not intended, so fix those. Found in the PaX patch, written by the PaX Team. Cc: PaX Team

[PATCH 2/2] scsi: don't reference freed command in scsi_prep_return

2014-04-15 Thread Christoph Hellwig
In the kill case of scsi_prep_return we have to release our device reference, but we do this trying to reference the just freed command. Use the local sdev pointer instead. Reported-by: Joe Lawrence joe.lawre...@stratus.com Signed-off-by: Christoph Hellwig h...@lst.de --- drivers/scsi/scsi_lib.c

[PATCH 1/2] scsi: don't reference freed command in scsi_init_sgtable

2014-04-15 Thread Christoph Hellwig
When scsi_init_io fails we have to release our device reference, but we do this trying to reference the just freed command. Add a local scsi_device pointer to fix this. Reported-by: Sander Eikelenboom li...@eikelenboom.it Signed-off-by: Christoph Hellwig h...@lst.de --- drivers/scsi/scsi_lib.c

scsi fixes for 3.15-rc2

2014-04-15 Thread Christoph Hellwig
Two simple fixes for use after free conditions in prep_fn error handling. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 4/5] tgt: defconfig cleanup

2014-04-15 Thread Christoph Hellwig
From: Bart Van Assche bvanass...@acm.org Because of the removal of the scsi_tgt kernel module, the kbuild variables CONFIG_SCSI_TGT, CONFIG_SCSI_SRP_TGT_ATTRS and CONFIG_SCSI_FC_TGT_ATTRS are obsolete. This patch removes these variables. This patch is the result of the following command: find

[PATCH 1/5] ibmvstgt: remove

2014-04-15 Thread Christoph Hellwig
The IBM virtual SCSI protocol has been obsoleted by ibmvfc, and there are no reported of the driver left. Signed-off-by: Christoph Hellwig h...@lst.de --- MAINTAINERS |1 - drivers/scsi/Kconfig | 14 - drivers/scsi/Makefile|1 -

[PATCH 3/5] tgt: removal

2014-04-15 Thread Christoph Hellwig
From: Bart Van Assche bvanass...@acm.org Now that the ibmvstgt driver as the only user of scsi_tgt is gone, the scsi_tgt kernel module, the CONFIG_SCSI_TGT, CONFIG_SCSI_SRP_TGT_ATTRS and CONFIG_SCSI_FC_TGT_ATTRS kbuild variable, the scsi_host_template transfer_response method are no longer

tgt infrastructure removal

2014-04-15 Thread Christoph Hellwig
This removes the old tgt infrastructure that has never been used except for the obsolete ibmvstgt hardware (for which a working scst and a never fully working lio driver exists). By it's intimate tie-in into the initiator layer it gets massively in the way of improvements in the initiator, most

3.15 drivers/net/ethernet/broadcom/cnic.c:576 suspicious rcu_dereference_check() usage!

2014-04-15 Thread Josh Boyer
Hi All, We've had a report [1] of the bnx2i/cnic driver(s) throwing suspicious RCU usage with 3.15 merge window kernels on an i686 machine. This corresponds to Linux v3.14-12812-g321d03c86732. I've included the dump below. Has anyone seen this issue before? josh [1]

Re: [PATCH v2 RESEND 22/23] qla4xxx: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-04-15 Thread Vikas Chaudhary
On 14/04/14 1:35 pm, Alexander Gordeev agord...@redhat.com wrote: As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() or pci_enable_msi_exact()

Re:

2014-04-15 Thread Jens Axboe
On 04/14/2014 02:30 AM, Christoph Hellwig wrote: This is the majority of the blk-mq work still required for switching over SCSI. There are a few more bits for I/O completion and requeueing pending, but they will need further work. Looks OK to me, I have applied them all. Note that patch 6

[PATCH] target: Allow non-supporting backends to set pi_prot_type to 0

2014-04-15 Thread Andy Grover
Userspace tools assume if a value is read from configfs, it is valid and will not cause an error if the same value is written back. The only valid value for pi_prot_type for backends not supporting DIF is 0, so allow this particular value to be set without returning an error. Reported-by: