[RFC v2 5/6] mptsas: use async probe

2014-09-04 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Its reported that mptsas can at times take over 30 seconds to recognize SCSI storage devices [0], this is done on the driver's probe path. Use the the new asynch probe to circumvent systemd from killing this driver. [0] https://bugs.launchpad.net/ubuntu/+source/linux/+b

[RFC v2 2/6] driver-core: add driver async_probe support

2014-09-04 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We now have two documented use cases for probing asynchronously: 0) since we bundle together driver init() and probe() systemd's new 30 second timeout has put a limit on the amount of time a driver probe routine can take, we need to enable drivers to complete p

[RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-04 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The new umh kill option has allowed kthreads to receive kill signals but they are generally accepting all sources of kill signals while the original motivation was to enable through the OOM from sending the kill. One particular user which has been found to send kill sign

[RFC v2 4/6] cxgb4: use async probe

2014-09-04 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" cxgb4 probe can take up to over 1 minute when the firmware is is written and installed on the device, even after this the device driver still does some device probing and can take quite a bit. systemd will kill this driver when probe does take over 30 seconds, use the as

Re: [PATCH 16/20] scsi: separate out scsi_retval_string()

2014-09-04 Thread Hannes Reinecke
On 09/05/2014 04:04 AM, Yoshihiro YUNOMAE wrote: > (2014/09/03 19:06), Hannes Reinecke wrote: >> Implement scsi_retval_string() to simplify logging. >> >> Signed-off-by: Hannes Reinecke >> --- >> drivers/scsi/constants.c | 28 >> drivers/scsi/scsi.c | 34 ++

Re: [PATCH 08/20] scsi: use 'bool' as return value for scsi_normalize_sense()

2014-09-04 Thread Hannes Reinecke
On 09/05/2014 02:51 AM, Yoshihiro YUNOMAE wrote: > (2014/09/03 19:06), Hannes Reinecke wrote: >> Convert scsi_normalize_sense() and frieds to return 'bool' >> instead of an integer. >> >> Signed-off-by: Hannes Reinecke >> --- >> drivers/scsi/scsi_error.c | 14 +++--- >> drivers/scsi/scs

Re: [PATCH 1/1] Drivers: scsi: storvsc: Get rid of warning messages

2014-09-04 Thread Christoph Hellwig
Looks good to me. Olaf, Hannes - can I get another review for this (and the older hyperv scanning patch set)? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-inf

Re: [PATCH] bnx2fc: fix incorrect DMA memory mapping in bnx2fc_unmap_sg_list()

2014-09-04 Thread Christoph Hellwig
Thanks, applied. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] SCSI: Don't store LUN bits in CDB[1] for USB mass-storage devices

2014-09-04 Thread Christoph Hellwig
Thanks, applied. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/19] lpfc 10.4.8000.0: Update lpfc version to driver version 10.4.8000.0

2014-09-04 Thread Christoph Hellwig
I've applied the series, but for next time can you make sure to follow the proper format: - remove the version number in every subject line - patches you resend from an original author should be unchanged, except that the From: lines moves into the mail body - patches that you send on with y

Re: [PATCH] scsi_debug: deadlock between completions and surprise module removal

2014-09-04 Thread Christoph Hellwig
Can I get another review for this one? On Sun, Aug 31, 2014 at 07:09:59PM -0400, Douglas Gilbert wrote: > A deadlock has been reported when the completion > of SCSI commands (simulated by a timer) was surprised > by a module removal. This patch removes one half of > the offending locks around time

Re: [PATCH 20/20] scsi_error: format abort error message

2014-09-04 Thread Yoshihiro YUNOMAE
(2014/09/03 19:06), Hannes Reinecke wrote: > Decode the return value if the command abort failed. > > Suggested-by: Robert Elliot > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/scsi_error.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/scsi_

Re: [PATCH 18/20] scsi: remove scsi_show_result()

2014-09-04 Thread Yoshihiro YUNOMAE
This patch looks good. Thanks, Yoshihiro YUNOMAE (2014/09/03 19:06), Hannes Reinecke wrote: > scsi_show_result() was only ever used in one place in sd.c. > So open-code scsi_show_result() in sd.c and remove it from > constants.c. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/constan

Re: [PATCH 17/20] scsi: separate out scsi_host_hostbyte() and scsi_show_driverbyte()

2014-09-04 Thread Yoshihiro YUNOMAE
This patch looks good. Thanks, Yoshihiro YUNOMAE (2014/09/03 19:06), Hannes Reinecke wrote: > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/constants.c | 56 > +--- > include/scsi/scsi_dbg.h | 2 ++ > 2 files changed, 46 insertions(+), 12

Re: Off topic: Test suite for LLDs

2014-09-04 Thread Christoph Hellwig
On Wed, Sep 03, 2014 at 11:11:54PM -0600, Sathya Prakash Veerichetty wrote: > Hello folks, > I would like to know whether we have any standard test suite for > validating a low level driver by executing all the interfaces the low > level driver registers with SML? Unfortunately there is none. But

Re: [SCSI] be2iscsi: adding functionality to change network settings using iscsiadm

2014-09-04 Thread Mike Christie
On 09/04/2014 05:27 AM, Dan Carpenter wrote: > Hello Mike Christie, > > The patch 0e43895ec1f4: "[SCSI] be2iscsi: adding functionality to > change network settings using iscsiadm" from Apr 3, 2012, leads to > the following static checker warning: > > drivers/scsi/be2iscsi/be_mgmt.c:945 mgmt

Re: [PATCH 16/20] scsi: separate out scsi_retval_string()

2014-09-04 Thread Yoshihiro YUNOMAE
(2014/09/03 19:06), Hannes Reinecke wrote: > Implement scsi_retval_string() to simplify logging. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/constants.c | 28 > drivers/scsi/scsi.c | 34 ++ > include/scsi/scsi_dbg.h

Re: [PATCH 14/20] scsi: use local buffer for printing CDB

2014-09-04 Thread Yoshihiro YUNOMAE
(2014/09/03 19:06), Hannes Reinecke wrote: > The CDB needs to be printed in one line (ie with one printk > statement) to avoid the individual bytes to be broken up > under high load. > As using individual printk() statements here would lead to > unnecessary complicated code and needs the stack spac

Re: [PATCH 12/20] scsi: merge print_opcode_name()

2014-09-04 Thread Yoshihiro YUNOMAE
(2014/09/03 19:06), Hannes Reinecke wrote: > Instead of having two versions of print_opcode_name() we > should be consolidating them into one version. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/constants.c | 90 > +++- > 1 file changed,

Re: [PATCH 08/20] scsi: use 'bool' as return value for scsi_normalize_sense()

2014-09-04 Thread Yoshihiro YUNOMAE
(2014/09/03 19:06), Hannes Reinecke wrote: > Convert scsi_normalize_sense() and frieds to return 'bool' > instead of an integer. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/scsi_error.c | 14 +++--- > drivers/scsi/scsi_lib.c | 2 +- > include/scsi/scsi_eh.h| 12

Re: Problem with USB-to-SATA adapters (was: AS2105-based enclosure size issues with >2TB HDDs)

2014-09-04 Thread Dale R. Worley
> From: James Bottomley > Before we embark on elaborate hacks, why don't we just make the capacity > writeable (by root) in sysfs from userspace (will require block change)? > We can then encode all the nasty heuristics (including gpt reading) in > userspace as a udev rule. Looking in from the o

Re: [PATCH v3 11/13] lpfc: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-09-04 Thread Christoph Hellwig
On Thu, Sep 04, 2014 at 02:29:39PM +0100, Alexander Gordeev wrote: > On Mon, Aug 18, 2014 at 08:01:51AM +0200, Alexander Gordeev wrote: > > As result of deprecation of MSI-X/MSI enablement functions > > pci_enable_msix() and pci_enable_msi_block() all drivers > > using these two interfaces need to

Re: [PATCH v3 11/13] lpfc: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-09-04 Thread Alexander Gordeev
On Mon, Aug 18, 2014 at 08:01:51AM +0200, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() or pci_enable_msi_exact

re: [SCSI] be2iscsi: adding functionality to change network settings using iscsiadm

2014-09-04 Thread Dan Carpenter
Hello Mike Christie, The patch 0e43895ec1f4: "[SCSI] be2iscsi: adding functionality to change network settings using iscsiadm" from Apr 3, 2012, leads to the following static checker warning: drivers/scsi/be2iscsi/be_mgmt.c:945 mgmt_static_ip_modify() error: 'ip_param->len' from u

Request for comment: monitoring Fibre ports bandwidth usage

2014-09-04 Thread Nicolas Michel
Hi guys, I wrote the script below because I wanted to monitor the bandwidth usage of my fibre port connected to the SAN. I had some difficulties because that information is not easy to grab: drivers don't implement all stats files in sysfs. Some populate fcp_input_megabytes and fcp_output_megabyte

Re: [PATCH 5/5] SES: Add power_status to SES enclosure component

2014-09-04 Thread Hannes Reinecke
On 08/25/2014 07:34 PM, Song Liu wrote: > From: Song Liu [mailto:songliubrav...@fb.com] > Sent: Monday, August 25, 2014 10:26 AM > To: Song Liu > Cc: Hannes Reinecke > Subject: [PATCH 5/5] SES: Add power_status to SES enclosure component > > Add power_status to SES enclosure component, so we can

Re: [PATCH 1/5] SES: close potential registration race

2014-09-04 Thread Hannes Reinecke
On 08/25/2014 07:34 PM, Song Liu wrote: > From: Song Liu [mailto:songliubrav...@fb.com] > Sent: Monday, August 25, 2014 10:26 AM > To: Song Liu > Cc: Dan Williams; Hannes Reinecke > Subject: [PATCH 1/5] SES: close potential registration race > > From: Dan Williams > > The slot and address field

Re: [PATCH 3/5] SES: add enclosure logical id

2014-09-04 Thread Hannes Reinecke
On 08/25/2014 07:34 PM, Song Liu wrote: > From: Song Liu [mailto:songliubrav...@fb.com] > Sent: Monday, August 25, 2014 10:26 AM > To: Song Liu > Cc: Dan Williams; Hannes Reinecke > Subject: [PATCH 3/5] SES: add enclosure logical id > > From: Dan Williams > > Export the NAA logical id for the e

Re: [PATCH 2/5] SES: generate KOBJ_CHANGE on enclosure attach

2014-09-04 Thread Hannes Reinecke
On 08/25/2014 07:34 PM, Song Liu wrote: > From: Song Liu [mailto:songliubrav...@fb.com] > Sent: Monday, August 25, 2014 10:26 AM > To: Song Liu > Cc: Dan Williams; Hannes Reinecke > Subject: [PATCH 2/5] SES: generate KOBJ_CHANGE on enclosure attach > > From: Dan Williams > > In support of a /de

Re: [PATCH 4/5] SES: add reliable slot attribute

2014-09-04 Thread Hannes Reinecke
On 08/25/2014 07:34 PM, Song Liu wrote: > From: Song Liu [mailto:songliubrav...@fb.com] > Sent: Monday, August 25, 2014 10:26 AM > To: Song Liu > Cc: Dan Williams; Hannes Reinecke > Subject: [PATCH 4/5] SES: add reliable slot attribute > > From: Dan Williams > > The name provided by firmware is

RE: [PATCH v3] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-09-04 Thread Sharma, Sanjeev
-Original Message- From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] Sent: Tuesday, August 19, 2014 3:01 PM To: Sharma, Sanjeev Cc: kra...@redhat.com; mdharm-...@one-eyed-alien.net; linux-...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-scsi@vger.kernel.org; Ha