On 10/16/14 07:37, micha...@cs.wisc.edu wrote:
The following patches implement the SCSI command COMPARE_AND_WRITE as a new
bio/request type REQ_CMP_AND_WRITE. COMPARE_AND_WRITE is defined in the
SCSI SBC (SCSI block command) specs as:
The COMPARE AND WRITE command requests that the device
On Fri, Oct 17, 2014 at 07:43:34PM +, Anish Bhatt wrote:
I actually wanted to get some clarification on how the branches on scsi-queue
work. The core/drivers separation is easy enough, but the current branches
are confusing. If say I am submitting a bug fix for the next 3.17 release,
On Fri, Oct 17, 2014 at 06:34:48PM +, Arvind Kumar wrote:
Hi Christoph,
Thanks for the change. Sorry for the delay. The change looks fine to me. I
just have a question.
The comment in include/scsi/scsi_cmnd.h says:
struct scsi_cmnd {
...
unsigned char tag; /* SCSI-II
On Fri, Oct 17, 2014 at 10:44:36PM +, Rustad, Mark D wrote:
The warning appears in W=2 builds. I had another way to silence it by using
diagnostic control macros, but those macros were not accepted. Using a single
designated initialization also silences it.
Oh well. I think the earlier
On Fri, Oct 17, 2014 at 07:38:37PM -0400, Martin K. Petersen wrote:
The problem with this is that, as it stands, a bio has no type. And it
would suck if we couldn't keep bio rw and request flags in sync.
I wonder if it would make more sense to move the remaining rq types to
cmd_flags after
Christoph, I don't see how the new tagging code with blk-mq can
be providing compatible behavior for existing SCSI drivers.
Do you know that scsi_populate_tag_msg() is always going to provide a
tag? Unconditionally, every time, when using blk-mq?
This is because the test:
if
On 10/17/2014 08:34 PM, Arvind Kumar wrote:
Hi Christoph,
Thanks for the change. Sorry for the delay. The change looks fine to me. I just
have a question.
The comment in include/scsi/scsi_cmnd.h says:
struct scsi_cmnd {
...
unsigned char tag; /* SCSI-II queued command tag */
}
On Sat, Oct 18, 2014 at 01:31:32PM -0400, David Miller wrote:
Christoph, I don't see how the new tagging code with blk-mq can
be providing compatible behavior for existing SCSI drivers.
It doesn't, and that's my fault.
Please try the patch below:
diff --git a/Documentation/block/biodoc.txt
Further to a January 2013 thread titled: [PATCH] SG_SCSI_RESET ioctl
should only perform requested operation by Jeremy Linton a patch (v3)
is presented that expands the existing ioctl to include no_escalate
versions to the existing resets. This requires no changes to SCSI low
level drivers
On 10/18/2014 03:11 AM, Bart Van Assche wrote:
On 10/16/14 07:37, micha...@cs.wisc.edu wrote:
The following patches implement the SCSI command COMPARE_AND_WRITE as
a new
bio/request type REQ_CMP_AND_WRITE. COMPARE_AND_WRITE is defined in the
SCSI SBC (SCSI block command) specs as:
The
Ensures that the string is null-terminate in connection with the
use of strncpy, by switching from strncpy to strzcpy.
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
drivers/scsi/bfa/bfa_fcs_lport.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Aah, thanks for the clarification. I have made mistakenly made this patch
against drivers-for-3.18 then, but it applies cleanly to drivers-for-3.17 as
well, please apply this to drivers-for-3.17.
-Anish
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a
12 matches
Mail list logo
