Re: [PATCH v2 19/36] mac_scsi: Add module option to Kconfig

2014-10-31 Thread Finn Thain
On Thu, 30 Oct 2014, Hannes Reinecke wrote: On 10/27/2014 06:26 AM, Finn Thain wrote: Allow mac_scsi to be built as a module. Replace the old validation of __setup options with code that validates both module and __setup options. Signed-off-by: Finn Thain fth...@telegraphics.com.au

Re: [PATCH v2 20/36] mac_scsi: Cleanup PDMA code

2014-10-31 Thread Finn Thain
On Thu, 30 Oct 2014, Hannes Reinecke wrote: On 10/30/2014 08:46 AM, Hannes Reinecke wrote: Any reason why you didn't re-indent [...] Ahh, forget it. Addressed with the next patch. So, does it get your reviewed-by tag? (Thanks for reviewing all this, BTW.) You also questioned

Re: [PATCH v2 29/36] atari_NCR5380: Refactor Falcon locking

2014-10-31 Thread Finn Thain
On Thu, 30 Oct 2014, Hannes Reinecke wrote: On 10/27/2014 06:26 AM, Finn Thain wrote: Simplify falcon_release_lock_if_possible() by making callers responsible for disabling local IRQ's, which they must do anyway to correctly synchronize the ST DMA lock with core driver data

Re: [PATCH v2 30/36] atari_NCR5380: Merge from sun3_NCR5380.c

2014-10-31 Thread Finn Thain
On Thu, 30 Oct 2014, Hannes Reinecke wrote: On 10/27/2014 06:26 AM, Finn Thain wrote: There is very little difference between the sun3_NCR5380.c core driver and atari_NCR5380.c. The former is a fork of the latter. Merge the sun3_NCR5380.c core driver into atari_NCR5380.c so that

Re: [PATCH v2 19/36] mac_scsi: Add module option to Kconfig

2014-10-31 Thread Hannes Reinecke
On 10/31/2014 08:17 AM, Finn Thain wrote: On Thu, 30 Oct 2014, Hannes Reinecke wrote: On 10/27/2014 06:26 AM, Finn Thain wrote: Allow mac_scsi to be built as a module. Replace the old validation of __setup options with code that validates both module and __setup options.

Re: [PATCH v2 20/36] mac_scsi: Cleanup PDMA code

2014-10-31 Thread Hannes Reinecke
On 10/31/2014 08:18 AM, Finn Thain wrote: On Thu, 30 Oct 2014, Hannes Reinecke wrote: On 10/30/2014 08:46 AM, Hannes Reinecke wrote: Any reason why you didn't re-indent [...] Ahh, forget it. Addressed with the next patch. So, does it get your reviewed-by tag? (Thanks for reviewing

Re: [PATCH v2 30/36] atari_NCR5380: Merge from sun3_NCR5380.c

2014-10-31 Thread Hannes Reinecke
On 10/31/2014 08:21 AM, Finn Thain wrote: On Thu, 30 Oct 2014, Hannes Reinecke wrote: On 10/27/2014 06:26 AM, Finn Thain wrote: There is very little difference between the sun3_NCR5380.c core driver and atari_NCR5380.c. The former is a fork of the latter. Merge the sun3_NCR5380.c core

Re: [PATCH v2 12/12] IB/srp: Add multichannel support

2014-10-31 Thread Bart Van Assche
On 10/30/14 18:33, Sagi Grimberg wrote: Now I realize that we can hit serious problems here since we never solved the issue of srp polling routine that might poll forever within an interrupt (or at least until a hard lockup). Its interesting that you weren't able to hit that with a high

Re: [dm-devel] [PATCH 0/18] SCSI XCOPY support for the kernel and device mapper

2014-10-31 Thread Mikulas Patocka
On Sun, 26 Oct 2014, Bart Van Assche wrote: On 10/22/14 15:24, Mikulas Patocka wrote: I uploaded the new version of SCSI/device-mapper XCOPY patches here: http://people.redhat.com/~mpatocka/patches/kernel/xcopy/series.html I am also sending the patches in the following emails.

Re: [PATCH v2 30/36] atari_NCR5380: Merge from sun3_NCR5380.c

2014-10-31 Thread Finn Thain
On Fri, 31 Oct 2014, Hannes Reinecke wrote: Hmm. I always feel a bit awkward by using personal names in the code. It's not good practice nowadays. Plus one can never be sure if that address is still valid. Or remains so for the foreseeable future. It was valid as of a couple of months ago.

[PATCH] uas: Add US_FL_NO_ATA_1X quirk for 1 more Seagate model

2014-10-31 Thread Hans de Goede
These drives hang when receiving ATA12 commands, so set the US_FL_NO_ATA_1X quirk to filter these out. Cc: sta...@vger.kernel.org # 3.16 Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/usb/storage/unusual_uas.h | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [PATCH 3/3] ipr: Wait for aborted command responses

2014-10-31 Thread Brian King
Adding Wendy... On 10/30/2014 05:27 PM, Brian King wrote: Fixes a race condition in abort handling that was injected when multiple interrupt support was added. When only a single interrupt is present, the adapter guarantees it will send responses for aborted commands prior to the response for

[PATCH 1/2] hpsa: create new workqueue instead of using a shared wq

2014-10-31 Thread Tomas Henzl
hpsa driver uses a shared wq, max sleep time spent in function hpsa_wait_for_clear_event_notify_ack may take up to 600sec and that is too much for a shared workqueue. This patch takes the easiest approach and just creates a driver's own workqueue. (instead of modifying

[PATCH 2/2] add a warning when wait_for_mode_change_ack timeouts

2014-10-31 Thread Tomas Henzl
and remove a redundant call to pci_get_drvdata in hpsa_remove_one Signed-off-by: Tomas Henzl the...@redhat.com --- drivers/scsi/hpsa.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index f60ce7e5bb..59ea37d175 100644 ---

[PATCH 0/2] hpsa: a worqueue fix

2014-10-31 Thread Tomas Henzl
When a thread uses shared workqueue for a long time it my block other tasks and in log you may see mesages like this : INFO: task sshd:6425 blocked for more than 120 seconds. Not tainted 2.6.32-431.11.2.el6.x86_64 #1 echo 0 /proc/sys/kernel/hung_task_timeout_secs disables this message.

Re: [PATCH 4/18] block copy: initial XCOPY offload support

2014-10-31 Thread Mikulas Patocka
On Wed, 22 Oct 2014, Douglas Gilbert wrote: See below ... Perhaps you are checking somewhere else ... EXTENDED_COPY opcode (0x83) has had service actions since SPC-4 rev 34 (February 2012). By the time SPC-4 becomes standardized this command will most likely be called EXTENDED COPY(LID1)

Re: [PATCH 3/3] ipr: Wait for aborted command responses

2014-10-31 Thread wenxiong
I have reviewed the patch and it fixed the issue we saw in our environment recently. Thanks, Wendy Quoting Brian King brk...@linux.vnet.ibm.com: Adding Wendy... On 10/30/2014 05:27 PM, Brian King wrote: Fixes a race condition in abort handling that was injected when multiple interrupt

Re: [PATCH v2 10/12] IB/srp: Use block layer tags

2014-10-31 Thread Hannes Reinecke
On 10/24/2014 08:45 AM, Christoph Hellwig wrote: On Fri, Oct 24, 2014 at 04:43:15AM +, Elliott, Robert (Server Storage) wrote: However, it was looking at scmd-tag, which is always 0xff (at least in those early discovery commands). scmd-request-tag looks like it is the field that has

RE: hyperv storvsc cleanup / optimization

2014-10-31 Thread KY Srinivasan
-Original Message- From: Christoph Hellwig [mailto:h...@lst.de] Sent: Sunday, October 19, 2014 8:18 AM To: KY Srinivasan Cc: linux-scsi@vger.kernel.org Subject: hyperv storvsc cleanup / optimization Hi KY, can you throw the patch below into your testing rig? It converts the