[PATCH] drivers: scsi: megaraid: Add megaraid_sas_internal.h for internal shared functions using

2014-11-09 Thread Chen Gang
For shared inline functions acrossed source files, better to let it as static inline in a header file. For extern functions, better to declare them in header file. For the latest upstream gcc/binutiles (gcc 5 with ld 2.25.51), it will cause building break (although it might be the gcc's or ld's

[PATCH] drivers: scsi: megaraid: Add megaraid_sas_internal.h for internal shared functions using

2014-11-09 Thread Chen Gang
For shared inline functions crossed source files, better to let it as static inline in a header file. For extern functions, better to declare them in header file. For the latest upstream gcc/binutiles (gcc 5 with ld 2.25.51), it will cause building break (although it might be the gcc's or ld's

Re: [PATCH v2 25/36] sun3_scsi: Convert to platform device

2014-11-09 Thread Geert Uytterhoeven
On Mon, Oct 27, 2014 at 6:26 AM, Finn Thain fth...@telegraphics.com.au wrote: --- linux.orig/arch/m68k/sun3/config.c 2014-10-27 16:17:59.0 +1100 +++ linux/arch/m68k/sun3/config.c 2014-10-27 16:25:50.0 +1100 @@ -169,3 +171,61 @@ static void __init sun3_sched_init(irq_h

Re: [PATCH v2 00/36] Fixes, cleanups and modernization for NCR5380 drivers

2014-11-09 Thread Geert Uytterhoeven
Hi Finn, On Fri, Nov 7, 2014 at 3:34 AM, Finn Thain fth...@telegraphics.com.au wrote: it's probably not Geert but James who needs to give the go-ahead. Given Geert's objections to the changes under arch/m68k in v1, I'm hoping for an acked-by from Geert for v2... I'm happy with the arch/m68k

Re: [PATCH v2 25/36] sun3_scsi: Convert to platform device

2014-11-09 Thread Finn Thain
On Sun, 9 Nov 2014, Geert Uytterhoeven wrote: On Mon, Oct 27, 2014 at 6:26 AM, Finn Thain fth...@telegraphics.com.au wrote: --- linux.orig/arch/m68k/sun3/config.c 2014-10-27 16:17:59.0 +1100 +++ linux/arch/m68k/sun3/config.c 2014-10-27 16:25:50.0 +1100 @@ -169,3

Re: [PATCH v2 19/36] mac_scsi: Add module option to Kconfig

2014-11-09 Thread Finn Thain
On Fri, 31 Oct 2014, Hannes Reinecke wrote: On 10/31/2014 08:17 AM, Finn Thain wrote: On Thu, 30 Oct 2014, Hannes Reinecke wrote: On 10/27/2014 06:26 AM, Finn Thain wrote: Allow mac_scsi to be built as a module. Replace the old validation of __setup options with code that

Re: [PATCH v2 25/36] sun3_scsi: Convert to platform device

2014-11-09 Thread Geert Uytterhoeven
On Sun, Nov 9, 2014 at 1:12 PM, Finn Thain fth...@telegraphics.com.au wrote: According to the Sun-3 Architecture Manual v2.0 (May 1985), end should be 0x0014001f. OK. Where did you find that, BTW? In my local collection of hardware docs I downloaded eons ago ;-) Fortunately it hasn't

Re: [PATCH v2 29/36] atari_NCR5380: Refactor Falcon locking

2014-11-09 Thread Finn Thain
Ping... On Fri, 31 Oct 2014, Finn Thain wrote: On Thu, 30 Oct 2014, Hannes Reinecke wrote: On 10/27/2014 06:26 AM, Finn Thain wrote: Simplify falcon_release_lock_if_possible() by making callers responsible for disabling local IRQ's, which they must do anyway to correctly

Re: [PATCH v2 06/36] ncr5380: Remove more useless prototypes

2014-11-09 Thread Finn Thain
Ping... On Wed, 29 Oct 2014, Hannes Reinecke wrote: On 10/27/2014 06:26 AM, Finn Thain wrote: Make use of the host template static initializer instead of assigning handlers at run-time. Move __maybe_unused qualifiers from declarations to definitions. Move the atari_scsi_bus_reset()

[PATCH 1/2] scsi: introduce force_blk_mq

2014-11-09 Thread Ming Lei
From scsi driver view, it is a bit troublesome to support both blk-mq and non-blk-mq at the same time, especially when drivers start to support multi hw-queue. This patch introduces 'force_blk_mq' to scsi_host_template so that drivers can provide blk-mq only support, and avoid to consider legacy

[PATCH 2/2] virtio_scsi: support multi hw queue of blk-mq

2014-11-09 Thread Ming Lei
Since virtio_scsi has supported multi virtqueue already, it is natural to map virtque to hw-queue of blk-mq. Cc: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Ming Lei ming@canonical.com --- drivers/scsi/virtio_scsi.c | 154 1 file changed, 14

[PATCH 0/2] virtio_scsi: support multi hw queue of blk-mq

2014-11-09 Thread Ming Lei
Hi, The 1st patch introduces 'force_blk_mq' so that one driver can claim that it only supports blk-mq. The 2nd patch implements multi hw queue support for virtio_scsi, since it is very natural to map virtqueue to hw queue of blk-mq. Thanks, Ming Lei -- To unsubscribe from this list: send the

Re: [PATCH 4/6] st: call scsi_set_medium_removal directly

2014-11-09 Thread Kai Mäkisara (Kolumbus)
On 7.11.2014, at 1.54, Elliott, Robert (Server Storage) elli...@hp.com wrote: ... 3. Reviewing the callers, st_release has an initialized result variable but does nothing else with it but return it: int result = 0; ... return result; It ignores the do_door_lock -

Re: [PATCH v2 19/36] mac_scsi: Add module option to Kconfig

2014-11-09 Thread Hannes Reinecke
On 11/09/2014 01:17 PM, Finn Thain wrote: On Fri, 31 Oct 2014, Hannes Reinecke wrote: On 10/31/2014 08:17 AM, Finn Thain wrote: On Thu, 30 Oct 2014, Hannes Reinecke wrote: On 10/27/2014 06:26 AM, Finn Thain wrote: Allow mac_scsi to be built as a module. Replace the old validation of

Re: [PATCH v2 29/36] atari_NCR5380: Refactor Falcon locking

2014-11-09 Thread Hannes Reinecke
On 11/09/2014 01:18 PM, Finn Thain wrote: Ping... On Fri, 31 Oct 2014, Finn Thain wrote: On Thu, 30 Oct 2014, Hannes Reinecke wrote: On 10/27/2014 06:26 AM, Finn Thain wrote: Simplify falcon_release_lock_if_possible() by making callers responsible for disabling local IRQ's, which