3.16.7-ckt1 -stable review patch. If anyone has any objections, please let me
know.
--
From: Jan Kara j...@suse.cz
commit 84ce0f0e94ac97217398b3b69c21c7a62ebeed05 upstream.
When sg_scsi_ioctl() fails to prepare request to submit in
blk_rq_map_kern() we jump to a label where
On 10/11/14 11:37 pm, Minh Duc Tran minhduc.t...@emulex.com wrote:
Adding Vikas to verify if qla4xxx has the same issue.
On 11/10/2014 12:52 AM, Minh Duc Tran wrote:
From: Minh Tran minhduc.t...@emulex.com
mailto:minhduc.t...@emulex.com
We are starting to see problems with
On 11/09/2014 01:19 PM, Finn Thain wrote:
Ping...
Ok, disregard the .proc_name issue for now.
Reviewed-by: Hannes Reinecke h...@suse.de
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries Storage
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH,
On 11/10/2014 01:21 PM, sumit.sax...@avagotech.com wrote:
Do not process any SCSI and IOCTL command further(return them with
appropriate return values to callers),
while driver removal is in progress/PCI shutdown is invoked.
Signed-off-by: Sumit Saxena sumit.sax...@avagotech.com
On 11/10/2014 01:21 PM, sumit.sax...@avagotech.com wrote:
megaraid_sas driver version upgrade
Signed-off-by: Sumit Saxena sumit.sax...@avagotech.com
---
drivers/scsi/megaraid/megaraid_sas.h | 2 +-
drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
2 files changed, 2 insertions(+), 2
On 11/10/2014 01:21 PM, sumit.sax...@avagotech.com wrote:
This patch provides driver compatibility for updating firmware online to
upgrade legacy(64 VD) firmware to Extended VD firmware
and viceversa. Currently, at driver load time only, driver will check whether
Firmware is legacy or 240
On 11/10/2014 04:56 PM, Christoph Hellwig wrote:
Remove the ordered_tags field, we haven't been issuing ordered tags based
on it since the big barrier rework in 2010.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Bart Van Assche bvanass...@acm.org
Reviewed-by: Martin K. Petersen
On 11/10/2014 04:56 PM, Christoph Hellwig wrote:
Unless we want to build a SPI tag message we should just check SCMD_TAGGED
instead of reverse engineering a tag type through the use of
scsi_populate_tag_msg.
Also rename the function to spi_populate_tag_msg, make it behave like the
other spi
On 11/10/2014 04:56 PM, Christoph Hellwig wrote:
Remove the tagged argument from scsi_adjust_queue_depth, and just let it
handle the queue depth. For most drivers those two are fairly separate,
given that most modern drivers don't care about the SCSI tagged status
of a command at all, and
On 11/10/2014 04:56 PM, Christoph Hellwig wrote:
Now that we also get proper values in cmd-request-tag for untagged
commands, there is no need to force tagged_supported to on in drivers
that need host-wide tags.
Signed-off-by: Christoph Hellwig h...@lst.de
Reviewed-by: Hannes Reinecke
On 11/10/2014 04:56 PM, Christoph Hellwig wrote:
ufs never looks at the tag type, so there is no need to set it either.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/ufs/ufshcd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c
On Thu, Nov 06, 2014 at 04:34:13PM +0100, Christoph Hellwig wrote:
On Thu, Nov 06, 2014 at 09:21:05AM +0100, Hannes Reinecke wrote:
Hmm? Isn't there a scsi_put_comand() too many?
You dropped it from the 'if' branch, moved it out of
the condition, but kept in in the 'else' branch ...
The
On 10/11/2014 17:05, Christoph Hellwig wrote:
a) there is no multiath support for it, and we simply can't break existing
setups that use.
b) there is no support for I/O schedulers at all. This might be okay
for virtio-scsi, where in general you have a host scheduler, but for
-Original Message-
From: Hannes Reinecke [mailto:h...@suse.de]
Sent: Tuesday, 04 November, 2014 2:07 AM
...
diff --git a/drivers/scsi/scsi_logging.c
b/drivers/scsi/scsi_logging.c
...
@@ -0,0 +1,119 @@
+/*
+ * scsi_logging.c
+ *
+ * Copyright (C) 2014 SUSE Linux Products GmbH
+
On 11/11/2014 05:37 PM, Christoph Hellwig wrote:
On Thu, Nov 06, 2014 at 04:34:13PM +0100, Christoph Hellwig wrote:
On Thu, Nov 06, 2014 at 09:21:05AM +0100, Hannes Reinecke wrote:
Hmm? Isn't there a scsi_put_comand() too many?
You dropped it from the 'if' branch, moved it out of
the
On 11/11/2014 06:38 PM, Elliott, Robert (Server Storage) wrote:
-Original Message-
From: Hannes Reinecke [mailto:h...@suse.de]
Sent: Tuesday, 04 November, 2014 2:07 AM
...
diff --git a/drivers/scsi/scsi_logging.c
b/drivers/scsi/scsi_logging.c
...
@@ -0,0 +1,119 @@
+/*
+ *
[+cc Guenter, linux-scsi]
On Tue, Nov 11, 2014 at 4:33 PM, Barto mister.free...@laposte.net wrote:
Hello everyone,
I notice a bug since kernel 3.17 ( and also with 3.18 branch ), a random
hang at boot on some PC configurations, I did a git bisect and I found
that the culprit is :
3.10-stable review patch. If anyone has any objections, please let me know.
--
From: Jan Kara j...@suse.cz
commit 84ce0f0e94ac97217398b3b69c21c7a62ebeed05 upstream.
When sg_scsi_ioctl() fails to prepare request to submit in
blk_rq_map_kern() we jump to a label where we just
3.14-stable review patch. If anyone has any objections, please let me know.
--
From: Jan Kara j...@suse.cz
commit 84ce0f0e94ac97217398b3b69c21c7a62ebeed05 upstream.
When sg_scsi_ioctl() fails to prepare request to submit in
blk_rq_map_kern() we jump to a label where we just
On 11/11/2014 04:17 PM, Bjorn Helgaas wrote:
[+cc Guenter, linux-scsi]
On Tue, Nov 11, 2014 at 4:33 PM, Barto mister.free...@laposte.net wrote:
Hello everyone,
I notice a bug since kernel 3.17 ( and also with 3.18 branch ), a random
hang at boot on some PC configurations, I did a git bisect
3.17-stable review patch. If anyone has any objections, please let me know.
--
From: Jan Kara j...@suse.cz
commit 84ce0f0e94ac97217398b3b69c21c7a62ebeed05 upstream.
When sg_scsi_ioctl() fails to prepare request to submit in
blk_rq_map_kern() we jump to a label where we just
From 5fdb4203c09d6896e7b71a8f839e46e84234eeb9 Mon Sep 17 00:00:00 2001
From: Charles Chiou charles.ch...@tw.promise.com
Date: Wed, 5 Nov 2014 14:18:43 +0800
Subject: [PATCH 1/4] scsi:stex.c Support to Pegasus series.
Pegasus is a high performace hardware RAID solution designed to unleash
the
From 070dfd671f4cefb2d54563b77b9c80a8c82f260a Mon Sep 17 00:00:00 2001
From: Charles Chiou charles.ch...@tw.promise.com
Date: Wed, 5 Nov 2014 17:18:37 +0800
Subject: [PATCH 2/4] scsi:stex.c Add hotplut support
1. Add hotplug support. Pegasus support surprise remove. To this, I
use
From 5eac0f3209e0857c983c986786a68eac0d67247b Mon Sep 17 00:00:00 2001
From: Charles Chiou charles.ch...@tw.promise.com
Date: Wed, 5 Nov 2014 19:29:46 +0800
Subject: [PATCH 3/4] scsi:stex.c Add reboot support
1. Add reboot support, Pegasus devices should be notified that
the host is going to
From d0bc6b814e5a16bea639bbdfad992a5593bf3420 Mon Sep 17 00:00:00 2001
From: Charles Chiou charles.ch...@tw.promise.com
Date: Fri, 7 Nov 2014 10:15:18 +0800
Subject: [PATCH 4/4] scsi:stex.c Add S3/S4 support
1. Add S3/S4 support, add .suspend and .resume function in pci_driver.
2. Pegasus take
After moving from from branch next-20141106 to next-2014 to pick up recent
changes to the st driver I found that the following message was being logged by
the kernel (for many other modules as well):
Driver 'st' needs an owner
There was a change in driver_register to check the struct
Some macros are never evaluated (i.e. FOO, USLEEP, SCSI2 and USE_WRAPPER;
and in some drivers, NCR5380_intr and NCR5380_proc_info). DRIVER_SETUP
serves no purpose anymore. Remove these macro definitions.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes Reinecke
Some __setup() options mentioned in Documentation/scsi don't work because
a few lines of code went missing sometime since Linux 2.4. Fix the options
and thus fix some compiler warnings for both the non-modular case,
CC drivers/scsi/dtc.o
drivers/scsi/dtc.c:176:20: warning: 'dtc_setup'
This patch series has fixes for bugs and compiler warnings as well as code
cleanup and modernization. It covers all ten NCR5380 drivers and the three
core NCR5380 drivers so it's fairly large.
These patches remove a lot of duplicated code and C pre-processor abuse.
There are also patches for
Remove unused fields from hostdata structs declared with the
NCR5380_implementation_fields macro.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/dmx3191d.c |4 ++--
drivers/scsi/mac_scsi.c | 33
Having defined NDEBUG, and having set the console log level, I'd like to see
some output. Don't use pr_debug(), it's annoying to have to define DEBUG as
well.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes Reinecke h...@suse.de
Tested-by: Michael Schmitz
Make use of the host template static initializer instead of assigning
handlers at run-time. Move __maybe_unused qualifiers from declarations
to definitions. Move the atari_scsi_bus_reset() wrapper after the
definition of NCR5380_bus_reset(). All of the host template handler
prototypes are now
Both atari_NCR5380.c and sun3_NCR5380.c core drivers #undef TAG_NONE and
then redefine it. But the original definition is unused because NCR5380.c
lacks support for tagged queueing. So just define it once.
The TAG_NEXT macro only appears in the arguments to NCR5380_select() calls.
But that
Every NCR5380 driver sets AUTOSENSE so it need not be optional (and the
mid-layer expects it). Remove this redundant macro to improve readability.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes Reinecke h...@suse.de
Tested-by: Michael Schmitz schmitz...@gmail.com
---
Convert mac_scsi to platform device and eliminate scsi_register().
Platform resources for chip registers now follow the documentation. This
should fix issues with the Mac IIci (and possibly other models too).
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes Reinecke
Convert atari_scsi to platform device and eliminate scsi_register().
Validate __setup options later on so that module options are checked as well.
Remove the comment about the scsi mid-layer disabling the host irq as it
is no longer true (AFAICT). Also remove the obsolete slow interrupt stuff
Compile-time override of scsi host defaults is pointless for drivers that
provide module parameters and __setup options for that. Too many macros make
the code hard to read so remove them.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes Reinecke h...@suse.de
Tested-by:
Convert Scsi_Cmnd to struct scsi_cmnd and drop the #include scsi.h.
The sun3_NCR5380.c core driver already uses struct scsi_cmnd so converting
the other core drivers reduces the diff which makes them easier to unify.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes
Add missing static qualifiers and remove the now pointless prototypes. The
NCR5380_* prototypes are all declared in NCR5380.h and renamed using macros.
Further declarations are redundant (some are completely unused). Remove
them.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by:
Simplify falcon_release_lock_if_possible() by making callers responsible for
disabling local IRQ's, which they must do anyway to correctly synchronize
the ST DMA lock with core driver data structures. Move this
synchronization logic to the core driver with which it is tightly coupled.
Other LLD's
There's no need to run the cmd-done callback for aborted commands. Remove
the old EH code and the RESET_RUN_DONE macro.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes Reinecke h...@suse.de
Tested-by: Michael Schmitz schmitz...@gmail.com
---
drivers/scsi/atari_NCR5380.c
The #defines in sun3_scsi.h are intended to influence subsequent #includes
in sun3_scsi.c. IMHO, that's too convoluted.
Move sun3_scsi.h macro definitions to sun3_scsi.c, consistent with other
NCR5380 drivers.
Omit the unused NCR5380_local_declare() and NCR5380_setup() macros.
Signed-off-by:
If the host-info() method is not set, then host-name is used by default.
For atari_scsi, that is exactly the same text. So remove the redundant
info() method. Keep sun3_scsi.c in line with atari_scsi.
Some NCR5380 drivers return an empty string from the info() method
(arm/cumana_1.c arm/oak.c
The NCR5380_STATS option is only enabled by g_NCR5380 yet it adds
clutter to all three core drivers. The atari_NCR5380.c and sun3_NCR5380.c
core drivers have a slightly different implementation of the
NCR5380_STATS option.
Out of all ten NCR5380 drivers, only one of them (g_NCR5380) actually
has
The static variable setup_use_tagged_queuing is declared in mac_scsi.c,
sun3_scsi.c and atari_scsi.c and doesn't belong in the core driver.
None of the other NCR5380 drivers suffer from this layering issue which
makes merging the core drivers more difficult and will likely hinder plans
for future
Signed-off-by: Finn Thain fth...@telegraphics.com.au
---
drivers/scsi/atari_NCR5380.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
Index: linux/drivers/scsi/atari_NCR5380.c
===
---
The #defines in atari_scsi.h are intended to influence subsequent #includes
in atari_scsi.c. IMHO, that's too convoluted.
Remove atari_scsi.h by moving those macro definitions to atari_scsi.c,
consistent with other NCR5380 drivers.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Static variables from dtc.c and pas16.c should not appear in the core
NCR5380.c driver. Aside from being a layering issue this worsens the
divergence between the three core driver variants (atari_NCR5380.c and
sun3_NCR5380.c don't support PSEUDO_DMA) and it can mean multiple hosts
share the same
Testing shows that the Domex 3191D card never asserts its IRQ. Hence it is
non-functional with Linux (worse, the EH bugs in the core driver are fatal
but that's a problem for another patch). Perhaps the DT-536 chip needs
special setup? I can't find documentation for it. The NetBSD driver uses
Given the preceding changes to atari_NCR5380.c, this patch should not change
behaviour of the sun3_scsi and sun3_scsi_vme modules.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes Reinecke h...@suse.de
---
MAINTAINERS |1
drivers/scsi/sun3_NCR5380.c
Allow mac_scsi to be built as a module. Replace the old validation of
__setup options with code that validates both module and __setup options.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/Kconfig|2
Convert sun3_scsi to platform device and eliminate scsi_register().
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes Reinecke h...@suse.de
Acked-by: Geert Uytterhoeven ge...@linux-m68k.org
---
Changes since v1:
- Use NO_IRQ instead of IRQ_NONE.
- Move device IRQ and
Unlike NCR5380.c, the atari_NCR5380.c core driver is limited to a single
instance because co-routine state is stored globally.
Fix this by removing the static scsi host pointer. For the co-routine,
obtain this pointer from the work_struct pointer instead. For the interrupt
handler, obtain it from
atari_NCR5380.c enables its IRQ when it is already enabled. Sun3 doesn't
use the ENABLE_IRQ/DISABLE_IRQ cruft. Remove it.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes Reinecke h...@suse.de
Tested-by: Michael Schmitz schmitz...@gmail.com
---
Fix whitespace, remove pointless volatile qualifiers and improve code style
by use of INPUT_DATA_REG and OUTPUT_DATA_REG macros.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/mac_scsi.c | 122
The NCR5380.c core driver has moved on since the atari_NCR5380.c fork.
Some of those changes are also relevant to atari_NCR5380.c so apply them
there as well.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes Reinecke h...@suse.de
Tested-by: Michael Schmitz
There is very little difference between the sun3_NCR5380.c core driver
and atari_NCR5380.c. The former is a fork of the latter.
Merge the sun3_NCR5380.c core driver into atari_NCR5380.c so that
sun3_scsi.c can adopt the latter and the former can be deleted.
Signed-off-by: Finn Thain
The LIMIT_TRANSFERSIZE, PSEUDO_DMA, PARITY and UNSAFE options are all
documented in the core drivers where they are used. The same goes for the
chip databook reference. Remove the duplicate comments.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes Reinecke h...@suse.de
The *_RELEASE macros don't tell me anything. In some cases the version in
the macro contradicts the version in the comments. Anyway, the Linux kernel
version is sufficient information. Remove these macros to improve readability.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by:
Don't disable irqs when waiting for the ST DMA lock; its release may
require an interrupt.
Introduce stdma_try_lock() for use in soft irq context. atari_scsi now tells
the SCSI mid-layer to defer queueing a command if the ST DMA lock is not
available, as per Michael's patch:
The #defines in mac_scsi.h are intended to influence subsequent #includes in
mac_scsi.c. IMHO, that's too convoluted.
Remove mac_scsi.h by moving those macro definitions to mac_scsi.c,
consistent with other NCR5380 drivers.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes
Make the atari_NCR5380.c core driver usable by sun3_scsi, mac_scsi and
others by moving some of the Falcon-specific code out of the core driver:
!IS_A_TT, atari_read_overruns and falcon_dont_release. Replace these with
hostdata variables and flags. FLAG_CHECK_LAST_BYTE_SENT is unused in
Oak scsi doesn't use any IRQ, but it sets irq = IRQ_NONE rather than
SCSI_IRQ_NONE. Problem is, the core NCR5380 driver expects SCSI_IRQ_NONE
if it is to issue IDENTIFY commands that prevent target disconnection.
And, as Geert points out, IRQ_NONE is part of enum irqreturn.
Other drivers, when
The atari_NCR5380.c core driver keeps some per-host data in a static
variable which limits the driver to a single instance. Fix this by moving
TagAlloc to the hostdata struct.
Signed-off-by: Finn Thain fth...@telegraphics.com.au
Reviewed-by: Hannes Reinecke h...@suse.de
Tested-by: Michael Schmitz
64 matches
Mail list logo
