I'm tempted to merge this into drivers-for-3.19 ASAP, any argument against
that? Guennadi, do you have any additional hardware to Hannes one real and one
virtual adapter to test this new driver on before?
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a
On Fri, Nov 21, 2014 at 02:56:00PM -0500, David Miller wrote:
I would suggest looking into the possibility that we allocate the memory
using the count of valid cpus, rather than the largest cpu number.
That's a common error that runs into problems with discontiguous
cpu numbering like Sparc
On 11/24/2014 09:14 AM, Christoph Hellwig wrote:
I'm tempted to merge this into drivers-for-3.19 ASAP, any argument against
that? Guennadi, do you have any additional hardware to Hannes one real and
one
virtual adapter to test this new driver on before?
Certainly not from me :-)
It would
Don't duplicate the code to handle the not cpu bounce case in the
caller, do it inside blk_mq_hctx_next_cpu instead.
Signed-off-by: Christoph Hellwig h...@lst.de
---
block/blk-mq.c | 31 ++-
1 file changed, 10 insertions(+), 21 deletions(-)
diff --git
We now first try to call -eh_abort_handler from a work queue, but libsas
was always failing that for no good reason. Allow async aborts.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/libsas/sas_scsi_host.c | 3 ---
1 file changed, 3 deletions(-)
diff --git
The task_collector mode (or latency_injector, (C) Dan Willians) is an
optional I/O path in libsas that queues up scsi commands instead of
directly sending it to the hardware. It generall increases latencies
to in the optiomal case slightly reduce mmio traffic to the hardware.
Only the obsolete
Any chance to get a review for this one?
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/24/2014 09:41 AM, Christoph Hellwig wrote:
The task_collector mode (or latency_injector, (C) Dan Willians) is an
optional I/O path in libsas that queues up scsi commands instead of
directly sending it to the hardware. It generall increases latencies
to in the optiomal case slightly
On 11/24/2014 09:40 AM, Christoph Hellwig wrote:
We now first try to call -eh_abort_handler from a work queue, but libsas
was always failing that for no good reason. Allow async aborts.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/libsas/sas_scsi_host.c | 3 ---
1 file
Why did you not remove the last argument from asd_can_queue() and
asd_can_dequeue(), too?
With that patch it's always '1' ...
Because I wanted to remove the libsas (mis-)feature and avoid to many boad
driver changes. Especially for a unmaintained big driver like aic94xx.
This 'while' loop
On 10/23/2014 10:33 PM, Douglas Gilbert wrote:
Changing a frequently hacked, big switch parser to being table
based is, of necessity, not a small patch. Testing showed up
some breakages which required extra code and re-factoring.
Since supporting the REPORT SUPPORTED OPERATION CODES command,
On 11/24/2014 09:54 AM, Christoph Hellwig wrote:
Why did you not remove the last argument from asd_can_queue() and
asd_can_dequeue(), too?
With that patch it's always '1' ...
Because I wanted to remove the libsas (mis-)feature and avoid to many boad
driver changes. Especially for a
On Thu, Nov 20, 2014 at 07:27:49PM +0100, Barto wrote:
but the sata DVD burner is now connected on a Jmicron sata PCIe card (
with this configuration the bug doesn't occur ), I don't know if this
change can modify the result of your command,
here is the result of another command :
$ for i
The annual Linux Storage, Filesystem and Memory Management Summit for
2015 will be held on March 9th and 10th before the Linux Foundation Vault
conference at the Revere Hotel, Boston MA. For those that do not know,
Vault is designed to be an event where open source storage and filesystem
Hi,
sorting out some diffs between the official Arcea driver and
the newest 3.18 patches I found a patch that might got lost:
https://lkml.org/lkml/2014/2/20/956
Could you check if that is desired?
Thanks in advance.
Markus
Note: for consistency, and to avoid sparse errors,
convert all fields, even those no longer in use
for virtio v1.0.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
include/linux/virtio_scsi.h | 32 +++-
drivers/scsi/virtio_scsi.c | 51
Introduce wd719x, a driver for Western Digital WD7193, WD7197 and WD7296 PCI
SCSI controllers based on WD33C296A chip.
Tested with WD7193 card.
Reviewed-by: Christoph Hellwig h...@lst.de
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
drivers/scsi/Kconfig |8 +
Add read-only support for EEPROMs configured in 8-bit mode (ORG pin connected
to GND).
This will be used by wd719x driver.
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
drivers/misc/eeprom/eeprom_93cx6.c | 62 +++-
include/linux/eeprom_93cx6.h
Hello,
this is a new driver for Western Digital WD7193, WD7197 and WD7296 PCI SCSI
controllers based on WD33C296A chip. These nice cards never worked good with
Linux.
It's based on old and ugly wd719x driver written back in 2.0 days, then hacked
to 2.2 and finally to 2.4 kernels. Most of the
Add documentation and script to obtain required firmware.
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
Documentation/scsi/wd719x.txt | 21 +
1 file changed, 21 insertions(+)
create mode 100644 Documentation/scsi/wd719x.txt
diff --git
On 11/24/2014 01:11 PM, Ondrej Zary wrote:
Add read-only support for EEPROMs configured in 8-bit mode (ORG pin connected
to GND).
This will be used by wd719x driver.
Signed-off-by: Ondrej Zary li...@rainbow-software.org
Reviewed-by: Hannes Reinecke h...@suse.de
Cheers,
Hannes
--
Dr.
On 11/24/2014 01:11 PM, Ondrej Zary wrote:
Introduce wd719x, a driver for Western Digital WD7193, WD7197 and WD7296 PCI
SCSI controllers based on WD33C296A chip.
Tested with WD7193 card.
Reviewed-by: Christoph Hellwig h...@lst.de
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
On Mon, Nov 24, 2014 at 11:47:02AM +, Markus Stockhausen wrote:
Hi,
sorting out some diffs between the official Arcea driver and
the newest 3.18 patches I found a patch that might got lost:
https://lkml.org/lkml/2014/2/20/956
Could you check if that is desired?
Looks sensible to
Can someone give me a review for this patch as well? Fortuately the
driver seems incredibly simple.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Can someone review this trivial patch for me? Thanks!
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Von: linux-scsi-ow...@vger.kernel.org
[linux-scsi-ow...@vger.kernel.org]quot; im Auftrag von quot;Christoph
Hellwig [h...@infradead.org]
Gesendet: Montag, 24. November 2014 14:23
An: Markus Stockhausen
Cc: ching2...@areca.com.tw; the...@redhat.com; linux-scsi@vger.kernel.org
Betreff: Re:
+/*
+ * AMD am53c974 driver.
+ * Copyright (c) 2014 Hannes Reinecke, SUSE Linux GmbH
+ */
Is there anything left from the old driver that should get credit here?
+#define PCI_ESP_GET_PRIV(esp) ((struct pci_esp_priv *) \
+pci_get_drvdata((struct pci_dev *) \
+
On 11/24/2014 02:50 PM, Christoph Hellwig wrote:
+/*
+ * AMD am53c974 driver.
+ * Copyright (c) 2014 Hannes Reinecke, SUSE Linux GmbH
+ */
Is there anything left from the old driver that should get credit here?
Hmm. I copied the EEprom handling more-or-less verbatim from the
tmscsim
As far as I can tell the queue tracking in the bfa driver is a copypaste
copy of the midlayer version, just without support to configure it through
sysfs.
Remove the bfa copy and rely on the mid layer version.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/bfa/bfad_im.c | 66
A read to ESP_INTRPT will clear ESP_STATUS and ESP_SSTEP. So read
all status registers in one go to avoid losing information.
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
Acked-by: David S. Miller da...@davemloft.net
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/esp_scsi.c | 8
Since we got rid of ordered tag support in 2010 the prime use case of
switching on and off ordered tags has been obsolete. The other function
of enabling/dsiabling tagging entirely has only been correctly implemented
by the 53c700 driver and isn't generally useful.
Signed-off-by: Christoph
Hi all,
having found some issues with the current tmscsim driver
I looked at the code and found is really awkward to clean
up.
Seeing that the am53c974 chip is actually based on the
'ESP' chip design I've re-implemented it based on the
common esp_scsi routines. This new driver
(cunningly named
The am53c974 has an design issue where a single byte might be
left in the SCSI FIFO after a DMA transfer.
As the handling code is currently untested add a WARN_ON()
statement here.
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
Acked-by: David S. Miller da...@davemloft.net
Signed-off-by: Hannes
Add new debug definitions for event and command logging.
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
Acked-by: David S. Miller da...@davemloft.net
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/esp_scsi.c | 15 +++
1 file changed, 15 insertions(+)
diff --git
Both remaining users are better of just checking sdev-simple_tags
directly.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/53c700.c | 4 ++--
drivers/scsi/ipr.c | 2 +-
include/scsi/scsi_tcq.h | 13 -
3 files changed, 3 insertions(+), 16 deletions(-)
diff
From: Paolo Bonzini pbonz...@redhat.com
On PCscsi, the FENAB configuration also enables 24-bit DMA
transfer lengths (and provides the chip id in TCHI after reset).
We want to be able to enable this parameter from the DMA driver.
Check if the caller of scsi_esp_register provided a value for
The am53c974 returns the same ID as the FAS236, but implements
things slightly differently. So detect the am53c974 by checking
for ESP_CONFIG4 register.
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/am53c974.c | 2 ++
Use dev_printk functions for correct device annotations.
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
Acked-by: David S. Miller da...@davemloft.net
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/esp_scsi.c | 212
1 file changed,
Using DMA for command submission has the drawback that it might
generate additional DMA completion interrupts after the command
has been submitted to the device.
Additionally the am53c974 has a design flaw causing it
to generate spurious interrupts even though DMA completion
interrupts are not
Add a field 'num_tags' to the esp structure to allow drivers
to overwrite the number of avialable tags if required.
Default is ESP_DEFAULT_TAGS.
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
Acked-by: David S. Miller da...@davemloft.net
Signed-off-by: Hannes Reinecke h...@suse.de
---
There is no benefit over just setting sdev-simple_tags directly.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/scsi/53c700.c | 2 +-
drivers/scsi/tmscsim.c | 2 +-
include/scsi/scsi_tcq.h | 15 ---
3 files changed, 2 insertions(+), 17 deletions(-)
diff --git
Dropping to untagged mode when ramping down a queue due to QUEUE FULL
events has two problems:
- nothing in the midlayer or drivers ever moves back to tagged mode
during queue ramp up.
- cmd_per_lun isn't the untagged queue depth for many modern drivers
that can handle multiple untagged
These are a few patches that follow up my previous cleanups for the
queue depth and type handling.
The first patch removes the now pointless write support for the queue_type
sysfs attribute. The second changes the queue full tracking code to
never drop out of tagged mode, as we can't recover
CONFIG2_FENAB ('feature enable') changed definition between chip
revisions, from 'Latch SCSI Phase' to 'Latch SCSI Phase, display
chip ID upon reset, and enable 24 bit addresses'.
So only enable it for am53c974 where we know what it's doing.
Acked-by: David S. Miller da...@davemloft.net
This patch adds a new implementation for the Tekram DC-390T /
AMD AM53c974 SCSI controller, based on the generic
esp_scsi infrastructure.
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/Kconfig| 18 ++
drivers/scsi/Makefile | 1
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
Acked-by: David S. Miller da...@davemloft.net
Signed-off-by: Hannes Reinecke h...@suse.de
---
drivers/scsi/esp_scsi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/esp_scsi.h b/drivers/scsi/esp_scsi.h
index
On 11/24/2014 01:27 AM, Christoph Hellwig wrote:
Don't duplicate the code to handle the not cpu bounce case in the
caller, do it inside blk_mq_hctx_next_cpu instead.
Thanks, applied.
--
Jens Axboe
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message
Thanks,
applied to drivers-for-3.19.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/24/2014 02:45 PM, Markus Stockhausen wrote:
Von: linux-scsi-ow...@vger.kernel.org
[linux-scsi-ow...@vger.kernel.org]quot; im Auftrag von quot;Christoph
Hellwig [h...@infradead.org]
Gesendet: Montag, 24. November 2014 14:23
An: Markus Stockhausen
Cc: ching2...@areca.com.tw;
On 11/24/2014 01:21 AM, Christoph Hellwig wrote:
On Fri, Nov 21, 2014 at 02:56:00PM -0500, David Miller wrote:
I would suggest looking into the possibility that we allocate the memory
using the count of valid cpus, rather than the largest cpu number.
That's a common error that runs into
On Mon, Nov 24, 2014 at 04:33:55PM +0100, Hannes Reinecke wrote:
The megaraid SAS driver uses a shared host tag map internally,
so we should be telling the block layer about it.
But it doesn't make use of request-tag yet. This would only be
useful if you got rid of the internal tag allocator.
On Mon, 2014-11-24 at 05:40 -0800, Christoph Hellwig wrote:
Can someone review this trivial patch for me? Thanks!
I don't really think we need reviewers for trivial patches, do we?
However, the patch is clearly bogus. What's supposed to happen is that
the unset variables (size and offs) get
On 11/12/14 11:45, Christoph Hellwig wrote:
FYI, I've updated this to use .use_blk_tags = 1 isntead of
scsi_activate_tcq now that I've rebased the drivers-for-3.19 branch
over the tcq rework. Please verify that it's workign as intented.
[ just arrived home from traveling ]
Hello Christoph,
On 11/24/2014 04:35 PM, Christoph Hellwig wrote:
On Mon, Nov 24, 2014 at 04:33:55PM +0100, Hannes Reinecke wrote:
The megaraid SAS driver uses a shared host tag map internally,
so we should be telling the block layer about it.
But it doesn't make use of request-tag yet. This would only be
-Original Message-
From: Christoph Hellwig [mailto:h...@lst.de]
Sent: Monday, November 24, 2014 9:06 PM
To: Hannes Reinecke
Cc: James Bottomley; Sumit Saxena; Kashyap Desai; Christoph Hellwig;
linux-
s...@vger.kernel.org
Subject: Re: [PATCH] megaraid_sas: Enable shared host tag map
On 11/24/2014 04:39 PM, James Bottomley wrote:
On Mon, 2014-11-24 at 05:40 -0800, Christoph Hellwig wrote:
Can someone review this trivial patch for me? Thanks!
I don't really think we need reviewers for trivial patches, do we?
However, the patch is clearly bogus. What's supposed to
-Original Message-
From: Hannes Reinecke [mailto:h...@suse.de]
Sent: Monday, November 24, 2014 9:21 PM
To: Christoph Hellwig
Cc: James Bottomley; Sumit Saxena; Kashyap Desai; linux-
s...@vger.kernel.org
Subject: Re: [PATCH] megaraid_sas: Enable shared host tag map
On 11/24/2014
On 11/24/2014 02:40 PM, Christoph Hellwig wrote:
Can someone review this trivial patch for me? Thanks!
The compiler complains because when asd_find_flash_de fails, the offs is not
initialized.
When that happens this code is invoked :
if (err) {
ASD_DPRINTK(couldn't find
On Mon, 2014-11-24 at 17:04 +0100, Tomas Henzl wrote:
On 11/24/2014 02:40 PM, Christoph Hellwig wrote:
Can someone review this trivial patch for me? Thanks!
The compiler complains because when asd_find_flash_de fails, the offs is not
initialized.
When that happens this code is invoked :
On Mon, Nov 24, 2014 at 08:35:46AM -0700, Jens Axboe wrote:
On 11/24/2014 01:21 AM, Christoph Hellwig wrote:
On Fri, Nov 21, 2014 at 02:56:00PM -0500, David Miller wrote:
I would suggest looking into the possibility that we allocate the memory
using the count of valid cpus, rather than the
On 11/24/2014 05:10 PM, James Bottomley wrote:
On Mon, 2014-11-24 at 17:04 +0100, Tomas Henzl wrote:
On 11/24/2014 02:40 PM, Christoph Hellwig wrote:
Can someone review this trivial patch for me? Thanks!
The compiler complains because when asd_find_flash_de fails, the offs is not
On Mon, Nov 24, 2014 at 12:41 AM, Christoph Hellwig h...@lst.de wrote:
The task_collector mode (or latency_injector, (C) Dan Willians) is an
optional I/O path in libsas that queues up scsi commands instead of
directly sending it to the hardware. It generall increases latencies
to in the
From: Markus Elfring elfr...@users.sourceforge.net
Date: Mon, 24 Nov 2014 15:35:48 +0100
A word was corrected in the description for
the sci_remote_device_destruct() function.
Signed-off-by: Markus Elfring elfr...@users.sourceforge.net
---
drivers/scsi/isci/remote_device.c | 2 +-
1 file
From: Markus Elfring elfr...@users.sourceforge.net
Date: Mon, 24 Nov 2014 15:40:41 +0100
Identifiers were corrected in descriptions for the functions
fc_fcp_pkt_destroy() and fc_fcp_destroy().
Signed-off-by: Markus Elfring elfr...@users.sourceforge.net
---
drivers/scsi/libfc/fc_fcp.c | 4 ++--
On 11/24/2014 09:22 AM, Paul E. McKenney wrote:
On Mon, Nov 24, 2014 at 08:35:46AM -0700, Jens Axboe wrote:
On 11/24/2014 01:21 AM, Christoph Hellwig wrote:
On Fri, Nov 21, 2014 at 02:56:00PM -0500, David Miller wrote:
I would suggest looking into the possibility that we allocate the memory
On Mon, Nov 24, 2014 at 10:16:15AM -0700, Jens Axboe wrote:
On 11/24/2014 09:22 AM, Paul E. McKenney wrote:
On Mon, Nov 24, 2014 at 08:35:46AM -0700, Jens Axboe wrote:
On 11/24/2014 01:21 AM, Christoph Hellwig wrote:
On Fri, Nov 21, 2014 at 02:56:00PM -0500, David Miller wrote:
I would
On 11/24/2014 10:31 AM, Paul E. McKenney wrote:
On Mon, Nov 24, 2014 at 10:16:15AM -0700, Jens Axboe wrote:
On 11/24/2014 09:22 AM, Paul E. McKenney wrote:
On Mon, Nov 24, 2014 at 08:35:46AM -0700, Jens Axboe wrote:
On 11/24/2014 01:21 AM, Christoph Hellwig wrote:
On Fri, Nov 21, 2014 at
On Mon, Nov 24, 2014 at 10:33:37AM -0700, Jens Axboe wrote:
On 11/24/2014 10:31 AM, Paul E. McKenney wrote:
On Mon, Nov 24, 2014 at 10:16:15AM -0700, Jens Axboe wrote:
On 11/24/2014 09:22 AM, Paul E. McKenney wrote:
On Mon, Nov 24, 2014 at 08:35:46AM -0700, Jens Axboe wrote:
On 11/24/2014
Dear Sir
Did your website get hit by Google Penguin update on October 17th 2014? What
basically is Google Penguin Update? It is actually a code name for Google
algorithm which aims at decreasing your websites search engine rankings that
violate Googles guidelines by using black hat SEO
Von: Tomas Henzl [the...@redhat.com]
Gesendet: Montag, 24. November 2014 15:47
An: Markus Stockhausen; Christoph Hellwig
Cc: ching2...@areca.com.tw; linux-scsi@vger.kernel.org
Betreff: Re: AW: ARCMSR - Notify sense data report - Lost patch?
On 11/24/2014 02:45 PM, Markus Stockhausen wrote:
-Original Message-
From: Christoph Hellwig [mailto:h...@infradead.org]
Sent: Thursday, November 20, 2014 9:55 AM
To: Don Brace
Cc: h...@infradead.org; webb.sca...@hp.com;
james.bottom...@parallels.com; brace; linux-scsi@vger.kernel.org
Subject: Re: [PATCH 00/13] hpsa update
I've
Looks good to me.
Reviewed-by: Subhash Jadavani subha...@codeaurora.org
-Original Message-
From: linux-scsi-ow...@vger.kernel.org
[mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Akinobu Mita
Sent: Sunday, November 23, 2014 9:24 PM
To: linux-scsi@vger.kernel.org
Cc: Akinobu Mita;
On Monday 24 November 2014 14:15:47 Hannes Reinecke wrote:
On 11/24/2014 01:11 PM, Ondrej Zary wrote:
Introduce wd719x, a driver for Western Digital WD7193, WD7197 and WD7296
PCI SCSI controllers based on WD33C296A chip.
Tested with WD7193 card.
Reviewed-by: Christoph Hellwig
Acked-by: Bradley Grove bgr...@attotech.com
Thanks,
Brad
On 11/16/2014 08:35 AM, Tomas Henzl wrote:
The patch moves an error code assigment to a 'default' case
in the previous switch statement.
Signed-off-by: Tomas Henzl the...@redhat.com
---
drivers/scsi/esas2r/esas2r_ioctl.c | 5 -
1
Acked-by: Bradley Grove bgr...@attotech.com
Thanks,
Brad
On 11/16/2014 08:35 AM, Tomas Henzl wrote:
Is seems strange to manipulate nvram_semaphore when in this place,
this patch fixes it.
Signed-off-by: Tomas Henzl the...@redhat.com
---
drivers/scsi/esas2r/esas2r_ioctl.c | 7 ---
1
Acked-by: Bradley Grove bgr...@attotech.com
Thanks,
Brad
On 11/16/2014 08:35 AM, Tomas Henzl wrote:
The patch moves an error code assigment to a 'default' case
in the previous switch statement.
Signed-off-by: Tomas Henzl the...@redhat.com
---
drivers/scsi/esas2r/esas2r_ioctl.c | 5 -
1
Looks good.
Acked-by: Bradley Grove bgr...@attotech.com
Thanks,
Brad
On 11/16/2014 08:35 AM, Tomas Henzl wrote:
This patch fixes an error path and rearranges error handling.
Signed-off-by: Tomas Henzl the...@redhat.com
---
drivers/scsi/esas2r/esas2r_ioctl.c | 10 +-
1 file
From: Jens Axboe ax...@kernel.dk
Date: Mon, 24 Nov 2014 10:16:15 -0700
How about this one?
The num in num_possible_cpus() means a count, as in how many are
there.
It doesn't mean largest ID of members of set X, which is what you
are asking for.
Even worse, having num_online_cpus() and
On 11/24/2014 02:56 PM, David Miller wrote:
From: Jens Axboe ax...@kernel.dk
Date: Mon, 24 Nov 2014 10:16:15 -0700
How about this one?
The num in num_possible_cpus() means a count, as in how many are
there.
It doesn't mean largest ID of members of set X, which is what you
are asking for.
From: Jens Axboe ax...@kernel.dk
Date: Mon, 24 Nov 2014 15:01:55 -0700
I'll just updated blk-mq to use nr_cpu_ids and be done with it.
Wow, a grep on nr_cpu_ids gets a lot of hits on people allocating just
these kinds of tables :)
--
To unsubscribe from this list: send the line unsubscribe
On 11/24/2014 03:09 PM, David Miller wrote:
From: Jens Axboe ax...@kernel.dk
Date: Mon, 24 Nov 2014 15:01:55 -0700
I'll just updated blk-mq to use nr_cpu_ids and be done with it.
Wow, a grep on nr_cpu_ids gets a lot of hits on people allocating just
these kinds of tables :)
Yep! It'd be
Yes, that does look like the case. Do you have a good trick on how
to allocate a map for the highest possible cpu number without first
iterating the cpu map? I couldn't find something that looks like a
highest_possible_cpu() helper.
Honestly I think that num_posible_cpus()
Add documentation and script to obtain required firmware.
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
Documentation/scsi/wd719x.txt | 21 +
1 file changed, 21 insertions(+)
create mode 100644 Documentation/scsi/wd719x.txt
diff --git
Hello,
this is a new driver for Western Digital WD7193, WD7197 and WD7296 PCI SCSI
controllers based on WD33C296A chip. These nice cards never worked good with
Linux.
It's based on old and ugly wd719x driver written back in 2.0 days, then hacked
to 2.2 and finally to 2.4 kernels. Most of the
Add read-only support for EEPROMs configured in 8-bit mode (ORG pin connected
to GND).
This will be used by wd719x driver.
Signed-off-by: Ondrej Zary li...@rainbow-software.org
Reviewed-by: Hannes Reinecke h...@suse.de
---
drivers/misc/eeprom/eeprom_93cx6.c | 62
Introduce wd719x, a driver for Western Digital WD7193, WD7197 and WD7296 PCI
SCSI controllers based on WD33C296A chip.
Tested with WD7193 card.
Reviewed-by: Christoph Hellwig h...@lst.de
Signed-off-by: Ondrej Zary li...@rainbow-software.org
---
drivers/scsi/Kconfig |8 +
From: mr...@linux.ee
Date: Tue, 25 Nov 2014 00:23:20 +0200 (EET)
Yes, that does look like the case. Do you have a good trick on how
to allocate a map for the highest possible cpu number without first
iterating the cpu map? I couldn't find something that looks like a
Add a new file t4_pci_id_tbl.h that contains T4/T5 PCI ID Table so that for all
drivers that uses T4/T5 PCI functions changes can be done in one place.
checkpatch.pl script reports following error, which if tried to fix ends up in
compilation error.
ERROR: Macros with complex values
This series of patches is in response to Hannes' comments
earlier today. He wanted the single large patch broken up.
Changes since v1:
- break single big patch into 4 smaller ones and one less
large
- resync with drivers-for-3.19
Patches:
[PATCH v2 1/5] pinpoint invalid field in
Use Sense Key Specific field in the sense data of an ILLEGAL REQUEST
to optionally pinpoint the location of the problem field. This may
be either in the cdb or the associated parameter list.
---
drivers/scsi/scsi_debug.c | 138 +-
1 file changed, 88
From: Douglas Gilbert dgilb...@interlog.com
Date: Mon, 24 Nov 2014 21:27:12 -0500
Subject: [PATCH 5/5] Add Report supported opcodes+tmfs; Compare and write
The Report supported operation codes command is very closely integrated
into the table driven parser and very useful for testing it. Its cdb
From: Douglas Gilbert dgilb...@interlog.com
Date: Mon, 24 Nov 2014 20:46:29 -0500
Subject: [PATCH 4/5] change SCSI command parser to table driven
The existing 'big switch' parser in queuecommand() is changed to
a table driven parser. The old and new queuecommand() were moved
in the source so
From: Douglas Gilbert dgilb...@interlog.com
Date: Mon, 24 Nov 2014 20:18:02 -0500
Subject: [PATCH 2/5] append inject error flags onto scsi_cmnd object
The way the existing scsi_debug command parser associated various
inject error flags to a command was difficult to replicate in the
table driven
From: Douglas Gilbert dgilb...@interlog.com
Date: Mon, 24 Nov 2014 20:27:51 -0500
Subject: [PATCH 3/5] add Capacity Changed Unit Attention
Via sysfs the virtual_gb scsi_debug parameter can be changed while
LUs are in use. If that changes, the 'Capacity data has changed'
Unit Attention is queued
On 11/25/2014 05:04 AM, Douglas Gilbert wrote:
Use Sense Key Specific field in the sense data of an ILLEGAL REQUEST
to optionally pinpoint the location of the problem field. This may
be either in the cdb or the associated parameter list.
---
drivers/scsi/scsi_debug.c | 138
On 11/25/2014 05:05 AM, Douglas Gilbert wrote:
From: Douglas Gilbert dgilb...@interlog.com
Date: Mon, 24 Nov 2014 20:18:02 -0500
Subject: [PATCH 2/5] append inject error flags onto scsi_cmnd object
The way the existing scsi_debug command parser associated various
inject error flags to a
On 11/25/2014 05:05 AM, Douglas Gilbert wrote:
From: Douglas Gilbert dgilb...@interlog.com
Date: Mon, 24 Nov 2014 20:27:51 -0500
Subject: [PATCH 3/5] add Capacity Changed Unit Attention
Via sysfs the virtual_gb scsi_debug parameter can be changed while
LUs are in use. If that changes, the
On 11/25/2014 05:05 AM, Douglas Gilbert wrote:
+ case 0x53: /* XDWRITEREAD(10) */
+ ei_lba = 0;
+ lba = get_unaligned_be32(cmd + 2);
+ num = get_unaligned_be16(cmd + 7);
+ check_prot = false;
+ break;
Why not use
On 11/25/2014 05:05 AM, Douglas Gilbert wrote:
From: Douglas Gilbert dgilb...@interlog.com
Date: Mon, 24 Nov 2014 21:27:12 -0500
Subject: [PATCH 5/5] Add Report supported opcodes+tmfs; Compare and
write
The Report supported operation codes command is very closely integrated
into the table
99 matches
Mail list logo
