This is a set of ten fixes: 8 for UFS including four static checker
warnings, a potential null deref in the voltage regulator code, a race
on module unload, a ref counting fix on the well known LUNs which made
it impossible to remove the ufs module and fix to correct the
information in pwr_info. I
On Wed, 2014-11-26 at 14:58 +0100, Hannes Reinecke wrote:
> tcm_loop has the I_T nexus associated with the HBA. This causes
> commands to become misdirected if the HBA has more than one
> target portal group; any command is then being sent to the
> first target portal group instead of the correct o
The macros PRINTP/ANDP make the code harder to read and depend on a
specific identifier name in the surrounding scope. Nuke them.
Signed-off-by: Rasmus Villemoes
---
drivers/scsi/g_NCR5380.c | 66 ++--
1 file changed, 30 insertions(+), 36 deletions(-)
Using seq_printf to print a simple string is a lot more expensive than
it needs to be, since seq_puts exists. Replace seq_printf with
seq_puts when possible.
Signed-off-by: Rasmus Villemoes
---
drivers/scsi/advansys.c | 157
1 file changed, 77 ins
Using seq_printf to print a simple string is a lot more expensive than
it needs to be, since seq_puts exists. Replace seq_printf with
seq_puts when possible.
Signed-off-by: Rasmus Villemoes
---
drivers/scsi/aha152x.c | 252 -
1 file changed, 126 in
Using seq_printf to print a simple string is a lot more expensive than
it needs to be, since seq_puts exists. Replace seq_printf with
seq_puts when possible.
Signed-off-by: Rasmus Villemoes
---
drivers/scsi/BusLogic.c | 10 +-
drivers/scsi/NCR5380.c | 6 +++---
Consecutive seq_puts calls with literal strings may be replaced by a
single call, saving a little .text.
Signed-off-by: Rasmus Villemoes
---
drivers/scsi/advansys.c | 40 ++--
drivers/scsi/atp870u.c | 5 ++---
drivers/scsi/dc395x.c| 4 ++--
Using seq_putc to print a single character saves at least a strlen()
call and a memory access, and may also give a small .text reduction.
Signed-off-by: Rasmus Villemoes
---
drivers/scsi/NCR5380.c | 2 +-
drivers/scsi/advansys.c | 34 +-
The macro SPRINTF doesn't save a lot of typing or make the code more
readable, and depending on a specific identifier (m) in the
surrounding scope is generally frowned upon. Nuke it.
Signed-off-by: Rasmus Villemoes
---
drivers/scsi/NCR5380.c | 42 +++---
drivers/scsi/aha152x.c | 301
These patches mostly replace seq_printf with simpler and faster
equivalents, e.g. seq_printf(m, "something") => seq_puts(m,
"something") and seq_printf(m, "\n") => seq_putc(m, '\n). But before
my Coccinelle scripts could be unleashed I had to clean up some
unnecessary, and in the PRINTP case quite
On 14-11-28 04:05 PM, Randy Dunlap wrote:
On 11/26/14 11:55, Douglas Gilbert wrote:
From: Douglas Gilbert
Date: Wed, 26 Nov 2014 14:41:55 -0500
Subject: [PATCH] scsi_debug improve driver description in Kconfig
Try to give a more accurate driver description and some extra
useful information in
On 11/26/14 11:55, Douglas Gilbert wrote:
> From: Douglas Gilbert
> Date: Wed, 26 Nov 2014 14:41:55 -0500
> Subject: [PATCH] scsi_debug improve driver description in Kconfig
>
> Try to give a more accurate driver description and some extra
> useful information in less lines.
> ---
> drivers/scsi
On 11/24/14 15:36, Christoph Hellwig wrote:
Since we got rid of ordered tag support in 2010 the prime use case of
switching on and off ordered tags has been obsolete. The other function
of enabling/dsiabling tagging entirely has only been correctly implemented
by the 53c700 driver and isn't gene
On 11/24/14 16:07, Christoph Hellwig wrote:
index 6719a33..2c5ce48 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@@ -7921,9 +7921,9 @@ static int asc_build_req(struct asc_board *boardp, struct
scsi_cmnd *scp,
*/
if ((asc_dvc->cur_dvc_qng[scp->device->id] > 0
ibute;
>> #define ARCMSR_MAX_FREECCB_NUM 320
>> #define ARCMSR_MAX_OUTSTANDING_CMD 255
>> #endif
>> -#define ARCMSR_DRIVER_VERSION"v1.30.00.04-20140919"
>> +#define ARCMSR_DRIVER_VERSION
On 11/24/14 15:36, Christoph Hellwig wrote:
Both remaining users are better of just checking sdev->simple_tags
directly.
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo i
On 11/24/14 15:36, Christoph Hellwig wrote:
There is no benefit over just setting sdev->simple_tags directly.
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at htt
On 11/24/14 15:36, Christoph Hellwig wrote:
Dropping to untagged mode when ramping down a queue due to QUEUE FULL
events has two problems:
- nothing in the midlayer or drivers ever moves back to tagged mode
during queue ramp up.
- cmd_per_lun isn't the untagged queue depth for many moder
/arcmsr.h2014-11-28 10:54:30.0 +0800
> @@ -52,7 +52,7 @@ struct device_attribute;
> #define ARCMSR_MAX_FREECCB_NUM 320
> #define ARCMSR_MAX_OUTSTANDING_CMD 255
> #endif
> -#define ARCMSR_DRIVER_VERSION"v1.30.00.04-20140919"
> +#define AR
MAX_FREECCB_NUM 320
#define ARCMSR_MAX_OUTSTANDING_CMD 255
#endif
-#define ARCMSR_DRIVER_VERSION "v1.30.00.04-20140919"
+#define ARCMSR_DRIVER_VERSION "v1.30.00.05-20141128"
#define ARCMSR_SCSI_INITIATOR_ID
Thanks to Dan's advice and Hannes' suggestion.
I will revise and resubmit it later.
On Fri, 2014-11-28 at 12:17 +0300, Dan Carpenter wrote:
> On Fri, Nov 28, 2014 at 12:20:44PM +0800, Ching Huang wrote:
> > This patch is relative to
> > http://git.infradead.org/users/hch/scsi-queue.git/tree/refs/
From: Nicholas Bellinger
This patch adds support for dev_stat_cit as an external config_item_type
using TB_CIT_SETUP() helper macro, and sets only ct_group_ops following
existing code.
It updates target_core_make_subdev() + target_core_setup_dev_attrib_cit() +
struct target_backend_cits, and dro
From: Nicholas Bellinger
This helper macro adds the default set of 30 device attributes for
virtual devices from existing target_core_configfs.c code, and moves
the definitions into a single macro to create the structs necessary
for backend drivers.
It allows them to populate their own external
From: Nicholas Bellinger
Now that target_core_backend_configfs.h macros will be using these
se_dev_set attribute functions externally to allow backend drivers
to populate different attributes, go ahead and add EXPORT_SYMBOL()
for the existing default set of 30 device attributes.
Also update targ
From: Nicholas Bellinger
This patch adds a number of configfs e-attr macros following
what existing target_core_configfs.c code does for internal
target_backend_dev_attrib setup, and similar to how target
fabric drivers allow for external config_item_type + cit->ct_attrs.
assignment.
This is use
From: Nicholas Bellinger
This patch converts TCM-USER to use an external set of device attributes,
and utilizes target_core_backend_configfs.h macros to generate a default
set of configfs extended-attr handlers.
It calls target_core_setup_sub_cits() to setup the initial config_item_type
based on
From: Nicholas Bellinger
This patch adds support for dev_attrib_cit as an external config_item_type
using TB_CIT_SETUP() helper macro, and sets both ct_item_ops + ct_attr
following existing code.
It updates target_core_make_subdev() + target_core_setup_dev_attrib_cit() +
struct target_backend_ci
From: Nicholas Bellinger
This patch adds support for dev_wwn_cit as an external config_item_type
using TB_CIT_SETUP() helper macro, and sets both ct_item_ops + ct_attr
following existing code.
It updates target_core_make_subdev() + target_core_setup_dev_attrib_cit() +
struct target_backend_cits,
From: Nicholas Bellinger
This patch adds support for dev_pr_cit as an external config_item_type
using TB_CIT_SETUP() helper macro, and sets both ct_item_ops + ct_attr
following existing code.
It updates target_core_make_subdev() + target_core_setup_dev_attrib_cit() +
struct target_backend_cits,
From: Nicholas Bellinger
This patch adds support for dev_alua_tg_pt_gps_cit as an external
config_item_type
using TB_CIT_SETUP() helper macro, and sets only ct_group_ops following
existing code.
It updates target_core_make_subdev() + target_core_setup_dev_attrib_cit() +
struct target_backend_ci
From: Nicholas Bellinger
This patch converts RAMDISK to use an external set of device attributes,
and utilizes target_core_backend_configfs.h macros to generate a default
set of configfs extended-attr handlers.
It calls target_core_setup_sub_cits() to setup the initial config_item_type
based on
From: Nicholas Bellinger
This patch converts IBLOCK to use an external set of device attributes,
and utilizes target_core_backend_configfs.h macros to generate a default
set of configfs extended-attr handlers.
It calls target_core_setup_sub_cits() to setup the initial config_item_type
based on e
From: Nicholas Bellinger
Hi all,
This series addresses a long standing limitation going back to early
LIO v3.x days, where all TCM backend devices originally used local
scope struct config_item_types in target_core_configfs.c code that
resulted in same /sys/kernel/config/target/core/$HBA/$DEV/at
From: Nicholas Bellinger
Now that backend drivers are populating their own device attributes,
go ahead and remove left-over definitions + internal attribute list
of device attributes from target_core_configfs.c code
Also update TB_CIT_SETUP(dev_attrib,...) to signal ct_attr = NULL.
Signed-off-b
From: Nicholas Bellinger
This patch converts FILEIO to use an external set of device attributes,
and utilizes target_core_backend_configfs.h macros to generate a default
set of configfs extended-attr handlers.
It calls target_core_setup_sub_cits() to setup the initial config_item_type
based on e
From: Nicholas Bellinger
This patch adds initial support for dev_cit as external config_item_type.
This includes a new struct target_backend_cits to hold the external CITs
within struct se_subsystem_api, and target_core_setup_sub_cits() to be
used by backend drivers ahead of transport_subsystem_
From: Nicholas Bellinger
Now that PSCSI is only exposing four hw_* read-only device attributes,
go ahead and drop the left-over -> legacy PHBA_PDEV checks in various
se_dev_set_* code, since it's now only used by virtual devices.
Signed-off-by: Nicholas Bellinger
---
drivers/target/target_core
From: Nicholas Bellinger
This patch converts PSCSI to use an external set of device attributes,
and utilizes target_core_backend_configfs.h macros to generate a default
set of configfs extended-attr handlers.
It calls target_core_setup_sub_cits() to setup the initial config_item_type
based on ex
On Fri, Nov 28, 2014 at 12:20:44PM +0800, Ching Huang wrote:
> This patch is relative to
> http://git.infradead.org/users/hch/scsi-queue.git/tree/refs/heads/drivers-for-3.18:/drivers/scsi/arcmsr
>
Put this information after the --- cut off line so that it is not
saved in the permanent git log.
2014-11-28 10:54:30.0 +0800
> @@ -52,7 +52,7 @@ struct device_attribute;
> #define ARCMSR_MAX_FREECCB_NUM 320
> #define ARCMSR_MAX_OUTSTANDING_CMD 255
> #endif
> -#define ARCMSR_DRIVER_VERSION"v1.30.00.04-20140919"
> +#define ARCMS
40 matches
Mail list logo
