[patch v2] scsi: set fmt to NULL scsi_extd_sense_format() by default

One of the two callers passes an unintialized pointer as fmt and expects it to be set to NULL if there is no format string. Let's make this function work as expected. Fixes: d811b848ebb7 ('scsi: use sdev as argument for sense code printing') Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

RE: [PATCH 0/2] mpt{2,3}sas remove disconnected phys on topology change

Hi James/Chris We are observing below issue due to this patch set code changes Issue Description: Drives connected Enclosure/Expander won't be visible to the OS if any one remove and add expander cable with in DMD (Device Missing Delay) time period (also if any power-off and power-on the

Re: [PATCH 0/2] mpt{2,3}sas remove disconnected phys on topology change

Hi Sreekanth, I think this should be handled as any other change with an usual patch sent to the list, 'git revert 3520f9c779' and 'git revert 963ba22b90' will create the patches for you. Cheers, Tomas On 12/02/2014 02:18 PM, Sreekanth Reddy wrote: Hi James/Chris We are observing below issue

Re: [PATCH 0/2] mpt{2,3}sas remove disconnected phys on topology change

Ok. Thanks Tomas, I will follow the same and will send the revert patch to Upstream. Thanks, Sreekanth. On Tue, Dec 2, 2014 at 7:37 PM, Tomas Henzl the...@redhat.com wrote: Hi Sreekanth, I think this should be handled as any other change with an usual patch sent to the list, 'git revert

Re: [patch v2] scsi: set fmt to NULL scsi_extd_sense_format() by default

On Tue, 2014-12-02 at 14:07 +0300, Dan Carpenter wrote: One of the two callers passes an unintialized pointer as fmt and expects it to be set to NULL if there is no format string. Let's make this function work as expected. Fixes: d811b848ebb7 ('scsi: use sdev as argument for sense code

[PATCH 2/2] Revert [SCSI] mpt3sas: Remove phys on topology change

This reverts commit 963ba22b90a955363644cd397b20226928eab976 (mpt3sas: Remove phys on topology change) Reverting the previous mpt3sas drives patch changes, since we will observe below issue Issue: Drives connected Enclosure/Expander will unregister with SCSI Transport Layer, if any one remove

[PATCH 1/2] Revert [SCSI] mpt2sas: Remove phys on topology change.

This reverts commit 3520f9c779bed098ca76dd3fb6377264301d57ed (mpt2sas: Remove phys on topology change) Reverting the previous mpt2sas drives patch changes, since we will observe below issue Issue: Drives connected Enclosure/Expander will unregister with SCSI Transport Layer, if any one remove

[PATCH 0/2] Revert mpt2sas, mpt3sas: remove disconnected phys on topology change

Reverting the below commit IDs 1. [PATCH 1/2] mpt2sas: Remove phys on topology change commit ID: 3520f9c779bed098ca76dd3fb6377264301d57ed 2. [PATCH 2/2] mpt3sas: Remove phys on topology change commit ID: 963ba22b90a955363644cd397b20226928eab976 Sreekanth Reddy (2): Revert [SCSI]

[PATCH] Initialize off value in asd_process_ctrl_a_user()

If the asd_find_flash_de() function returns ENOENT the off value will be used uninitialized in the call to asd_read_flash_seg(). Signed-off-by: Eric B Munson emun...@akamai.com Cc: sta...@vger.kernel.org --- drivers/scsi/aic94xx/aic94xx_sds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH RESEND 1/5] ipr: Add support for async scanning to speed up boot

Switch device scanning logic in the ipr driver to use the async scan API. This speeds up boot times, particularly on large systems. Signed-off-by: Brian King brk...@linux.vnet.ibm.com --- drivers/scsi/ipr.c | 88 + drivers/scsi/ipr.h |4

[PATCH RESEND 5/5] ipr: Driver version 2.6.1

Bump driver version. Signed-off-by: Brian King brk...@linux.vnet.ibm.com --- drivers/scsi/ipr.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/scsi/ipr.h~ipr_version_2_6_1 drivers/scsi/ipr.h --- scsi-queue/drivers/scsi/ipr.h~ipr_version_2_6_1 2014-12-02

[PATCH RESEND 3/5] ipr: Kexec boot speed improvements

Currently when performing a kexec boot with an ipr adapter, the adapter gets shutdown completely, flushing all write cache, as well as performing a full hardware reset of the card during the shutdown phase of the old kernel. This forces the new kernel to then wait for the adapter firmware to

[PATCH RESEND 4/5] ipr: Set scsi_level correctly for disk arrays

Set the scsi_level correctly for disk arrays such that things like the rotational field get set properly by sd.c. Signed-off-by: Brian King brk...@linux.vnet.ibm.com --- drivers/scsi/ipr.c |1 + 1 file changed, 1 insertion(+) diff -puN drivers/scsi/ipr.c~ipr_array_scsi_level

[PATCH RESEND 2/5] kexec: Export kexec_in_progress

A kexec boot for some ipr SAS adapters was seen to take ~20 seconds just doing ipr adapter initialization. This is due to the fact that a kexec invokes the driver's shutdown handler which places the adapter into a state that requires a hard reset and resulting firmware initialization to be usable

Re: [PATCH RESEND 1/5] ipr: Add support for async scanning to speed up boot

Reviewed-by: Wen Xiongwenxi...@linux.vnet.ibm.com Thanks, Wendy Quoting Brian King brk...@linux.vnet.ibm.com: Switch device scanning logic in the ipr driver to use the async scan API. This speeds up boot times, particularly on large systems. Signed-off-by: Brian King

Re: [PATCH RESEND 2/5] kexec: Export kexec_in_progress

Reviewed-by: Wen Xiongwenxi...@linux.vnet.ibm.com Thanks, Wendy Quoting Brian King brk...@linux.vnet.ibm.com: A kexec boot for some ipr SAS adapters was seen to take ~20 seconds just doing ipr adapter initialization. This is due to the fact that a kexec invokes the driver's shutdown handler

Re: [PATCH RESEND 3/5] ipr: Kexec boot speed improvements

Reviewed-by: Wen Xiongwenxi...@linux.vnet.ibm.com Thanks, Wendy Quoting Brian King brk...@linux.vnet.ibm.com: Currently when performing a kexec boot with an ipr adapter, the adapter gets shutdown completely, flushing all write cache, as well as performing a full hardware reset of the card

Re: [PATCH RESEND 4/5] ipr: Set scsi_level correctly for disk arrays

Reviewed-by: Wen Xiongwenxi...@linux.vnet.ibm.com Thanks, Wendy Quoting Brian King brk...@linux.vnet.ibm.com: Set the scsi_level correctly for disk arrays such that things like the rotational field get set properly by sd.c. Signed-off-by: Brian King brk...@linux.vnet.ibm.com ---

Re: [PATCH RESEND 5/5] ipr: Driver version 2.6.1

Reviewed-by: Wen Xiongwenxi...@linux.vnet.ibm.com Thanks, Wendy Quoting Brian King brk...@linux.vnet.ibm.com: Bump driver version. Signed-off-by: Brian King brk...@linux.vnet.ibm.com --- drivers/scsi/ipr.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN

[BUG] kzalloc overflow in lpfc driver on 6k core system

Hey guys, We've recently upgraded our big machine up to 6144 cores, and we're shaking out a number of bugs related to booting at that large core count. Last night I tripped a warning from the lpfc driver that appears to be related to a kzalloc that uses the number of cores as part of it's size

RE: [BUG] kzalloc overflow in lpfc driver on 6k core system

-Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Alex Thorlton Sent: Tuesday, 02 December, 2014 3:58 PM ... We've recently upgraded our big machine up to 6144 cores, and we're shaking out a number of bugs related to

[PATCH v2 6/6] scsi: misc: Print single-character strings with seq_putc

Using seq_putc to print a single character saves at least a strlen() call and a memory access, and may also give a small .text reduction. Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk --- drivers/scsi/NCR5380.c | 2 +- drivers/scsi/advansys.c | 34

[PATCH v2 4/6] scsi: misc: Replace seq_printf with seq_puts

Using seq_printf to print a simple string is a lot more expensive than it needs to be, since seq_puts exists. Replace seq_printf with seq_puts when possible. Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk --- drivers/scsi/BusLogic.c | 10 +- drivers/scsi/NCR5380.c

[PATCH v2 1/6] scsi: Remove SPRINTF macro

The macro SPRINTF doesn't save a lot of typing or make the code more readable, and depending on a specific identifier (m) in the surrounding scope is generally frowned upon. Nuke it. Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk --- drivers/scsi/NCR5380.c | 20 ++-

[PATCH v2 5/6] scsi: misc: Merge consecutive seq_puts calls

Consecutive seq_puts calls with literal strings may be replaced by a single call, saving a little .text. Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk --- drivers/scsi/advansys.c | 43 +++ drivers/scsi/atp870u.c | 5 ++---

[PATCH v2 2/6] scsi/advansys: Replace seq_printf with seq_puts

Using seq_printf to print a simple string is a lot more expensive than it needs to be, since seq_puts exists. Replace seq_printf with seq_puts when possible. Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk --- drivers/scsi/advansys.c | 155

[PATCH] drivers: scsi: aic7xxx: Fix positive error codes.

Note: There are more instances of the problem described below, but I thought I'd explain the first one in detail, to make sure it's worth fixing the others (and to make sure I didn't do anything stupid, which I may have. I'm new to this :-). Alright, here we go! A few drivers seem to return

Re: iSCSI request keep rejected by microsoft iSCSI target because of write_same check

Mike == Michael Christie micha...@cs.wisc.edu writes: Mike, Mike This was the issue we worked with Microsoft on wasn’t it? You guys Mike figured out it was fixed in their target in a recent release Mike right? The issue we worked recently was wrt. the thin provisioning reporting. The WRITE