Re: [PATCH 3/4 v3] scsi:stex.c Add reboot support

2014-12-17 Thread Christoph Hellwig
I'm not going to add a new reboot notifier for a driver. If you can convince the driver model / PM people to pass this information to -shutdown we can add support for this difference, but not in this way. Can you send me a series that just adds the hardware support for now, so we can dash this

Re: [Lsf-pc] [LSF/MM TOPIC] Integrated Unit Attention handling

2014-12-17 Thread Christoph Hellwig
On Tue, Dec 16, 2014 at 04:30:34PM +0100, Hannes Reinecke wrote: On 12/16/2014 09:32 AM, Christoph Hellwig wrote: Sounds like a good topic, altough I hope we'll see considerable progress before LSF on this item.. Full integration requires a change of the SCSI device model; currently

Re: [Lsf-pc] [LSF/MM TOPIC] Integrated Unit Attention handling

2014-12-17 Thread Bart Van Assche
On 12/16/14 16:30, Hannes Reinecke wrote: On 12/16/2014 09:32 AM, Christoph Hellwig wrote: Sounds like a good topic, altough I hope we'll see considerable progress before LSF on this item.. Full integration requires a change of the SCSI device model; currently struct scsi_device has a fixed

[PATCH 0/1] int to bool conversion

2014-12-17 Thread Quentin Lambert
This patch converts local variable declared as integer and used as boolean into actual booleans. It only patches variables that are not returned to limit the scope of the changes. This patch was generated with Coccinelle using the semantic patch below. Quentin Lambert (1): [SCSI] mpt2sas:

[PATCH 1/1] [SCSI] mpt2sas: Convert non-returned local variable to boolean when relevant

2014-12-17 Thread Quentin Lambert
This patch was produced using Coccinelle. A simplified version of the semantic patch is: @r exists@ identifier f; local idexpression u8 x; identifier xname; @@ f(...) { ...when any ( x@xname = 1; | x@xname = 0; ) ...when any } @bad exists@ identifier r.f; local idexpression u8 r.x

Using common code for csiostor.

2014-12-17 Thread Praveen Madhavan
Hi Christoph, csiostor is chelsio full offload FCoE physical function driver. I would like to reuse common hardware interface functions defined in t4_hw.c of chelsio networking driver(cxgb4). Below is makefile change that creates softlink to t4_hw.c and builds the same. Is this change is

Re: Using common code for csiostor.

2014-12-17 Thread James Bottomley
On Wed, 2014-12-17 at 15:51 +, Praveen Madhavan wrote: Hi Christoph, csiostor is chelsio full offload FCoE physical function driver. I would like to reuse common hardware interface functions defined in t4_hw.c of chelsio networking driver(cxgb4). Below is makefile change that creates

Re: Tagged overlapped commands

2014-12-17 Thread Andrew Brooks
On 1 December 2014 at 12:22, Andrew Brooks a...@sat.dundee.ac.uk wrote: I'm having trouble writing to an LTO-5 tape drive connected via Adaptec 1405 Writing aborts with this in syslog: st0: Sense Key : Aborted Command [current] st0: Add. Sense: Tagged overlapped commands (task tag 0) Both

[PATCH v1 1/2] ahci_xgene: Fix the endianess issue in APM X-Gene SoC AHCI SATA controller driver.

2014-12-17 Thread Suman Tripathi
This patch fixes the big endian mode issue with function xgene_ahci_read_id. Signed-off-by: Suman Tripathi stripa...@apm.com --- drivers/ata/ahci_xgene.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c index 0f8538f..0ffd3c9

[PATCH v1 2/2] ahci_xgene: Fix the DMA state machine lockup for the ATA_CMD_PACKET PIO mode command.

2014-12-17 Thread Suman Tripathi
This patch addresses the issue with ATA_CMD_PACKET pio mode command for enumeration and device detection with ATAPI devices.It is the same issue as in patch www.spinics.net/lists/linux-ide/msg49092.html Signed-off-by: Suman Tripathi stripa...@apm.com --- drivers/ata/ahci_xgene.c | 12

Re: [PATCH 2/2] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_PACKET PIO mode command.

2014-12-17 Thread Sergei Shtylyov
Hello. On 12/17/2014 08:21 AM, Suman Tripathi wrote: This patch addresses the issue with ATA_CMD_PACKET pio mode command for enumeration and device detection with ATAPI devices.It is the same issue as in patch Ugh, HTML... Please stick to plain text when posting to the

Re: [PATCH 1/1] [SCSI] mpt2sas: Convert non-returned local variable to boolean when relevant

2014-12-17 Thread Joe Perches
On Wed, 2014-12-17 at 15:56 +0100, Quentin Lambert wrote: This patch was produced using Coccinelle. A simplified version of the semantic patch is: [...] Interesting. Some of these conversions show what I think is relatively poor logic. For instance: diff --git

[Bug 81861] Oops by mvsas v0.8.16: sas: ataX: end_device-Y:0:Z: dev error handler - general protection fault, RIP: mvs_task_prep_ata+0x80/0x3a0

2014-12-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=81861 Christian Vilhelm christian.vilh...@univ-lille2.fr changed: What|Removed |Added CC|

Delayed FC rport removal causes errors on other device

2014-12-17 Thread Tony Battersby
Initiator-mode problem summary: FC initiator HBA cabled directly (no FC switch) to FC target device #1. Unplug cable from FC target device #1 and quickly plug it into FC target device #2, keeping the other end of the cable plugged into the same initiator HBA port. The new device shows up

Re: Delayed FC rport removal causes errors on other device

2014-12-17 Thread Giridhar Malavali
Tony, We will look into this further and get back to you. Do you have driver logs with extended error logging for this failure. If not, can you please capture one and send it across. Thanks, Giridhar On 12/17/14 2:41 PM, Tony Battersby to...@cybernetics.com wrote: Initiator-mode problem

Re: Clarification for Persistent Reservation + All Registrants

2014-12-17 Thread Lee Duncan
Sorry to come to this late, but I have one addition ... On 12/13/2014 10:27 PM, Nicholas A. Bellinger wrote: On Sat, 2014-12-13 at 08:33 +0100, James Bottomley wrote: On Fri, 2014-12-12 at 17:53 -0800, Nicholas A. Bellinger wrote: On Sat, 2014-12-13 at 00:52 +0100, James Bottomley wrote: On

RE: Tagged overlapped commands

2014-12-17 Thread Elliott, Robert (Server Storage)
-Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Andrew Brooks Sent: Tuesday, 16 December, 2014 4:23 AM ... On 8 December 2014 at 07:02, James Bottomley james.bottom...@hansenpartnership.com wrote: The error

RE: [PATCH 3/5] scsi: add support for COMPARE_AND_WRITE

2014-12-17 Thread Elliott, Robert (Server Storage)
I haven't reviewed the whole patch, but noticed one thing: -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of micha...@cs.wisc.edu Sent: Thursday, 16 October, 2014 12:37 AM ... @@ -635,6 +646,54 @@ static void

Re: [PATCH 4/4 v4] scsi:stex.c Add S3/S4 support

2014-12-17 Thread Charles Chiou
On 12/16/2014 05:34 PM, Oliver Neukum wrote: On Tue, 2014-12-16 at 14:14 +0800, Charles Chiou wrote: From f9d84df080c16097218092630db9b5df31d487b5 Mon Sep 17 00:00:00 2001 From: Charles Chiou charles.ch...@tw.promise.com Date: Fri, 7 Nov 2014 10:15:18 +0800 Subject: [PATCH 4/4] scsi:stex.c

Re: [PATCH 3/4 v3] scsi:stex.c Add reboot support

2014-12-17 Thread Charles Chiou
On 12/17/2014 05:30 PM, Christoph Hellwig wrote: I'm not going to add a new reboot notifier for a driver. If you can convince the driver model / PM people to pass this information to -shutdown we can add support for this difference, but not in this way. Can you send me a series that just

Re: [PATCH 2/2] target: Avoid dropping AllRegistrants reservation during unregister

2014-12-17 Thread Lee Duncan
On 12/15/2014 04:09 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch fixes an issue with AllRegistrants reservations where an unregister operation by the I_T nexus reservation holder would incorrectly drop the reservation, instead of waiting until the

Re: [PATCH 1/2] target: Fix R_HOLDER bit usage for AllRegistrants

2014-12-17 Thread Lee Duncan
On 12/15/2014 04:09 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch fixes the usage of R_HOLDER bit for an All Registrants reservation in READ_FULL_STATUS, where only the registration who issued RESERVE was being reported as having an active