Re: [PATCH 1/7] blk-mq: fix use of incorrect goto label in blk_mq_init_queue error path

2015-03-12 Thread Ming Lei
On Thu, Mar 12, 2015 at 11:56 AM, Mike Snitzer snit...@redhat.com wrote: If percpu_ref_init() fails the 'err_hctxs' label should be used instead of 'err_map'. Signed-off-by: Mike Snitzer snit...@redhat.com --- block/blk-mq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH 2/7] blk-mq: add blk_mq_init_allocated_queue and export blk_mq_register_disk

2015-03-12 Thread Ming Lei
On Thu, Mar 12, 2015 at 11:56 AM, Mike Snitzer snit...@redhat.com wrote: Add a variant of blk_mq_init_queue that allows a previously allocated queue to be initialized. blk_mq_init_allocated_queue models blk_init_allocated_queue -- which was also created for DM's use. DM's approach to device

[PATCH 15/15] iscsi-target: don't export static symbol

2015-03-12 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r@ type T; identifier f; @@ static T f (...) { ... } @@ identifier r.f; declarer name EXPORT_SYMBOL; @@ -EXPORT_SYMBOL(f); // /smpl Signed-off-by: Julia

[PATCH v2 1/9] snic: snic module infrastructure

2015-03-12 Thread Narsimhulu Musini
snic_main.c contains module load and unload, global driver context, PCI Registration, PCI probe and remove, SCSI ML registration functionality. snic.h contains snic structure definition, snic global context, and prototypes. snic_os.h contains OS specific interfaces. snic_attrs.c contains device

[PATCH v2 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS

2015-03-12 Thread Narsimhulu Musini
Kconfig for kbuild Makefile to build snic module Updated MAINTAINERS file v2 Added compile time flags for debugfs dependent functionality. Signed-off-by: Narsimhulu Musini nmus...@cisco.com Signed-off-by: Sesidhar Baddela sebad...@cisco.com --- MAINTAINERS| 7 +++

[PATCH v2 2/9] snic:Add interrupt, resource firmware interfaces

2015-03-12 Thread Narsimhulu Musini
snic_fwint.h contains firmware interface structures. snic_res.h contains firmware request initialization snic_res.c contains retrieval of resource configuration, and allocation, and initialization of HW Queues. snic_isr.c contains interrupt request, release, and handling Signed-off-by:

[PATCH v6 2/3] scsi: ufs: add debugfs for ufs

2015-03-12 Thread Gilad Broner
From: Lee Susman lsus...@codeaurora.org Adding debugfs capability for ufshcd. debugfs attributes introduced in this patch: - View driver/controller runtime data - Command tag statistics for performance analisis - Dump device descriptor info - Track recoverable errors statistics during

Re: [PATCH v6 1/3] scsi: ufs: add ioctl interface for query request

2015-03-12 Thread Akinobu Mita
2015-03-12 21:27 GMT+09:00 Gilad Broner gbro...@codeaurora.org: From: Dolev Raviv dra...@codeaurora.org This patch exposes the ioctl interface for UFS driver via SCSI device ioctl interface. As of now UFS driver would provide the ioctl for query interface to connected UFS device.

Re: [PATCH 1/7] blk-mq: fix use of incorrect goto label in blk_mq_init_queue error path

2015-03-12 Thread Mike Snitzer
On Thu, Mar 12 2015 at 3:48am -0400, Ming Lei tom.leim...@gmail.com wrote: On Thu, Mar 12, 2015 at 11:56 AM, Mike Snitzer snit...@redhat.com wrote: If percpu_ref_init() fails the 'err_hctxs' label should be used instead of 'err_map'. Signed-off-by: Mike Snitzer snit...@redhat.com ---

Re: [PATCH ] qla2xxx Add SCSI command jammer/discard capabilty to the qla2xxx target module - revision3

2015-03-12 Thread Laurence Oberman
Hello Bart, Quinn Tran Thanks for the feedback. Revision3 Moved the discard to the __qlt_do_work code to prevent the memory leak, this cleans up the allocations. I will look at seeing how best this can be done for the other transports, or in the core but for me the most useful case has been

[PATCH 1/7 v3] blk-mq: fix use of incorrect goto label in blk_mq_init_queue error path

2015-03-12 Thread Mike Snitzer
If percpu_ref_init() fails the allocated q and hctxs must get cleaned up; using 'err_map' doesn't allow that to happen. Signed-off-by: Mike Snitzer snit...@redhat.com Reviewed-by: Ming Lei ming@canonical.com --- block/blk-mq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH 1/7] blk-mq: fix use of incorrect goto label in blk_mq_init_queue error path

2015-03-12 Thread Mike Snitzer
On Thu, Mar 12 2015 at 9:51am -0400, Mike Snitzer snit...@redhat.com wrote: On Thu, Mar 12 2015 at 3:48am -0400, Ming Lei tom.leim...@gmail.com wrote: On Thu, Mar 12, 2015 at 11:56 AM, Mike Snitzer snit...@redhat.com wrote: If percpu_ref_init() fails the 'err_hctxs' label should be

[PATCH 2/7 v3] blk-mq: add blk_mq_init_allocated_queue and export blk_mq_register_disk

2015-03-12 Thread Mike Snitzer
Add a variant of blk_mq_init_queue that allows a previously allocated queue to be initialized. blk_mq_init_allocated_queue models blk_init_allocated_queue -- which was also created for DM's use. DM's approach to device creation requires a placeholder request_queue be allocated for use with

[PATCH v7 2/3] scsi: ufs: add debugfs for ufs

2015-03-12 Thread Gilad Broner
From: Lee Susman lsus...@codeaurora.org Adding debugfs capability for ufshcd. debugfs attributes introduced in this patch: - View driver/controller runtime data - Command tag statistics for performance analisis - Dump device descriptor info - Track recoverable errors statistics during

[PATCH v7 1/3] scsi: ufs: add ioctl interface for query request

2015-03-12 Thread Gilad Broner
From: Dolev Raviv dra...@codeaurora.org This patch exposes the ioctl interface for UFS driver via SCSI device ioctl interface. As of now UFS driver would provide the ioctl for query interface to connected UFS device. Signed-off-by: Dolev Raviv dra...@codeaurora.org Signed-off-by: Noa Rubens

[PATCH v7 0/3] Add ioctl and debug utilities to UFS driver

2015-03-12 Thread Gilad Broner
Changes from V6: Moved NULL user argument check from ufshcd_ioctl to ufshcd_query_ioctl. Add comment in include/scsi/scsi.h to note 0x5388 is in use. *** BLURB HERE *** Dolev Raviv (1): scsi: ufs: add ioctl interface for query request Gilad Broner (1): scsi: ufs: add trace events and dump

Re: [PATCH v7 3/3] scsi: ufs: add trace events and dump prints for debug

2015-03-12 Thread Steven Rostedt
On Thu, 12 Mar 2015 17:55:00 +0200 Gilad Broner gbro...@codeaurora.org wrote: Add trace events to driver to allow monitoring and profilig of activities such as PM suspend/resume, hibernate enter/exit, clock gating and clock scaling up/down. In addition, add UFS host controller register dumps

[PATCH v7 0/3] Add ioctl and debug utilities to UFS driver

2015-03-12 Thread Gilad Broner
Changes from V6: Moved NULL user argument check from ufshcd_ioctl to ufshcd_query_ioctl. Add comment in include/scsi/scsi.h to note 0x5388 is in use. Dolev Raviv (1): scsi: ufs: add ioctl interface for query request Gilad Broner (1): scsi: ufs: add trace events and dump prints for debug Lee

[PATCH v7 3/3] scsi: ufs: add trace events and dump prints for debug

2015-03-12 Thread Gilad Broner
Add trace events to driver to allow monitoring and profilig of activities such as PM suspend/resume, hibernate enter/exit, clock gating and clock scaling up/down. In addition, add UFS host controller register dumps to provide detailed information in case of errors to assist in analysis of issues.

[PATCH v7 1/3] scsi: ufs: add ioctl interface for query request

2015-03-12 Thread Gilad Broner
From: Dolev Raviv dra...@codeaurora.org This patch exposes the ioctl interface for UFS driver via SCSI device ioctl interface. As of now UFS driver would provide the ioctl for query interface to connected UFS device. Signed-off-by: Dolev Raviv dra...@codeaurora.org Signed-off-by: Noa Rubens

Re: [PATCH ] tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module

2015-03-12 Thread Quinn Tran
This idea definitely help flush out additional interaction issues between fabric drivers and TCM. However, the current spot where the error injection is placed will cause memory leak. The error injection tries to drop the command before submission to TCM. TCM QLA drivers will loose track of

Re: [PATCH v5 3/3] scsi: ufs: add trace events and dump prints for debug

2015-03-12 Thread Gilad Broner
This and the auto_bkops_state is pretty much the same. Can't you use the same TP_printk() and just have a DECLARE_EVENT_CLASS? The trace point name is printed with the event to see different events. I agree. will upload the fix in next patchset. -- Qualcomm Israel, on behalf of Qualcomm

[no subject]

2015-03-12 Thread pepa6...@ono.com
Proposal, Respond to my personal email; mrs.zhangxiao1962@outlook. com Yours Sincerely. Mrs. Zhang Xiao (Accounts book Keeper) Angang Steel Company Limited 396 Nan Zhong Hua Lu, Tie Dong District Anshan, Liaoning 114021, China. -- To unsubscribe from this list: send the line unsubscribe

[PATCH v6 0/3] Add ioctl and debug utilities to UFS driver

2015-03-12 Thread Gilad Broner
Changes from V5: Created a common trace event class for driver state changes instead of individual trace events definitions. Dolev Raviv (1): scsi: ufs: add ioctl interface for query request Gilad Broner (1): scsi: ufs: add trace events and dump prints for debug Lee Susman (1): scsi: ufs:

[PATCH v6 1/3] scsi: ufs: add ioctl interface for query request

2015-03-12 Thread Gilad Broner
From: Dolev Raviv dra...@codeaurora.org This patch exposes the ioctl interface for UFS driver via SCSI device ioctl interface. As of now UFS driver would provide the ioctl for query interface to connected UFS device. Signed-off-by: Dolev Raviv dra...@codeaurora.org Signed-off-by: Noa Rubens

Re: [PATCH 17/22] esp_scsi: %pF is only for function pointers

2015-03-12 Thread Hannes Reinecke
On 03/11/2015 11:13 PM, Scott Wood wrote: Use %pS for actual addresses, otherwise you'll get bad output on arches like ppc64 where %pF expects a function descriptor. Signed-off-by: Scott Wood scottw...@freescale.com Cc: linux-scsi@vger.kernel.org Cc: Hannes Reinecke h...@suse.de Acked-by:

Re: [PATCH ] tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module

2015-03-12 Thread Laurence Oberman
Hello Quinn Tran Thank you for the feedback. There is a revision2 of this patch I sent as a follow on to Bart that is much cleaner but its still exposed to the memory leaks. The newer version has a single jam_host parameter as suggested by Bart and the messaging removed. Have a look for it.