Re: [PATCH net-next v2 1/4] cxgb4/iw_cxgb4/cxgb4i: remove duplicate definitions

2015-04-15 Thread Varun Prakash
On Mon, Apr 13, 2015 at 10:38:08AM -0600, Jason Gunthorpe wrote: On Mon, Apr 13, 2015 at 07:34:23PM +0530, Varun Prakash wrote: define struct ulptx_idata in common header file t4_msg.h to remove duplicate definitions. The Infiniband side of this patch looks OK. Reviewed-By: Jason

Re: [RFC] Simlify dif_verify routines and fixup fileio protection information code.

2015-04-15 Thread Akinobu Mita
2015-04-15 19:07 GMT+09:00 Sagi Grimberg sa...@dev.mellanox.co.il: On 4/15/2015 2:52 AM, Akinobu Mita wrote: Looks good... I'll test with these patches and check if the problems I met disappear. Thanks Akinobu, Waiting to hear your verdict before sending a formal patchset. I hit a

Re: [RFC] Simlify dif_verify routines and fixup fileio protection information code.

2015-04-15 Thread Sagi Grimberg
On 4/15/2015 5:33 PM, Sagi Grimberg wrote: On 4/15/2015 5:16 PM, Akinobu Mita wrote: 2015-04-15 19:07 GMT+09:00 Sagi Grimberg sa...@dev.mellanox.co.il: On 4/15/2015 2:52 AM, Akinobu Mita wrote: Looks good... I'll test with these patches and check if the problems I met disappear. Thanks

Re: [RFC] Simlify dif_verify routines and fixup fileio protection information code.

2015-04-15 Thread Sagi Grimberg
On 4/15/2015 5:16 PM, Akinobu Mita wrote: 2015-04-15 19:07 GMT+09:00 Sagi Grimberg sa...@dev.mellanox.co.il: On 4/15/2015 2:52 AM, Akinobu Mita wrote: Looks good... I'll test with these patches and check if the problems I met disappear. Thanks Akinobu, Waiting to hear your verdict

Re: [RFC] Simlify dif_verify routines and fixup fileio protection information code.

2015-04-15 Thread Martin K. Petersen
Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes: Sagi I don't think this is sufficient. With this we actually write Sagi unprotected data for WRITE_SAME (i.e. write data blocks but not Sagi storing the corresponding PI information). When this data will be Sagi read back you will see PI

RE: smp_processor_id warning in megasas driver on 3.19.3

2015-04-15 Thread Sumit Saxena
-Original Message- From: Andy Lutomirski [mailto:l...@amacapital.net] Sent: Thursday, April 09, 2015 12:45 AM To: Christoph Hellwig Cc: Kashyap Desai; Sumit Saxena; Uday Lingala; megaraidlinux@avagotech.com; Linux SCSI List Subject: Re: smp_processor_id warning in megasas driver on

[PATCH] megaraid_sas: use raw_smp_processor_id()

2015-04-15 Thread Christoph Hellwig
We only want to steer the I/O completion towards a queue, but don't actually access any per-CPU data, so the raw_ version is fine to use and avoids the warnings when using smp_processor_id(). Signed-off-by: Christoph Hellwig h...@lst.de Reported-by: Andy Lutomirski l...@kernel.org Tested-by: Andy

Re: [RFC] Simlify dif_verify routines and fixup fileio protection information code.

2015-04-15 Thread Martin K. Petersen
Sagi == Sagi Grimberg sa...@dev.mellanox.co.il writes: By the commit 436f4a0a (loopback: Add fabric_prot_type attribute support), When WRITE_SAME command with WRPROTECT=0 is executed, sbc_dif_generate() is called but cmd-t_prot_sg is NULL as block layer didn't allocate it for WRITE_SAME.

Re: [PATCH net-next v2 1/4] cxgb4/iw_cxgb4/cxgb4i: remove duplicate definitions

2015-04-15 Thread Jason Gunthorpe
On Wed, Apr 15, 2015 at 06:34:27PM +0530, Varun Prakash wrote: On Mon, Apr 13, 2015 at 10:38:08AM -0600, Jason Gunthorpe wrote: On Mon, Apr 13, 2015 at 07:34:23PM +0530, Varun Prakash wrote: define struct ulptx_idata in common header file t4_msg.h to remove duplicate definitions. The

Re: [PATCH 2/5] ufs: Rename of regulator_set_optimum_mode

2015-04-15 Thread Bjorn Andersson
On Tue 14 Apr 05:11 PDT 2015, Akinobu Mita wrote: 2015-02-12 12:35 GMT+09:00 Bjorn Andersson bjorn.anders...@sonymobile.com: The function regulator_set_optimum_mode() is changing name to regulator_set_load(), so update the code accordingly. Also cleaned up ufshcd_config_vreg_load() while

Re: [PATCH] megaraid_sas: use raw_smp_processor_id()

2015-04-15 Thread Andy Lutomirski
On Wed, Apr 15, 2015 at 9:44 AM, Christoph Hellwig h...@infradead.org wrote: We only want to steer the I/O completion towards a queue, but don't actually access any per-CPU data, so the raw_ version is fine to use and avoids the warnings when using smp_processor_id(). Signed-off-by: Christoph

[PATCH] ufs: Reinstate NULL pointer checks for regulators

2015-04-15 Thread Bjorn Andersson
The cleanup during the introduction of regulator_set_load() was a too optimistic and re-opened an issue with vreg being dereferenced while being NULL. So reinstate the NULL checks and add back the BUG_ON() to follow the general coding convention of the implementation. Fixes: 7b16a07c3293 (ufs:

Re: [PATCH 1/3] target/file: Fix BUG() when CONFIG_DEBUG_SG=y and DIF protection enabled

2015-04-15 Thread Nicholas A. Bellinger
On Mon, 2015-04-13 at 23:21 +0900, Akinobu Mita wrote: When CONFIG_DEBUG_SG=y and DIF protection support enabled, kernel BUG()s are triggered due to the following two issues: 1) prot_sg is not initialized by sg_init_table(). When CONFIG_DEBUG_SG=y, scatterlist helpers check sg entry has a

Re: [PATCH 3/3] target/file: Fix UNMAP with DIF protection support

2015-04-15 Thread Nicholas A. Bellinger
On Mon, 2015-04-13 at 23:21 +0900, Akinobu Mita wrote: When UNMAP command is issued with DIF protection support enabled, the protection info for the unmapped region is remain unchanged. So READ command for the region causes data integrity failure. This fixes it by invalidating protection

/investice

2015-04-15 Thread Chn Jng
Dobrý den, Já jsem Vás kontaktovat o projektu vzájemných výhod pro nás oba. V pripade zájmu me mužete dostat na muj e-mail níže pro více informací a vysvetlení, po telefonu. E-mail: jg.ch...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a

Re: [PATCH 2/3] target/file: Fix SG table for prot_buf initialization

2015-04-15 Thread Nicholas A. Bellinger
On Mon, 2015-04-13 at 23:21 +0900, Akinobu Mita wrote: In fd_do_prot_rw(), it allocates prot_buf which is used to copy from se_cmd-t_prot_sg by sbc_dif_copy_prot(). The SG table for prot_buf is also initialized by allocating 'se_cmd-t_prot_nents' entries of scatterlist and setting the data

Re: mvsas panics and dies when attached to a port extender on newer kernels

2015-04-15 Thread James Bottomley
On Tue, 2015-04-14 at 14:41 -0700, Adam Talbot wrote: Removing the sas expander and attaching the SATA drives directly works just fine. I had to limp along with the drives direct attached for a while, while debugging. Well, that narrows it down. It looks like there's a longstanding bug in

Re: [PATCH 0/3] Fix return code for ioctl( BLKRRPART ) if device is down

2015-04-15 Thread Fam Zheng
On Tue, 03/24 11:34, Paolo Bonzini wrote: On 24/03/2015 11:16, Fam Zheng wrote: If issued right after link down, blockdev --rereadpt will be stuck for a while and then return normally. Although the underlying capacity and partition table are not correctly updated. And it means that

Re: [PATCH] sd: Fix missing ATO tag check

2015-04-15 Thread Sagi Grimberg
On 4/15/2015 12:11 AM, Martin K. Petersen wrote: 3aec2f41a8bae introduced a merge error where we would end up check for sdkp instead of sdkp-ATO. Fix this so we register app tag capability correctly. Signed-off-by: Martin K. Petersen martin.peter...@oracle.com Cc: sta...@vger.kernel.org #

Re: [RFC] Simlify dif_verify routines and fixup fileio protection information code.

2015-04-15 Thread Sagi Grimberg
On 4/15/2015 2:52 AM, Akinobu Mita wrote: Looks good... I'll test with these patches and check if the problems I met disappear. Thanks Akinobu, Waiting to hear your verdict before sending a formal patchset. I hit a original bug in sbc_dif_verify() which is not introduced by your patch

Re: [PATCH] sd: Unregister integrity profile

2015-04-15 Thread Sagi Grimberg
On 4/14/2015 11:56 PM, Martin K. Petersen wrote: The new integrity code did not correctly unregister the profile for SD disks. Call blk_integrity_unregister() when we release a disk. Signed-off-by: Martin K. Petersen martin.peter...@oracle.com Reported-by: Sagi Grimberg sa...@dev.mellanox.co.il