[PATCH] scsi: retry MODE SENSE on unit attention

2015-06-11 Thread Hannes Reinecke
The 'sd' driver is calling scsi_mode_sense() to figure out internal details. But scsi_mode_sense() never checks for any pending unit attentions, so we're getting annoying error messages like: MODE SENSE: unimplemented page/subpage: 0x00/0x00 and a possible wrong decision for device cache

Re: [Patch V2 4/9] [SCSI] aacraid: Enable 64-bit write to controller register

2015-06-11 Thread Johannes Thumshirn
On Wed, Jun 10, 2015 at 06:42:26PM -0700, rajinikanth.panduran...@pmcs.com wrote: From: Rajinikanth Pandurangan rajinikanth.panduran...@pmcs.com Description: If writeq() not supported, then do atomic two 32bit write Signed-off-by: Rajinikanth Pandurangan

[PATCH] scsi: Add ALUA state change UA handling

2015-06-11 Thread Hannes Reinecke
Log the ALUA state change unit attention correctly with the message log and emit an event to allow user-space tools to react to it. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_error.c | 4 drivers/scsi/scsi_lib.c| 4 include/scsi/scsi_device.h | 1 + 3 files

Re: [PATCH] scsi: retry MODE SENSE on unit attention

2015-06-11 Thread Ewan Milne
On Thu, 2015-06-11 at 13:01 +0200, Hannes Reinecke wrote: The 'sd' driver is calling scsi_mode_sense() to figure out internal details. But scsi_mode_sense() never checks for any pending unit attentions, so we're getting annoying error messages like: MODE SENSE: unimplemented page/subpage:

Re: [PATCH 0/2] target: 64-bit LUN support

2015-06-11 Thread Bart Van Assche
On 06/10/15 22:56, Hannes Reinecke wrote: Actually, I've been thinking about this. Currently I'm not sure if we should fully embrace this route; after all, 'scsilun_to_int' is meant to be a conversion from the (abstract) LUN number into our internal representation. And as it's internal we're

RE: [Patch V2 4/9] [SCSI] aacraid: Enable 64-bit write to controller register

2015-06-11 Thread Rajinikanth Pandurangan
Hello Johannes, My comments are inline. Thanks, -Raj P. -Original Message- From: Johannes Thumshirn [mailto:jthumsh...@suse.de] Sent: Thursday, June 11, 2015 3:02 AM To: Rajinikanth Pandurangan Cc: jbottom...@parallels.com; linux-scsi@vger.kernel.org; aacr...@pmc-sierra.com; Harry

Re: [Pv-drivers] [PATCH] VMW_PVSCSI: Fix the issue of DMA-API related warnings.

2015-06-11 Thread Thomas Hellstrom
On 06/11/2015 02:32 PM, Josh Boyer wrote: On Fri, Mar 21, 2014 at 2:08 PM, Arvind Kumar arvindku...@vmware.com wrote: The driver is missing calls to pci_dma_mapping_error() after performing the DMA mapping, which caused DMA-API warning to show up in dmesg's output. Though that happens only

Re: [PATCH v6] cxlflash: Base support for IBM CXL Flash Adapter

2015-06-11 Thread Brian King
On 06/09/2015 05:15 PM, Matthew R. Ochs wrote: SCSI device driver to support filesystem access on the IBM CXL Flash adapter. Supported-by: Stephen Bates stephen.ba...@pmcs.com Reviewed-by: Michael Neuling mi...@neuling.org Signed-off-by: Matthew R. Ochs mro...@linux.vnet.ibm.com

Re: [PATCH] megaraid_sas : Pass driver version to firmware inside IOC init frame

2015-06-11 Thread Tomas Henzl
On 06/10/2015 12:22 PM, sumit.sax...@avagotech.com wrote: Here should be an explanation why is this needed. The driver knows the fw version and can adapt to it. When sending the version to firmware fails, the driver just logs it and is able to continue. Why is the information needed for the fw ?

Re: [PATCH] VMW_PVSCSI: Fix the issue of DMA-API related warnings.

2015-06-11 Thread Josh Boyer
On Fri, Mar 21, 2014 at 2:08 PM, Arvind Kumar arvindku...@vmware.com wrote: The driver is missing calls to pci_dma_mapping_error() after performing the DMA mapping, which caused DMA-API warning to show up in dmesg's output. Though that happens only when DMA_API_DEBUG option is enabled. This

Re: [PATCH] VMW_PVSCSI: Fix the issue of DMA-API related warnings.

2015-06-11 Thread James Bottomley
On Thu, 2015-06-11 at 08:32 -0400, Josh Boyer wrote: On Fri, Mar 21, 2014 at 2:08 PM, Arvind Kumar arvindku...@vmware.com wrote: The driver is missing calls to pci_dma_mapping_error() after performing the DMA mapping, which caused DMA-API warning to show up in dmesg's output. Though that

[PATCH] bfa: fix leak of bfad_im_port_index on module unload

2015-06-11 Thread Alexey Khoroshilov
Resources allocated within bfad_im_port_index idr are not deallocated on module unload. The patch adds idr_destroy() in exit function. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov khoroshi...@ispras.ru --- drivers/scsi/bfa/bfad_im.c | 2 ++ 1

[PATCH 4/4] ipr: Driver version 2.6.2

2015-06-11 Thread Brian King
Bump driver version. Signed-off-by: Brian King brk...@linux.vnet.ibm.com --- drivers/scsi/ipr.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/scsi/ipr.h~ipr_version_2_6_2 drivers/scsi/ipr.h --- linux/drivers/scsi/ipr.h~ipr_version_2_6_2 2015-06-11

[PATCH 3/4] ipr: Endian / sparse fixes

2015-06-11 Thread Brian King
Some misc fixes for endianness checking with sparse so sparse with endian checking now runs clean. Fixes a minor bug in the process which was uncovered by sparse which would result in unnecessary error recovery for check conditions. Signed-off-by: Brian King brk...@linux.vnet.ibm.com ---

[PATCH 1/4] ipr: Fix locking for unit attention handling

2015-06-11 Thread Brian King
Make sure we have the host lock held when calling scsi_report_bus_reset. Fixes a crash seen as the __devices list in the scsi host was changing as we were iterating through it. Cc: sta...@vger.kernel.org Signed-off-by: Brian King brk...@linux.vnet.ibm.com --- drivers/scsi/ipr.c | 12

[PATCH 3/6] target: use 'se_dev_entry' when allocating UAs

2015-06-11 Thread Hannes Reinecke
We need to use 'se_dev_entry' as argument when allocating UAs, otherwise we'll never see any UAs for an implicit ALUA state transition triggered from userspace. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/target/target_core_alua.c | 27 ++-

[PATCH 4/6] target: Send UA on ALUA target port group change

2015-06-11 Thread Hannes Reinecke
When the ALUA target port group changes an INQUIRY DATA CHANGE UA needs to be sent. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/target/target_core_alua.c | 7 +++ drivers/target/target_core_ua.h | 2 ++ 2 files changed, 9 insertions(+) diff --git

[PATCH 2/6] target: Remove 'ua_nacl' pointer from se_ua structure

2015-06-11 Thread Hannes Reinecke
Unused. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/target/target_core_ua.c | 1 - include/target/target_core_base.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/target/target_core_ua.c b/drivers/target/target_core_ua.c index e53d4ee..e506224 100644 ---

[PATCH 0/6] target: Update UA handling

2015-06-11 Thread Hannes Reinecke
Hi Nic, lio-target is very minimalistic when it comes to generate UAs; primarily they are generated for persistent reservations, but generic changes tend to be ignored. This patchset updates the UA handling and generates UA for internal state changes (REPORTED LUNS DATA CHANGED, INQUIRY DATA

[PATCH 6/6] target: Send UA when changing LUN inventory

2015-06-11 Thread Hannes Reinecke
When changind the LUN inventory via core_enable_device_list_for_node() or core_disable_device_list_for_node() a REPORTED LUNS DATA HAS CHANGED UA should be send. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/target/target_core_device.c | 26 +-

[PATCH 1/6] target_core_alua: Correct UA handling when switching states

2015-06-11 Thread Hannes Reinecke
When switching target port group ALUA states we need to send one UA when setting the ALUA state to 'transitioning', and another one once the final state has been set. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/target/target_core_alua.c | 22 -- 1 file changed, 16

[PATCH 5/6] target: Send UA upon LUN RESET tmr completion

2015-06-11 Thread Hannes Reinecke
SAM mandates that an BUS DEVICE RESET FUNCTION OCCURRED UA needs to be send after a LUN RESET tmr has completed. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/target/target_core_transport.c | 11 +++ 1 file changed, 11 insertions(+) diff --git