Re: [PATCH v4 2/3] cxlflash: Superpipe support

2015-08-10 Thread Michael Neuling
Some comments inline On Mon, 2015-08-10 at 12:09 -0500, Matthew R. Ochs wrote: Add superpipe supporting infrastructure to device driver for the IBM CXL Flash adapter. This patch allows userspace applications to take advantage of the accelerated I/O features that this adapter provides and

Re: [PATCH v4 2/3] cxlflash: Superpipe support

2015-08-10 Thread Benjamin Herrenschmidt
On Mon, 2015-08-10 at 12:09 -0500, Matthew R. Ochs wrote: Add superpipe supporting infrastructure to device driver for the IBM CXL Flash adapter. This patch allows userspace applications to take advantage of the accelerated I/O features that this adapter provides and bypass the traditional

[PATCH V6 00/10] [SCSI] aacraid: Patchset for aacraid driver version 41010

2015-08-10 Thread Mahesh Rajashekhara
This patchset includes the following changes (bug fixes and new feature support) specific to aacraid driver. V6: Applied driver update change at the end. Merged 10 and 11 of V5 into 9 of V6. AAC_MAX_MSIX definition change. aac_msi option description and subject change. Removed 'reviewed-by' tag.

[PATCH V6 02/10] [SCSI] aacraid: Add Power Management support

2015-08-10 Thread Mahesh Rajashekhara
Description: * .suspend() and .resume() routines implemented in the driver * aac_release_resources() initiates firmware shutdown * aac_acquire_resources re-initializes the host interface Changes from V2: Increased msleep(1) to msleep(20) Reverted pci_enable_msix_exact() to

[PATCH V6 04/10] [SCSI] aacraid: Enable 64-bit write to controller register

2015-08-10 Thread Mahesh Rajashekhara
Description: If writeq() not supported, then do atomic two 32bit write Changes from V2: None Signed-off-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com --- drivers/scsi/aacraid/aacraid.h | 9 + drivers/scsi/aacraid/comminit.c | 1 + drivers/scsi/aacraid/src.c | 12

[PATCH V6 05/10] [SCSI] aacraid: Tune response path if IsFastPath bit set

2015-08-10 Thread Mahesh Rajashekhara
Description: If 'IsFastPath' bit is set, then response path assumes no error and skips error check. Changes from V2: None Signed-off-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com --- drivers/scsi/aacraid/aachba.c | 259 ++ 1 file

[PATCH V6 01/10] [SCSI] aacraid: Fix for logical device name and UID not exposed to the OS

2015-08-10 Thread Mahesh Rajashekhara
Description: Driver sends the right size of the response buffer. Changes from V2: None Signed-off-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com --- drivers/scsi/aacraid/aachba.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aacraid/aachba.c

[PATCH V6 06/10] [SCSI] aacraid: Reset irq affinity hints before releasing irq

2015-08-10 Thread Mahesh Rajashekhara
Description: Reset irq affinity hints before releasing IRQ Removed duplicate code of IRQ acquire/release Changes from V2: None Signed-off-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com --- drivers/scsi/aacraid/aacraid.h | 2 + drivers/scsi/aacraid/commsup.c | 113

[PATCH V6 07/10] [SCSI] aacraid: Unblock IOCTLs to controller once system resumed from suspend

2015-08-10 Thread Mahesh Rajashekhara
Description: Driver blocks ioctls once it received shutdown/suspend request during suspend/hybernation. This patch unblocks ioctls on resume path. Changes from V2: None Signed-off-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com --- drivers/scsi/aacraid/linit.c | 5 + 1

[PATCH V6 03/10] [SCSI] aacraid: Change interrupt mode to MSI for series-6 controller

2015-08-10 Thread Mahesh Rajashekhara
Description: This change always sets MSI interrupt mode for series-6 controller. Changes from V2: aac_msi option description and subject change. Signed-off-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com --- drivers/scsi/aacraid/aachba.c | 2 +- drivers/scsi/aacraid/src.c| 2 +-

Re: threads scsi_eh_ and scsi_tmf_ don't die when ib_srp reconnect

2015-08-10 Thread Bart Van Assche
On 08/10/2015 08:18 AM, Konstantin Krotov wrote: I was faced with the following problem: Im exported to compute-node scsi disks through ib_srp from storages. And if reconnect occurs for any reason, eg [1201117.626498] scsi host62: ib_srp: REJ received [1201117.626507] scsi host62: ib_srp: SRP

[PATCH v4 0/3] CXL Flash Error Recovery and Superpipe

2015-08-10 Thread Matthew R. Ochs
This patch set is intended for the 4.3 release and adds support for error recovery and the superpipe features provided by the IBM CXL Flash adapter. The superpipe function was originally presented in an RFC patch set in late April. To aid with the review of the superpipe portion of these

[PATCH v4 3/3] cxlflash: Virtual LUN support

2015-08-10 Thread Matthew R. Ochs
Add support for physical LUN segmentation (virtual LUNs) to device driver supporting the IBM CXL Flash adapter. This patch allows user space applications to virtually segment a physical LUN into N virtual LUNs, taking advantage of the translation features provided by this adapter. Signed-off-by:

[PATCH v4 1/3] cxlflash: Base error recovery support

2015-08-10 Thread Matthew R. Ochs
Introduce support for enhanced I/O error handling. Signed-off-by: Matthew R. Ochs mro...@linux.vnet.ibm.com Signed-off-by: Manoj N. Kumar ma...@linux.vnet.ibm.com --- drivers/scsi/cxlflash/Kconfig | 2 +- drivers/scsi/cxlflash/common.h | 11 ++- drivers/scsi/cxlflash/main.c | 166

threads scsi_eh_ and scsi_tmf_ don't die when ib_srp reconnect

2015-08-10 Thread Konstantin Krotov
Hello list! I was faced with the following problem: Im exported to compute-node scsi disks through ib_srp from storages. And if reconnect occurs for any reason, eg [1201117.626498] scsi host62: ib_srp: REJ received [1201117.626507] scsi host62: ib_srp: SRP LOGIN from

Re: [PATCH v4 1/3] cxlflash: Base error recovery support

2015-08-10 Thread Daniel Axtens
@@ -487,11 +515,27 @@ static int cxlflash_eh_host_reset_handler(struct scsi_cmnd *scp) get_unaligned_be32(((u32 *)scp-cmnd)[2]), get_unaligned_be32(((u32 *)scp-cmnd)[3])); - rcr = cxlflash_afu_reset(cfg); - if (rcr == 0) - rc = SUCCESS;

Re: [PATCH v4 1/3] cxlflash: Base error recovery support

2015-08-10 Thread Benjamin Herrenschmidt
On Mon, 2015-08-10 at 12:09 -0500, Matthew R. Ochs wrote: Introduce support for enhanced I/O error handling. Signed-off-by: Matthew R. Ochs mro...@linux.vnet.ibm.com Signed-off-by: Manoj N. Kumar ma...@linux.vnet.ibm.com --- So I'm not necessarily very qualified to review SCSI bits as I

Re: [PATCH v4 1/3] cxlflash: Base error recovery support

2015-08-10 Thread Michael Neuling
On Mon, 2015-08-10 at 12:09 -0500, Matthew R. Ochs wrote: Introduce support for enhanced I/O error handling. This needs more description of what you're doing. What's the overall approach? There seems to be a new limbo queue thats created stall things while the device is in error state. That

Re: [PATCH v4 0/3] CXL Flash Error Recovery and Superpipe

2015-08-10 Thread Michael Neuling
This patch set is intended for the 4.3 release and adds support for error recovery and the superpipe features provided by the IBM CXL Flash adapter. The superpipe function was originally presented in an RFC patch set in late April. To aid with the review of the superpipe portion of these

Re: [PATCH v3 1/2] mpt2sas: Refcount sas_device objects and fix unsafe list usage

2015-08-10 Thread Sreekanth Reddy
On Sat, Aug 1, 2015 at 10:32 AM, Calvin Owens calvinow...@fb.com wrote: These objects can be referenced concurrently throughout the driver, we need a way to make sure threads can't delete them out from under each other. This patch adds the refcount, and refactors the code to use it.