Re: [PATCH] scsi: fix scsi_error_handler vs. scsi_host_dev_release race

2015-08-28 Thread Hannes Reinecke
On 08/27/2015 08:16 PM, mho...@kernel.org wrote: From: Michal Hocko mho...@suse.com b9d5c6b7ef57 ([SCSI] cleanup setting task state in scsi_error_handler()) has introduced a race between scsi_error_handler and scsi_host_dev_release resulting in the hang when the device goes away because

[PATCH V8 3/9] aacraid: Change interrupt mode to MSI for Series 6

2015-08-28 Thread Mahesh Rajashekhara
This change always sets MSI interrupt mode for series-6 controller. Reviewed-by: Tomas Henzl the...@redhat.com Reviewed-by: Murthy Bhat murthy.b...@pmcs.com Reviewed-by: Karthikeya Sunkesula karthikeya.sunkes...@pmcs.com Signed-off-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com --- Changes

[PATCH V8 9/9] aacraid: Update driver version

2015-08-28 Thread Mahesh Rajashekhara
Reviewed-by: Tomas Henzl the...@redhat.com Reviewed-by: Murthy Bhat murthy.b...@pmcs.com Reviewed-by: Karthikeya Sunkesula karthikeya.sunkes...@pmcs.com Signed-off-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com --- drivers/scsi/aacraid/aacraid.h | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH V8 7/9] aacraid: IOCTL fix

2015-08-28 Thread Mahesh Rajashekhara
Driver blocks ioctls once it received shutdown/suspend request during suspend/hybernation. This patch unblocks ioctls on resume path. Reviewed-by: Tomas Henzl the...@redhat.com Reviewed-by: Murthy Bhat murthy.b...@pmcs.com Reviewed-by: Karthikeya Sunkesula karthikeya.sunkes...@pmcs.com

[PATCH V8 6/9] aacraid: Reset irq affinity hints

2015-08-28 Thread Mahesh Rajashekhara
Reset irq affinity hints before releasing IRQ. Removed duplicate code of IRQ acquire/release. Reviewed-by: Tomas Henzl the...@redhat.com Reviewed-by: Murthy Bhat murthy.b...@pmcs.com Reviewed-by: Karthikeya Sunkesula karthikeya.sunkes...@pmcs.com Signed-off-by: Mahesh Rajashekhara

[PATCH V8 5/9] aacraid: Tune response path if IsFastPath bit set

2015-08-28 Thread Mahesh Rajashekhara
If 'IsFastPath' bit is set, then response path assumes no error and skips error check. Reviewed-by: Murthy Bhat murthy.b...@pmcs.com Reviewed-by: Karthikeya Sunkesula karthikeya.sunkes...@pmcs.com Signed-off-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com --- Changes from V2: None

[PATCH V8 4/9] aacraid: Enable 64bit write to controller register

2015-08-28 Thread Mahesh Rajashekhara
If writeq() not supported, then do atomic two 32bit write Reviewed-by: Tomas Henzl the...@redhat.com Reviewed-by: Murthy Bhat murthy.b...@pmcs.com Reviewed-by: Karthikeya Sunkesula karthikeya.sunkes...@pmcs.com Signed-off-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com --- Changes from V2:

[PATCH V8 8/9] aacraid: Use pci_enable_msix_range()

2015-08-28 Thread Mahesh Rajashekhara
As pci_enable_msix() deprecated, replaced with pci_enable_msix_range() Reviewed-by: Tomas Henzl the...@redhat.com Reviewed-by: Murthy Bhat murthy.b...@pmcs.com Reviewed-by: Karthikeya Sunkesula karthikeya.sunkes...@pmcs.com Signed-off-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com ---

[PATCH V8 1/9] aacraid: Fix for LD name and UID not exposed to OS

2015-08-28 Thread Mahesh Rajashekhara
Driver sends the right size of the response buffer. Reviewed-by: Tomas Henzl the...@redhat.com Reviewed-by: Murthy Bhat murthy.b...@pmcs.com Reviewed-by: Karthikeya Sunkesula karthikeya.sunkes...@pmcs.com Signed-off-by: Mahesh Rajashekhara mahesh.rajashekh...@pmcs.com --- Changes from V2: None

Re: [PATCH 02/10] scsi: ufs: add quirk to contain unconformable utrd field

2015-08-28 Thread Alim Akhtar
Hi Amit, Thanks for your review comments. On 08/26/2015 11:43 AM, amit daniel kachhap wrote: Few minor comments below, On Fri, Aug 21, 2015 at 2:57 PM, Alim Akhtar alim.akh...@samsung.com wrote: From: Seungwon Jeon tgih@samsung.com UTRD(UTP Transfer Request Descriptor)'s field such as

RE: [PATCH V7 1/9] [SCSI] aacraid: Fix for logical device name and UID not exposed to the OS

2015-08-28 Thread Mahesh Rajashekhara
Hi James, I have taken care your review comments in V8 patch series. Thanks, Mahesh -Original Message- From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] Sent: Thursday, August 27, 2015 8:38 PM To: Mahesh Rajashekhara Cc: jbottom...@parallels.com;

RE: [PATCH] megaraid_sas: init tasklet earlier

2015-08-28 Thread Sumit Saxena
-Original Message- From: Tomas Henzl [mailto:the...@redhat.com] Sent: Wednesday, August 26, 2015 7:45 PM To: Sumit Saxena; linux-scsi@vger.kernel.org Cc: Kashyap Desai; Kiran Kumar Kasturi Subject: Re: [PATCH] megaraid_sas: init tasklet earlier On 26.8.2015 15:15, Sumit Saxena

[PATCH V8 0/9] aacraid: Patchset for aacraid driver version 41010

2015-08-28 Thread Mahesh Rajashekhara
This patchset includes the following changes (bug fixes and new feature support) specific to aacraid driver. V8: Right format for commit messages. V7: Removed patch 08 of V6. Keep the review-tags going V6-V7. V6: Applied driver update change at the end. Merged 10 and 11 of V5 into 9 of V6.

Re: [PATCH] scsi: fix scsi_error_handler vs. scsi_host_dev_release race

2015-08-28 Thread James Bottomley
On Thu, 2015-08-27 at 20:16 +0200, mho...@kernel.org wrote: From: Michal Hocko mho...@suse.com b9d5c6b7ef57 ([SCSI] cleanup setting task state in Heh, it's tempting to revert that. The reason is we always need to be interruptible state before we check the flag to avoid missing wakeups.

Re: [PATCH] scsi: fix scsi_error_handler vs. scsi_host_dev_release race

2015-08-28 Thread Michal Hocko
On Fri 28-08-15 07:56:13, James Bottomley wrote: [...] diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index 6457a8a0db9c..2c0a817d5dbe 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -2169,8 +2169,11 @@ int scsi_error_handler(void *data)

Re: [PATCH 0/2] Patches for scsi misc branch

2015-08-28 Thread James Bottomley
On Thu, 2015-08-13 at 06:41 -0400, anil.gurumur...@qlogic.com wrote: From: Anil Gurumurthy anil.gurumur...@qlogic.com Hi James, Christoph, Please apply the following patches to the scsi tree, misc branch at your earliest convenience. Both of these patches look OK to me. Could I get a

Re: [PATCH 10/10] scsi_dh: move 'dh_state' sysfs attribute to generic code

2015-08-28 Thread James Bottomley
On Thu, 2015-08-27 at 14:17 +0200, Hannes Reinecke wrote: As scsi_dh.c is now always compiled in we should be moving the 'dh_state' attribute to the generic code. Signed-off-by: Hannes Reinecke h...@suse.de This looks OK, but needs another reviewer. If you could also fix up the rejections

Re: [PATCH v2 0/10] megaraid_sas : Updates for scsi for-next

2015-08-28 Thread James Bottomley
On Thu, 2015-08-20 at 18:43 +0530, sumit.sax...@avagotech.com wrote: MegaRaid driver changes. This patch set is resent based on feedback received by Martin Petersen. Please consider this patch set for next kernel release. Signed-off-by: Sumit Saxena sumit.sax...@avagotech.com

Re: [PATCH 02/10] dm-mpath, scsi_dh: request scsi_dh modules in scsi_dh, not dm-mpath

2015-08-28 Thread James Bottomley
On Thu, 2015-08-27 at 14:16 +0200, Hannes Reinecke wrote: @@ -158,7 +171,7 @@ store_dh_state(struct device *dev, struct device_attribute *attr, /* * Attach to a device handler */ - if (!(scsi_dh = get_device_handler(buf))) +