Re: [PATCH 19/23] scsi_dh_alua: Use workqueue for RTPG

2015-09-02 Thread Christoph Hellwig
On Tue, Sep 01, 2015 at 02:57:57PM +0200, Hannes Reinecke wrote: > That is what I'm eventually planning to do. > My final goal is to move the multipath path monitoring stuff > into the kernel (via the block device polling mechanism), and sending > block events for path failure and

[PATCH v5 4/8] add ufshcd_get_variant ufshcd_set_variant

2015-09-02 Thread Yaniv Gardi
Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufs-qcom.c | 34 +- drivers/scsi/ufs/ufshcd.h | 21 + 2 files changed, 38 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/ufs/ufs-qcom.c

[PATCH v5 0/8] Fix error message and present UFS variant

2015-09-02 Thread Yaniv Gardi
V5: removed a redundant null check V4: add file Documentation/devicetree/bindings/ufs/ufs-qcom.txt and modify the compatible strings in Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt V3: fixes a few minor issues. V2: fixes a few issues of unnecessary EXPORT_SYMBOL, types of parameters

[PATCH v5 6/8] scsi: ufs: make the UFS variant a platform device

2015-09-02 Thread Yaniv Gardi
This change turns the UFS variant (SCSI_UFS_QCOM) into a UFS a platform device. In order to do so a few additional changes are required: 1. The ufshcd-pltfrm is no longer serves as a platform device. Now it only serves as a group of platform APIs such as PM APIs (runtime suspend/resume,

[PATCH v5 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations

2015-09-02 Thread Yaniv Gardi
New revisions of UFS host controller supports the new UniPro hardware controller (referred as QUniPro). This patch adds the support to enable this new UniPro controller hardware. This change also adds power optimization for bus scaling feature, as well as support for HS-G3 power mode.

Re: [PATCH v4 6/8] scsi: ufs: make the UFS variant a platform device

2015-09-02 Thread ygardi
> On Sun, Aug 30, 2015 at 9:52 AM, Yaniv Gardi > wrote: >> This change turns the UFS variant (SCSI_UFS_QCOM) into a UFS >> a platform device. >> In order to do so a few additional changes are required: >> 1. The ufshcd-pltfrm is no longer serves as a platform device. >>

Re: [PATCH 19/23] scsi_dh_alua: Use workqueue for RTPG

2015-09-02 Thread Hannes Reinecke
On 09/02/2015 08:39 AM, Christoph Hellwig wrote: > On Tue, Sep 01, 2015 at 02:57:57PM +0200, Hannes Reinecke wrote: >> That is what I'm eventually planning to do. >> My final goal is to move the multipath path monitoring stuff >> into the kernel (via the block device polling mechanism), and

[PATCH v5 5/8] scsi: ufs: creates wrapper functions for vops

2015-09-02 Thread Yaniv Gardi
In order to simplify the code a set of wrapper functions is created to test and call each of the variant operations. Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufs-qcom.c | 1 - drivers/scsi/ufs/ufshcd.c | 104 +---

[PATCH v5 7/8] scsi: ufs-qcom: add debug prints for test bus

2015-09-02 Thread Yaniv Gardi
Adds support for configuring and reading the test bus and debug registers. This change also adds another vops in order to print the debug registers. Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufs-qcom.c | 165 +++-

[PATCH v5 2/8] scsi: ufs-qcom: fix compilation warning if compiled as a module

2015-09-02 Thread Yaniv Gardi
This change fixes a compilation warning that happens if SCSI_UFS_QCOM is compiled as a module. Also this patch fixes an error happens when insmod the module: "ufs_qcom: module license 'unspecified' taints kernel." Signed-off-by: Yaniv Gardi ---

[PATCH v5 1/8] phy: qcom-ufs: fix build error when the component is built as a module

2015-09-02 Thread Yaniv Gardi
Export the following functions in order to avoid build errors when the component PHY_QCOM_UFS is compiled as a module: ERROR: "ufs_qcom_phy_disable_ref_clk" [drivers/scsi/ufs/ufs-qcom.ko] undefined! ERROR: "ufs_qcom_phy_enable_ref_clk" [drivers/scsi/ufs/ufs-qcom.ko] undefined!

[PATCH v5 3/8] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component

2015-09-02 Thread Yaniv Gardi
This change is required in order to be able to build the component as a module. Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig index

Re: [PATCHv3] Update scsi host to use ida for host number

2015-09-02 Thread Christoph Hellwig
On Tue, Sep 01, 2015 at 05:03:28PM -0700, Lee Duncan wrote: > +static int host_get_index(int *index) > +{ > + int error = -ENOMEM; > + > + do { > + if (!ida_pre_get(_index_ida, GFP_KERNEL)) > + break; > + spin_lock(_index_lock); > +

Re: [PATCH v5 6/8] scsi: ufs: make the UFS variant a platform device

2015-09-02 Thread ygardi
> On Wed, Sep 2, 2015 at 3:32 AM, Yaniv Gardi wrote: >> This change turns the UFS variant (SCSI_UFS_QCOM) into a UFS >> a platform device. >> In order to do so a few additional changes are required: >> 1. The ufshcd-pltfrm is no longer serves as a platform device. >>Now

Re: [PATCH v7 2/8] scsi: ufs-qcom: fix compilation warning if compiled as a module

2015-09-02 Thread Rob Herring
On Wed, Sep 2, 2015 at 9:45 AM, Yaniv Gardi wrote: > This change fixes a compilation warning that happens if SCSI_UFS_QCOM > is compiled as a module. > Also this patch fixes an error happens when insmod the module: > "ufs_qcom: module license 'unspecified' taints kernel." >

[PATCH 1/3] scsi:stex.c Support to Pegasus series.

2015-09-02 Thread Charles Chiou
From 63f806abc43237285a918f559ce6e5e410d90d85 Mon Sep 17 00:00:00 2001 From: Charles Date: Wed, 2 Sep 2015 20:41:56 +0800 Subject: [PATCH 1/3] scsi:stex.c Support to Pegasus series. Pegasus is a high performace hardware RAID solution designed to unleash the raw

[PATCH 3/3] scsi:stex.c Add S3/S4 support

2015-09-02 Thread Charles Chiou
From 7d98f8c500de452277e2700a950b23bf4685ed64 Mon Sep 17 00:00:00 2001 From: Charles Date: Wed, 2 Sep 2015 20:54:45 +0800 Subject: [PATCH 3/3] scsi:stex.c Add S3/S4 support Add S3/S4 support, add .suspend and .resume function in pci_driver. In .suspend handler,

RE: [PATCH] csiostor:Fix locking issues in the function csio_scsim_cleanup_io_lnode

2015-09-02 Thread Anish Bhatt
> -Original Message- > From: Nicholas Krause [mailto:xerofo...@gmail.com] > Sent: Wednesday, September 2, 2015 10:36 AM > To: jbottom...@odin.com > Cc: h...@suse.de; micha...@cs.wisc.edu; da...@davemloft.net; Anish > Bhatt; Hariprasad S; linux-scsi@vger.kernel.org; linux- >

[PATCH 2/4] scsi:stex.c Add hotplug support

2015-09-02 Thread Charles Chiou
From 9f6cf26367419ed746c6c0f4e80fad6066b99d06 Mon Sep 17 00:00:00 2001 From: Charles Date: Wed, 2 Sep 2015 20:48:55 +0800 Subject: [PATCH 2/3] scsi:stex.c Add hotplug support 1. Add hotplug support. Pegasus support surprise removal. To this end, I use

Re: [PATCH v7 6/8] scsi: ufs: make the UFS variant a platform device

2015-09-02 Thread Rob Herring
On Wed, Sep 2, 2015 at 9:45 AM, Yaniv Gardi wrote: > This change turns the UFS variant (SCSI_UFS_QCOM) into a UFS > a platform device. > In order to do so a few additional changes are required: > 1. The ufshcd-pltfrm is no longer serves as a platform device. >Now it

dobrý den..

2015-09-02 Thread Mssge
odpovezte mi na nize uvedenou e-mailovou adresu pro vysvetlení výroku. E-mail: chn.j...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] SCSI: mvsas: Fix NULL pointer dereference in mvs_slot_task_free

2015-09-02 Thread Tomas Henzl
On 21.8.2015 06:29, Dāvis Mosāns wrote: > When pci_pool_alloc fails in mvs_task_prep then task->lldd_task stays > NULL but it's later used in mvs_abort_task as slot which is passed > to mvs_slot_task_free causing NULL pointer dereference. > > Just return from mvs_slot_task_free when passed with

[PATCH v3 04/15] scsi: ufs: clear outstanding_request bit in case query timeout

2015-09-02 Thread Yaniv Gardi
When sending a query to the device returns with a timeout error, we clear the corresponding bit in the DOORBELL register but we don't clear the outstanding_request field as we should. This patch fixes this bug. Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufshcd.c |

[PATCH v3 05/15] scsi: ufs: increase fDeviceInit query response timeout

2015-09-02 Thread Yaniv Gardi
fDeviceInit query response time for some devices is too long that default query request timeout of 100ms may not be enough. Experiments show that fDeviceInit response sometimes takes 500ms so to be on safer side this change sets the timeout to 600ms. Without this change, we might unnecessarily

Schváleno Claire

2015-09-02 Thread Sidney L. Waddington
Schváleno Claire El Gordo Award 20th/08/2015 Email Gratulujeme práve vyhrál 150,000,00 Euro bylo mezi víteze mesíce množství Won 150,000,00 úcastníku Euro .Všechny byly vybrány náhodne z World Wide webu pres pocítac cerpá systemTo Facebook pro váš soubor Claire kontaktujte prosím naše duverník

[PATCH v3 01/15] scsi: ufs: clear UTRD, UPIU req and rsp before new transfers

2015-09-02 Thread Yaniv Gardi
Clear the UFS data structures before sending new request. The SCSI command is sent to the device within the UFS UPIU request. As part of the transfer UPIU preparation, the SCSI command is copied to the UPIU structure according to the SCSI command size. As different SCSI commands differ in size

[PATCH v3 14/15] scsi: ufs: commit descriptors before setting the doorbell

2015-09-02 Thread Yaniv Gardi
Add a write memory barrier to make sure descriptors prepared are actually written to memory before ringing the doorbell. We have also added the write memory barrier after ringing the doorbell register so that controller sees the new request immediately. Signed-off-by: Gilad Broner

[PATCH v3 09/15] scsi: ufs: add retries for hibern8 enter

2015-09-02 Thread Yaniv Gardi
If hibern8 enter command fails then UFS link state may be unknown which may result into timeout of all the commands issued after failure. This change does 2 things (for pre-defined number of retry counts) after hibern8 enter failure: 1. Recovers the UFS link to active state 2. If link is

[PATCH v3 11/15] scsi: ufs: retry failed query flag requests

2015-09-02 Thread Yaniv Gardi
UFS flag query requests may fail sometimes due to timeouts etc. Add a wrapper function to retry up to 10 times in case of such failure, similar to retries being made for attribute queries. Signed-off-by: Gilad Broner Signed-off-by: Yaniv Gardi ---

[PATCH v3 10/15] scsi: ufs: fix error recovery after the hibern8 exit failure

2015-09-02 Thread Yaniv Gardi
Hibern8 exit can be called from 3 different context: - ufshcd_hibern8_exit_work - ufshcd_ungate_work - runtime/system resume If hibern8 exit fails for some reason then we try to bring the link to active state by link startup but this recovery mechanism results into deadlock or errors

[PATCH v3 08/15] scsi: ufs: add retries to dme_peer get and set attribute

2015-09-02 Thread Yaniv Gardi
The dme_peer get/set attribute commands are prone to errors, therefore we add three retries for the UIC command sending. Error code returned from ufshcd_send_uic_cmd() is checked, and unless it was successful or the retries have finished, another command will be sent. Signed-off-by: Lee Susman

[PATCH v3 12/15] scsi: ufs: reduce the interrupts for power mode change requests

2015-09-02 Thread Yaniv Gardi
DME commands such as Hibern8 enter/exit and gear switch generate 2 completion interrupts, one for confirmation that command is received by local UniPro and 2nd one is the final confirmation after communication with remote UniPro. Currently both of these completions are registered as interrupt

[PATCH v3 13/15] scsi: ufs: add missing memory barriers

2015-09-02 Thread Yaniv Gardi
Performing several writes to UFS host controller registers has no gurrantee of ordering, so we must make sure register writes to setup request list base address etc. are performed before the run/stop register is enabled. In addition, when setting up a task request, we must make sure the updating

[PATCH v3 00/15] Big fixes, retries, handle a race condition

2015-09-02 Thread Yaniv Gardi
Important: This serie of 15 small patches should be pushed after the series of 8 patches "Fix error message and present UFS variant probe" V3: removed specific calls to wmb() since they are redundant. V2: a few minor changes V1: This serie of 15 small patches should be pushed after the series

[PATCH v3 15/15] scsi: ufs: add wrapper for retrying sending query attribute

2015-09-02 Thread Yaniv Gardi
Sometimes queries from the device might return a failure so it is recommended to retry sending the query, before giving up. This change adds a wrapper to retry sending a query attribute, in cases where we need to wait longer, before we continue, or before reporting a failure. Signed-off-by: Yaniv

[PATCH v3 03/15] scsi: ufs: verify command tag validity

2015-09-02 Thread Yaniv Gardi
A race condition appear to exist between request completion when scsi_done() is called to end the request and set the tag back to -1 (at blk_queue_end_tag() scsi_end_request), and scsi layer error handling which aborts the command and reuses it to request sense data. Sending the request sense is

[PATCH v3 06/15] scsi: ufs: avoid exception event handler racing with PM callbacks

2015-09-02 Thread Yaniv Gardi
If device raises the exception event in the response to the commands sent during the runtime/system PM callbacks, exception event handler might run in parallel with PM callbacks and may see unclocked register accesses. This change fixes this issue by not scheduling the exception event handler

[PATCH v3 07/15] scsi: ufs: set REQUEST_SENSE command size to 18 bytes

2015-09-02 Thread Yaniv Gardi
According to UFS device specification REQUEST_SENSE command can only report back up to 18 bytes of data. Signed-off-by: Gilad Broner Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufshcd.c | 11 ++- 1 file changed, 6 insertions(+), 5

[PATCH v3 02/15] scsi: ufs: clear fields UTRD, UPIU req and rsp before new transfers

2015-09-02 Thread Yaniv Gardi
Some of the data structures (like response UPIU) and/or its elements (unused fields) should be cleared before sending out the respective command to UFS device. This change clears the UPIU response data structure for query commands and NOP command before sending out the command. We also initialize

Re: [PATCH v5 6/8] scsi: ufs: make the UFS variant a platform device

2015-09-02 Thread Rob Herring
On Wed, Sep 2, 2015 at 3:32 AM, Yaniv Gardi wrote: > This change turns the UFS variant (SCSI_UFS_QCOM) into a UFS > a platform device. > In order to do so a few additional changes are required: > 1. The ufshcd-pltfrm is no longer serves as a platform device. >Now it

[PATCH v7 2/8] scsi: ufs-qcom: fix compilation warning if compiled as a module

2015-09-02 Thread Yaniv Gardi
This change fixes a compilation warning that happens if SCSI_UFS_QCOM is compiled as a module. Also this patch fixes an error happens when insmod the module: "ufs_qcom: module license 'unspecified' taints kernel." Signed-off-by: Yaniv Gardi ---

[PATCH v7 3/8] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component

2015-09-02 Thread Yaniv Gardi
This change is required in order to be able to build the component as a module. Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig index

[PATCH v7 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations

2015-09-02 Thread Yaniv Gardi
New revisions of UFS host controller supports the new UniPro hardware controller (referred as QUniPro). This patch adds the support to enable this new UniPro controller hardware. This change also adds power optimization for bus scaling feature, as well as support for HS-G3 power mode.

[PATCH v7 7/8] scsi: ufs-qcom: add debug prints for test bus

2015-09-02 Thread Yaniv Gardi
Adds support for configuring and reading the test bus and debug registers. This change also adds another vops in order to print the debug registers. Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufs-qcom.c | 165 +++-

[PATCH v7 6/8] scsi: ufs: make the UFS variant a platform device

2015-09-02 Thread Yaniv Gardi
This change turns the UFS variant (SCSI_UFS_QCOM) into a UFS a platform device. In order to do so a few additional changes are required: 1. The ufshcd-pltfrm is no longer serves as a platform device. Now it only serves as a group of platform APIs such as PM APIs (runtime suspend/resume,

[PATCH v7 4/8] add ufshcd_get_variant ufshcd_set_variant

2015-09-02 Thread Yaniv Gardi
Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufs-qcom.c | 34 +- drivers/scsi/ufs/ufshcd.h | 21 + 2 files changed, 38 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/ufs/ufs-qcom.c

[PATCH v7 5/8] scsi: ufs: creates wrapper functions for vops

2015-09-02 Thread Yaniv Gardi
In order to simplify the code a set of wrapper functions is created to test and call each of the variant operations. Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufs-qcom.c | 1 - drivers/scsi/ufs/ufshcd.c | 104 +---

[PATCH v7 1/8] phy: qcom-ufs: fix build error when the component is built as a module

2015-09-02 Thread Yaniv Gardi
Export the following functions in order to avoid build errors when the component PHY_QCOM_UFS is compiled as a module: ERROR: "ufs_qcom_phy_disable_ref_clk" [drivers/scsi/ufs/ufs-qcom.ko] undefined! ERROR: "ufs_qcom_phy_enable_ref_clk" [drivers/scsi/ufs/ufs-qcom.ko] undefined!

[PATCH v7 0/8] Fix error message and present UFS variant

2015-09-02 Thread Yaniv Gardi
V7: removed additional dead code V6: removed dead code from ufs-qcom.c and added calling to ufshcd_dealloc_host() in ufshcd-pltfrm.c in case of an error after a successfull ufshcd_alloc_host() V5: removed a redundant null check V4: add file Documentation/devicetree/bindings/ufs/ufs-qcom.txt and

[PATCH] SCSI: Scale up REPORT_LUNS timeout on failure

2015-09-02 Thread Brian King
This patch fixes an issue seen with an IBM 2145 (SVC) where, following an error injection test which results in paths going offline, when they came back online, the path would timeout the REPORT_LUNS issued during the scan. This timeout situation continued until retries were expired, resulting in

[PATCH v6 5/8] scsi: ufs: creates wrapper functions for vops

2015-09-02 Thread Yaniv Gardi
In order to simplify the code a set of wrapper functions is created to test and call each of the variant operations. Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufs-qcom.c | 1 - drivers/scsi/ufs/ufshcd.c | 104 +---

[PATCH v6 4/8] add ufshcd_get_variant ufshcd_set_variant

2015-09-02 Thread Yaniv Gardi
Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufs-qcom.c | 34 +- drivers/scsi/ufs/ufshcd.h | 21 + 2 files changed, 38 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/ufs/ufs-qcom.c

[PATCH v6 1/8] phy: qcom-ufs: fix build error when the component is built as a module

2015-09-02 Thread Yaniv Gardi
Export the following functions in order to avoid build errors when the component PHY_QCOM_UFS is compiled as a module: ERROR: "ufs_qcom_phy_disable_ref_clk" [drivers/scsi/ufs/ufs-qcom.ko] undefined! ERROR: "ufs_qcom_phy_enable_ref_clk" [drivers/scsi/ufs/ufs-qcom.ko] undefined!

[PATCH v6 2/8] scsi: ufs-qcom: fix compilation warning if compiled as a module

2015-09-02 Thread Yaniv Gardi
This change fixes a compilation warning that happens if SCSI_UFS_QCOM is compiled as a module. Also this patch fixes an error happens when insmod the module: "ufs_qcom: module license 'unspecified' taints kernel." Signed-off-by: Yaniv Gardi ---

[PATCH v6 3/8] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component

2015-09-02 Thread Yaniv Gardi
This change is required in order to be able to build the component as a module. Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig index

[PATCH v6 0/8] Fix error message and present UFS variant

2015-09-02 Thread Yaniv Gardi
V6: removed dead code from ufs-qcom.c and added calling to ufshcd_dealloc_host() in ufshcd-pltfrm.c in case of an error after a successfull ufshcd_alloc_host() V5: removed a redundant null check V4: add file Documentation/devicetree/bindings/ufs/ufs-qcom.txt and modify the compatible strings in