Re: [PATCH] SCSI: Increase REPORT_LUNS timeout

2015-09-13 Thread Hannes Reinecke
On 09/04/2015 09:47 PM, Brian King wrote: > On 09/04/2015 11:15 AM, James Bottomley wrote: >> On Fri, 2015-09-04 at 10:47 -0500, Brian King wrote: >>> On 09/04/2015 10:36 AM, James Bottomley wrote: On Wed, 2015-09-02 at 09:31 -0500, Brian King wrote: > This patch fixes an issue seen with

[PATCH v1 06/17] scsi :ufs: verify hba controller hce reg value

2015-09-13 Thread Yaniv Gardi
Sometimes due to hw issues it takes some time to the host controller register to update. In order to verify the register has updated, a polling is done until its value is set. In addition the functions ufshcd_hba_stop() and ufshcd_wait_for_register() was updated with an additional input

[PATCH v1 10/17] scsi: ufs: make error handling bit faster

2015-09-13 Thread Yaniv Gardi
UFS driver's error handler forcefully tries to clear all the pending requests. For each pending request in the queue, it waits 1 sec for it to get cleared. If we have multiple requests in the queue then it's possible that we might end up waiting for those many seconds before resetting the host.

[PATCH v1 08/17] scsi: ufs: split broken LCC quirk

2015-09-13 Thread Yaniv Gardi
Currently when UFSHCD_BROKEN_LCC quirk is defined, LCC is getting disabled on both host and device side but there could be a need where we don't want to disable the LCC on both side hence this change splits the quirk in 2 parts one for host and one for device. Signed-off-by: Subhash Jadavani

[PATCH v1 09/17] scsi: ufs: disable vccq if it's not needed by UFS device

2015-09-13 Thread Yaniv Gardi
Some UFS devices don't require VCCQ rail for device operations hence this change adds support to recognize such devices and remove vote for the unused VCCQ rail. Signed-off-by: Subhash Jadavani Signed-off-by: Yaniv Gardi ---

[PATCH v1 11/17] scsi: ufs: add error recovery after DL NAC error

2015-09-13 Thread Yaniv Gardi
Some vendor's UFS device sends back to back NACs for the DL data frames causing the host controller to raise the DFES error status. Sometimes such UFS devices send back to back NAC without waiting for new retransmitted DL frame from the host and in such cases it might be possible the Host UniPro

[PATCH v1 07/17] scsi: ufs: separate device and host quirks

2015-09-13 Thread Yaniv Gardi
Currently we use the host quirks mechanism in order to handle both device and host controller quirks. In order to support various of UFS devices we should separate handling the device quirks from the host controller's. Signed-off-by: Raviv Shvili Signed-off-by: Yaniv

[PATCH v1 12/17] scsi: ufs: add retry for query descriptors

2015-09-13 Thread Yaniv Gardi
Query commands have 100ms timeout and it may timeout if they are issued in parallel to ongoing read/write SCSI commands, this change adds the retry (max: 10) in case command timeouts. Signed-off-by: Subhash Jadavani Signed-off-by: Yaniv Gardi ---

Re: randconfig build error with next-20150908, in drivers/md/dm-mpath.c

2015-09-13 Thread Hannes Reinecke
On 09/08/2015 08:30 PM, Mike Snitzer wrote: > On Tue, Sep 08 2015 at 1:34pm -0400, > James Bottomley wrote: > >> On Tue, 2015-09-08 at 13:23 -0400, Mike Snitzer wrote: >>> On Tue, Sep 08 2015 at 1:10pm -0400, >>> Jim Davis wrote: >>> Building

[PATCH v1 14/17] scsi: ufs: tune UniPro parameters to optimize hibern8 exit time

2015-09-13 Thread Yaniv Gardi
Optimal values of local UniPro parameters like PA_Hibern8Time & PA_TActivate can help reduce the hibern8 exit latency. If both host and device supports UniPro ver1.6 or later, these parameters will be automatically tuned during link startup itself. But if either host or device doesn't support

[PATCH v1 17/17] scsi: ufs-qcom: set PA_Local_TX_LCC_Enable before link startup

2015-09-13 Thread Yaniv Gardi
Some UFS devices (and may be host) have issues if LCC is enabled. So we are setting PA_Local_TX_LCC_Enable to 0 before link startup which will make sure that both host and device TX LCC are disabled once link startup is completed. This change also: - enables the device ref clock before changing

[PATCH v1 16/17] scsi: ufs: add delay before putting UFS rails in low power modes

2015-09-13 Thread Yaniv Gardi
We put the UFS device in sleep state & UFS link in hibern8 state during runtime suspaned. After this we put all the UFS rails in low power modes immediately but it seems some devices may still draw more than sleep current from UFS rails (especially from VCCQ rail) atleast for 500us. To avoid this

[PATCH v1 13/17] scsi: ufs: handle non spec compliant bkops behaviour by device

2015-09-13 Thread Yaniv Gardi
We are seeing that some devices are raising the urgent bkops exception events even when BKOPS status doesn't indicate performace impacted or critical. Handle these device by determining their urgent bkops status at runtime. Signed-off-by: Subhash Jadavani Signed-off-by:

[PATCH v1 15/17] scsi: ufs: fix leakage during link off state

2015-09-13 Thread Yaniv Gardi
Currently when we try to put the link in off/disabled state during suspend, it seems link is not being kept in low power mode. This patch fixes the issue by putting the link in hibern8 first (so device also puts the link in low power mode) and then stop the host controller. Signed-off-by: Subhash

[PATCH v1 02/17] scsi: ufs: add option to change default UFS power management level

2015-09-13 Thread Yaniv Gardi
UFS device and link can be put in multiple different low power modes hence UFS driver supports multiple different low power modes. By default UFS driver selects the default (optimal) low power mode (which gives moderate power savings and have relatively less enter and exit latencies) but we might

[PATCH v1 01/17] scsi: ufs-qcom: add number of lanes per direction

2015-09-13 Thread Yaniv Gardi
Different platform may have different number of lanes for the UFS link. Add parameter to device tree specifying how many lanes should be configured for the UFS link. Signed-off-by: Gilad Broner Signed-off-by: Yaniv Gardi ---

[PATCH v1 04/17] scsi: ufs: avoid spurious UFS host controller interrupts

2015-09-13 Thread Yaniv Gardi
When control reaches to Linux UFS driver during UFS boot mode, UFS host controller interrupt status/enable registers may have left over settings. In order to avoid any spurious interrupts due to these left overs, it's important to clear these interrupt status/enable registers before enabling UFS

[PATCH v1 03/17] scsi: ufs: optimize system suspend handling

2015-09-13 Thread Yaniv Gardi
Consider following sequence of events: 1. UFS is runtime suspended, link_state = Hibern8, device_state = sleep 2. System goes into system suspend, ufshcd_system_suspend() brings both link and device to active state and then puts the device in Power_Down state and link in OFF state. 3. System

[PATCH v1 05/17] scsi: ufs: implement scsi host timeout handler

2015-09-13 Thread Yaniv Gardi
A race condition exists between request requeueing and scsi layer error handling: When UFS driver queuecommand returns a busy status for a request, it will be requeued and its tag will be freed and set to -1. At the same time it is possible that the request will timeout and scsi layer will start

[PATCH v1 00/17] add fixes, device quirks, error recovery,

2015-09-13 Thread Yaniv Gardi
V1: This series should be pushed on top of 15 patches series: "Big fixes, retries, handle a race condition" Yaniv Gardi (17): scsi: ufs-qcom: add number of lanes per direction scsi: ufs: add option to change default UFS power management level scsi: ufs: optimize system suspend handling

Ich schätze Ihre Hilfe

2015-09-13 Thread Mr. Wenyao Zhou
Ich bin Mr.Wenyao Zhou Independent Director der Bank of China, habe ich einen Geschäftsvorgang von $ 23,5 Mio. und ich gebe Ihnen 30% Entschädigung für Ihre Unterstützung in dieser Transaktion sollten Sie daran interessiert sein, bitte senden Sie mir Ihre vollen Informationen, wie unten

Re: [PATCH 00/29] cxlflash: Miscellaneous bug fixes and corrections

2015-09-13 Thread Ian Munsie
Hi Matt & Manoj, Just a general comment about this series - I'd like to see more detailed commit messages for almost all these patches. Of course James is the scsi maintainer and it's up to him whether to take these as is or not, but generally when you write a commit message for a bug fix you

[Bugfix 0/3] Convert eata driver to a normal PCI device driver

2015-09-13 Thread Jiang Liu
Hi Authur, As suggested by Bjorn, patch 1-2 set implement a PCI device driver to manage eata PCI devices. And patch 3 tries to support PCI device hot-removal for eata, but I have no change to test due to limited knowledge about scsi subsystem and lacking of hardware for tests. So

[Bugfix 1/3] eata: Use IDA to manage eata board IDs

2015-09-13 Thread Jiang Liu
Use IDA to manage eata board IDs, so we could dynamically allocate and free board IDs later. Signed-off-by: Jiang Liu --- drivers/scsi/eata.c | 46 ++ 1 file changed, 30 insertions(+), 16 deletions(-) diff --git

[Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal

2015-09-13 Thread Jiang Liu
Due to having no hardware for testing, this is just a sample code to support PCI device hot-removal. It just passing compilation, no any tests. Signed-off-by: Jiang Liu --- drivers/scsi/eata.c | 26 ++ 1 file changed, 26 insertions(+) diff

[PATCH] target: Fix PR registration + APTPL RCU conversion regression

2015-09-13 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch fixes a v4.2+ regression introduced by commit 79dc9c9e86 where lookup of t10_pr_registration->pr_reg_deve and associated ->pr_kref get was missing from __core_scsi3_do_alloc_registration(), which is responsible for setting