Re: [PATCH V2 1/3] scsi: mptxsas: try 64 bit DMA when 32 bit DMA fails

2015-11-09 Thread Sinan Kaya
On 11/9/2015 2:09 AM, Hannes Reinecke wrote: On 11/09/2015 02:57 AM, Sinan Kaya wrote: Current code gives up when 32 bit DMA is not supported. This problem has been observed on systems without any memory below 4 gig. This patch tests 64 bit support before bailing out to find a working

Re: [PATCH v3 3/3] ibmvscsi: Allow to configure maximum LUN

2015-11-09 Thread Hannes Reinecke
On 11/09/2015 02:53 PM, Laurent Vivier wrote: > QEMU allows until 32 LUNs. > > Signed-off-by: Laurent Vivier > --- > drivers/scsi/ibmvscsi/ibmvscsi.c | 9 - > drivers/scsi/ibmvscsi/ibmvscsi.h | 1 + > 2 files changed, 9 insertions(+), 1 deletion(-) > Nothing to do

Re: [PATCH v3 3/3] ibmvscsi: Allow to configure maximum LUN

2015-11-09 Thread Laurent Vivier
On 09/11/2015 15:04, Hannes Reinecke wrote: > On 11/09/2015 02:53 PM, Laurent Vivier wrote: >> QEMU allows until 32 LUNs. >> >> Signed-off-by: Laurent Vivier >> --- >> drivers/scsi/ibmvscsi/ibmvscsi.c | 9 - >> drivers/scsi/ibmvscsi/ibmvscsi.h | 1 + >> 2 files

[PATCH v4 3/3] ibmvscsi: Allow to configure maximum LUN

2015-11-09 Thread Laurent Vivier
This patch allows to define the maximum LUN numbers. As defined in 4.6.9 of SAM-4, the encoding of LUN is on 5 bits (max_lun=32) and the current value is only 8. Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 9 -

[PATCH v4 2/3] ibmvscsi: display default value for max_id, max_lun and max_channel.

2015-11-09 Thread Laurent Vivier
As devices with values greater than that are silently ignored, this gives some hints to the sys admin to know why he doesn't see his devices... Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)

[PATCH v4 1/3] ibmvscsi: make parameters max_id and max_channel read-only

2015-11-09 Thread Laurent Vivier
The value of the parameter is never re-read by the driver, so a new value is ignored. Let know the user he can't modify it by removing writable attribute. Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 04/18] scsi_dh_alua: Use vpd_pg83 information

2015-11-09 Thread Hannes Reinecke
The SCSI device now has the VPD page 0x83 information attached, so there is no need to query it again. Reviewed-by: Martin K. Petersen Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke ---

[PATCH v3 2/3] ibmvscsi: display default value for max_id, max_lun and max_channel.

2015-11-09 Thread Laurent Vivier
As devices with values greater than that are silently ignored, this gives some hints to the sys admin to know why he doesn't see his devices... Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)

[PATCH v3 3/3] ibmvscsi: Allow to configure maximum LUN

2015-11-09 Thread Laurent Vivier
QEMU allows until 32 LUNs. Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 9 - drivers/scsi/ibmvscsi/ibmvscsi.h | 1 + 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c

[PATCH v3 0/3] ibmvscsi parameter cleanup

2015-11-09 Thread Laurent Vivier
v3 checks that max_lun is less or equal to 31 v2 of this series only fix the format type of max_lun: drivers/scsi/ibmvscsi/ibmvscsi.c:2298:4: warning: format '%d' expects argument of type 'int', but argument 4 has type 'u64 {aka long long unsigned int}' [-Wformat=] "Maximum ID: %d Maximum

Re: [PATCH v4 3/3] ibmvscsi: Allow to configure maximum LUN

2015-11-09 Thread Hannes Reinecke
On 11/09/2015 03:47 PM, Laurent Vivier wrote: > This patch allows to define the maximum LUN numbers. > As defined in 4.6.9 of SAM-4, the encoding of LUN is > on 5 bits (max_lun=32) and the current value is only 8. > > Signed-off-by: Laurent Vivier > --- >

[PATCH 18/18] scsi_dh_alua: use scsi_vpd_tpg_id()

2015-11-09 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 39 +- 1 file changed, 6 insertions(+), 33 deletions(-) diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c index

[PATCH 00/18] ALUA device handler update, part 1

2015-11-09 Thread Hannes Reinecke
Hi all, here's the first part of my ALUA device handler update. It's mainly bugfixes and minor improvements; the two important things are the addition of VPD parsing functions scsi_vpd_lun_id() and scsi_vpd_tpg_id(). This series has been split off from the original 'Asynchronous ALUA' patchset,

[PATCH 14/18] scsi_dh_alua: simplify sense code handling

2015-11-09 Thread Hannes Reinecke
Most sense code is already handled in the generic code, so we shouldn't be adding special cases here. However, when doing so we need to check for unit attention whenever we're sending an internal command. Reviewed-by: Ewan Milne Reviewed-by: Christoph Hellwig

[PATCH 11/18] scsi_dh_alua: use flag for RTPG extended header

2015-11-09 Thread Hannes Reinecke
We should be using a flag when RTPG extended header is not supported, that saves us sending RTPG twice for older arrays. Reviewed-by: Bart Van Assche Reviewed-by: Christoph Hellwig Reviewed-by: Martin K. Petersen

[PATCH 12/18] scsi_dh_alua: use unaligned access macros

2015-11-09 Thread Hannes Reinecke
Use 'get_unaligned_XX' and 'put_unaligned_XX' instead of open-coding it. Reviewed-by: Martin K. Petersen Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 23

[PATCH 13/18] scsi_dh_alua: rework alua_check_tpgs() to return the tpgs mode

2015-11-09 Thread Hannes Reinecke
Instead of returning an error code in alua_check_tpgs() we should rather return the tpgs mode directly and have a cleaner syntax. Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 25 +++-- 1 file changed, 11 insertions(+), 14

[PATCH 06/18] scsi_dh_alua: sanitze sense code handling

2015-11-09 Thread Hannes Reinecke
The only check for a valid sense code is calling scsi_normalize_sense() and check the return value. So drop the pointless checks and rely on scsi_normalize_sense() to figure out if the sense code is valid. With that we can also remove the 'senselen' field. Reviewed-by: Bart van Assche

[PATCH 17/18] scsi: Add scsi_vpd_tpg_id()

2015-11-09 Thread Hannes Reinecke
Implement scsi_vpd_tpg_id() to extract the target port group id and the relative port id from SCSI VPD page 0x83. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_lib.c| 48 ++ include/scsi/scsi_device.h | 1 + 2 files changed,

[PATCH 10/18] scsi: remove scsi_show_sense_hdr()

2015-11-09 Thread Hannes Reinecke
Last caller is gone, so remove it. Reviewed-by: Bart Van Assche Reviewed-by: Christoph Hellwig Reviewed-by: Martin K. Petersen Signed-off-by: Hannes Reinecke --- include/scsi/scsi_dbg.h | 2 -- 1 file changed,

[PATCH 16/18] scsi: export 'device_id' to sysfs

2015-11-09 Thread Hannes Reinecke
Use scsi_vpd_lun_id() to export the device id to sysfs. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_sysfs.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index 7b41b2c..aaa38c2 100644 ---

[PATCH 07/18] scsi_dh_alua: use standard logging functions

2015-11-09 Thread Hannes Reinecke
Use standard logging functions instead of hand-crafted ones. Reviewed-by: Bart Van Assche Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-)

[PATCH 08/18] scsi_dh_alua: return standard SCSI return codes in submit_rtpg

2015-11-09 Thread Hannes Reinecke
Fixup submit_rtpg() to always return a standard SCSI return code. Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 33 +++--- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git

[PATCH 02/18] scsi: ignore errors from scsi_dh_add_device()

2015-11-09 Thread Hannes Reinecke
device handler initialisation might fail due to a number of reasons. But as device_handlers are optional this shouldn't cause us to disable the device entirely. So just ignore errors from scsi_dh_add_device(). Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_sysfs.c | 7

[PATCH 15/18] scsi: Add scsi_vpd_lun_id()

2015-11-09 Thread Hannes Reinecke
Add a function scsi_vpd_lun_id() to return a unique device identifcation based on the designation descriptors of VPD page 0x83. As devices might implement several descriptors the order of preference is: - NAA IEE Registered Extended - EUI-64 based 16-byte - EUI-64 based 12-byte - NAA IEEE

[PATCH 05/18] scsi_dh_alua: improved logging

2015-11-09 Thread Hannes Reinecke
Issue different logging messages if ALUA is not supported or the TPGS setting is invalid. Reviewed-by: Martin K. Petersen Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 10

[PATCH 09/18] scsi_dh_alua: fixup description of stpg_endio()

2015-11-09 Thread Hannes Reinecke
Fixup copy-and-paste error in the description of stpg_endio(). Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig Reviewed-by: Martin K. Petersen --- drivers/scsi/device_handler/scsi_dh_alua.c | 6 ++ 1 file changed, 2

[PATCH 01/18] scsi_dh: move 'dh_state' sysfs attribute to generic code

2015-11-09 Thread Hannes Reinecke
As scsi_dh.c is now always compiled in we should be moving the 'dh_state' attribute to the generic code. Reviewed-by: Christoph Hellwig Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_dh.c| 68 +--

[PATCH 03/18] scsi_dh_alua: Disable ALUA handling for non-disk devices

2015-11-09 Thread Hannes Reinecke
Non-disk devices might support ALUA, but the firmware implementation is untested and frequently broken. As we're don't actually need it disable ALUA support for non-disk device for now. Signed-off-by: Hannes Reinecke Reviewed-by: Bart Van Assche

Re: [PATCH v4 3/3] ibmvscsi: Allow to configure maximum LUN

2015-11-09 Thread Laurent Vivier
On 09/11/2015 15:50, Hannes Reinecke wrote: > On 11/09/2015 03:47 PM, Laurent Vivier wrote: >> This patch allows to define the maximum LUN numbers. >> As defined in 4.6.9 of SAM-4, the encoding of LUN is >> on 5 bits (max_lun=32) and the current value is only 8. >> >> Signed-off-by: Laurent

Re: [PATCH v4 1/3] ibmvscsi: make parameters max_id and max_channel read-only

2015-11-09 Thread James Bottomley
On Mon, 2015-11-09 at 15:47 +0100, Laurent Vivier wrote: > The value of the parameter is never re-read by the driver, > so a new value is ignored. Let know the user he > can't modify it by removing writable attribute. This isn't correct. They're read in every time a new SCSI host is bound. I

[PATCH] scsi: rescan VPD attributes

2015-11-09 Thread Hannes Reinecke
The VPD page information might change, so we need to be able to update it. This patch implements a VPD page rescan whenever the 'rescan' sysfs attribute is triggered. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi.c| 20 +--- drivers/scsi/scsi_scan.c

[PATCH v3 1/3] ibmvscsi: make parameters max_id and max_channel read-only

2015-11-09 Thread Laurent Vivier
The value of the parameter is never re-read by the driver, so a new value is ignored. Let know the user he can't modify it by removing writable attribute. Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH V2 1/3] scsi: mptxsas: try 64 bit DMA when 32 bit DMA fails

2015-11-09 Thread Sinan Kaya
On 11/9/2015 3:59 AM, Arnd Bergmann wrote: On Monday 09 November 2015 08:09:39 Hannes Reinecke wrote: On 11/09/2015 02:57 AM, Sinan Kaya wrote: Current code gives up when 32 bit DMA is not supported. This problem has been observed on systems without any memory below 4 gig. This patch tests

[PATCH v4 0/3] ibmvscsi parameter cleanup

2015-11-09 Thread Laurent Vivier
v4 udpates 3/3 description max_lun can be less or equal to 32 v3 checks that max_lun is less or equal to 31 v2 of this series only fix the format type of max_lun: drivers/scsi/ibmvscsi/ibmvscsi.c:2298:4: warning: format '%d' expects argument of type 'int', but argument 4 has type 'u64 {aka

Re: [PATCH V2 1/3] scsi: mptxsas: try 64 bit DMA when 32 bit DMA fails

2015-11-09 Thread Arnd Bergmann
On Monday 09 November 2015 09:07:36 Sinan Kaya wrote: > > On 11/9/2015 3:59 AM, Arnd Bergmann wrote: > > On Monday 09 November 2015 08:09:39 Hannes Reinecke wrote: > >> On 11/09/2015 02:57 AM, Sinan Kaya wrote: > >>> Current code gives up when 32 bit DMA is not supported. > >>> This problem has

Re: [PATCH v4 3/3] ibmvscsi: Allow to configure maximum LUN

2015-11-09 Thread Hannes Reinecke
On 11/09/2015 03:59 PM, Laurent Vivier wrote: > > > On 09/11/2015 15:50, Hannes Reinecke wrote: >> On 11/09/2015 03:47 PM, Laurent Vivier wrote: >>> This patch allows to define the maximum LUN numbers. >>> As defined in 4.6.9 of SAM-4, the encoding of LUN is >>> on 5 bits (max_lun=32) and the

Re: [BUG] Boot failures with mpt2sas / Intel RMS25JB080 module

2015-11-09 Thread Sreekanth Reddy
Hi Matthew, Can you please try with mpt2sas driver's max_msix_vectors set to one. ~Sreekanth On Fri, Nov 6, 2015 at 11:38 PM, Matthew Vernon wrote: > Hi, > > [These lists are in the MAINTAINERS file for mpt2sas; I hope this is > the correct place to report this problem.

Re: [PATCH V2 3/3] scsi: mptxsas: offload IRQ execution

2015-11-09 Thread Sinan Kaya
On 11/9/2015 2:15 AM, Hannes Reinecke wrote: On 11/09/2015 02:57 AM, Sinan Kaya wrote: The mpt2sas and mpt3sas drivers are spinning forever in their IRQ handlers if there are a lot of jobs queued up by the PCIe card. This handler is causing spikes for the rest of the system and sluggish

Re: [PATCH V2 2/3] scsi: fix compiler warning for sg

2015-11-09 Thread Andy Shevchenko
On Mon, Nov 9, 2015 at 3:57 AM, Sinan Kaya wrote: > The MULDIV macro has been designed for small numbers. > Compiler emits an overflow warning on 64 bit systems. > This patch uses 64 bit numbers in order to suppress > warning. > > Signed-off-by: Sinan Kaya

Re: [PATCH V2 2/3] scsi: fix compiler warning for sg

2015-11-09 Thread Sinan Kaya
On 11/9/2015 10:26 PM, Timur Tabi wrote: Sinan Kaya wrote: I created this patch back in March with an older version of the compiler and older kernel (3.19). I'm no longer able to reproduce this with this compiler and linux-next. Thread model: posix gcc version 4.8.3 20140401 (prerelease)

Re: [PATCH V2 2/3] scsi: fix compiler warning for sg

2015-11-09 Thread Timur Tabi
Sinan Kaya wrote: The code says it is using these macros for small integers only which can't overflow. I was trying to get rid of compiler warning and it seems to have disappeared. I would double-check the assembly code, if I were you. I don't like it when warnings just go away like that.

Re: [PATCH v3 08/32] scsi: hisi_sas: add hisi_sas_remove

2015-11-09 Thread Wei Fang
Hi John, On 2015/11/10 0:32, John Garry wrote: > This patch also includes relevant memory/pool > free'ing and sas/scsi host removal > > Signed-off-by: John Garry > --- > drivers/scsi/hisi_sas/hisi_sas_main.c | 71 > ++- > 1 file changed,

[scsi:misc 64/77] drivers/scsi/aacraid/linit.c:1321:6: sparse: symbol 'aac_release_resources' was not declared. Should it be static?

2015-11-09 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc head: 46782becf4cc80153bdefebdb548ad35a5cd8b06 commit: de665f28f788ad72ff6a0ce6ac2721d77248b7cf [64/77] aacraid: Add Power Management support reproduce: # apt-get install sparse git checkout

Re: [PATCH V2 3/3] scsi: mptxsas: offload IRQ execution

2015-11-09 Thread Sinan Kaya
On 11/9/2015 2:15 AM, Hannes Reinecke wrote: On 11/09/2015 02:57 AM, Sinan Kaya wrote: The mpt2sas and mpt3sas drivers are spinning forever in their IRQ handlers if there are a lot of jobs queued up by the PCIe card. This handler is causing spikes for the rest of the system and sluggish

[RFC PATCH scsi] aacraid: aac_release_resources() can be static

2015-11-09 Thread kbuild test robot
Signed-off-by: Fengguang Wu --- linit.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index 37375cf..7724583f 100644 --- a/drivers/scsi/aacraid/linit.c +++ b/drivers/scsi/aacraid/linit.c

Re: [PATCH v2 00/27] hpsa updates

2015-11-09 Thread Martin K. Petersen
Applied this series. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 02/32] devicetree: bindings: scsi: HiSi SAS

2015-11-09 Thread Rob Herring
On Tue, Nov 10, 2015 at 12:32:07AM +0800, John Garry wrote: > Add devicetree bindings for HiSilicon SAS driver. > > Signed-off-by: John Garry > Signed-off-by: Zhangfei Gao > --- > .../devicetree/bindings/scsi/hisilicon-sas.txt | 81 >

[PATCH v3 23/32] scsi: hisi_sas: add cq interrupt handler

2015-11-09 Thread John Garry
Add cq interrupt handler and also slot error handler function. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 9 + drivers/scsi/hisi_sas/hisi_sas_main.c | 35 drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 347 +

[PATCH v3 32/32] MAINTAINERS: add maintainer for HiSi SAS driver

2015-11-09 Thread John Garry
Add maintainer for HiSilicon SAS driver. Signed-off-by: John Garry --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7af7f4a..cb10581 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5007,6 +5007,13 @@ F:

[PATCH v3 08/32] scsi: hisi_sas: add hisi_sas_remove

2015-11-09 Thread John Garry
This patch also includes relevant memory/pool free'ing and sas/scsi host removal Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 71 ++- 1 file changed, 70 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v5 10/11] Documentation: devicetree: ufs: Add DT bindings for exynos UFS host controller

2015-11-09 Thread Rob Herring
On Mon, Nov 09, 2015 at 10:56:26AM +0530, Alim Akhtar wrote: > From: Seungwon Jeon > > This adds Exynos Universal Flash Storage (UFS) Host Controller DT bindings. > > Signed-off-by: Seungwon Jeon > Signed-off-by: Alim Akhtar > --- >

Re: [PATCH v3 00/32] HiSilicon SAS driver

2015-11-09 Thread Arnd Bergmann
On Tuesday 10 November 2015 00:32:05 John Garry wrote: > This is the driver patchset for the HiSilicon SAS driver. The driver > is a platform driver. > > The driver will support multiple revisions of HW. Currently only "v1" > HW is supported. > > The driver uses libsas framework within the SCSI

[PATCH v5 1/2] ibmvscsi: display default value for max_id, max_lun and max_channel.

2015-11-09 Thread Laurent Vivier
As devices with values greater than that are silently ignored, this gives some hints to the sys admin to know why he doesn't see his devices... Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)

Re: [PATCH v3 11/32] scsi: hisi_sas: add phy SAS ADDR initialization

2015-11-09 Thread John Garry
On 09/11/2015 16:28, Arnd Bergmann wrote: On Tuesday 10 November 2015 00:32:16 John Garry wrote: } +static void hisi_sas_init_add(struct hisi_hba *hisi_hba) +{ + int i; + + for (i = 0; i < hisi_hba->n_phy; i++) + memcpy(_hba->phy[i].dev_sas_addr, +

Re: [PATCH RESEND] hpsa: move lockup_detected attribute to host attr

2015-11-09 Thread Martin K. Petersen
> "Tomas" == Tomas Henzl writes: Tomas> This patch fixes a 'general protection fault' issue by moving the Tomas> attribute to where it was likely meant. Applied. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Money Donation To You

2015-11-09 Thread Pedro
Mr. Pedro Quezada & family has donated $750,000 USD to you. Contact email below for more details about the donated funds. pedroq...@gmail.com Mr Pedro Quezada -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More

[PATCH v3 25/32] scsi: hisi_sas: add abnormal irq handler

2015-11-09 Thread John Garry
Add abnormal irq handler. This handler is concerned with phy down event. Also add port formed and port deformed handlers. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 2 + drivers/scsi/hisi_sas/hisi_sas_main.c | 118

[PATCH v3 01/32] [SCSI] sas: centralise ssp frame information units

2015-11-09 Thread John Garry
The xfer_rdy, command, and task frame's iu structures are not available in , but only aic94xx driver folder. Add them to include/scsi/sas.h Signed-off-by: John Garry --- drivers/scsi/aic94xx/aic94xx_sas.h | 49 - include/scsi/sas.h

[PATCH v5 0/2] ibmvscsi parameter cleanup

2015-11-09 Thread Laurent Vivier
v5 set directly max_lun to 32 remove patch 1/3 "make parameters max_id and max_channel read-only" v4 udpates 3/3 description max_lun can be less or equal to 32 v3 checks that max_lun is less or equal to 31 v2 of this series only fix the format type of max_lun:

Re: [PATCH 0/2] megaraid_sas: couple of fixes

2015-11-09 Thread Martin K. Petersen
> "Sumit" == Sumit Saxena writes: Applied. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH v3 20/32] scsi: hisi_sas: add v1 hw interrupt init

2015-11-09 Thread John Garry
Add code to interrupts, so now we can get a phy up interrupt when a disk is connected. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 5 + drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 162 + 2 files changed, 167

[PATCH v3 30/32] scsi: hisi_sas: add control phy handler

2015-11-09 Thread John Garry
Add method for lldd_control_phy. Currently link rate control and spinup hold is unsupported. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 3 +++ drivers/scsi/hisi_sas/hisi_sas_main.c | 29 +

[PATCH v3 26/32] scsi: hisi_sas: add bcast interrupt handler

2015-11-09 Thread John Garry
This is for expander broadcast event. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c

[PATCH v3 05/32] scsi: hisi_sas: scan device tree

2015-11-09 Thread John Garry
Scan the device tree for all properties. Also do this: - do ioremap for SAS registers - allocate memor for interrupt names Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 10 drivers/scsi/hisi_sas/hisi_sas_main.c | 45

[PATCH v3 12/32] scsi: hisi_sas: set dev DMA mask

2015-11-09 Thread John Garry
Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c index 9e6eebe..f78c2a9 100644 ---

Re: [PATCH v4 1/3] ibmvscsi: make parameters max_id and max_channel read-only

2015-11-09 Thread Laurent Vivier
On 09/11/2015 16:07, James Bottomley wrote: > On Mon, 2015-11-09 at 15:47 +0100, Laurent Vivier wrote: >> The value of the parameter is never re-read by the driver, >> so a new value is ignored. Let know the user he >> can't modify it by removing writable attribute. > > This isn't correct.

[PATCH v3 14/32] scsi: hisi_sas: add hisi sas device type

2015-11-09 Thread John Garry
Include initialisation. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 12 drivers/scsi/hisi_sas/hisi_sas_main.c | 6 ++ 2 files changed, 18 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas.h

[PATCH v3 04/32] scsi: hisi_sas: add scsi host registration

2015-11-09 Thread John Garry
Add functionality to register device as a scsi host. The SAS domain transport ops are empty at this point. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 34 ++ drivers/scsi/hisi_sas/hisi_sas_main.c | 116 ++

[PATCH v3 16/32] scsi: hisi_sas: add timer and spinlock init

2015-11-09 Thread John Garry
Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 2 ++ drivers/scsi/hisi_sas/hisi_sas_main.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers/scsi/hisi_sas/hisi_sas.h index e04fd67..146a236 100644 ---

[PATCH v3 11/32] scsi: hisi_sas: add phy SAS ADDR initialization

2015-11-09 Thread John Garry
The SAS address for the HBA comes from the device tree. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 1 + drivers/scsi/hisi_sas/hisi_sas_main.c | 12 2 files changed, 13 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas.h

Re: [PATCH v3 11/32] scsi: hisi_sas: add phy SAS ADDR initialization

2015-11-09 Thread Arnd Bergmann
On Tuesday 10 November 2015 00:32:16 John Garry wrote: > } > > +static void hisi_sas_init_add(struct hisi_hba *hisi_hba) > +{ > + int i; > + > + for (i = 0; i < hisi_hba->n_phy; i++) > + memcpy(_hba->phy[i].dev_sas_addr, > + hisi_hba->sas_addr, > +

[PATCH v3 03/32] scsi: hisi_sas: add initial bare main driver

2015-11-09 Thread John Garry
This patch adds the initial bare main driver for the HiSilicon SAS HBA. This only introduces the changes to build and load the main driver module. The complete driver consists of the core main module and also a module platform driver for driving the hw. The HBA is a platform device.

[PATCH v5 2/2] ibmvscsi: set max_lun to 32

2015-11-09 Thread Laurent Vivier
As defined in 4.6.9 of SAM-4, the encoding of LUN is on 5 bits (max_lun=32) and the current value is only 8. Set max_lun to IBMVSCSI_MAX_LUN (32). Signed-off-by: Laurent Vivier --- drivers/scsi/ibmvscsi/ibmvscsi.c | 2 +- drivers/scsi/ibmvscsi/ibmvscsi.h | 1 + 2 files

[PATCH v3 06/32] scsi: hisi_sas: add HW DMA structures

2015-11-09 Thread John Garry
Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 131 +++ 1 file changed, 131 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers/scsi/hisi_sas/hisi_sas.h index 87f4b61..19d40b7 100644 ---

[PATCH v3 00/32] HiSilicon SAS driver

2015-11-09 Thread John Garry
This is the driver patchset for the HiSilicon SAS driver. The driver is a platform driver. The driver will support multiple revisions of HW. Currently only "v1" HW is supported. The driver uses libsas framework within the SCSI framework. The v1 HW supports SSP and SMP, but not STP/SATA.

[PATCH v3 07/32] scsi: hisi_sas: allocate memories and create pools

2015-11-09 Thread John Garry
Allocate DMA and non-DMA memories for the controller. Also create DMA pools. These include: - Delivery queues - Completion queues - Command status buffer - Command table - ITCT (For device context) - Host slot info - IO status - Breakpoint - host slot indexing - SG data - FIS - interrupts names

[PATCH v3 15/32] scsi: hisi_sas: add phy and port init

2015-11-09 Thread John Garry
Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 17 + drivers/scsi/hisi_sas/hisi_sas_main.c | 31 +++ 2 files changed, 48 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas.h

[PATCH v3 22/32] scsi: hisi_sas: add ssp command function

2015-11-09 Thread John Garry
Add path to send ssp command to HW Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 30 + drivers/scsi/hisi_sas/hisi_sas_main.c | 234 + drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 194 +++ 3

[PATCH v3 29/32] scsi: hisi_sas: add tmf methods

2015-11-09 Thread John Garry
Add function methods for tmf's. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_main.c | 309 ++ 1 file changed, 309 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c

[PATCH v3 09/32] scsi: hisi_sas: add slot init code

2015-11-09 Thread John Garry
Add functionality to init slot indexing. Slot indexing is for the host to track which slots (or tags) are free and which are used. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 4 drivers/scsi/hisi_sas/hisi_sas_main.c | 23

[PATCH v3 24/32] scsi: hisi_sas: add dev_found and dev_gone

2015-11-09 Thread John Garry
Add functions to deal with lldd_dev_found and lldd_dev_gone. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 13 + drivers/scsi/hisi_sas/hisi_sas_main.c | 88 ++ drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 41

[PATCH v3 19/32] scsi: hisi_sas: add v1 HW initialisation code

2015-11-09 Thread John Garry
Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 1 + drivers/scsi/hisi_sas/hisi_sas_main.c | 4 + drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 337 + 3 files changed, 342 insertions(+) diff --git

[PATCH v3 18/32] scsi: hisi_sas: add v1 hardware register definitions

2015-11-09 Thread John Garry
Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 389 + 1 file changed, 389 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c index 011bfe3..d1c9c27 100644 ---

[PATCH v3 17/32] scsi: hisi_sas: add v1 hw module init

2015-11-09 Thread John Garry
Add module init code for v1 hw. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/Makefile | 1 + drivers/scsi/hisi_sas/hisi_sas.h | 3 ++ drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 53 ++ 3 files changed, 57 insertions(+)

[PATCH v3 13/32] scsi: hisi_sas: add hisi_hba workqueue

2015-11-09 Thread John Garry
Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 1 + drivers/scsi/hisi_sas/hisi_sas_main.c | 8 2 files changed, 9 insertions(+) diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers/scsi/hisi_sas/hisi_sas.h index c50384f..62bc6f3 100644

[PATCH v3 28/32] scsi: hisi_sas: add scan finished and start

2015-11-09 Thread John Garry
Add functions for scsi host template scan_finished and scan_start methods Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 1 + drivers/scsi/hisi_sas/hisi_sas_main.c | 25 + 2 files changed, 26 insertions(+) diff --git

[PATCH v3 27/32] scsi: hisi_sas: add smp protocol support

2015-11-09 Thread John Garry
Add support for smp function, which allows devices attached by expander to be controlled Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 3 ++ drivers/scsi/hisi_sas/hisi_sas_main.c | 9 drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 88

[PATCH v3 10/32] scsi: hisi_sas: add cq structure initialization

2015-11-09 Thread John Garry
Each completion queue has a structure. This is mainly for passing to irq handler so we know which queue the irq occured on. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 7 +++ drivers/scsi/hisi_sas/hisi_sas_main.c | 6 ++ 2 files changed,

[PATCH v3 21/32] scsi: hisi_sas: add path from phyup irq to SAS framework

2015-11-09 Thread John Garry
Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas.h | 2 ++ drivers/scsi/hisi_sas/hisi_sas_main.c | 49 ++ drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 15 +++ 3 files changed, 66 insertions(+) diff --git

Re: [PATCH RESEND] scsi: Export SCSI Inquiry data to sysfs

2015-11-09 Thread Martin K. Petersen
> "Johannes" == Johannes Thumshirn writes: Johannes> Export the RAW SCSI Inquiry to sysfs as binfile. This way the Johannes> data can be used by userland without the need to have and Johannes> ioctl or use the sg_inq tool. Applied. -- Martin K. Petersen Oracle

[PATCH v3] scsi: pmcraid: replace struct timeval with ktime_get_real_seconds()

2015-11-09 Thread Alison Schofield
Replace the use of struct timeval and do_gettimeofday() with 64 bit ktime_get_real_seconds. Prevents 32-bit type overflow in year 2038 on 32-bit systems. Driver was using the seconds portion of struct timeval (.tv_secs) to pass a millseconds timestamp to the firmware. This change maintains that

Re: [Y2038] [PATCH v3] scsi: pmcraid: replace struct timeval with ktime_get_real_seconds()

2015-11-09 Thread Arnd Bergmann
On Monday 09 November 2015 11:34:20 Alison Schofield wrote: > Replace the use of struct timeval and do_gettimeofday() with > 64 bit ktime_get_real_seconds. Prevents 32-bit type overflow > in year 2038 on 32-bit systems. > > Driver was using the seconds portion of struct timeval (.tv_secs) > to

Re: [PATCH v3 00/32] HiSilicon SAS driver

2015-11-09 Thread Hannes Reinecke
On 11/09/2015 05:32 PM, John Garry wrote: > This is the driver patchset for the HiSilicon SAS driver. The driver > is a platform driver. > > The driver will support multiple revisions of HW. Currently only "v1" > HW is supported. > > The driver uses libsas framework within the SCSI framework. >

Re: [PATCH V2 2/3] scsi: fix compiler warning for sg

2015-11-09 Thread Sinan Kaya
On 11/9/2015 9:14 AM, Andy Shevchenko wrote: Parens are useless, noticed later, sorry. Isn't mult_frac() enough here? Btw, can you mention explicitly what is the warning you get (copy'n'paste of the line would be okay)? I created this patch back in March with an older version of the

Re: [PATCH] wd719x: Remove use of macro DEFINE_PCI_DEVICE_TABLE

2015-11-09 Thread Vaishali Thakkar
On Fri, Jul 17, 2015 at 11:16 AM, Vaishali Thakkar wrote: > Macro DEFINE_PCI_DEVICE_TABLE is deprecated. So, here use > struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with > the goal of getting rid of this macro completely. > > The Coccinelle semantic patch that

Re: [PATCH V2 2/3] scsi: fix compiler warning for sg

2015-11-09 Thread Timur Tabi
Sinan Kaya wrote: I created this patch back in March with an older version of the compiler and older kernel (3.19). I'm no longer able to reproduce this with this compiler and linux-next. Thread model: posix gcc version 4.8.3 20140401 (prerelease) (crosstool-NG linaro-1.13.1-4.8-2014.04 -

Re: [PATCH V2 1/3] scsi: mptxsas: try 64 bit DMA when 32 bit DMA fails

2015-11-09 Thread Sinan Kaya
On 11/9/2015 9:33 AM, Arnd Bergmann wrote: On Monday 09 November 2015 09:07:36 Sinan Kaya wrote: On 11/9/2015 3:59 AM, Arnd Bergmann wrote: On Monday 09 November 2015 08:09:39 Hannes Reinecke wrote: On 11/09/2015 02:57 AM, Sinan Kaya wrote: Current code gives up when 32 bit DMA is not

Re: [PATCH V2 1/3] scsi: mptxsas: try 64 bit DMA when 32 bit DMA fails

2015-11-09 Thread Arnd Bergmann
On Monday 09 November 2015 08:09:39 Hannes Reinecke wrote: > On 11/09/2015 02:57 AM, Sinan Kaya wrote: > > Current code gives up when 32 bit DMA is not supported. > > This problem has been observed on systems without any > > memory below 4 gig. > > > > This patch tests 64 bit support before

Re: [PATCH v2 17/27] hpsa: enhance hpsa_get_device_id

2015-11-09 Thread Hannes Reinecke
On 11/04/2015 10:51 PM, Don Brace wrote: > use an index into vpd data for SAS/SATA drives > > Reviewed-by: Scott Teel > Reviewed-by: Justin Lindley > Reviewed-by: Kevin Barnett > Reviewed-by: Tomas Henzl

  1   2   >