Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

2015-11-12 Thread Mike Christie
On 11/12/2015 06:03 AM, Sagi Grimberg wrote: > >> The bug is caused by this patch: >> >> 659743b02c411075b26601725947b21df0bb29c8 >> >> which allowed the task lists to be manipulated under different locks >> in the xmit and completion path. >> >> To fix the oops this patch just reverts that

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

2015-11-12 Thread Chris Leech
On Thu, Nov 12, 2015 at 4:03 AM, Sagi Grimberg wrote: > >> The bug is caused by this patch: >> >> 659743b02c411075b26601725947b21df0bb29c8 >> >> which allowed the task lists to be manipulated under different locks >> in the xmit and completion path. >> >> To fix the oops

Re: [PATCH 00/25] mpt3sas: Mergering mpt2sas & mpt3sas driver code

2015-11-12 Thread Yinghai Lu
On Wed, Nov 11, 2015 at 5:09 PM, Martin K. Petersen wrote: >> "Sreekanth" == Sreekanth Reddy writes: > > The patches in the single-module portion of the series did not compile > individually and I gave up untangling them. They were

[patch] hpsa: logical vs bitwise AND typo

2015-11-12 Thread Dan Carpenter
HPSA_DIAG_OPTS_DISABLE_RLD_CACHING is a mask and bitwise AND was intended here instead of logical &&. This bug is essentially harmless, it means that sometimes we don't print a warning message which we wanted to print. Fixes: c2adae44e916 ('hpsa: disable report lun data caching') Signed-off-by:

Re: [patch] hpsa: logical vs bitwise AND typo

2015-11-12 Thread Johannes Thumshirn
On Thu, 2015-11-12 at 12:43 +0300, Dan Carpenter wrote: > HPSA_DIAG_OPTS_DISABLE_RLD_CACHING is a mask and bitwise AND was > intended here instead of logical &&.  This bug is essentially > harmless, > it means that sometimes we don't print a warning message which we > wanted > to print. > >

Re: [PATCH 1/1] iscsi: fix regression caused by session lock patch

2015-11-12 Thread Sagi Grimberg
The bug is caused by this patch: 659743b02c411075b26601725947b21df0bb29c8 which allowed the task lists to be manipulated under different locks in the xmit and completion path. To fix the oops this patch just reverts that patch. It also reverts these 2 patches for regressions that were also a

Re: [PATCH] mpt3sas: Fix use sas_is_tlr_enabled API before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag

2015-11-12 Thread Hannes Reinecke
On 11/12/2015 07:10 PM, Sreekanth Reddy wrote: > Before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag in MPI SCSI IO > request message, check whether TLR is enabled on the drive using > 'sas_is_tlr_enabled' API. > > Actually in the driver code, driver is using below API's > > 1. sas_enable_tlr() - to

Re: [PATCH 0/2] scsi_transport_fc: LUN masking

2015-11-12 Thread Hannes Reinecke
On 11/12/2015 02:33 PM, Steffen Maier wrote: > Hi Hannes, > > On 11/11/2015 11:34 AM, Hannes Reinecke wrote: >> having been subjected to the pain of trying to bootstrap a really >> large machine with systemd I decided to implement LUN masking in > > This is very interesting. > > I also thought

Re: [patch] hpsa: logical vs bitwise AND typo

2015-11-12 Thread Don Brace
On 11/12/2015 03:59 AM, Johannes Thumshirn wrote: On Thu, 2015-11-12 at 12:43 +0300, Dan Carpenter wrote: HPSA_DIAG_OPTS_DISABLE_RLD_CACHING is a mask and bitwise AND was intended here instead of logical &&. This bug is essentially harmless, it means that sometimes we don't print a warning

[PATCH] mpt3sas: Fix use sas_is_tlr_enabled API before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag

2015-11-12 Thread Sreekanth Reddy
Before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag in MPI SCSI IO request message, check whether TLR is enabled on the drive using 'sas_is_tlr_enabled' API. Actually in the driver code, driver is using below API's 1. sas_enable_tlr() - to enable the TLR 2. sas_disable_tlr() - to disable the TLR 3.

Re: [PATCH v2 02/17] scsi: ufs: add option to change default UFS power management level

2015-11-12 Thread Rob Herring
On Mon, Oct 26, 2015 at 05:40:57PM +0200, Yaniv Gardi wrote: > UFS device and link can be put in multiple different low power modes > hence UFS driver supports multiple different low power modes. > By default UFS driver selects the default (optimal) low power mode > (which gives moderate power

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-11-12 Thread Lee Duncan
On 10/14/2015 08:53 PM, James Bottomley wrote: > On Wed, 2015-10-14 at 11:34 -0700, Lee Duncan wrote: >> On 10/14/2015 06:55 AM, James Bottomley wrote: >>> On Wed, 2015-10-07 at 16:51 -0700, Lee Duncan wrote: Update the SCSI hosts module to use the ida_simple*() routines to manage its