Re: MPT2SAS boot fail... due to silently loosing the driver

[cc to linux-scsi added] On Mon, 2015-11-30 at 12:21 -0500, Martin K. Petersen wrote: > > "Ingo" == Ingo Molnar writes: > > Ingo> So you need to make it interactive, with a short help text that > Ingo> explains to users that this is legacy option only, and that they > Ingo>

Re: [PATCH 01/18] scsi_dh: move 'dh_state' sysfs attribute to generic code

> "Hannes" == Hannes Reinecke writes: Hannes> As scsi_dh.c is now always compiled in we should be moving the Hannes> 'dh_state' attribute to the generic code. This patch conflicts with 23695e41a1ca ("scsi_dh: fix use-after-free when removing scsi device"). Looked simple

Re: [PATCH v1 1/1] scsi_debug: check for bigger value first

> "Andy" == Andy Shevchenko writes: Andy> Even for signed types we have to check for bigger positive value Andy> first. Otherwise it will be never happened. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe

Re: [PATCH] scsi: rescan VPD attributes

> "Hannes" == Hannes Reinecke writes: Hannes> The VPD page information might change, so we need to be able to Hannes> update it. This patch implements a VPD page rescan whenever the Hannes> 'rescan' sysfs attribute is triggered. Applied to 4.5/scsi-queue. -- Martin K.

[Bug 108621] kernel BUG in drivers/scsi/scsi_lib.c

https://bugzilla.kernel.org/show_bug.cgi?id=108621 --- Comment #2 from Martin Ziegler --- So I better wait for 4.4-rc4... Thanks, Martin -- You are receiving this mail because: You are watching the assignee of the bug. -- To unsubscribe from this list: send the line

Re: [PATCH v2 0/4] bfa: Patches for scsi "misc" branch

> "Anil" == writes: Anil, Anil> Re-sending the patches that were submitted earlier, but appear to Anil> have fallen through the cracks. Addressed a comment regarding the Anil> commit message as well. Please add all existing review tags when you post an updated

[Bug 108621] New: kernel BUG in drivers/scsi/scsi_lib.c

https://bugzilla.kernel.org/show_bug.cgi?id=108621 Bug ID: 108621 Summary: kernel BUG in drivers/scsi/scsi_lib.c Product: SCSI Drivers Version: 2.5 Kernel Version: 4.4.-rc3 Hardware: All OS: Linux Tree:

You Have WON!!

POSTCODELOTERIJ PROMOTION DISBURSEMENT AWARD!! We are please to inform you of our end of year promotion disbursement program held 29th November 2015,which have pronounce your email-address as the lucky winner of a total sum:of €500,000.00 In respect of the donation of Saudi Arabian

[Bug 108621] kernel BUG in drivers/scsi/scsi_lib.c

https://bugzilla.kernel.org/show_bug.cgi?id=108621 Bart Van Assche changed: What|Removed |Added CC||bvanass...@acm.org

Re: [PATCH 1/2] scsi_transport_fc: Introduce scsi_host_{get,put}()

On 11/30/2015 09:34 AM, Martin K. Petersen wrote: "Bart" == Bart Van Assche writes: Bart, Bart> Use scsi_host_{get,put}() instead of open-coding these functions. Bart> Compile-tested only. Do you want me to queue this as a general cleanup for 4.5 (independently

Re: [PATCH 1/2] scsi_transport_fc: Introduce scsi_host_{get,put}()

> "Bart" == Bart Van Assche writes: Bart, Bart> Use scsi_host_{get,put}() instead of open-coding these functions. Bart> Compile-tested only. Do you want me to queue this as a general cleanup for 4.5 (independently of the leak patch)? -- Martin K. Petersen

Re: [RESEND] scsi: mvsas: fix misleading indentation

> "Luis" == Luis de Bethencourt writes: Luis> Fix a smatch warning: drivers/scsi/mvsas/mv_sas.c:740 Luis> mvs_task_prep() warn: curly braces intended? Luis> The code is correct, the indention is misleading. When the device Luis> is not ready we want to return

Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data

On Mon, 2015-11-30 at 19:17 -0500, Martin K. Petersen wrote: > > "Ching" == Ching Huang writes: > > Hello Ching, > > I applied both your series to 4.5/scsi-queue. > > In the future please run checkpatch before submitting. Warnings are OK > but in this case there

Re: [PATCH] Fix a bdi reregistration race, v2

> "Bart" == Bart Van Assche writes: Bart, Bart> This race is hard to trigger. I can trigger it by repeatedly Bart> removing and re-adding SRP SCSI devices. Enabling debug options Bart> like SLUB debugging and kmemleak helps. I think that is because Bart> these

Re: [PATCH] scsi: ufs: fix spelling mistake in error message

> "Colin" == Colin King writes: Colin, Colin> Minor issue, fix spelling mistake, Intialization -> Colin> Initialization Applied to 4.5/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: [PATCH] Fix a bdi reregistration race, v2

On 11/30/2015 04:57 PM, Martin K. Petersen wrote: "Bart" == Bart Van Assche writes: Bart> This race is hard to trigger. I can trigger it by repeatedly Bart> removing and re-adding SRP SCSI devices. Enabling debug options Bart> like SLUB debugging and kmemleak

Re: [PATCH] Fix a memory leak in scsi_host_dev_release()

> "Bart" == Bart Van Assche writes: Bart> Avoid that kmemleak reports the following memory leak if a SCSI Bart> LLD calls scsi_host_alloc() and scsi_host_put() but neither Bart> scsi_host_add() nor scsi_host_remove(). The following shell Bart> command triggers

Re: [PATCH 1/2] scsi_transport_fc: Introduce scsi_host_{get,put}()

> "Bart" == Bart Van Assche writes: >> Do you want me to queue this as a general cleanup for 4.5 >> (independently of the leak patch)? Bart> That would be appreciated. OK. Done. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this

Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data

> "Ching" == Ching Huang writes: Hello Ching, I applied both your series to 4.5/scsi-queue. In the future please run checkpatch before submitting. Warnings are OK but in this case there were several things flagged as errors that I had to fix up by hand. Also make

[PATCH 1/2]Revert "SCSI: Fix NULL pointer dereference in runtime PM"

This reverts commit 49718f0fb8c9 ("SCSI: Fix NULL pointer dereference in runtime PM") The old commit may lead to a issue that blk_{pre|post}_runtime_suspend and blk_{pre|post}_runtime_resume may not be called in pairs. Take sr device as example, when sr device goes to runtime suspend,

Re: [PATCH v2 2/4] bfa:Fix for crash when bfa_itnim is NULL

On Thu, 2015-11-26 at 03:54 -0500, anil.gurumur...@qlogic.com wrote: > From: Anil Gurumurthy > > Fix a very corner case when the port gets disconnected and the BFA and FCS > layers clean up references to the IT nexus. > During this window if a task management command

Re: [PATCH] Fix a bdi reregistration race, v2

On Mon, Nov 30, 2015 at 05:18:50PM -0800, Bart Van Assche wrote: > Since the original patch caused a regression, please proceed with reverting > the original patch. > > Regarding this patch: is there anyone on the CC-list of this e-mail who can > review it ? I'm not too fond of the approach.

Re: [RFC PATCH 74/71] ncr5380: Enable PDMA for NCR53C400A

On Sun, 29 Nov 2015, Ondrej Zary wrote: > Add I/O register mapping for NCR53C400A and enable PDMA mode to > improve performance and fix non-working IRQ. > > Tested with HP C2502 (and user-space enabler). > > Signed-off-by: Ondrej Zary > --- >

Re: [RFC PATCH 74/71] ncr5380: Enable PDMA for NCR53C400A

On Sun, 29 Nov 2015, Ondrej Zary wrote: > Add I/O register mapping for NCR53C400A and enable PDMA mode to > improve performance and fix non-working IRQ. > Is CONFIG_SCSI_GENERIC_NCR53C400 is still needed? Can the driver be fully configured at runtime now? > Tested with HP C2502 (and

Re: [RFC PATCH 73/71] ncr5380: Use runtime register mapping

On Sun, 29 Nov 2015, Ondrej Zary wrote: > Convert compile-time C400_ register mapping to runtime mapping. > This removes the weird negative register offsets and allows adding > additional mappings. > > Signed-off-by: Ondrej Zary > --- > drivers/scsi/NCR5380.h |

Re: [RFC PATCH 74/71] ncr5380: Enable PDMA for NCR53C400A

On Monday 30 November 2015, Finn Thain wrote: > > On Sun, 29 Nov 2015, Ondrej Zary wrote: > > > Add I/O register mapping for NCR53C400A and enable PDMA mode to > > improve performance and fix non-working IRQ. > > > > Is CONFIG_SCSI_GENERIC_NCR53C400 is still needed? Can the driver be fully >

Re: [PATCH v1 1/1] scsi_debug: check for bigger value first

On Thu, 2015-11-26 at 20:22 +0200, Andy Shevchenko wrote: > From: Andy Shevchenko > > Even for signed types we have to check for bigger positive value first. > Otherwise it will be never happened. > > Acked-by: Douglas Gilbert > Signed-off-by:

[RESEND] scsi: mvsas: fix misleading indentation

Fix a smatch warning: drivers/scsi/mvsas/mv_sas.c:740 mvs_task_prep() warn: curly braces intended? The code is correct, the indention is misleading. When the device is not ready we want to return SAS_PHY_DOWN. But current indentation makes it look like we only do so in the else branch of if